This is an archive of the discontinued LLVM Phabricator instance.

Differential D100825

[RISCV][MC] Mask load should not have VMConstraint.
ClosedPublic

Authored by khchen on Apr 20 2021, 1:27 AM.

Details

Reviewers
craig.topper
jrtc27
HsiangKai
evandro
Commits
rGad0fe5db2fa0: [RISCV][MC] Mask load should not have VMConstraint.
Summary

Add a test, dest register could be v0.

Diff Detail

Event Timeline

khchen created this revision.Apr 20 2021, 1:27 AM
Herald added subscribers: vkmr, frasercrmck, luismarques and 23 others. · View Herald TranscriptApr 20 2021, 1:27 AM
khchen requested review of this revision.Apr 20 2021, 1:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 20 2021, 1:27 AM
Herald added subscribers: llvm-commits, MaskRay. · View Herald Transcript
HsiangKai accepted this revision.Apr 20 2021, 1:42 AM

LGTM.

This revision is now accepted and ready to land.Apr 20 2021, 1:42 AM
Harbormaster completed remote builds in B99645: Diff 338758.Apr 20 2021, 2:23 AM
Closed by commit rGad0fe5db2fa0: [RISCV][MC] Mask load should not have VMConstraint. (authored by khchen). · Explain WhyApr 21 2021, 12:22 AM
This revision was automatically updated to reflect the committed changes.
khchen added a commit: rGad0fe5db2fa0: [RISCV][MC] Mask load should not have VMConstraint..

Revision Contents

PathSize
llvm/
lib/
Target/
RISCV/
1 line
test/
MC/
RISCV/
rvv/
6 lines

Diff 339121

llvm/lib/Target/RISCV/RISCVInstrInfoV.td

Show First 20 Lines • Show All 82 Lines • ▼ Show 20 Lines
let hasSideEffects = 0, mayLoad = 1, mayStore = 0 in { let hasSideEffects = 0, mayLoad = 1, mayStore = 0 in {
// load vd, (rs1) // load vd, (rs1)
class VUnitStrideLoadMask<string opcodestr> class VUnitStrideLoadMask<string opcodestr>
: RVInstVLU<0b000, LSWidth8.Value{3}, LUMOPUnitStrideMask, LSWidth8.Value{2-0}, : RVInstVLU<0b000, LSWidth8.Value{3}, LUMOPUnitStrideMask, LSWidth8.Value{2-0},
(outs VR:$vd), (outs VR:$vd),
(ins GPR:$rs1), opcodestr, "$vd, (${rs1})"> { (ins GPR:$rs1), opcodestr, "$vd, (${rs1})"> {
let vm = 1; let vm = 1;
let RVVConstraint = NoConstraint;
} }
// load vd, (rs1), vm // load vd, (rs1), vm
class VUnitStrideLoad<RISCVLSUMOP lumop, RISCVWidth width, class VUnitStrideLoad<RISCVLSUMOP lumop, RISCVWidth width,
string opcodestr> string opcodestr>
: RVInstVLU<0b000, width.Value{3}, lumop, width.Value{2-0}, : RVInstVLU<0b000, width.Value{3}, lumop, width.Value{2-0},
(outs VR:$vd), (outs VR:$vd),
(ins GPR:$rs1, VMaskOp:$vm), opcodestr, "$vd, (${rs1})$vm">; (ins GPR:$rs1, VMaskOp:$vm), opcodestr, "$vd, (${rs1})$vm">;
▲ Show 20 Lines • Show All 1,074 Lines • Show Last 20 Lines

llvm/test/MC/RISCV/rvv/load.s

# RUN: llvm-mc -triple=riscv64 -show-encoding --mattr=+experimental-v %s \ # RUN: llvm-mc -triple=riscv64 -show-encoding --mattr=+experimental-v %s \
# RUN: --riscv-no-aliases | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST # RUN: --riscv-no-aliases | FileCheck %s --check-prefixes=CHECK-ENCODING,CHECK-INST
# RUN: not llvm-mc -triple=riscv64 -show-encoding %s 2>&1 \ # RUN: not llvm-mc -triple=riscv64 -show-encoding %s 2>&1 \
# RUN: | FileCheck %s --check-prefix=CHECK-ERROR # RUN: | FileCheck %s --check-prefix=CHECK-ERROR
# RUN: llvm-mc -triple=riscv64 -filetype=obj --mattr=+experimental-v %s \ # RUN: llvm-mc -triple=riscv64 -filetype=obj --mattr=+experimental-v %s \
# RUN: | llvm-objdump -d --mattr=+experimental-v - --riscv-no-aliases \ # RUN: | llvm-objdump -d --mattr=+experimental-v - --riscv-no-aliases \
# RUN: | FileCheck %s --check-prefix=CHECK-INST # RUN: | FileCheck %s --check-prefix=CHECK-INST
# RUN: llvm-mc -triple=riscv64 -filetype=obj --mattr=+experimental-v %s \ # RUN: llvm-mc -triple=riscv64 -filetype=obj --mattr=+experimental-v %s \
# RUN: | llvm-objdump -d - | FileCheck %s --check-prefix=CHECK-UNKNOWN # RUN: | llvm-objdump -d - | FileCheck %s --check-prefix=CHECK-UNKNOWN
vle1.v v0, (a0)
# CHECK-INST: vle1.v v0, (a0)
# CHECK-ENCODING: [0x07,0x00,0xb5,0x02]
# CHECK-ERROR: instruction requires the following: 'V' (Vector Instructions)
# CHECK-UNKNOWN: 07 00 b5 02 <unknown>
vle1.v v8, (a0) vle1.v v8, (a0)
# CHECK-INST: vle1.v v8, (a0) # CHECK-INST: vle1.v v8, (a0)
# CHECK-ENCODING: [0x07,0x04,0xb5,0x02] # CHECK-ENCODING: [0x07,0x04,0xb5,0x02]
# CHECK-ERROR: instruction requires the following: 'V' (Vector Instructions) # CHECK-ERROR: instruction requires the following: 'V' (Vector Instructions)
# CHECK-UNKNOWN: 07 04 b5 02 <unknown> # CHECK-UNKNOWN: 07 04 b5 02 <unknown>
vle8.v v8, (a0), v0.t vle8.v v8, (a0), v0.t
# CHECK-INST: vle8.v v8, (a0), v0.t # CHECK-INST: vle8.v v8, (a0), v0.t
▲ Show 20 Lines • Show All 333 Lines • Show Last 20 Lines