Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp | ||
---|---|---|
586–589 | Matt usually objects to this indentation change on the grounds that clang-format is wrong :) | |
2983–2984 | Pull this buildICmp out of the "if"s, since it is identical in both cases, and you don't want to build it twice in the divrem case? | |
llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h | ||
113 | It looks odd that you did not change the name of this function, but I see it is not implemented, so maybe just remove the declaration here? |
llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp | ||
---|---|---|
586–589 | Oh. It was auto-formatted by clang-format. | |
2983–2984 | Thanks Jay. It is addressed with D103083. | |
llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h | ||
113 | Yes, it was a dead declaration. Cleaned it up with e3b8e6d48251 |
clang-tidy: warning: invalid case style for function 'legalizeUnsignedDIV_REM' [readability-identifier-naming]
not useful