This is an archive of the discontinued LLVM Phabricator instance.

Differential D100655

[flang][nfc] Port 2 tests to use the new driver when enabled
ClosedPublic

Authored by awarzynski on Apr 16 2021, 8:33 AM.

Details

Reviewers
sscalpone
tskeith
Leporacanthicus
SouraVX
arnamoy10
DavidTruby
Commits
rGc2e452fb05a7: [flang][nfc] Port 2 tests to use the new driver when enabled
Summary

This is similar to https://reviews.llvm.org/D100309, i.e. %f18 is
replaced with %flang_new.

resolve105.f90 wasn't in tree when D100309 was worked on, so it's
updated here instead.

label14.f90 requires -fsyntax-only. I didn't notice that when
submitting D100309, hence updating it now instead. -fsyntax-only is
required to prevent %f18 from calling an external compiler (which then
fails and returns a non-zero exit code).

Diff Detail

Event Timeline

awarzynski created this revision.Apr 16 2021, 8:33 AM
Herald added a reviewer: sscalpone. · View Herald TranscriptApr 16 2021, 8:33 AM
awarzynski requested review of this revision.Apr 16 2021, 8:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 16 2021, 8:33 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
awarzynski added reviewers: tskeith, Leporacanthicus, SouraVX, arnamoy10.Apr 16 2021, 8:35 AM
awarzynski added a project: Restricted Project.
Herald added a subscriber: jdoerfert. · View Herald TranscriptApr 16 2021, 8:35 AM
awarzynski added a comment.Apr 16 2021, 8:35 AM

@Leporacanthicus , since you reviewed https://reviews.llvm.org/D100309, would you mind checking this one as well?

Harbormaster completed remote builds in B99191: Diff 338130.Apr 16 2021, 9:59 AM
DavidTruby accepted this revision.Apr 20 2021, 3:05 AM
DavidTruby added a subscriber: DavidTruby.

LGTM

This revision is now accepted and ready to land.Apr 20 2021, 3:05 AM
Leporacanthicus accepted this revision.Apr 20 2021, 3:10 AM

LGTM

SouraVX accepted this revision.Apr 20 2021, 3:38 AM
Closed by commit rGc2e452fb05a7: [flang][nfc] Port 2 tests to use the new driver when enabled (authored by awarzynski). · Explain WhyApr 20 2021, 5:59 AM
This revision was automatically updated to reflect the committed changes.
awarzynski added a commit: rGc2e452fb05a7: [flang][nfc] Port 2 tests to use the new driver when enabled.

Revision Contents

PathSize
flang/
test/
Semantics/
2 lines
2 lines

Diff 338841

flang/test/Semantics/label14.f90

! Tests implemented for this standard ! Tests implemented for this standard
! 11.1.4 - 4 It is permissible to branch to and end-block-stmt only withinh its ! 11.1.4 - 4 It is permissible to branch to and end-block-stmt only withinh its
! Block Construct ! Block Construct
! RUN: not %f18 %s 2>&1 | FileCheck %s ! RUN: %flang_fc1 -fsyntax-only %s 2>&1 | FileCheck %s
! CHECK: Label '20' is not in scope ! CHECK: Label '20' is not in scope
subroutine s1 subroutine s1
block block
goto (10) 1 goto (10) 1
10 end block 10 end block
block block
Show All 27 Lines

flang/test/Semantics/resolve105.f90

! RUN: %S/test_errors.sh %s %t %f18 ! RUN: %S/test_errors.sh %s %t %flang_fc1
! Test instantiation of components that are procedure pointers. ! Test instantiation of components that are procedure pointers.
! !
program test program test
type dtype(kindParam) type dtype(kindParam)
integer, kind :: kindParam = 4 integer, kind :: kindParam = 4
!ERROR: KIND parameter value (66) of intrinsic type REAL did not resolve to a supported value !ERROR: KIND parameter value (66) of intrinsic type REAL did not resolve to a supported value
!ERROR: KIND parameter value (55) of intrinsic type REAL did not resolve to a supported value !ERROR: KIND parameter value (55) of intrinsic type REAL did not resolve to a supported value
procedure (real(kindParam)), pointer, nopass :: field => null() procedure (real(kindParam)), pointer, nopass :: field => null()
▲ Show 20 Lines • Show All 73 Lines • Show Last 20 Lines