Page MenuHomePhabricator

[Debug-Info][DBX] DW_AT_noreturn should not be generated when dwarf version is not 5
AbandonedPublic

Authored by shchenz on Fri, Apr 16, 2:25 AM.

Details

Reviewers
dblaikie
aprantl
probinson
jsji
Esme
echristo
Group Reviewers
Restricted Project
Summary

As discussed in D99250 , we added a new tuning debugger DBX(D99400) to add some debug info customizations for DBX on AIX.

This is part of the customizations, not generating DWARF infos not matching the DWARF version.

This patch is for attribute DW_AT_noreturn which is introduced in DWARF 5.

Now for DBX, we only generate this attribute when DWARF version is 5 or higher.

Diff Detail

Event Timeline

shchenz created this revision.Fri, Apr 16, 2:25 AM
shchenz requested review of this revision.Fri, Apr 16, 2:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Apr 16, 2:25 AM
shchenz planned changes to this revision.Mon, Apr 19, 8:53 PM
shchenz updated this revision to Diff 338765.Tue, Apr 20, 1:35 AM

1: use strict dwarf flag instead of DBX debugger

shchenz abandoned this revision.Thu, Apr 22, 12:16 AM

we use a new way in D101024, so this is not needed

aprantl added inline comments.Fri, Apr 23, 9:58 AM
llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
1281

Should we factor out a FlagSupported(attribute) function? I think Dwarf.def already stores the version in which an attribute was introduced, so we don't need to duplicate this in the code here?

shchenz added inline comments.Sat, Apr 24, 5:39 PM
llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
1281

Thanks Adrian, @aprantl . Great minds think alike, haha. All of you, including @probinson and @dblaikie have the same opinions for this change. I have added the function in D101125 and abandoned related patches including this one.