Page MenuHomePhabricator

[mlir] Add a vscode language extension for MLIR
ClosedPublic

Authored by rriddle on Apr 15 2021, 4:35 PM.

Details

Summary

This utilizes the mlir-lsp server to provide language services for MLIR files opened in vscode. The extension currently supports syntax highlighting, as well as tracking definitions/uses/source locations for SSA values and blocks.

Depends On D100439

Diff Detail

Event Timeline

rriddle created this revision.Apr 15 2021, 4:35 PM
rriddle requested review of this revision.Apr 15 2021, 4:35 PM

If it works, that'll be good enough for me :)

I'm looking forward for better "getting started" instruction on the website though: something step by step with screenshots of VSCode, or alternatively a screencast on YouTube! :)

mehdi_amini accepted this revision.Apr 15 2021, 4:52 PM
This revision is now accepted and ready to land.Apr 15 2021, 4:52 PM
jpienaar accepted this revision.Apr 21 2021, 1:36 PM
jpienaar added inline comments.
mlir/utils/vscode/package.json
37

I'm missing this file. Will it be generated from the grammer file already in tree?

rriddle marked an inline comment as done.Apr 21 2021, 2:35 PM
rriddle added inline comments.
mlir/utils/vscode/package.json
37

Right now I just added a comment in the docs that it needs to be copied when developing in-tree. I'm going to try adding it as part of the build step in a followup, but I need to figure out how to do that first.

This revision was automatically updated to reflect the committed changes.
rriddle marked an inline comment as done.