Page MenuHomePhabricator

[PoC] Reduce impact `riscv_vector.h` when testing
Needs ReviewPublic

Authored by rogfer01 on Apr 15 2021, 12:14 AM.

Details

Summary

Not to be commited.

This patch is a proof of concept of a way to reduce the impact of the size of riscv_vector.h when testing.

Diff Detail

Event Timeline

rogfer01 created this revision.Apr 15 2021, 12:14 AM
rogfer01 requested review of this revision.Apr 15 2021, 12:15 AM

I think using this proxy header for testing seems good.

IMO, maybe we still need to find a way to reduce the compilation time for better user experience.

asb added a comment.Apr 29 2021, 8:50 AM

I think using this proxy header for testing seems good.

IMO, maybe we still need to find a way to reduce the compilation time for better user experience.

Somewhat outside the scope of this review, but noting here for posterity seeing as we discussed it in the RISC-V sync-up today:

  • It may be worth looking at the related discussion about parsing OpenCL headers (the thread moved on to discussing how the same problem applies to x86 intrinsics)
  • Kito pointed out that for SVE, GCC implemented something like the approach by by providing #pragma GCC aarch64 "arm_sve.h" which is used as the body of arm_sve.h