This information isn't useful for general compilation, but is useful for building tools that process .mlir files. This class will be used in a followup to start building an LSP language server for MLIR.
Depends On D100437
Paths
| Differential D100438
[mlir] Add a new AsmParserState class to capture detailed source information for .mlir files ClosedPublic Authored by rriddle on Apr 13 2021, 7:55 PM.
Details Summary This information isn't useful for general compilation, but is useful for building tools that process .mlir files. This class will be used in a followup to start building an LSP language server for MLIR. Depends On D100437
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Apr 13 2021, 8:44 PM Comment Actions Nice, thanks. And so only overhead here is checking if null in regular execution?
This revision was landed with ongoing or failed builds.Apr 21 2021, 2:46 PM Closed by commit rGf8ac31314b42: Add a new AsmParserState class to capture detailed source information for .mlir… (authored by rriddle). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 337319 mlir/include/mlir/Parser.h
mlir/include/mlir/Parser/AsmParserState.h
mlir/lib/Parser/AsmParserState.cpp
mlir/lib/Parser/CMakeLists.txt
mlir/lib/Parser/DialectSymbolParser.cpp
mlir/lib/Parser/Parser.h
mlir/lib/Parser/Parser.cpp
mlir/lib/Parser/ParserState.h
|
Could you document AsmParserState usage here? (e.g., when should it be passed in, when does it not need to, what are the considerations while doing so)