This is an archive of the discontinued LLVM Phabricator instance.

Differential D100301

[flang] Fix a test (use %s instead of $s)
ClosedPublic

Authored by awarzynski on Apr 12 2021, 5:38 AM.

Details

Reviewers
arnamoy10
ashermancinelli
SouraVX
klausler
kiranchandramohan
AMDChirag
Commits
rG4217e6bf95f5: [flang] Fix a test (use %s instead of $s)
Summary

With the typo ($S instead of %s), the driver was expecting
input from stdin. In such cases, it prints:

Enter Fortran source
Use EOF character (^D) to end file

This was piped to FileCheck. Together with the available CHECK-NOT
statement, this was sufficient for the test to pass (incorrectly).

This patch makes sure that the provided input file is used instead of
stdin.

Diff Detail

Event Timeline

awarzynski requested review of this revision.Apr 12 2021, 5:38 AM
awarzynski created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2021, 5:38 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
awarzynski added reviewers: arnamoy10, ashermancinelli, SouraVX, klausler, kiranchandramohan, AMDChirag.Apr 12 2021, 5:41 AM
awarzynski added a project: Restricted Project.
Herald added a subscriber: jdoerfert. · View Herald TranscriptApr 12 2021, 5:41 AM
arnamoy10 accepted this revision.Apr 12 2021, 5:52 AM

LGTM

This revision is now accepted and ready to land.Apr 12 2021, 5:52 AM
Harbormaster completed remote builds in B98259: Diff 336811.Apr 12 2021, 6:06 AM
Closed by commit rG4217e6bf95f5: [flang] Fix a test (use %s instead of $s) (authored by awarzynski). · Explain WhyApr 13 2021, 3:04 AM
This revision was automatically updated to reflect the committed changes.
awarzynski added a commit: rG4217e6bf95f5: [flang] Fix a test (use %s instead of $s).

Revision Contents

PathSize
flang/
test/
Semantics/
2 lines

Diff 336811

flang/test/Semantics/call17.f90

! RUN: %f18 -fsyntax-only $s 2>&1 | FileCheck %s ! RUN: %f18 -fsyntax-only %s 2>&1 | FileCheck %s --allow-empty
! Regression test: don't emit a bogus error about an invalid specification expression ! Regression test: don't emit a bogus error about an invalid specification expression
! in the declaration of a binding ! in the declaration of a binding
module m module m
type :: t type :: t
integer :: n integer :: n
contains contains
Show All 10 Lines