Page MenuHomePhabricator

[OpenMP] [OMPD] [4/6] Implementation of OMPD debugging library - libompd. omp-icv: OMPD Internal control variable handlers.
ClosedPublic

Authored by Vigneshbalu on Apr 9 2021, 5:26 AM.

Details

Summary

This is part of review: https://reviews.llvm.org/D100181
Handlers of the OMPD internal control variable. It helps retrieving ICV values when called for the current state.

Diff Detail

Event Timeline

Vigneshbalu created this revision.Apr 9 2021, 5:26 AM
Vigneshbalu requested review of this revision.Apr 9 2021, 5:26 AM
Herald added a project: Restricted Project. · View Herald Transcript
Vigneshbalu changed the visibility from "Public (No Login Required)" to "Vigneshbalu (Vignesh Balasubramanian)".Apr 9 2021, 7:55 AM
Vigneshbalu changed the visibility from "Vigneshbalu (Vignesh Balasubramanian)" to "Public (No Login Required)".Apr 11 2021, 9:48 AM

Addressed clang-tidy warnings.

Rebasing the patch.

Rebasing the patch.

Vigneshbalu edited the summary of this revision. (Show Details)

Rebasing.

Gentle Reminder.

Gentle Reminder !.

hbae added inline comments.Oct 21 2021, 4:58 PM
openmp/libompd/src/omp-icv.cpp
83

Can we move // clang-format on at line 22 to here and make FOREACH_OMPD_ICV more readable?

Addressed review comment.

Vigneshbalu marked an inline comment as done.Oct 24 2021, 9:09 PM
hbae accepted this revision.Oct 26 2021, 4:10 PM

LGTM

This revision is now accepted and ready to land.Oct 26 2021, 4:10 PM