Page MenuHomePhabricator

[OpenMP] [OMPD] [4/6] Implementation of OMPD debugging library - libompd. omp-icv: OMPD Internal control variable handlers.
ClosedPublic

Authored by Vigneshbalu on Apr 9 2021, 5:26 AM.

Details

Summary

This is part of review: https://reviews.llvm.org/D100181
Handlers of the OMPD internal control variable. It helps retrieving ICV values when called for the current state.

Diff Detail

Unit TestsFailed

TimeTest
1,160 msx64 debian > libomp.ompt/parallel::max_active_levels_serialized.c
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test -I /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/src -L /mnt/disks/ssd0/agent/llvm-project/build/lib -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt/parallel/max_active_levels_serialized.c -o /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/ompt/parallel/Output/max_active_levels_serialized.c.tmp -lm -latomic && /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/ompt/parallel/Output/max_active_levels_serialized.c.tmp | tee /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/ompt/parallel/Output/max_active_levels_serialized.c.tmp.out | /mnt/disks/ssd0/agent/llvm-project/build/./bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt/parallel/max_active_levels_serialized.c
1,240 msx64 debian > libomp.ompt/parallel::nested_lwt.c
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test -I /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/src -L /mnt/disks/ssd0/agent/llvm-project/build/lib -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt/parallel/nested_lwt.c -o /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/ompt/parallel/Output/nested_lwt.c.tmp -lm -latomic && /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/ompt/parallel/Output/nested_lwt.c.tmp | tee /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/ompt/parallel/Output/nested_lwt.c.tmp.out | /mnt/disks/ssd0/agent/llvm-project/build/./bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt/parallel/nested_lwt.c
920 msx64 debian > libomp.ompt/parallel::nested_serialized.c
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test -I /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/src -L /mnt/disks/ssd0/agent/llvm-project/build/lib -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt/parallel/nested_serialized.c -o /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/ompt/parallel/Output/nested_serialized.c.tmp -lm -latomic && /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/ompt/parallel/Output/nested_serialized.c.tmp | tee /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/ompt/parallel/Output/nested_serialized.c.tmp.out | /mnt/disks/ssd0/agent/llvm-project/build/./bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt/parallel/nested_serialized.c
630 msx64 debian > libomp.ompt/parallel::parallel_if0.c
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test -I /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/src -L /mnt/disks/ssd0/agent/llvm-project/build/lib -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt/parallel/parallel_if0.c -o /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/ompt/parallel/Output/parallel_if0.c.tmp -lm -latomic && /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/ompt/parallel/Output/parallel_if0.c.tmp | tee /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/ompt/parallel/Output/parallel_if0.c.tmp.out | /mnt/disks/ssd0/agent/llvm-project/build/./bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt/parallel/parallel_if0.c
560 msx64 debian > libomp.ompt/parallel::serialized.c
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test -I /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/src -L /mnt/disks/ssd0/agent/llvm-project/build/lib -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt/parallel/serialized.c -o /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/ompt/parallel/Output/serialized.c.tmp -lm -latomic && /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/ompt/parallel/Output/serialized.c.tmp | tee /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/ompt/parallel/Output/serialized.c.tmp.out | /mnt/disks/ssd0/agent/llvm-project/build/./bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt/parallel/serialized.c
View Full Test Results (6 Failed)

Event Timeline

Vigneshbalu created this revision.Apr 9 2021, 5:26 AM
Vigneshbalu requested review of this revision.Apr 9 2021, 5:26 AM
Herald added a project: Restricted Project. · View Herald Transcript
Vigneshbalu changed the visibility from "Public (No Login Required)" to "Vigneshbalu (Vignesh Balasubramanian)".Apr 9 2021, 7:55 AM
Vigneshbalu changed the visibility from "Vigneshbalu (Vignesh Balasubramanian)" to "Public (No Login Required)".Apr 11 2021, 9:48 AM

Addressed clang-tidy warnings.

Rebasing the patch.

Rebasing the patch.

Vigneshbalu edited the summary of this revision. (Show Details)

Rebasing.

Gentle Reminder.

Gentle Reminder !.

hbae added inline comments.Oct 21 2021, 4:58 PM
openmp/libompd/src/omp-icv.cpp
84

Can we move // clang-format on at line 22 to here and make FOREACH_OMPD_ICV more readable?

Addressed review comment.

Vigneshbalu marked an inline comment as done.Oct 24 2021, 9:09 PM
hbae accepted this revision.Oct 26 2021, 4:10 PM

LGTM

This revision is now accepted and ready to land.Oct 26 2021, 4:10 PM