Page MenuHomePhabricator

[mlir][spirv] Timely fail type conversion
ClosedPublic

Authored by antiagainst on Wed, Apr 7, 11:40 AM.

Details

Summary

Per the TypeConverter API contract, returning llvm:None means
other conversion rules should be tried. But we only have one
rule per input type. So there is no need to try others and we can
just directly fail, which should return nullptr. This avoids
unnecessary checks.

Diff Detail