Page MenuHomePhabricator

[mlir][spirv] Timely fail type conversion
AbandonedPublic

Authored by hanchung on Apr 8 2021, 7:34 AM.

Details

Summary

Mirror of https://reviews.llvm.org/D100058

Per the TypeConverter API contract, returning llvm:None means
other conversion rules should be tried. But we only have one
rule per input type. So there is no need to try others and we can
just directly fail, which should return nullptr. This avoids
unnecessary checks.

Diff Detail