Page MenuHomePhabricator

[X86][FPEnv] Lowering of {get,set,reset}_fpenv
Needs ReviewPublic

Authored by sepavloff on Jun 15 2020, 3:13 AM.

Details

Summary

The change implements lowering of get_fpenv, set_fpenv and
reset_fpenv.

Diff Detail

Event Timeline

sepavloff created this revision.Jun 15 2020, 3:13 AM
Herald added a project: Restricted Project. · View Herald Transcript
sepavloff updated this revision to Diff 270701.Jun 15 2020, 3:20 AM

Fixed formatting issues

craig.topper added inline comments.Jun 15 2020, 12:21 PM
llvm/lib/Target/X86/X86SelectionDAGInfo.cpp
390 ↗(On Diff #270701)

Windows defaults to 53 bit precision.

sepavloff updated this revision to Diff 272365.Jun 22 2020, 2:59 AM

Updated patch after update of dependency

sepavloff marked 2 inline comments as done.Jun 22 2020, 3:02 AM
sepavloff added inline comments.
llvm/lib/Target/X86/X86SelectionDAGInfo.cpp
390 ↗(On Diff #270701)

Fixed.

kpn added a subscriber: kpn.Jun 23 2020, 12:34 PM
sepavloff marked an inline comment as done.

Updated patch

  • Remove changes related to fix for mayLoad/mayStore properties, the relevant changes are already in master,
  • Removed lowering of ISD::GET_FPENV and friends. This operation is useless as lowering of FPEnv intrinsics is made when constructing DAG.
lebedev.ri resigned from this revision.Aug 12 2020, 2:36 PM

Intrinsics now do not use pointers