Page MenuHomePhabricator

spatel (Sanjay Patel)
User

Projects

User does not belong to any projects.

User Details

User Since
May 22 2014, 1:24 PM (347 w, 2 d)

Recent Activity

Today

spatel committed rG49b96cd9ef2f: [SLP] remove opcode field from reduction data class (authored by spatel).
[SLP] remove opcode field from reduction data class
Sat, Jan 16, 11:11 AM
spatel committed rGfcfcc3cc6b16: [SLP] fix typos; NFC (authored by spatel).
[SLP] fix typos; NFC
Sat, Jan 16, 11:11 AM
spatel committed rG48dbac5b6b0b: [SLP] remove unnecessary use of 'OperationData' (authored by spatel).
[SLP] remove unnecessary use of 'OperationData'
Sat, Jan 16, 11:11 AM

Yesterday

spatel committed rGceb3cdccd0fb: [SLP] remove dead code in reduction matching; NFC (authored by spatel).
[SLP] remove dead code in reduction matching; NFC
Fri, Jan 15, 2:03 PM
spatel committed rG1f21de535d37: [SLP] remove unused reduction functions; NFC (authored by spatel).
[SLP] remove unused reduction functions; NFC
Fri, Jan 15, 11:59 AM

Thu, Jan 14

spatel committed rGb21905dfe379: [SLP] remove unnecessary state in matching reductions (authored by spatel).
[SLP] remove unnecessary state in matching reductions
Thu, Jan 14, 3:32 PM

Wed, Jan 13

spatel committed rG123674a81674: [SLP] simplify type check for reductions (authored by spatel).
[SLP] simplify type check for reductions
Wed, Jan 13, 10:31 AM
spatel added a comment to D94576: [LoopVectorize] Guard verifyFunction with EXPENSIVE_CHECKS macro.
Wed, Jan 13, 8:52 AM · Restricted Project
spatel committed rGe433ca28ec92: [SLP] add reduction test for FMF; NFC (authored by spatel).
[SLP] add reduction test for FMF; NFC
Wed, Jan 13, 8:44 AM

Tue, Jan 12

spatel committed rG9e7895a8682c: [SLP] reduce code duplication while processing reductions; NFC (authored by spatel).
[SLP] reduce code duplication while processing reductions; NFC
Tue, Jan 12, 1:05 PM
spatel committed rG92fb5c49e8aa: [SLP] rename variable to improve readability; NFC (authored by spatel).
[SLP] rename variable to improve readability; NFC
Tue, Jan 12, 1:05 PM
spatel committed rG554be30a4280: [SLP] reduce code duplication in processing reductions; NFC (authored by spatel).
[SLP] reduce code duplication in processing reductions; NFC
Tue, Jan 12, 1:05 PM
spatel committed rG46507a96fc13: [SLP] reduce code duplication while matching reductions; NFC (authored by spatel).
[SLP] reduce code duplication while matching reductions; NFC
Tue, Jan 12, 1:05 PM

Mon, Jan 11

spatel committed rG288f3fc5dfee: [InstCombine] reduce icmp(ashr X, C1), C2 to sign-bit test (authored by spatel).
[InstCombine] reduce icmp(ashr X, C1), C2 to sign-bit test
Mon, Jan 11, 12:54 PM
spatel closed D94014: [InstCombine] reduce icmp(ashr X, C1), C2 to sign-bit test.
Mon, Jan 11, 12:53 PM · Restricted Project
spatel added a comment to D94433: [ValueTracking] Check that alignment is non-zero in computeKnownBitsFromAssume (PR48713)..

Please upload patch with context:
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Mon, Jan 11, 11:04 AM · Restricted Project
spatel added reviewers for D94433: [ValueTracking] Check that alignment is non-zero in computeKnownBitsFromAssume (PR48713).: scui, jdoerfert.

Adding more potential reviewers based on D88669 (where this code was added).

Mon, Jan 11, 11:02 AM · Restricted Project
spatel added a comment to D94014: [InstCombine] reduce icmp(ashr X, C1), C2 to sign-bit test.

Another way is to use assume to encode the precondition if you prefer: https://alive2.llvm.org/ce/z/__szVL

Mon, Jan 11, 9:37 AM · Restricted Project
spatel added a comment to D94014: [InstCombine] reduce icmp(ashr X, C1), C2 to sign-bit test.

Anyone see problems with this Alive2 implementation using count-leading-*?
https://alive2.llvm.org/ce/z/SWxadd

Mon, Jan 11, 8:09 AM · Restricted Project
spatel updated subscribers of D94014: [InstCombine] reduce icmp(ashr X, C1), C2 to sign-bit test.

alive1 does not actually have a countLeadingOnes() precondition

Mon, Jan 11, 7:18 AM · Restricted Project
spatel updated the diff for D94014: [InstCombine] reduce icmp(ashr X, C1), C2 to sign-bit test.

Ping.
Note: I added a bitwidth > 2 constraint to be safe and avoid degenerate narrow bit patterns, but I'm not sure how to write negative tests for that would actually survive to this point in instcombine (instsimplify appears to reduce those first).

Mon, Jan 11, 6:14 AM · Restricted Project

Sun, Jan 10

spatel committed rG3f09c77d33dc: [SLP] fix typo in assert (authored by spatel).
[SLP] fix typo in assert
Sun, Jan 10, 10:16 AM
spatel committed rG0aa75fb12faa: [SLP] put verifyFunction call behind EXPENSIVE_CHECKS (authored by spatel).
[SLP] put verifyFunction call behind EXPENSIVE_CHECKS
Sun, Jan 10, 10:05 AM
spatel closed D94328: [SLP] put verifyFunction call behind EXPENSIVE_CHECKS.
Sun, Jan 10, 10:05 AM · Restricted Project

Fri, Jan 8

spatel requested review of D94328: [SLP] put verifyFunction call behind EXPENSIVE_CHECKS.
Fri, Jan 8, 11:30 AM · Restricted Project
spatel committed rG267ff7901c74: [SLP] limit verifyFunction to debug build (PR48689) (authored by spatel).
[SLP] limit verifyFunction to debug build (PR48689)
Fri, Jan 8, 5:10 AM

Thu, Jan 7

spatel committed rG4c7148d75cd7: [SLP] remove opcode identifier for reduction; NFC (authored by spatel).
[SLP] remove opcode identifier for reduction; NFC
Thu, Jan 7, 11:07 AM
spatel updated subscribers of D89697: * [x86] Implement smarter instruction lowering for FP_TO_UINT from vXf32 to vXi32 for SSE2 and AVX2 by using the exact semantic of the CVTTPS2SI instruction..

No regression appeared in our internal testcases.
It seems the transform is correct, have you verified it with alive-tv?

Thu, Jan 7, 10:34 AM · Restricted Project

Wed, Jan 6

spatel committed rG4c022b5a41de: [SLP] use reduction kind's opcode to create new instructions; NFC (authored by spatel).
[SLP] use reduction kind's opcode to create new instructions; NFC
Wed, Jan 6, 11:38 AM
spatel committed rG5d24089a7001: [SLP] reduce code for propagating flags on reductions; NFC (authored by spatel).
[SLP] reduce code for propagating flags on reductions; NFC
Wed, Jan 6, 11:38 AM
spatel accepted D93599: [DAG] Simplify OR(X,SHL(Y,BW/2)) eq/ne 0/-1 'all/any-of' style patterns.

LGTM - see inline for possible missed comment.

Wed, Jan 6, 10:37 AM · Restricted Project
spatel added inline comments to D93599: [DAG] Simplify OR(X,SHL(Y,BW/2)) eq/ne 0/-1 'all/any-of' style patterns.
Wed, Jan 6, 9:03 AM · Restricted Project
spatel accepted D93891: [DAGCombine] Remove the check for unsafe-fp-math when we are checking the AFN.

Hmm, so we can try to remove those parts that not relative with the parameter arsenm mentioned. I guess most of the check in the DAGCombiner could be removed if I understand correctly. To remove it completely, some work is needed for parameters or others that current IR cannot represent the semantics of the global setting. Is it right ?

Maybe, we can start it with this simple patch first ?

Wed, Jan 6, 8:01 AM · Restricted Project
spatel added a comment to D94069: [NFC][InstructionCost]Migrate VectorCombine.cpp to use InstructionCost.

I haven't followed the details enough to comment on the changes directly, but thanks for the cleanup! The mismatched signed/unsigned cost model APIs are/were a mess.

Wed, Jan 6, 7:42 AM · Restricted Project

Tue, Jan 5

spatel committed rG6a03f8ab629b: [SLP] reduce code for finding reduction costs; NFC (authored by spatel).
[SLP] reduce code for finding reduction costs; NFC
Tue, Jan 5, 2:36 PM
spatel committed rG5a1d31a28490: [SLP] use reduction kind's opcode for cost model queries; NFC (authored by spatel).
[SLP] use reduction kind's opcode for cost model queries; NFC
Tue, Jan 5, 12:27 PM
spatel committed rGd4a999b453a4: [SLP] reduce code duplication; NFC (authored by spatel).
[SLP] reduce code duplication; NFC
Tue, Jan 5, 12:27 PM
spatel accepted D94056: [CodeGen] Update transformations to use poison for shufflevector/insertelem's initial vector elem.

LGTM - other reviewers are probably more familiar with InterleavedAccess than me, so might want to wait for a 2nd opinion.
I made another assert suggestion for that code. Similar to the assert that you have proposed in this patch, we could add the asserts before this patch just to make the shuffle assumptions clearer (assuming those are correct assertions).

Tue, Jan 5, 11:32 AM · Restricted Project
spatel committed rG3b8b2c7da2ef: [SLP] delete unused pairwise reduction option (authored by spatel).
[SLP] delete unused pairwise reduction option
Tue, Jan 5, 10:39 AM
spatel closed D93860: [SLP] delete unused pairwise reduction option.
Tue, Jan 5, 10:39 AM · Restricted Project
spatel added a comment to D93599: [DAG] Simplify OR(X,SHL(Y,BW/2)) eq/ne 0/-1 'all/any-of' style patterns.

Does this work with scalars too? Let me know if I missed the test(s).

Tue, Jan 5, 9:07 AM · Restricted Project

Mon, Jan 4

spatel committed rG36263a7cccc0: [LoopUtils] remove redundant opcode parameter; NFC (authored by spatel).
[LoopUtils] remove redundant opcode parameter; NFC
Mon, Jan 4, 2:05 PM
spatel committed rG976695752416: [LoopUtils] reduce code for creatng reduction; NFC (authored by spatel).
[LoopUtils] reduce code for creatng reduction; NFC
Mon, Jan 4, 1:05 PM
spatel committed rG58b6c5d932a0: [LoopUtils] reorder logic for creating reduction; NFC (authored by spatel).
[LoopUtils] reorder logic for creating reduction; NFC
Mon, Jan 4, 1:05 PM
spatel committed rG6976812129bf: [InstCombine] add tests for ashr+icmp; NFC (authored by spatel).
[InstCombine] add tests for ashr+icmp; NFC
Mon, Jan 4, 10:35 AM
spatel updated the diff for D94014: [InstCombine] reduce icmp(ashr X, C1), C2 to sign-bit test.

Patch updated:
Fixed semi-colon typos in test comments.

Mon, Jan 4, 10:14 AM · Restricted Project
spatel added inline comments to D94014: [InstCombine] reduce icmp(ashr X, C1), C2 to sign-bit test.
Mon, Jan 4, 10:14 AM · Restricted Project
spatel requested review of D94014: [InstCombine] reduce icmp(ashr X, C1), C2 to sign-bit test.
Mon, Jan 4, 9:13 AM · Restricted Project

Fri, Jan 1

spatel committed rGc74e8539ff37: [Analysis] flatten enums for recurrence types (authored by spatel).
[Analysis] flatten enums for recurrence types
Fri, Jan 1, 9:46 AM
spatel committed rGc182a000954d: [Analysis] fix typo in code comment; NFC (authored by spatel).
[Analysis] fix typo in code comment; NFC
Fri, Jan 1, 9:45 AM

Thu, Dec 31

spatel committed rGeaab71106b81: [Analysis] reduce code for matching min/max; NFC (authored by spatel).
[Analysis] reduce code for matching min/max; NFC
Thu, Dec 31, 2:20 PM
spatel added a comment to D93860: [SLP] delete unused pairwise reduction option.

Yep, that's definitely wrong. But I think FMF propagation is not an easy thing. We cannot always copy the original FMF, right? E.g. reassoc reduction may result in inf which "sequential" doesn't. Should ninf be propagated or not after reduction?

Thu, Dec 31, 7:02 AM · Restricted Project
spatel accepted D92015: [DAGCombiner] Fold BRCOND(FREEZE(COND)) to BRCOND(COND).

LGTM - please pre-commit the test with the current (trunk) codegen, so we see the diff (and don't lose the test in case we have to revert).

Thu, Dec 31, 6:20 AM · Restricted Project

Wed, Dec 30

spatel committed rG8ca60db40bd9: [LoopUtils] reduce FMF and min/max complexity when forming reductions (authored by spatel).
[LoopUtils] reduce FMF and min/max complexity when forming reductions
Wed, Dec 30, 12:31 PM
spatel committed rG5ced712e9851: [LoopVectorizer] add test to show wrong FMF propagation; NFC (authored by spatel).
[LoopVectorizer] add test to show wrong FMF propagation; NFC
Wed, Dec 30, 12:22 PM
spatel added a comment to D93860: [SLP] delete unused pairwise reduction option.

SLP requires fast as a pre-condition before matching a reduction (although I'm not sure if that implementation is completely sound), so the hard-coded logic:

Unsafe.setFast();
Builder.setFastMathFlags(Unsafe);

...is theoretically safe here. But yes, that is one bug I am hoping to fix. LoopVectorizer appears to have different bug(s).

Wed, Dec 30, 8:35 AM · Restricted Project
spatel committed rG3567908d8ceb: [SLP] add fadd reduction test to show broken FMF propagation; NFC (authored by spatel).
[SLP] add fadd reduction test to show broken FMF propagation; NFC
Wed, Dec 30, 8:33 AM
spatel added a comment to D93860: [SLP] delete unused pairwise reduction option.

Hi Sanjay, pairwise reduction seems not adopted by any targets. But do we need to consider the FMF here? I found LangRef says the intrinsic is sequential for fadd and fmul if reassoc flag is not set.

Hi @pengfei -
Sorry for the delayed reply - I did not get an email notification for your comment here in Phab.

We do not need to care about FMF directly here because neither of these shuffle variations corresponds to "sequential" reduction of the elements. In other words, we should require reassoc (at the least) to form an fadd or fmul reduction that is expected to need any shuffles. Let me know if you see any holes in that theory.

One motivation for this cleanup is to correct bugs with using/propagating FMF (that was also true for D87416). For example - https://llvm.org/PR35538

Thanks for explanation. I was confused it with reduction intrinsics. I noticed tryToReduce sets fast flag instead of requires. Is that the problem you mentioned? By the way, can we build reduction intrinsics directly here instead of doing shuffle?

Wed, Dec 30, 7:45 AM · Restricted Project
spatel committed rGe90ea76380d4: [IR] remove 'NoNan' param when creating FP reductions (authored by spatel).
[IR] remove 'NoNan' param when creating FP reductions
Wed, Dec 30, 6:52 AM
spatel added reviewers for D93891: [DAGCombine] Remove the check for unsafe-fp-math when we are checking the AFN: aemerson, craig.topper, fhahn.

We're trying to (very slowly...) move away from needing the global/target options. Also, I'm not sure how those translate with GlobalISel.
If there's a real-world case where the target options do not match the fast-math-flags on the IR, we should investigate if that was unexpected. Otherwise, I would prefer that we not add to the uses of target options.

Hmm, do you know the specific reason that it is removed so slowly ... (What I imagine is just removing it and update some tests. Some targets still want it ?) It is not right to me that it is handled inconsistent. i.e.
FPOW didn't check the unsafe-fp-math while SQRT check it.

Wed, Dec 30, 6:08 AM · Restricted Project
spatel added a comment to D93860: [SLP] delete unused pairwise reduction option.

Hi Sanjay, pairwise reduction seems not adopted by any targets. But do we need to consider the FMF here? I found LangRef says the intrinsic is sequential for fadd and fmul if reassoc flag is not set.

Wed, Dec 30, 5:48 AM · Restricted Project
spatel accepted D93923: Use unary CreateShuffleVector if possible.

See inline comments to avoid bot failures - otherwise, LGTM. Thanks for the cleanup!

Wed, Dec 30, 5:11 AM · Restricted Project, Restricted Project

Tue, Dec 29

spatel committed rG8d18bc8e6db7: [Utils] reduce code in createTargetReduction(); NFC (authored by spatel).
[Utils] reduce code in createTargetReduction(); NFC
Tue, Dec 29, 1:06 PM
spatel committed rG21a3a0225d84: [SLP] replace local reduction enum with RecurrenceKind; NFCI (authored by spatel).
[SLP] replace local reduction enum with RecurrenceKind; NFCI
Tue, Dec 29, 11:53 AM
spatel added inline comments to D93817: [InstCombine] Update transformations to use poison for insertelement/shufflevector's placeholder value (2/2).
Tue, Dec 29, 7:53 AM · Restricted Project, Restricted Project
spatel added a comment to D93891: [DAGCombine] Remove the check for unsafe-fp-math when we are checking the AFN.

We're trying to (very slowly...) move away from needing the global/target options. Also, I'm not sure how those translate with GlobalISel.
If there's a real-world case where the target options do not match the fast-math-flags on the IR, we should investigate if that was unexpected. Otherwise, I would prefer that we not add to the uses of target options.

Tue, Dec 29, 7:32 AM · Restricted Project
spatel added inline comments to D93793: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as placeholder.
Tue, Dec 29, 7:24 AM · Restricted Project, Restricted Project

Mon, Dec 28

spatel committed rG236c4524a7cd: [InstSimplify] remove ctpop of 1 (low) bit (authored by spatel).
[InstSimplify] remove ctpop of 1 (low) bit
Mon, Dec 28, 1:08 PM
spatel committed rG1351f719d496: [InstSimplify] add tests for ctpop; NFC (PR48608) (authored by spatel).
[InstSimplify] add tests for ctpop; NFC (PR48608)
Mon, Dec 28, 1:08 PM
spatel requested review of D93860: [SLP] delete unused pairwise reduction option.
Mon, Dec 28, 8:12 AM · Restricted Project

Sat, Dec 26

spatel committed rGbadf0f20f3b3: [SLP] rename reduction variables for readability; NFC (authored by spatel).
[SLP] rename reduction variables for readability; NFC
Sat, Dec 26, 8:29 AM
spatel committed rGc4ca10896692: [SLP] use switch to improve readability; NFC (authored by spatel).
[SLP] use switch to improve readability; NFC
Sat, Dec 26, 8:29 AM

Tue, Dec 22

spatel committed rGf6929c01952b: [SLP] add reduction tests for maxnum/minnum intrinsics; NFC (authored by spatel).
[SLP] add reduction tests for maxnum/minnum intrinsics; NFC
Tue, Dec 22, 1:07 PM
spatel committed rG0d15d4b6f43a: [SLP] use operand index abstraction for number of operands (authored by spatel).
[SLP] use operand index abstraction for number of operands
Tue, Dec 22, 1:07 PM
spatel added a comment to D93586: [InstCombine] use poison as placeholder for undemanded elems.

There are 792 files in llvm/test, most of which are in test/Transform (119) and test/CodeGen(655).
The transition will be swiftly done (if there's no other issue hopefully) by the next weekend.

Thinking about these again, do we need to make a poison copy for test/CodeGen? I don't think so, since the backend won't be changed anyway.

Tue, Dec 22, 9:27 AM · Restricted Project, Restricted Project
spatel accepted D93274: [DAGCombiner] Don't create sexts of deleted xors when they were in-visit replaced.

LGTM - there's also a code pattern like this in DAGCombiner::rebuildSetCC(), so it's hopefully safe. But as noted, we can probably do better by changing the structure a bit.

Tue, Dec 22, 9:14 AM · Restricted Project

Mon, Dec 21

spatel accepted D93272: [InstCombine] Add checking of i1 types when converting select instructions into zext/sext instructions.

LGTM

Mon, Dec 21, 8:56 AM · Restricted Project, Restricted Project
spatel added inline comments to D93274: [DAGCombiner] Don't create sexts of deleted xors when they were in-visit replaced.
Mon, Dec 21, 8:51 AM · Restricted Project
spatel added reviewers for D93360: [LibCallSimplifier] fold memset(malloc(x), 0, x) to calloc(1, x) if memset is intrinsic: xbolva00, lebedev.ri.

Please review the comments in D16337 - especially:
https://reviews.llvm.org/D16337#331117

Mon, Dec 21, 7:49 AM · Restricted Project
spatel accepted D90625: [AggressiveInstCombine] Generalize foldGuardedRotateToFunnelShift to generic funnel shifts.

LGTM - the only diff from the earlier rev is that we now check the dominator tree to confirm that the shift ops are safe to hoist.

Mon, Dec 21, 6:19 AM · Restricted Project
spatel committed rG38ca7face67e: [InstSimplify] reduce logic with inverted add/sub ops (authored by spatel).
[InstSimplify] reduce logic with inverted add/sub ops
Mon, Dec 21, 6:15 AM
spatel committed rGd6118759f30e: [InstSimplify] add tests for inverted logic operands; NFC (authored by spatel).
[InstSimplify] add tests for inverted logic operands; NFC
Mon, Dec 21, 6:15 AM

Sun, Dec 20

spatel added reviewers for D93586: [InstCombine] use poison as placeholder for undemanded elems: nlopes, regehr, RKSimon, zhengyangl, nikic, hfinkel.

Thank you for working on this! Looking back at the bug comments (and adding reviewers based on those comments), this is a step towards killing undef that has been discussed for a long time now. :)

Sun, Dec 20, 6:39 AM · Restricted Project, Restricted Project

Fri, Dec 18

spatel committed rG37d0dda739aa: [SLP] fix typo; NFC (authored by spatel).
[SLP] fix typo; NFC
Fri, Dec 18, 1:56 PM
spatel committed rG47aaa99c0e1e: [VectorCombine] allow peeking through GEPs when creating a vector load (authored by spatel).
[VectorCombine] allow peeking through GEPs when creating a vector load
Fri, Dec 18, 6:25 AM
spatel closed D93229: [VectorCombine] allow peeking through GEPs when creating a vector load.
Fri, Dec 18, 6:25 AM · Restricted Project
spatel added inline comments to D93229: [VectorCombine] allow peeking through GEPs when creating a vector load.
Fri, Dec 18, 5:47 AM · Restricted Project

Dec 17 2020

spatel updated the diff for D93229: [VectorCombine] allow peeking through GEPs when creating a vector load.

Patch updated:
Adjusted order/spelling of offset checks as suggested. Also added a test (gep012) just below the offset cut-off, so we have positive and negative tests at the boundary condition.

Dec 17 2020, 1:57 PM · Restricted Project
spatel committed rG71a1b9fe76ac: [VectorCombine] add tests for gep load with cast; NFC (authored by spatel).
[VectorCombine] add tests for gep load with cast; NFC
Dec 17 2020, 1:41 PM
spatel added a comment to D93229: [VectorCombine] allow peeking through GEPs when creating a vector load.

We can use an alternate plan to make incremental progress, but it will cause redundancy while we transition:

  1. Replicate all of the regression tests with the poison constant instead of undef. If we add some unique TODO text marker on all of those new tests, we can then grep to make sure everything that we expect to get updated is actually updated in later steps.
  2. Update instcombine/simplify/vectorizer folds to match poison patterns (create a m_UndefOrPoison() pattern matcher?)

m_Undef already matches poison because PoisonValue is a subclass of UndefValue :)

  1. Run Alive2 through all of the updated regression tests to verify.
  2. Update codegen to deal with poison constant?
  3. Update folds from step 2 to create poison rather than undef (if that's what they were doing)?
  4. Change IRBuilder or other instruction creators to create poison from the start.

I think we can split the goal and first work on replacing the placeholder value that is used by insertelement only.
In this case, actually InstSimplify/InstCombine change isn't necessary as well. It can be done only when suboptimal assembly is being generated.
What do you think?

Dec 17 2020, 11:00 AM · Restricted Project
spatel updated the diff for D93229: [VectorCombine] allow peeking through GEPs when creating a vector load.

Patch updated:

  1. Added constraints on address offset with respect to vector element size.
  2. Added negative tests for those.
  3. Added asserts to make sure address assumptions are valid.
  4. Added code comment about offset math (negation) logic.
Dec 17 2020, 10:56 AM · Restricted Project
spatel added a comment to D93065: [InstCombine] Disable optimizations of select instructions that causes propagation of poison values.

However, on internal benchmarks I see much less degradation from the freeze solution compared to this patch.

Does this sound like a clue that we should go ahead with the freeze solution? If so I'll post the freeze solution and see how we can go from there.

Dec 17 2020, 10:40 AM · Restricted Project, Restricted Project
spatel added inline comments to D93229: [VectorCombine] allow peeking through GEPs when creating a vector load.
Dec 17 2020, 10:01 AM · Restricted Project
spatel added inline comments to D93229: [VectorCombine] allow peeking through GEPs when creating a vector load.
Dec 17 2020, 5:53 AM · Restricted Project
spatel accepted D93389: [InstCombine] Remove scalable vector restriction in InstCombineCasts.

Code changes look fairly mechanical at this point, so if the output is as expected, LGTM

Dec 17 2020, 4:53 AM · Restricted Project

Dec 16 2020

spatel committed rG46c331bf26d1: [VectorCombine] adjust test alignments for better coverage; NFC (authored by spatel).
[VectorCombine] adjust test alignments for better coverage; NFC
Dec 16 2020, 1:31 PM
spatel updated the diff for D93229: [VectorCombine] allow peeking through GEPs when creating a vector load.

Patch updated:
D93397 / D93406 improved the basic alignment logic, so that is adjusted here to include the effect of gep offset.
In the last test diff, note that the final alignment is not the same as either of the starting alignments.

Dec 16 2020, 1:29 PM · Restricted Project
spatel committed rG38ebc1a13dc8: [VectorCombine] optimize alignment for load transform (authored by spatel).
[VectorCombine] optimize alignment for load transform
Dec 16 2020, 12:27 PM
spatel closed D93406: [VectorCombine] optimize alignment for load transform.
Dec 16 2020, 12:26 PM · Restricted Project
spatel requested review of D93406: [VectorCombine] optimize alignment for load transform.
Dec 16 2020, 10:08 AM · Restricted Project