Page MenuHomePhabricator

MaskRay (Fangrui Song)
UserAdministrator

Projects

User Details

User Since
Dec 30 2016, 3:24 PM (204 w, 5 d)
Roles
Administrator

Recent Activity

Yesterday

MaskRay accepted D92478: [yaml2obj/obj2yaml] - Make fields of the `Symbol` to be optional..

LGTM.

Wed, Dec 2, 11:28 PM · Restricted Project
MaskRay requested review of D92543: Switch to std::is_trivially_move_constructible and std::is_trivially_copy_constructible.
Wed, Dec 2, 11:00 PM · Restricted Project
MaskRay committed rG1d6ebdfb66b9: Switch from llvm::is_trivially_copyable to std::is_trivially_copyable (authored by MaskRay).
Switch from llvm::is_trivially_copyable to std::is_trivially_copyable
Wed, Dec 2, 10:03 PM
MaskRay closed D92514: Switch from llvm::is_trivially_copyable to std::is_trivially_copyable.
Wed, Dec 2, 10:03 PM · Restricted Project
MaskRay added inline comments to D92278: [Clang] Don't adjust align for IBM extended double type.
Wed, Dec 2, 7:04 PM · Restricted Project
MaskRay updated the diff for D92514: Switch from llvm::is_trivially_copyable to std::is_trivially_copyable.

Remove Optional.h

Wed, Dec 2, 7:00 PM · Restricted Project
MaskRay updated subscribers of D92514: Switch from llvm::is_trivially_copyable to std::is_trivially_copyable.

MSVC is unhappy (https://buildkite.com/llvm-project/premerge-checks/builds/18597#12d9421a-c989-4774-b9fb-e0823600baa4)

FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/WasmEHPrepare.cpp.obj
sccache C:\BuildTools\VC\Tools\MSVC\14.27.29110\bin\Hostx64\x64\cl.exe  /nologo /TP -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\CodeGen -IC:\ws\w32-1\llvm-project\premerge-checks\llvm\lib\CodeGen -Iinclude -IC:\ws\w32-1\llvm-project\premerge-checks\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Zc:strictStrings /Oi /Zc:rvalueCast /bigobj /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd4324 -w14062 -we4238 /Gw /MD /O2 /Ob2    /EHs-c- /GR- -UNDEBUG -std:c++14 /showIncludes /Folib\CodeGen\CMakeFiles\LLVMCodeGen.dir\WasmEHPrepare.cpp.obj /Fdlib\CodeGen\CMakeFiles\LLVMCodeGen.dir\LLVMCodeGen.pdb /FS -c C:\ws\w32-1\llvm-project\premerge-checks\llvm\lib\CodeGen\WasmEHPrepare.cpp
C:\ws\w32-1\llvm-project\premerge-checks\llvm\include\llvm/ADT/BreadthFirstIterator.h(96): error C2280: 'llvm::Optional<std::pair<llvm::DomTreeNodeBase<llvm::BasicBlock> *,llvm::Optional<llvm::DomTreeNodeBase<llvm::BasicBlock> *const *>>> &llvm::Optional<std::pair<llvm::DomTreeNodeBase<llvm::BasicBlock> *,llvm::Optional<llvm::DomTreeNodeBase<llvm::BasicBlock> *const *>>>::operator =(const llvm::Optional<std::pair<llvm::DomTreeNodeBase<llvm::BasicBlock> *,llvm::Optional<llvm::DomTreeNodeBase<llvm::BasicBlock> *const *>>> &)': attempting to reference a deleted function
C:\ws\w32-1\llvm-project\premerge-checks\llvm\include\llvm/ADT/Optional.h(250): note: see declaration of 'llvm::Optional<std::pair<llvm::DomTreeNodeBase<llvm::BasicBlock> *,llvm::Optional<llvm::DomTreeNodeBase<llvm::BasicBlock> *const *>>>::operator ='
Wed, Dec 2, 4:47 PM · Restricted Project
MaskRay requested review of D92514: Switch from llvm::is_trivially_copyable to std::is_trivially_copyable.
Wed, Dec 2, 3:20 PM · Restricted Project
MaskRay added a comment to rG91e66bfd321f: Revert "Use std::is_trivially_copyable", breaks MSVC build.

Is there a sample MSVC failure? llvm-clang-x86_64-win-fast (http://lab.llvm.org:8011/#/builders/86) appeared to be good...

Wed, Dec 2, 2:43 PM
MaskRay updated the diff for D92078: [asan] Default to -asan-use-private-alias=1.

Fix two clang/test/CodeGen tests

Wed, Dec 2, 2:20 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay committed rGee571f87bf41: [ThinLTO][test] Fix X86/nossp.ll after D91816 (authored by MaskRay).
[ThinLTO][test] Fix X86/nossp.ll after D91816
Wed, Dec 2, 1:14 PM
MaskRay added inline comments to D92478: [yaml2obj/obj2yaml] - Make fields of the `Symbol` to be optional..
Wed, Dec 2, 12:57 PM · Restricted Project
MaskRay added inline comments to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.
Wed, Dec 2, 11:15 AM · Restricted Project
MaskRay added a comment to D92078: [asan] Default to -asan-use-private-alias=1.

I guess another cons was binary size increase? Would you like to run large scale testing on internal Google code?

Wed, Dec 2, 10:46 AM · Restricted Project, Restricted Project, Restricted Project
MaskRay added inline comments to D92278: [Clang] Don't adjust align for IBM extended double type.
Wed, Dec 2, 10:08 AM · Restricted Project
MaskRay committed rG4d4bd40b578d: Use std::is_trivially_copyable (authored by MaskRay).
Use std::is_trivially_copyable
Wed, Dec 2, 9:58 AM
MaskRay committed rG557b00e0afb2: Delete llvm::is_trivially_copyable and CMake variable… (authored by MaskRay).
Delete llvm::is_trivially_copyable and CMake variable…
Wed, Dec 2, 9:58 AM
MaskRay added a comment to D91841: [builtins] Define fmax and scalbn inline.

The runtime libraries should have a proper layering. Generally compiler-rt builtins (libgcc_s.so.1) should not depend on libc. (There are use cases where people depend on compiler-rt builtins but not libc) abort is a known exception but we should generally avoid adding more exceptions.

Wed, Dec 2, 9:52 AM · Restricted Project
MaskRay accepted D91816: [Inline] prevent inlining on stack protector mismatch.
Wed, Dec 2, 9:47 AM · Restricted Project
MaskRay added a comment to D92054: [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables.

Ping:)

Wed, Dec 2, 8:32 AM · Restricted Project

Tue, Dec 1

MaskRay added a comment to D92445: [PowerPC] Add powerpcle target..

This patch should be split. I suggest that you create 4 patches.

Tue, Dec 1, 7:22 PM · Restricted Project, Restricted Project, Restricted Project
MaskRay added a comment to rG1f40d60a3b7f: Remove CXXBasePaths::found_decls and simplify and modernize its only.

Fixed lldb with ce5e21868c22479df62ebd8884adc1bd7c964433

Tue, Dec 1, 7:15 PM
MaskRay committed rGce5e21868c22: [lldb] Fix build after found_decls was removed by… (authored by MaskRay).
[lldb] Fix build after found_decls was removed by…
Tue, Dec 1, 7:15 PM
MaskRay accepted D92382: [llvm-readelf/obj] - Report unique warnings in `parseDynamicTable`..

Looks great!

Tue, Dec 1, 6:32 PM · Restricted Project
MaskRay accepted D92380: [llvm-readelf/obj] - Refine the error message about the broken string table..
Tue, Dec 1, 6:32 PM · Restricted Project
MaskRay accepted D92437: [mac/lld] Include archive name in diagnostics.

Thanks! This is what lld/ELF does...

Tue, Dec 1, 5:52 PM · Restricted Project, Restricted Project
MaskRay added a comment to rG1f40d60a3b7f: Remove CXXBasePaths::found_decls and simplify and modernize its only.

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp uses paths.found_decls() and .. it is not clear how to fix it..

Tue, Dec 1, 5:13 PM
MaskRay committed rG31e03a9bd956: [WebAssembly] Rename --lto-no-new-pass-manager to --no-lto-new-pass-manager (authored by MaskRay).
[WebAssembly] Rename --lto-no-new-pass-manager to --no-lto-new-pass-manager
Tue, Dec 1, 4:53 PM
MaskRay closed D92422: [WebAssembly] Rename --lto-no-new-pass-manager to --no-lto-new-pass-manager.
Tue, Dec 1, 4:52 PM · Restricted Project
MaskRay added a comment to D92422: [WebAssembly] Rename --lto-no-new-pass-manager to --no-lto-new-pass-manager.

Chatted offline, Sam is happy with this change. Committing...

Tue, Dec 1, 4:45 PM · Restricted Project
MaskRay added a comment to D92437: [mac/lld] Include archive name in diagnostics.

Reasonable

Tue, Dec 1, 4:39 PM · Restricted Project, Restricted Project
MaskRay committed rGe27e3ba9c9d8: [RISCVAsmParser] Allow a SymbolRef operand to be a complex expression (authored by MaskRay).
[RISCVAsmParser] Allow a SymbolRef operand to be a complex expression
Tue, Dec 1, 4:08 PM
MaskRay closed D92293: [RISCVAsmParser] Allow a SymbolRef operand to be a complex expression.
Tue, Dec 1, 4:08 PM · Restricted Project
MaskRay added inline comments to D92293: [RISCVAsmParser] Allow a SymbolRef operand to be a complex expression.
Tue, Dec 1, 4:04 PM · Restricted Project
MaskRay added a comment to D92433: [NewPM][LTO] Use new pass manager with ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER.

In LLD, we generally don't recommend configure-time default values. We expect the driver to set the proper options. We can default to true and let the clang driver pass --no-lto-new-pass-manager to LLD if needed.

Tue, Dec 1, 3:01 PM · Restricted Project
MaskRay accepted D92318: [llvm-readobj, libSupport] - Refine the implementation of the code that dumps build attributes..
Tue, Dec 1, 2:32 PM · Restricted Project
MaskRay added a comment to D87997: [RISCV][crt] support building without init_array.

This does not look right to me. Newer architectures like aarch64/risc-v do not need to have .ctors/.dtors support. Can you investigate why -DCRT_HAS_INITFINI_ARRAY isn't set in your build instead?

Tue, Dec 1, 2:10 PM · Restricted Project
MaskRay accepted D92417: [LLD][ELF][NewPM] Add option to force legacy PM.

LGTM.

Tue, Dec 1, 1:28 PM · Restricted Project
MaskRay requested review of D92422: [WebAssembly] Rename --lto-no-new-pass-manager to --no-lto-new-pass-manager.
Tue, Dec 1, 12:46 PM · Restricted Project
MaskRay added inline comments to D92417: [LLD][ELF][NewPM] Add option to force legacy PM.
Tue, Dec 1, 12:41 PM · Restricted Project
MaskRay retitled D92301: [LLD][ELF] - Don't keep empty output sections which have explicit program headers from [LLD][ELF] - Don't keep empty output sections that are explicitly assigned to segment. to [LLD][ELF] - Don't keep empty output sections which have explicit program headers.
Tue, Dec 1, 12:03 PM · Restricted Project
MaskRay added inline comments to D92301: [LLD][ELF] - Don't keep empty output sections which have explicit program headers.
Tue, Dec 1, 11:55 AM · Restricted Project
MaskRay accepted D92301: [LLD][ELF] - Don't keep empty output sections which have explicit program headers.

Suggest a rewrite of the description:

Tue, Dec 1, 11:54 AM · Restricted Project
MaskRay added a comment to D88988: [llvm-symbolizer] Add inline stack traces for Windows..

(Taking out-of-line since the comment thread has rather diverged from the original thing)

Perhaps - I'd be happy to widen the use case of debuginfo-tests for other things like symbolizing. And if the existing interactive debugger parts weren't Windows suitable/of interest, I'd be OK with it being possible to run those symbolizer bits without the interactive debugger bits. But would provide a space for a full clang+lld+llvm-symbolizer test cases, which currently can't be done in either the clang or lld repository, for instance.

We've internally been considering a need for an "integration" lit-based testsuite that is able to test the interactions in tools that would otherwise not really fit in one or the other location. We have our own downstream non-lit based test repository, but for some tests this is too heavyweight, and it would be nice to test things more locally. Examples include showing, for example, that tools can consume debug data produced by clang (note that because defaults might change as to what version of DWARF is emitted, an llvm-mc assembly or YAML based test here wouldn't be appropriate), or similarly for relocations being handled by the downstream tools. The intent here is not to replace targeted lit tests, but rather to show that end-to-end behaviour is still sensible.

Maybe this idea could be useful upstream? It would need the ability to create a lit-based testsuite, probably as a separate top-level directory in the llvm-project tree, which can use components from all projects. We'd want REQUIRES support that could be used to say REQUIRES: clang or similar so that users could still run the subset of tests that work with the projects they build.

Yeah - I'd probably first suggest that such tests could go into debuginfo-tests, though if it's meant to extend to things other than debug info - yeah, another top level repo might be suitable. Maybe even the test-suite itself, though that's a bit of a dark place and maybe a distinct place with narrower, pure lit based testing would be beneficial.

Tue, Dec 1, 11:07 AM · Restricted Project, Restricted Project
MaskRay added inline comments to D91551: Initial commit of mktime..
Tue, Dec 1, 10:47 AM · Restricted Project
MaskRay committed rGa5309438fe8d: static const char *const foo => const char foo[] (authored by MaskRay).
static const char *const foo => const char foo[]
Tue, Dec 1, 10:33 AM
MaskRay committed rGbb993b1d9de3: [ELF][test] Fix lto/version-script2.ll (authored by MaskRay).
[ELF][test] Fix lto/version-script2.ll
Tue, Dec 1, 10:22 AM
MaskRay added inline comments to D89566: [LV] Epilogue Vectorization with Optimal Control Flow.
Tue, Dec 1, 10:04 AM · Restricted Project
MaskRay accepted D92310: [llvm-objdump] Use "--" for long options in --help text.
Tue, Dec 1, 9:33 AM · Restricted Project
MaskRay added a reviewer for D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version: rsmith.
Tue, Dec 1, 9:30 AM · Restricted Project, Restricted Project
MaskRay added a comment to D92375: [MergeICmps] Fix missing split..

As a follow-up, would be good adding some tests whether the pointer operand of a GEP references an instruction defined in a basic block. Currently in all tests the pointer operands refer to arguments.

Tue, Dec 1, 9:09 AM · Restricted Project
MaskRay abandoned D92364: [MergeICmps] Disable if a GEP does not reference an Argument.
Tue, Dec 1, 9:02 AM · Restricted Project
MaskRay committed rG843c2b230300: [ELF] Error for undefined foo@v1 (authored by MaskRay).
[ELF] Error for undefined foo@v1
Tue, Dec 1, 9:00 AM
MaskRay closed D92260: [ELF] Error for undefined foo@v1.
Tue, Dec 1, 9:00 AM · Restricted Project
MaskRay updated the diff for D92260: [ELF] Error for undefined foo@v1.

Fix an assertion failure

Tue, Dec 1, 8:59 AM · Restricted Project
MaskRay committed rG941e9336d092: [ELF] Make foo@@v1 resolve undefined foo@v1 (authored by MaskRay).
[ELF] Make foo@@v1 resolve undefined foo@v1
Tue, Dec 1, 8:54 AM
MaskRay closed D92259: [ELF] Make foo@@v1 resolve undefined foo@v1.
Tue, Dec 1, 8:54 AM · Restricted Project
MaskRay updated the diff for D92259: [ELF] Make foo@@v1 resolve undefined foo@v1.

NUl -> NUL

Tue, Dec 1, 8:50 AM · Restricted Project
MaskRay committed rGa5f95887d0f8: [ELF][test] Add some tests for versioned symbols in object files (authored by MaskRay).
[ELF][test] Add some tests for versioned symbols in object files
Tue, Dec 1, 8:49 AM
MaskRay closed D92258: [ELF][test] Add some tests for versioned symbols in object files.
Tue, Dec 1, 8:49 AM · Restricted Project
MaskRay committed rGf0659c067341: [X86] Support modifier @PLTOFF for R_X86_64_PLTOFF64 (authored by MaskRay).
[X86] Support modifier @PLTOFF for R_X86_64_PLTOFF64
Tue, Dec 1, 8:39 AM
MaskRay closed D92294: [X86] Support modifier @PLTOFF for R_X86_64_PLTOFF64.
Tue, Dec 1, 8:39 AM · Restricted Project
MaskRay added inline comments to D92258: [ELF][test] Add some tests for versioned symbols in object files.
Tue, Dec 1, 12:49 AM · Restricted Project

Mon, Nov 30

MaskRay accepted D92241: [compiler-rt] [builtins] Use _Float16 on extendhfsf2, truncdfhf2 __truncsfhf2 if available.
Mon, Nov 30, 11:00 PM · Restricted Project
MaskRay accepted D92356: lld/ELF: Make three rarely-used flags work with --reproduce.

LGTM.

Mon, Nov 30, 11:00 PM · Restricted Project
MaskRay updated the diff for D92364: [MergeICmps] Disable if a GEP does not reference an Argument.

Placed LLVM_DEBUG in the wrong place in the previous diff...

Mon, Nov 30, 10:11 PM · Restricted Project
MaskRay updated the diff for D92364: [MergeICmps] Disable if a GEP does not reference an Argument.

Add log

Mon, Nov 30, 10:11 PM · Restricted Project
MaskRay requested review of D92364: [MergeICmps] Disable if a GEP does not reference an Argument.
Mon, Nov 30, 10:09 PM · Restricted Project
MaskRay committed rGd928dfc6f924: [GlobalISel] Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off builds (authored by MaskRay).
[GlobalISel] Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off builds
Mon, Nov 30, 6:32 PM
MaskRay committed rG36fe1a9dea94: [GlobalISel] Fix -Wunused-variable (authored by MaskRay).
[GlobalISel] Fix -Wunused-variable
Mon, Nov 30, 6:26 PM
MaskRay added inline comments to D92293: [RISCVAsmParser] Allow a SymbolRef operand to be a complex expression.
Mon, Nov 30, 3:40 PM · Restricted Project
MaskRay accepted D92316: [llvm-readobj][test] - Merge 2 test cases together..

LG. I wonder the test should be named attributes-invalid.test since users can find related tests by checking the prefix.

Mon, Nov 30, 2:08 PM · Restricted Project
MaskRay added inline comments to D91816: [Inline] prevent inlining on stack protector mismatch.
Mon, Nov 30, 1:56 PM · Restricted Project
MaskRay committed rG164410324d8b: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to… (authored by MaskRay).
[CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to…
Mon, Nov 30, 12:44 PM
MaskRay closed D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null.
Mon, Nov 30, 12:44 PM · Restricted Project
MaskRay updated the diff for D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null.

Fix a comment

Mon, Nov 30, 12:38 PM · Restricted Project
MaskRay accepted D92113: Let .llvm_bb_addr_map section use the same unique id as its associated .text section..

Thank you for the comments @MaskRay . Are there any style guidelines for the test files? I wasn't able to find anything online.

Mon, Nov 30, 12:13 PM · Restricted Project
MaskRay accepted D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools.
Mon, Nov 30, 11:30 AM · Restricted Project
MaskRay added inline comments to D92260: [ELF] Error for undefined foo@v1.
Mon, Nov 30, 11:27 AM · Restricted Project
MaskRay updated the diff for D92260: [ELF] Error for undefined foo@v1.

Comments. Rebase

Mon, Nov 30, 11:23 AM · Restricted Project
MaskRay updated the diff for D92259: [ELF] Make foo@@v1 resolve undefined foo@v1.

Rebase

Mon, Nov 30, 11:23 AM · Restricted Project
MaskRay updated the diff for D92258: [ELF][test] Add some tests for versioned symbols in object files.

Add test

Mon, Nov 30, 11:22 AM · Restricted Project
MaskRay accepted D91803: [lld] Use -1 as tombstone value for discarded code ranges.

Looks great! Please include diff context in future patches (https://llvm.org/docs/GettingStarted.html#sending-patches)

Mon, Nov 30, 10:35 AM · Restricted Project
MaskRay added inline comments to D92293: [RISCVAsmParser] Allow a SymbolRef operand to be a complex expression.
Mon, Nov 30, 10:31 AM · Restricted Project
MaskRay added inline comments to D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null.
Mon, Nov 30, 10:28 AM · Restricted Project
MaskRay updated the diff for D92297: [CodeGen] -fno-delete-null-pointer-checks: change dereferenceable to dereferenceable_or_null.

Add FIXME

Mon, Nov 30, 10:26 AM · Restricted Project
MaskRay committed rG7c4555f60d96: [PowerPC] Delete remnant Darwin code in PPCAsmParser (authored by MaskRay).
[PowerPC] Delete remnant Darwin code in PPCAsmParser
Mon, Nov 30, 10:16 AM
MaskRay closed D91836: [PowerPC] Delete remnant Darwin code in PPCAsmParser.
Mon, Nov 30, 10:16 AM · Restricted Project
MaskRay updated the diff for D91836: [PowerPC] Delete remnant Darwin code in PPCAsmParser.

Keep the comment attached to createPPCAsmprinterPass.
Reword it to conform to the coding standard.
/ -> since static /// is useless.

Mon, Nov 30, 10:13 AM · Restricted Project
MaskRay updated the diff for D92259: [ELF] Make foo@@v1 resolve undefined foo@v1.

Fix comments

Mon, Nov 30, 10:10 AM · Restricted Project
MaskRay added inline comments to D92259: [ELF] Make foo@@v1 resolve undefined foo@v1.
Mon, Nov 30, 10:08 AM · Restricted Project
MaskRay retitled D92259: [ELF] Make foo@@v1 resolve undefined foo@v1 from [ELF] Make foo@@v1 resolved undefined foo@v1 to [ELF] Make foo@@v1 resolve undefined foo@v1.
Mon, Nov 30, 10:07 AM · Restricted Project
MaskRay updated the diff for D92259: [ELF] Make foo@@v1 resolve undefined foo@v1.

Comments

Mon, Nov 30, 10:07 AM · Restricted Project
MaskRay updated the diff for D92258: [ELF][test] Add some tests for versioned symbols in object files.

Improve --wrap comments

Mon, Nov 30, 9:28 AM · Restricted Project
MaskRay updated the summary of D92258: [ELF][test] Add some tests for versioned symbols in object files.
Mon, Nov 30, 9:23 AM · Restricted Project
MaskRay updated the diff for D92258: [ELF][test] Add some tests for versioned symbols in object files.

Add more tests

Mon, Nov 30, 9:15 AM · Restricted Project
MaskRay committed rG589e10f8586e: [ELF] Don't relax R_X86_64_GOTPCRELX if addend != -4 (authored by MaskRay).
[ELF] Don't relax R_X86_64_GOTPCRELX if addend != -4
Mon, Nov 30, 8:30 AM
MaskRay closed D91993: [ELF] Don't relax R_X86_64_GOTPCRELX if addend != -4.
Mon, Nov 30, 8:30 AM · Restricted Project
MaskRay abandoned D91965: Revert "[X86] Produce R_X86_64_GOTPCRELX for test/binop instructions (MOV32rm/TEST32rm/...) when -Wa,-mrelax-relocations=yes is enabled".
Mon, Nov 30, 8:28 AM · Restricted Project
MaskRay commandeered D91965: Revert "[X86] Produce R_X86_64_GOTPCRELX for test/binop instructions (MOV32rm/TEST32rm/...) when -Wa,-mrelax-relocations=yes is enabled".

Obsoleted by D92114

Mon, Nov 30, 8:28 AM · Restricted Project