Page MenuHomePhabricator

hiraditya (Aditya Kumar)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2014, 4:23 PM (370 w, 5 d)

Recent Activity

Mar 10 2021

hiraditya committed rG6976255faffb: Add noreturn attribute to non-returning functions (authored by hiraditya).
Add noreturn attribute to non-returning functions
Mar 10 2021, 2:36 PM
hiraditya closed D97308: Add noreturn attribute to non-returning functions.
Mar 10 2021, 2:36 PM · Restricted Project
hiraditya added a comment to D97308: Add noreturn attribute to non-returning functions.
  • void __throw_runtime_error(const char* msg) in src/locale.cpp: what's the deal with this one? should you attribute it as well?

__throw_runtime_error is attributed with noreturn https://github.com/llvm/llvm-project/blob/main/libcxx/src/locale.cpp#L132

No, I meant this version: https://github.com/llvm/llvm-project/blob/main/libcxx/src/locale.cpp#L6270

Mar 10 2021, 10:49 AM · Restricted Project
hiraditya committed rW788319fadebb: [LLVM+CGO] Add slide deck by Arun (authored by hiraditya).
[LLVM+CGO] Add slide deck by Arun
Mar 10 2021, 6:23 AM
hiraditya added a comment to D97308: Add noreturn attribute to non-returning functions.

I did a grep for void __throw and verified that every other instance is attributed, except for:

  • __throw_if_valueless in <variant>: this is good and intentional
  • void __throw_runtime_error(const char* msg) in src/locale.cpp: what's the deal with this one? should you attribute it as well?

__throw_runtime_error is attributed with noreturn https://github.com/llvm/llvm-project/blob/main/libcxx/src/locale.cpp#L132

Mar 10 2021, 12:03 AM · Restricted Project

Mar 8 2021

hiraditya committed rW380b81ea9521: [LLVM+CGO] Add slide decks by Arun (authored by hiraditya).
[LLVM+CGO] Add slide decks by Arun
Mar 8 2021, 2:33 PM

Mar 2 2021

hiraditya committed rWff6911bf9c67: [LLVM CGO] Add slide deck of presenters (authored by hiraditya).
[LLVM CGO] Add slide deck of presenters
Mar 2 2021, 4:22 PM

Feb 25 2021

hiraditya committed rW8bf170784e88: [LLVM CGO] Update abstract by Denis (authored by hiraditya).
[LLVM CGO] Update abstract by Denis
Feb 25 2021, 3:31 PM
hiraditya added reviewers for D97308: Add noreturn attribute to non-returning functions: ldionne, mclow.lists.
Feb 25 2021, 11:44 AM · Restricted Project

Feb 23 2021

hiraditya committed rWd131edbb660c: [LLVM CGO] Move Denis before Aditya (authored by hiraditya).
[LLVM CGO] Move Denis before Aditya
Feb 23 2021, 8:05 PM
hiraditya requested review of D97308: Add noreturn attribute to non-returning functions.
Feb 23 2021, 11:17 AM · Restricted Project

Feb 16 2021

hiraditya added inline comments to D88460: Strlen loop idiom recognition.
Feb 16 2021, 11:00 AM · Restricted Project

Feb 14 2021

hiraditya requested review of D96685: [WIP] Add noexcept clang-tidy codemod.
Feb 14 2021, 10:48 PM · Restricted Project

Feb 10 2021

hiraditya committed rWa2da935907bf: [LLVM+CGO] Increase Stefanos presentation to 45 minutes (authored by hiraditya).
[LLVM+CGO] Increase Stefanos presentation to 45 minutes
Feb 10 2021, 2:29 AM

Feb 9 2021

hiraditya committed rW39bfdd37a465: [LLVM+CGO] Moved Stefanos 1.5 hours earlier (authored by hiraditya).
[LLVM+CGO] Moved Stefanos 1.5 hours earlier
Feb 9 2021, 5:16 PM
hiraditya committed rW959dcfd8595d: [LLVM+CGO] Fix typo in schedule and reduced a talk to 30 minutes (authored by hiraditya).
[LLVM+CGO] Fix typo in schedule and reduced a talk to 30 minutes
Feb 9 2021, 6:53 AM

Feb 8 2021

hiraditya committed rWa696f5565735: [LLVM+CGO] Added abstract of Gokcen (authored by hiraditya).
[LLVM+CGO] Added abstract of Gokcen
Feb 8 2021, 9:53 PM

Feb 3 2021

hiraditya committed rW7fe2d2c14212: [LLVM CGO 2021] Table Border (authored by hiraditya).
[LLVM CGO 2021] Table Border
Feb 3 2021, 7:35 PM
hiraditya committed rW040ce07c4d97: [LLVM CGO 2021] Note to presenters (authored by hiraditya).
[LLVM CGO 2021] Note to presenters
Feb 3 2021, 7:05 PM
hiraditya committed rWa6ec64918b51: [LLVM CGO 2021] Adding link and affiliations (authored by hiraditya).
[LLVM CGO 2021] Adding link and affiliations
Feb 3 2021, 7:02 PM
hiraditya committed rWc7a9885a5b20: [LLVM CGO 2021] Fix formatting issues (authored by hiraditya).
[LLVM CGO 2021] Fix formatting issues
Feb 3 2021, 6:28 PM
hiraditya committed rWd369802a025c: [LLVM+CGO 2021] Add tentative schedule (authored by hiraditya).
[LLVM+CGO 2021] Add tentative schedule
Feb 3 2021, 6:18 PM

Jan 26 2021

hiraditya committed rW1486fd048407: Move LLVM-HPC to past events (authored by hiraditya).
Move LLVM-HPC to past events
Jan 26 2021, 3:33 PM

Jan 24 2021

hiraditya committed rW04533102f2ca: Adding the slide for Function entry instrumentation (authored by hiraditya).
Adding the slide for Function entry instrumentation
Jan 24 2021, 2:48 PM
hiraditya committed rWb3ca7ceed984: Added slides for LLVM-CGO 2020 (authored by hiraditya).
Added slides for LLVM-CGO 2020
Jan 24 2021, 9:57 AM

Jan 16 2021

hiraditya added inline comments to D94202: Preserve the lexical order of global variables during llvm-link merge.
Jan 16 2021, 10:01 AM · Restricted Project

Jan 14 2021

hiraditya added a reviewer for D94167: [ARM][GISel] Treat calls as variadic even if only fixed arguments provided: t.p.northover.
Jan 14 2021, 8:30 AM · Restricted Project

Jan 5 2021

hiraditya committed rW98514120753a: Added note about video recording (authored by hiraditya).
Added note about video recording
Jan 5 2021, 1:07 PM
hiraditya committed rW54461db6c77e: Extending the deadline by another 10 days (authored by hiraditya).
Extending the deadline by another 10 days
Jan 5 2021, 7:08 AM

Dec 18 2020

hiraditya committed rG1ab4db0f847f: [HotColdSplit] Reflect full cost of parameters in split penalty (authored by hiraditya).
[HotColdSplit] Reflect full cost of parameters in split penalty
Dec 18 2020, 5:07 PM
hiraditya closed D59715: [HotColdSplit] Reflect full cost of parameters in split penalty.
Dec 18 2020, 5:06 PM · Restricted Project
hiraditya committed rW4eae6584ffb0: [LLVM CGO Workshop] Formatting fixes (authored by hiraditya).
[LLVM CGO Workshop] Formatting fixes
Dec 18 2020, 4:52 PM
hiraditya added a comment to D93559: Rename files with same (case insensitive) name.

I need to setup access token because github has changed commit policy recently.

Dec 18 2020, 12:57 PM · Restricted Project
hiraditya added a comment to D93559: Rename files with same (case insensitive) name.

It seems, I'm no longer having access to the llvm-project. Please commit this for me.

Dec 18 2020, 12:55 PM · Restricted Project
hiraditya updated the diff for D93559: Rename files with same (case insensitive) name.

rename

Dec 18 2020, 12:08 PM · Restricted Project
hiraditya added a comment to D93559: Rename files with same (case insensitive) name.

ok i'll rename this before commit.

Dec 18 2020, 12:07 PM · Restricted Project
hiraditya added a reviewer for D93559: Rename files with same (case insensitive) name: smeenai.
Dec 18 2020, 11:52 AM · Restricted Project
hiraditya updated the summary of D93559: Rename files with same (case insensitive) name.
Dec 18 2020, 11:46 AM · Restricted Project
hiraditya requested review of D93559: Rename files with same (case insensitive) name.
Dec 18 2020, 11:44 AM · Restricted Project
hiraditya updated the diff for D59715: [HotColdSplit] Reflect full cost of parameters in split penalty.

Rebase, fix a typo, change default hotcoldsplit-max-params=4

Dec 18 2020, 11:30 AM · Restricted Project
hiraditya added a reviewer for D91718: [LV] Legalize scalable VF hints: zinob.
Dec 18 2020, 10:01 AM · Restricted Project

Dec 17 2020

hiraditya retitled D93518: [Not for review, only reference] Adding private method attribute by inferring from the program from [Not fore review, only reference] Adding private method attribute by inferring from the program to [Not for review, only reference] Adding private method attribute by inferring from the program.
Dec 17 2020, 11:57 PM
hiraditya retitled D93518: [Not for review, only reference] Adding private method attribute by inferring from the program from Adding private method attribute by inferring from the program to [Not fore review, only reference] Adding private method attribute by inferring from the program.
Dec 17 2020, 11:57 PM
hiraditya retitled D93519: [Not for review, only reference] Add objc_private_attr as function attribute from [Not fore review, only reference] Add objc_private_attr as function attribute to [Not for review, only reference] Add objc_private_attr as function attribute.
Dec 17 2020, 11:57 PM
hiraditya requested review of D93519: [Not for review, only reference] Add objc_private_attr as function attribute.
Dec 17 2020, 11:57 PM
hiraditya requested review of D93518: [Not for review, only reference] Adding private method attribute by inferring from the program.
Dec 17 2020, 11:56 PM
hiraditya edited reviewers for D93517: [Not for review, only reference] Adding attribute to private method for inlining, added: hiraditya; removed: aaron.ballman.
Dec 17 2020, 11:54 PM
hiraditya retitled D93517: [Not for review, only reference] Adding attribute to private method for inlining from Adding attribute to private method for inlining to [Not for review, only reference] Adding attribute to private method for inlining.
Dec 17 2020, 11:54 PM
hiraditya requested review of D93517: [Not for review, only reference] Adding attribute to private method for inlining.
Dec 17 2020, 11:54 PM
hiraditya updated subscribers of D93515: [Not for review, only for reference] Devirtualize private methods which are annotated with private attribute.
Dec 17 2020, 11:34 PM
hiraditya updated the diff for D93515: [Not for review, only for reference] Devirtualize private methods which are annotated with private attribute.
Dec 17 2020, 11:34 PM
hiraditya requested review of D93515: [Not for review, only for reference] Devirtualize private methods which are annotated with private attribute.
Dec 17 2020, 11:28 PM
hiraditya added a comment to D88460: Strlen loop idiom recognition.

It'll be nice to know if this patch worked fine with a set of regression tests.
results on LLVM testsuite, or clang bootstrap will really help.

Thanks for working on this.

Thank you for the feedback @hiraditya! I have tested the latest patch at various options (O2, O3, LTO and PGO) against the SPEC benchmarks as well as run the lnt tests and bootstrap tests successfully. If you were concerned about any other specific testsuite, pls let me know.

Dec 17 2020, 11:14 PM · Restricted Project

Dec 5 2020

hiraditya added a comment to D92506: Remove memory allocation with string.

the following failures reported by buildbot are unrelated to this change:

Dec 5 2020, 3:17 PM · Restricted Project
hiraditya committed rGc4e327a960d2: Remove memory allocation with string (authored by hiraditya).
Remove memory allocation with string
Dec 5 2020, 3:15 PM
hiraditya closed D92506: Remove memory allocation with string.
Dec 5 2020, 3:15 PM · Restricted Project
hiraditya updated the diff for D92506: Remove memory allocation with string.

remove consume

Dec 5 2020, 11:44 AM · Restricted Project

Dec 4 2020

hiraditya updated the diff for D92506: Remove memory allocation with string.

Rebase

Dec 4 2020, 4:45 PM · Restricted Project

Dec 2 2020

hiraditya added a reviewer for D92506: Remove memory allocation with string: zinob.
Dec 2 2020, 1:10 PM · Restricted Project
hiraditya added a reviewer for D92506: Remove memory allocation with string: nadav.
Dec 2 2020, 1:09 PM · Restricted Project
hiraditya requested review of D92506: Remove memory allocation with string.
Dec 2 2020, 1:09 PM · Restricted Project
hiraditya added a comment to D90831: DebugInfo support for OCaml bindings.

Maybe ask in Discord to get reviewers?

Dec 2 2020, 10:26 AM · Restricted Project

Nov 3 2020

hiraditya added a comment to D90708: [LangRef] Clarify GEP inbounds wrapping semantics.

LGTM, an example of a gep with inbounds wouldbe nice. there are some test cases like: CodeGen/2009-02-13-zerosize-union-field.c, CodeGen/2010-07-14-ref-off-end.c etc from where we can take a reduced example for the doc.

Nov 3 2020, 2:16 PM · Restricted Project
hiraditya updated subscribers of D90342: [POC][LoopVectorizer] Propagate ElementCount to interfaces in preparation for scalable auto-vec. .
Nov 3 2020, 2:08 PM · Restricted Project
hiraditya added inline comments to D90342: [POC][LoopVectorizer] Propagate ElementCount to interfaces in preparation for scalable auto-vec. .
Nov 3 2020, 2:07 PM · Restricted Project
hiraditya added a reviewer for D89322: [LV] Initial VPlan cost modelling: nadav.
Nov 3 2020, 2:04 PM · Restricted Project
hiraditya added a comment to D59715: [HotColdSplit] Reflect full cost of parameters in split penalty.

@vsk Let me know if you dont have bandwidth to land. I can land it otherwise.

Nov 3 2020, 2:01 PM · Restricted Project

Oct 24 2020

hiraditya added a reviewer for D82892: [NFC] Methods to compare IR added in each IR subclass: hiraditya.
Oct 24 2020, 4:26 AM · Restricted Project
hiraditya added a comment to D79485: [BPI] Improve static heuristics for "cold" paths..

Please fix clang-format issues.

Oct 24 2020, 4:21 AM · Restricted Project
hiraditya added a comment to D88893: [SROA] Only generate memcpy if the slices is large 'enough' (WIP)..

Instcombine also expands small (16 bytes, hardcoded) memcpy's

Oct 24 2020, 4:18 AM · Restricted Project
hiraditya accepted D59715: [HotColdSplit] Reflect full cost of parameters in split penalty.

or if you prefer, I can land it in its current state.

Oct 24 2020, 4:05 AM · Restricted Project

Oct 20 2020

hiraditya added a comment to D88392: [M68k] (Patch 6/8) IR Tests.

Good to have these tests. I'd wait for the previous patches in the stack to be reviewed.

Oct 20 2020, 2:56 PM · Restricted Project
hiraditya added a comment to D59715: [HotColdSplit] Reflect full cost of parameters in split penalty.

@rjf do you have numbers on Firefox. Let us know.

Oct 20 2020, 2:54 PM · Restricted Project
hiraditya added a comment to D88460: Strlen loop idiom recognition.

It'll be nice to know if this patch worked fine with a set of regression tests.
results on LLVM testsuite, or clang bootstrap will really help.

Oct 20 2020, 2:51 PM · Restricted Project

Oct 3 2020

hiraditya added a reviewer for D24033: Convert clamp into fmaxnum/fminnum pairs.: hiraditya.
Oct 3 2020, 7:22 PM · Restricted Project

Sep 9 2020

hiraditya added a comment to D59715: [HotColdSplit] Reflect full cost of parameters in split penalty.

Any plans to merge this patch?

Sep 9 2020, 10:00 AM · Restricted Project
hiraditya accepted D87347: [NFC] Fix compiler warnings due to integer comparison of different signedness.
Sep 9 2020, 9:51 AM · Restricted Project, Restricted Project

Aug 28 2020

hiraditya added a comment to D85368: [llvm][CodeGen] Machine Function Splitter.

nit: If FIXME's are mostly future works, then please replace them with TODOs.

Aug 28 2020, 8:58 AM · Restricted Project
hiraditya added inline comments to D85368: [llvm][CodeGen] Machine Function Splitter.
Aug 28 2020, 8:43 AM · Restricted Project

Aug 21 2020

hiraditya added a comment to D79485: [BPI] Improve static heuristics for "cold" paths..

Is the test failure related to this patch?

Aug 21 2020, 3:18 PM · Restricted Project

Aug 17 2020

hiraditya added a reviewer for D86032: NFC: [GVNHoist] Outline functions from the class: hiraditya.
Aug 17 2020, 5:41 PM · Restricted Project
hiraditya added a comment to D86032: NFC: [GVNHoist] Outline functions from the class.

Self approving because this is NFC change to outline function definitions.

Aug 17 2020, 5:40 PM · Restricted Project
hiraditya committed rG370330f084c0: NFC: [GVNHoist] Outline functions from the class (authored by hiraditya).
NFC: [GVNHoist] Outline functions from the class
Aug 17 2020, 5:40 PM
hiraditya closed D86032: NFC: [GVNHoist] Outline functions from the class.
Aug 17 2020, 5:40 PM · Restricted Project
hiraditya updated the diff for D86032: NFC: [GVNHoist] Outline functions from the class.

rebase

Aug 17 2020, 1:51 PM · Restricted Project
hiraditya added a comment to D85628: [HotColdSplitting] Add command line options for supplying cold function names via user input..

then it may be possible to construct a synthetic/fake profile as a pre-processing step

Aug 17 2020, 11:31 AM · Restricted Project
hiraditya updated the diff for D86032: NFC: [GVNHoist] Outline functions from the class.

Rebase

Aug 17 2020, 11:02 AM · Restricted Project
hiraditya committed rGcb6e6936db35: NFC: [GVNHoist] Hoist loop invariant code and rename variables for readability (authored by hiraditya).
NFC: [GVNHoist] Hoist loop invariant code and rename variables for readability
Aug 17 2020, 9:44 AM
hiraditya closed D86031: NFC: [GVNHoist] Hoist loop invariant code and rename variables for readability.
Aug 17 2020, 9:43 AM · Restricted Project
hiraditya updated the diff for D86031: NFC: [GVNHoist] Hoist loop invariant code and rename variables for readability.

Addressed fhahn's comments

Aug 17 2020, 9:22 AM · Restricted Project
hiraditya added a comment to D82892: [NFC] Methods to compare IR added in each IR subclass.

please run clang-format

Aug 17 2020, 9:17 AM · Restricted Project
hiraditya added a reviewer for D86031: NFC: [GVNHoist] Hoist loop invariant code and rename variables for readability: sebpop.
Aug 17 2020, 6:35 AM · Restricted Project

Aug 15 2020

hiraditya closed D85975: [NFC] Fix typo and variable names.

49a944af7f1980b54d8a2be0ef640f5a956bc423

Aug 15 2020, 10:12 PM · Restricted Project
hiraditya requested review of D86032: NFC: [GVNHoist] Outline functions from the class.
Aug 15 2020, 8:44 PM · Restricted Project
hiraditya requested review of D86031: NFC: [GVNHoist] Hoist loop invariant code and rename variables for readability.
Aug 15 2020, 8:00 PM · Restricted Project
hiraditya committed rG49a944af7f19: [NFC] Fix typo and variable names (authored by hiraditya).
[NFC] Fix typo and variable names
Aug 15 2020, 9:06 AM

Aug 14 2020

hiraditya added a comment to D85975: [NFC] Fix typo and variable names.

FWIW C++ doesn't really have a lattice anymore: https://wg21.link/p0418

Is there a guidance for the users of 'isStrongerThan', isStrongerThanUnordered etc.?

Aug 14 2020, 11:12 AM · Restricted Project
Herald added a project to D53779: [CodeExtractor] Allow extracting allocas within simple stack{save,restore} pairs: Restricted Project.

Is this patch still useful now that D53514 has landed?

Aug 14 2020, 10:47 AM · Restricted Project
hiraditya added inline comments to D82892: [NFC] Methods to compare IR added in each IR subclass.
Aug 14 2020, 10:27 AM · Restricted Project
hiraditya added reviewers for D85975: [NFC] Fix typo and variable names: jfb, chandlerc.
Aug 14 2020, 10:24 AM · Restricted Project