User Details
- User Since
- Feb 13 2015, 12:29 AM (309 w, 3 d)
Dec 9 2019
Ping, rebase
Dec 2 2019
Nov 24 2019
That is indeed the step I was missing. Thanks everybody for getting me up to speed.
Nov 23 2019
Alright, this is the first time I have to commit something with the new github process, and I have to admit, I do not know how to do it - or if I can do it at all. Running git llvm push ask me for a username and password, and my old one do not work. What's the next step for me here?
Nov 22 2019
Address some of the comments
Nov 20 2019
I'm a bit late to the party, but this is nothing short of amazing. Congratulations!
Nov 19 2019
Also while I'm at it, first sorry for taking so long to review, I missed that patch. Second, if I understand properly, getting node to be processed in the right order actually can collapse arbitrary long addition chains, but it's not clear how to get there, there is a bit of a wack a mole problem that start poping up every time.
Can you please explain a bit more what this is doing? This seems interesting, but I'm not quite sure the pattern is correct.
Oct 22 2019
O => Op
It's indeed not clear if what you have is the result of the legalizer. In this case just proceed.
Add a few comments
Oct 10 2019
Rebase and ping.
Oct 8 2019
Fix erroneously inverted condition and ensuring previously broken tests are now passing again.
Add test for vector - but nothing changes for them (see rL374043 ) and use isSubsetOf and getAllOnesValue.
Oct 7 2019
Oct 6 2019
Oct 2 2019
Use isConstOrConstSplat and getAPIntValue
Sep 30 2019
Rebase on top of NFC changes
Sep 29 2019
Sep 19 2019
Sep 3 2019
Ping ?
Aug 31 2019
Aug 30 2019
Add tests for the commutative case.
Precommit tests.
Aug 29 2019
Tighten the checks before creating the node.
- Avoid creating the shift node when not stricly required.
- Add negative tests.
I looked at the problem that @spatel ran into. It is not applicable to DAGCombiner, because the DAG is processed only once rather than in a loop as long as it is modified. I wouldn't be possible to change it to work like InstCombine does as there are a ton of A -> B -> A type of tranforms. That being said, it's not a good reason to add more, so it's worth looking into improving this if possible.
Aug 28 2019
IndexC => ExtrIndex
Upadte the doc comment to make it clear that the Mask argument can be modified.
Aug 27 2019
@nathanchance Thanks for this. Having a test case will help tremendously. Sorry for the inconvenience.
Rebase on top of D66804
Aug 26 2019
Because the order in which nodes are traversed is not reliable, it is very hard to come up with a test for this. Ultimately, this is part of a larger body of work that intend to ensure nodes are processed in topological order by DAGCombiner. Even if they do not change the codegen, doing these changes are useful as they reduce the pressure on the logic that maintains the topological order.
Add TODOs
Restore calls that are not tested.
Comments amrked as done.
Aug 25 2019
Ok, I found a handful of cases that are not coevered by the test suite. I'll investigate if adding test coverage is possible, if it is do so. If not, then I'll remove any modification from that diff.
Build NewMask using iterators
- Add comments
- dyn_cast -> cast
Aug 24 2019
Aug 23 2019
Fix outdated comment
SO I came up with a plan to get things processed in topological order. However, as mentioned previously, this is indeed leading into a world of pain. I have a prototype, but it causes numerous regression that I want to investigate.
Aug 22 2019
rebase and regenerate test
Restore check for qvfcmpeq