Page MenuHomePhabricator

sepavloff (Serge Pavlov)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 13 2013, 7:26 AM (387 w, 1 h)

Recent Activity

Today

sepavloff updated the diff for D83036: [X86][FPEnv] Lowering of {get,set,reset}_fpmode.

Rebased and used update_llc_test_checks.py script

Wed, Aug 12, 7:33 AM · Restricted Project
sepavloff updated the diff for D82525: [FPEnv] Intrinsics for access to FP control modes.

Rebased patch

Wed, Aug 12, 7:30 AM · Restricted Project

Mon, Aug 3

sepavloff added a comment to D82525: [FPEnv] Intrinsics for access to FP control modes.

Ping.

Mon, Aug 3, 5:10 AM · Restricted Project
sepavloff added a comment to D78902: [Driver] Add output file to properties of Command.

Ping.

Mon, Aug 3, 4:29 AM · Restricted Project

Thu, Jul 30

sepavloff updated the diff for D83036: [X86][FPEnv] Lowering of {get,set,reset}_fpmode.

Rebased patch

Thu, Jul 30, 1:41 AM · Restricted Project
sepavloff updated the diff for D82525: [FPEnv] Intrinsics for access to FP control modes.

Rebased patch

Thu, Jul 30, 1:37 AM · Restricted Project

Wed, Jul 29

sepavloff committed rG032ed39defc7: [Support] Class to facilitate file locking (authored by sepavloff).
[Support] Class to facilitate file locking
Wed, Jul 29, 11:43 PM
sepavloff closed D79066: [Support] Class to facilitate file locking.
Wed, Jul 29, 11:43 PM · Restricted Project

Tue, Jul 28

sepavloff committed rG536736995bf5: [Support] Add file lock/unlock functions (authored by sepavloff).
[Support] Add file lock/unlock functions
Tue, Jul 28, 2:45 AM
sepavloff closed D78896: [Support] Add file lock/unlock functions.
Tue, Jul 28, 2:45 AM · Restricted Project
sepavloff accepted D84159: GlobalISel: Handle llvm.roundeven.

The patch looks good to me, however I am not experienced in GlobalISel. Someone more familiar with it should look at this patch.

Tue, Jul 28, 12:04 AM · Restricted Project

Mon, Jul 27

sepavloff accepted D84592: [X86] Add custom lowering for llvm.roundeven with sse4.1..

LGTM.

Mon, Jul 27, 11:55 PM · Restricted Project
sepavloff added inline comments to D84592: [X86] Add custom lowering for llvm.roundeven with sse4.1..
Mon, Jul 27, 9:45 PM · Restricted Project
sepavloff added a comment to D78896: [Support] Add file lock/unlock functions.

As I noted on April 30, I'm OK with the Windows portions of this. I didn't explicitly "Accept" because I didn't want to pre-empt the concerns of the other reviewers.

I see that @MaskRay is still marked as requesting revisions.

Mon, Jul 27, 11:03 AM · Restricted Project
sepavloff added inline comments to D84159: GlobalISel: Handle llvm.roundeven.
Mon, Jul 27, 9:17 AM · Restricted Project
sepavloff updated the diff for D78899: [Driver] Add callback to Command execution.

Rebased patch

Mon, Jul 27, 2:28 AM · Restricted Project
sepavloff added a reviewer for D78896: [Support] Add file lock/unlock functions: amccarth.

@amccarth Could you please review Windows part of this patch? Thank you.

Mon, Jul 27, 1:00 AM · Restricted Project
sepavloff added a comment to D78902: [Driver] Add output file to properties of Command.

Adding output files property is a prerequisite for D78903 (Add option -fproc-stat-report). Despite large size of the patch, the change is very simple: it only adds new state variable OutputFilenames initialized by the new parameter to the constructor of Command.

Mon, Jul 27, 12:57 AM · Restricted Project

Sun, Jul 26

sepavloff updated the diff for D78902: [Driver] Add output file to properties of Command.

Rebased patch

Sun, Jul 26, 11:47 PM · Restricted Project
sepavloff updated the diff for D74730: [FPEnv][X86] Implement lowering of llvm.set.rounding.

Rebased patch

Sun, Jul 26, 10:11 PM · Restricted Project
sepavloff updated the diff for D74729: [FPEnv] Intrinsic for setting rounding mode.

Rebased patch

Sun, Jul 26, 10:06 PM · Restricted Project

Thu, Jul 23

sepavloff committed rG70e7aa4a4ed3: [AST][FPEnv] Keep FP options in trailing storage of CallExpr (authored by sepavloff).
[AST][FPEnv] Keep FP options in trailing storage of CallExpr
Thu, Jul 23, 10:06 PM
sepavloff closed D84343: [AST] Keep FP options in trailing storage of CallExpr.
Thu, Jul 23, 10:05 PM · Restricted Project
sepavloff added inline comments to D84159: GlobalISel: Handle llvm.roundeven.
Thu, Jul 23, 6:40 AM · Restricted Project
sepavloff updated the diff for D84343: [AST] Keep FP options in trailing storage of CallExpr.

Extended test with PCH read

Thu, Jul 23, 12:22 AM · Restricted Project

Wed, Jul 22

sepavloff committed rGdab898f9ab62: [Windows] Fix limit on command line size (authored by sepavloff).
[Windows] Fix limit on command line size
Wed, Jul 22, 10:27 PM
sepavloff closed D83772: [Windows] Fix limit on command line size.
Wed, Jul 22, 10:26 PM · Restricted Project, Restricted Project
Herald added a project to D84343: [AST] Keep FP options in trailing storage of CallExpr: Restricted Project.
Wed, Jul 22, 9:59 AM · Restricted Project

Tue, Jul 21

sepavloff added reviewers for D83772: [Windows] Fix limit on command line size: k8stone, max-kudr.

@k8stone @max-kudr Could you please review the changes for LLDB?

Tue, Jul 21, 11:31 PM · Restricted Project, Restricted Project
sepavloff updated the diff for D83772: [Windows] Fix limit on command line size.

Added changes for LLDB

Tue, Jul 21, 11:28 PM · Restricted Project, Restricted Project
sepavloff reopened D83772: [Windows] Fix limit on command line size.
Tue, Jul 21, 11:27 PM · Restricted Project, Restricted Project
sepavloff committed rGac0edc55887b: Revert "[Windows] Fix limit on command line size" (authored by sepavloff).
Revert "[Windows] Fix limit on command line size"
Tue, Jul 21, 11:01 AM
sepavloff added a reverting change for rGd4020ef7c474: [Windows] Fix limit on command line size: rGac0edc55887b: Revert "[Windows] Fix limit on command line size".
Tue, Jul 21, 11:01 AM
sepavloff committed rGd4020ef7c474: [Windows] Fix limit on command line size (authored by sepavloff).
[Windows] Fix limit on command line size
Tue, Jul 21, 3:34 AM
sepavloff closed D83772: [Windows] Fix limit on command line size.
Tue, Jul 21, 3:34 AM · Restricted Project, Restricted Project
sepavloff committed rG21cd7b72a3d4: Use typedef to represent storage type in FPOption and FPOptionsOverride (authored by sepavloff).
Use typedef to represent storage type in FPOption and FPOptionsOverride
Tue, Jul 21, 12:37 AM
sepavloff closed D84147: Use typedef to represent storage type in FPOption and FPOptionsOverride.
Tue, Jul 21, 12:37 AM · Restricted Project
sepavloff added inline comments to D84159: GlobalISel: Handle llvm.roundeven.
Tue, Jul 21, 12:34 AM · Restricted Project

Mon, Jul 20

sepavloff added inline comments to D71742: Added intrinsics for access to FP environment.
Mon, Jul 20, 5:00 AM · Restricted Project
Herald added a project to D84147: Use typedef to represent storage type in FPOption and FPOptionsOverride: Restricted Project.
Mon, Jul 20, 3:20 AM · Restricted Project

Wed, Jul 15

sepavloff updated the diff for D83772: [Windows] Fix limit on command line size.

Fixed unit test

Wed, Jul 15, 9:33 AM · Restricted Project, Restricted Project
sepavloff updated the diff for D83772: [Windows] Fix limit on command line size.

Fixed typo

Wed, Jul 15, 3:46 AM · Restricted Project, Restricted Project
sepavloff added a comment to D83772: [Windows] Fix limit on command line size.

Thank you for your detailed feedback!

Wed, Jul 15, 2:37 AM · Restricted Project, Restricted Project
sepavloff updated the diff for D83772: [Windows] Fix limit on command line size.

Addressed reviewer's notes

Wed, Jul 15, 2:28 AM · Restricted Project, Restricted Project

Tue, Jul 14

Herald added a project to D83772: [Windows] Fix limit on command line size: Restricted Project.
Tue, Jul 14, 7:22 AM · Restricted Project, Restricted Project

Mon, Jul 13

sepavloff accepted D83661: [llvm][unittests] Fix LLVM-Unit :: Support/./SupportTests/ProgramEnvTest.TestExecuteAndWaitStatistics on Solaris.

I would also make commit title a bit shorter, for example [llvm][unittests] Fix ProgramEnvTest.TestExecuteAndWaitStatistics on Solaris.

Mon, Jul 13, 9:53 PM · Restricted Project

Jul 13 2020

sepavloff added inline comments to D83661: [llvm][unittests] Fix LLVM-Unit :: Support/./SupportTests/ProgramEnvTest.TestExecuteAndWaitStatistics on Solaris.
Jul 13 2020, 9:07 AM · Restricted Project

Jul 10 2020

sepavloff updated the diff for D78902: [Driver] Add output file to properties of Command.

Rebased patch

Jul 10 2020, 9:07 AM · Restricted Project
sepavloff updated the diff for D78899: [Driver] Add callback to Command execution.

Rebased patch

Jul 10 2020, 1:16 AM · Restricted Project

Jul 9 2020

sepavloff updated the diff for D78896: [Support] Add file lock/unlock functions.

Rebased patch

Jul 9 2020, 11:17 PM · Restricted Project

Jul 7 2020

sepavloff updated the diff for D74729: [FPEnv] Intrinsic for setting rounding mode.

Rebased patch

Jul 7 2020, 10:56 PM · Restricted Project

Jul 3 2020

sepavloff updated the diff for D82525: [FPEnv] Intrinsics for access to FP control modes.

Missed change

Jul 3 2020, 5:53 AM · Restricted Project

Jul 2 2020

Herald added a reviewer for D74729: [FPEnv] Intrinsic for setting rounding mode: jdoerfert.

I'm wondering if this should be more opaque, and broader for the entire FP environment (not just the rounding mode). For AMDGPU we have a number of additional bits in the FP environment. We also have the denormal mode, enabling FP exceptions, and a few more exotic target specific FP mode bits.

Jul 2 2020, 4:48 AM · Restricted Project
sepavloff added a reviewer for D82525: [FPEnv] Intrinsics for access to FP control modes: arsenm.
Jul 2 2020, 4:47 AM · Restricted Project
sepavloff created D83036: [X86][FPEnv] Lowering of {get,set,reset}_fpmode.
Jul 2 2020, 4:47 AM · Restricted Project
sepavloff updated the diff for D82525: [FPEnv] Intrinsics for access to FP control modes.

Fixed legalization of SET_FPMODE

Jul 2 2020, 4:15 AM · Restricted Project

Jun 29 2020

sepavloff updated the diff for D81833: [X86][FPEnv] Lowering of {get,set,reset}_fpenv.

Updated patch

Jun 29 2020, 1:02 AM · Restricted Project

Jun 26 2020

sepavloff added inline comments to D71742: Added intrinsics for access to FP environment.
Jun 26 2020, 4:18 AM · Restricted Project
sepavloff added a comment to D78896: [Support] Add file lock/unlock functions.

Any feedback?

Jun 26 2020, 3:45 AM · Restricted Project

Jun 25 2020

sepavloff added inline comments to D78901: [Support] Get process statistics in ExecuteAndWait and Wait.
Jun 25 2020, 9:17 PM · Restricted Project
sepavloff created D82525: [FPEnv] Intrinsics for access to FP control modes.
Jun 25 2020, 1:35 AM · Restricted Project

Jun 24 2020

sepavloff added a comment to D78899: [Driver] Add callback to Command execution.

Ping.

Jun 24 2020, 10:47 AM · Restricted Project
sepavloff added a comment to D78902: [Driver] Add output file to properties of Command.

Ping.

Jun 24 2020, 10:47 AM · Restricted Project

Jun 22 2020

sepavloff added a comment to D82282: [Support][AIX] Implement wait4 wrapper to fix build.

Could you please select 'Commandeer Revision' in the 'Add Action' field? You will be able to rule this patch.

Jun 22 2020, 10:44 AM · Restricted Project
sepavloff added inline comments to D81843: [ARM][FPEnv] Lowering of {get,set,reset}_fpenv.
Jun 22 2020, 3:11 AM · Restricted Project
sepavloff added inline comments to D81833: [X86][FPEnv] Lowering of {get,set,reset}_fpenv.
Jun 22 2020, 3:11 AM · Restricted Project
sepavloff updated the diff for D81843: [ARM][FPEnv] Lowering of {get,set,reset}_fpenv.

Updated patch as its dependency changed

Jun 22 2020, 3:11 AM · Restricted Project
sepavloff updated the diff for D81833: [X86][FPEnv] Lowering of {get,set,reset}_fpenv.

Updated patch after update of dependency

Jun 22 2020, 3:11 AM · Restricted Project
sepavloff updated the diff for D71742: Added intrinsics for access to FP environment.

Removed dependency on DataLayout

Jun 22 2020, 3:11 AM · Restricted Project
sepavloff planned changes to D71741: Add size of FP environment to DataLayout.

The dependent revision D71742 is modified so that it does not require size of FP environment to be specified in DataLayout. Probably when implementing frontend part this information will become necessary.

Jun 22 2020, 3:11 AM · Restricted Project

Jun 21 2020

sepavloff created D82282: [Support][AIX] Implement wait4 wrapper to fix build.
Jun 21 2020, 9:41 PM · Restricted Project
sepavloff added inline comments to D78901: [Support] Get process statistics in ExecuteAndWait and Wait.
Jun 21 2020, 9:41 PM · Restricted Project

Jun 19 2020

sepavloff updated the diff for D81843: [ARM][FPEnv] Lowering of {get,set,reset}_fpenv.

Simplified address type calculation

Jun 19 2020, 9:44 AM · Restricted Project
sepavloff updated the diff for D78899: [Driver] Add callback to Command execution.

Rebased patch

Jun 19 2020, 6:59 AM · Restricted Project
sepavloff updated the diff for D79066: [Support] Class to facilitate file locking.

New method names, fixed unit test

Jun 19 2020, 3:11 AM · Restricted Project
sepavloff updated the diff for D78896: [Support] Add file lock/unlock functions.

Updated patch

Jun 19 2020, 12:29 AM · Restricted Project

Jun 18 2020

sepavloff updated the diff for D78902: [Driver] Add output file to properties of Command.

Clang-formatted the patch

Jun 18 2020, 11:23 PM · Restricted Project
sepavloff updated the diff for D78902: [Driver] Add output file to properties of Command.

Rebased patch

Jun 18 2020, 11:23 PM · Restricted Project
sepavloff added a comment to D78903: [Driver] Add option -fproc-stat-report.

Thank you @aganea !

Jun 18 2020, 9:45 AM · Restricted Project
sepavloff added inline comments to D78903: [Driver] Add option -fproc-stat-report.
Jun 18 2020, 7:02 AM · Restricted Project
sepavloff updated the diff for D78903: [Driver] Add option -fproc-stat-report.

Updated patch

Jun 18 2020, 5:24 AM · Restricted Project
sepavloff updated the diff for D78903: [Driver] Add option -fproc-stat-report.

Updated patch according to reviewer's notes

Jun 18 2020, 4:18 AM · Restricted Project

Jun 17 2020

sepavloff added inline comments to D78903: [Driver] Add option -fproc-stat-report.
Jun 17 2020, 9:40 AM · Restricted Project
sepavloff committed rG8bc8d2d678a2: Use explicitly unsigned zero to prevent from a warning (authored by sepavloff).
Use explicitly unsigned zero to prevent from a warning
Jun 17 2020, 2:07 AM

Jun 16 2020

sepavloff committed rG2e613d2ded2c: [Support] Get process statistics in ExecuteAndWait and Wait (authored by sepavloff).
[Support] Get process statistics in ExecuteAndWait and Wait
Jun 16 2020, 11:58 PM
sepavloff closed D78901: [Support] Get process statistics in ExecuteAndWait and Wait.
Jun 16 2020, 11:57 PM · Restricted Project

Jun 15 2020

sepavloff added inline comments to D71742: Added intrinsics for access to FP environment.
Jun 15 2020, 10:23 AM · Restricted Project
sepavloff created D81843: [ARM][FPEnv] Lowering of {get,set,reset}_fpenv.
Jun 15 2020, 8:07 AM · Restricted Project
sepavloff updated the diff for D81833: [X86][FPEnv] Lowering of {get,set,reset}_fpenv.

Fixed formatting issues

Jun 15 2020, 3:46 AM · Restricted Project
sepavloff created D81833: [X86][FPEnv] Lowering of {get,set,reset}_fpenv.
Jun 15 2020, 3:14 AM · Restricted Project
sepavloff added inline comments to D71742: Added intrinsics for access to FP environment.
Jun 15 2020, 2:08 AM · Restricted Project
sepavloff updated the diff for D71742: Added intrinsics for access to FP environment.

Updated patch

Jun 15 2020, 2:08 AM · Restricted Project

Jun 14 2020

sepavloff added a comment to D71741: Add size of FP environment to DataLayout.

Do we really need this in the datalayout? I can imagine certain frontends might care, but I can't imagine optimizations inserting new save/restore operations.

Jun 14 2020, 11:58 PM · Restricted Project
sepavloff updated the summary of D71741: Add size of FP environment to DataLayout.
Jun 14 2020, 10:55 PM · Restricted Project

Jun 12 2020

sepavloff updated the summary of D71742: Added intrinsics for access to FP environment.
Jun 12 2020, 10:52 AM · Restricted Project
sepavloff updated the diff for D71742: Added intrinsics for access to FP environment.

Updated patch

Jun 12 2020, 10:52 AM · Restricted Project
sepavloff updated the diff for D71741: Add size of FP environment to DataLayout.

Updated patch

Jun 12 2020, 10:52 AM · Restricted Project

Jun 10 2020

sepavloff updated the diff for D78896: [Support] Add file lock/unlock functions.

Forgotten changes

Jun 10 2020, 2:08 AM · Restricted Project
sepavloff added a comment to D78896: [Support] Add file lock/unlock functions.

It's a pitty about flock&solaris. It's a much saner api, and a lot closer to the windows implementation.

I guess we have to stick to fcntl then. The new version looks good. I just think it would be good to acknowledge the weirdness of the flock api in the method documentation. Maybe something like "Care should be taken when using this function in a multithreaded context, as it may not prevent other threads in the same process from obtaining a lock on the same file, even if they are using a different file descriptor."

Jun 10 2020, 1:36 AM · Restricted Project
sepavloff updated the diff for D78896: [Support] Add file lock/unlock functions.

Updated patch

Jun 10 2020, 1:36 AM · Restricted Project