Page MenuHomePhabricator

RKSimon (Simon Pilgrim)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2014, 7:26 AM (349 w, 5 d)

Recent Activity

Yesterday

RKSimon added a comment to D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions.

@myhsu Please can you raise a bug covering the CodeBeads vs TSFlags refactor options and make it a blocker against a second bug for making the m68k backend non-experimental?

Fri, Jan 15, 2:01 PM · Restricted Project
RKSimon committed rGbe69e66b1cd8: [X86][SSE] Attempt to fold shuffle(binop(),binop()) -> binop(shuffle(),shuffle… (authored by RKSimon).
[X86][SSE] Attempt to fold shuffle(binop(),binop()) -> binop(shuffle(),shuffle…
Fri, Jan 15, 8:38 AM
RKSimon committed rG46aa3c6c331c: [DAG] visitVECTOR_SHUFFLE - MergeInnerShuffle - improve shuffle(shuffle(x,y)… (authored by RKSimon).
[DAG] visitVECTOR_SHUFFLE - MergeInnerShuffle - improve shuffle(shuffle(x,y)…
Fri, Jan 15, 7:09 AM
RKSimon closed D94671: [DAG] visitVECTOR_SHUFFLE - MergeInnerShuffle - improve shuffle(shuffle(x,y),shuffle(x,y)) merging.
Fri, Jan 15, 7:09 AM · Restricted Project
RKSimon updated the diff for D94532: [DAG] SimplifyDemandedBits - use KnownBits comparisons to remove ISD::UMIN/UMAX ops.

add ult/ugt handling

Fri, Jan 15, 6:45 AM · Restricted Project
RKSimon committed rG5183a13d3782: [X86] Add umin knownbits/demandedbits ult test for D94532 (authored by RKSimon).
[X86] Add umin knownbits/demandedbits ult test for D94532
Fri, Jan 15, 6:43 AM
RKSimon committed rG1dfd5c9ad8cf: [X86][AVX] combineHorizOpWithShuffle - support target shuffles in HOP(SHUFFLE(X… (authored by RKSimon).
[X86][AVX] combineHorizOpWithShuffle - support target shuffles in HOP(SHUFFLE(X…
Fri, Jan 15, 5:55 AM
RKSimon added inline comments to D88569: [DAGCombiner] Call SimplifyDemandedBits to simplify EXTRACT_VECTOR_ELT.
Fri, Jan 15, 5:54 AM · Restricted Project
RKSimon added a comment to D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions.

The impact on existing targets is pretty minimal - I suppose the logical operand mappings code is the most exposed part? The CodeBeads code is relatively self-contained.

Fri, Jan 15, 2:04 AM · Restricted Project
RKSimon added inline comments to D94532: [DAG] SimplifyDemandedBits - use KnownBits comparisons to remove ISD::UMIN/UMAX ops.
Fri, Jan 15, 1:57 AM · Restricted Project
RKSimon resigned from D52818: [Tablegen/SubtargetEmitter] Add Id field to ProcResource.
Fri, Jan 15, 1:18 AM

Thu, Jan 14

RKSimon added a comment to D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions.

FWIW I still think we're better off keeping (m68k only) CodeBeads rather than refactoring a lot of code that will affect mainstream targets. After m68k has been pushed, we can reinvestigate whether to keep CodeBeads (and whether other targets would benefit from using it), or moving m68k to a refactored TSFlag mechanism - we can make either a pre-requisite for it losing its experimental status if necessary.

Thu, Jan 14, 10:17 AM · Restricted Project
RKSimon accepted D87145: [SelectionDAG] Remove an early-out from computeKnownBits for smin/smax.

LGTM - cheers!

Thu, Jan 14, 10:09 AM · Restricted Project
RKSimon added a comment to D87145: [SelectionDAG] Remove an early-out from computeKnownBits for smin/smax.

@foad Please can you rebase? I think I've replaced the dodgy test with something useful now

Thu, Jan 14, 9:58 AM · Restricted Project
RKSimon committed rGb99782cf7850: [X86][AVX] Adjust unsigned saturation downconvert negative test (authored by RKSimon).
[X86][AVX] Adjust unsigned saturation downconvert negative test
Thu, Jan 14, 9:57 AM
RKSimon added inline comments to D92238: [SCEVExpander] Migrate costAndCollectOperands to use InstructionCost..
Thu, Jan 14, 9:55 AM · Restricted Project
RKSimon added inline comments to D94693: Improve KnownBits analyses for SMIN/SMAX DAG nodes..
Thu, Jan 14, 8:12 AM · Restricted Project
RKSimon committed rG0a59647ee407: [SystemZ] misched-cutoff tests can only be tested on non-NDEBUG (assertion)… (authored by RKSimon).
[SystemZ] misched-cutoff tests can only be tested on non-NDEBUG (assertion)…
Thu, Jan 14, 7:47 AM
RKSimon committed rGd0dbb0468c26: [Support] Remove redundant sign bit tests from KnownBits… (authored by RKSimon).
[Support] Remove redundant sign bit tests from KnownBits…
Thu, Jan 14, 7:47 AM
RKSimon committed rGc0939fddf80c: [Support] Simplify KnownBits::sextInReg implementation. (authored by RKSimon).
[Support] Simplify KnownBits::sextInReg implementation.
Thu, Jan 14, 7:15 AM
RKSimon added a comment to D94532: [DAG] SimplifyDemandedBits - use KnownBits comparisons to remove ISD::UMIN/UMAX ops.

Anyone have any final comments - otherwise I'll commit this tomorrow.

Thu, Jan 14, 7:12 AM · Restricted Project
RKSimon committed rG0b46f19a9ecd: [Support] Ensure KnownBits::sextInReg can handle the src == dst sext-in-reg… (authored by RKSimon).
[Support] Ensure KnownBits::sextInReg can handle the src == dst sext-in-reg…
Thu, Jan 14, 6:51 AM
RKSimon added a comment to rG9cf4f493a72f: [DAG] Move SelectionDAG implementation to KnownBits::setInReg(). NFCI..

This was a direct move from SelectionDAG's implementation as I wanted to avoid introducing any subtle behaviour changes - I've added the exhaustive tests (which has already exposed one issue I'm fixing now) and I'll start cleaning up the KnownBits::sextInReg implementation after that.

Thu, Jan 14, 6:34 AM
RKSimon committed rGe8622d27c0e3: [Support] Add KnownBits::sextInReg exhaustive tests (authored by RKSimon).
[Support] Add KnownBits::sextInReg exhaustive tests
Thu, Jan 14, 6:28 AM
RKSimon accepted D94595: [Support] Simplify KnownBits::icmp helpers. NFC..

LGTM

Thu, Jan 14, 5:54 AM · Restricted Project
RKSimon accepted D94587: [SelectionDAG] Make use of KnownBits::commonBits. NFC..

LGTM - cheers

Thu, Jan 14, 5:53 AM · Restricted Project
RKSimon requested review of D94671: [DAG] visitVECTOR_SHUFFLE - MergeInnerShuffle - improve shuffle(shuffle(x,y),shuffle(x,y)) merging.
Thu, Jan 14, 4:18 AM · Restricted Project
RKSimon committed rG7c30c05ff71d: [DAG] visitVECTOR_SHUFFLE - MergeInnerShuffle - reset shuffle ops and reorder… (authored by RKSimon).
[DAG] visitVECTOR_SHUFFLE - MergeInnerShuffle - reset shuffle ops and reorder…
Thu, Jan 14, 3:55 AM
RKSimon added a comment to D93510: Fix llvm::Optional build breaks in MSVC using std::is_trivially_copyable.

@jplayer-nv It looks like this patch has broken the ppc buildbots - please can you take a look? http://lab.llvm.org:8011/#/builders/93/builds/1435

Thu, Jan 14, 3:16 AM · Restricted Project
RKSimon committed rG8f1d7f3753ca: [X86] Improve sum-of-reductions v4f32 test coverage (authored by RKSimon).
[X86] Improve sum-of-reductions v4f32 test coverage
Thu, Jan 14, 3:05 AM
RKSimon committed rGaf8d27a7a826: [DAG] visitVECTOR_SHUFFLE - pull out shuffle merging code into lambda helper. (authored by RKSimon).
[DAG] visitVECTOR_SHUFFLE - pull out shuffle merging code into lambda helper.
Thu, Jan 14, 3:05 AM
RKSimon added a reviewer for D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad: hfinkel.

LGTM but a PPC-guru needs to signoff

Thu, Jan 14, 2:35 AM · Restricted Project
RKSimon added a comment to D94658: Remove redundant move call in return statements.

Also, sorry for hijacking but if you're looking at std::move cleanup, this scary static analysis warning has been around for a while: https://llvm.org/reports/scan-build/report-BitcodeReader.cpp-BitcodeReader-0-1.html#EndPath

Thu, Jan 14, 2:20 AM · Restricted Project
RKSimon added a comment to D94658: Remove redundant move call in return statements.

I'm not certain but I thought some of these moves had to be kept to appease old versions of gcc - but I can't remember any details.

Thu, Jan 14, 2:18 AM · Restricted Project
RKSimon resigned from D94597: [X86] Lower calls with rv_marker attribute..
Thu, Jan 14, 2:06 AM · Restricted Project
RKSimon resigned from D93101: [Clang][Codegen] Truncate initializers of union bitfield members.
Thu, Jan 14, 2:05 AM · Restricted Project

Wed, Jan 13

RKSimon committed rG993c488ed2b3: [DAG] visitVECTOR_SHUFFLE - use all_of to check for all-undef shuffle mask. (authored by RKSimon).
[DAG] visitVECTOR_SHUFFLE - use all_of to check for all-undef shuffle mask.
Wed, Jan 13, 9:20 AM
RKSimon committed rGefb6e45d2be8: [X86][AVX] Add test for another 'reverse HADD' pattern mentioned in PR41813 (authored by RKSimon).
[X86][AVX] Add test for another 'reverse HADD' pattern mentioned in PR41813
Wed, Jan 13, 9:20 AM
RKSimon committed rGcbbfc8258615: [X86][SSE] canonicalizeShuffleMaskWithHorizOp - simplify shuffle(HOP(HOP(X,Y)… (authored by RKSimon).
[X86][SSE] canonicalizeShuffleMaskWithHorizOp - simplify shuffle(HOP(HOP(X,Y)…
Wed, Jan 13, 9:20 AM
RKSimon added inline comments to D94595: [Support] Simplify KnownBits::icmp helpers. NFC..
Wed, Jan 13, 8:24 AM · Restricted Project
RKSimon added inline comments to D94595: [Support] Simplify KnownBits::icmp helpers. NFC..
Wed, Jan 13, 7:11 AM · Restricted Project
RKSimon added a comment to D94532: [DAG] SimplifyDemandedBits - use KnownBits comparisons to remove ISD::UMIN/UMAX ops.

LGTM. Any reason not to do this for SMAX and SMIN too?

Wed, Jan 13, 6:42 AM · Restricted Project
RKSimon committed rG0a0ee7f5a5af: [X86] canonicalizeShuffleMaskWithHorizOp - minor refactor to support multiple… (authored by RKSimon).
[X86] canonicalizeShuffleMaskWithHorizOp - minor refactor to support multiple…
Wed, Jan 13, 6:01 AM
RKSimon added a comment to rG23b41986527a: [Support] Add KnownBits::icmp helpers..

@foad Can you raise a patch please?

Wed, Jan 13, 5:08 AM
RKSimon added inline comments to rG899674274124: [KnownBits] Add KnownBits::makeConstant helper. NFCI..
Wed, Jan 13, 3:54 AM
RKSimon accepted D94588: [Analysis,CodeGen] Make use of KnownBits::makeConstant. NFC..

LGTM

Wed, Jan 13, 3:45 AM · Restricted Project
RKSimon added a reviewer for D94532: [DAG] SimplifyDemandedBits - use KnownBits comparisons to remove ISD::UMIN/UMAX ops: foad.
Wed, Jan 13, 3:25 AM · Restricted Project
RKSimon committed rG0f59d099571d: [X86][AVX] combineVectorSignBitsTruncation - limit AVX512 truncations to 128… (authored by RKSimon).
[X86][AVX] combineVectorSignBitsTruncation - limit AVX512 truncations to 128…
Wed, Jan 13, 2:47 AM

Tue, Jan 12

RKSimon commandeered D25987: [X86] New pattern to generate PSUBUS from SELECT.

I've been working on PR40111 to make most x86 ISD::USUBSAT code generic and moved into DAGCombine - I'll look at this as well.

Tue, Jan 12, 2:31 PM
RKSimon requested review of D94532: [DAG] SimplifyDemandedBits - use KnownBits comparisons to remove ISD::UMIN/UMAX ops.
Tue, Jan 12, 10:31 AM · Restricted Project
RKSimon committed rGa4931d4fe38d: [AMDGPU] Regenerate umax crash test (authored by RKSimon).
[AMDGPU] Regenerate umax crash test
Tue, Jan 12, 10:02 AM
RKSimon committed rG85aaa3e310c2: [X86] Regenerate sdiv_fix_sat.ll + udiv_fix_sat.ll tests (authored by RKSimon).
[X86] Regenerate sdiv_fix_sat.ll + udiv_fix_sat.ll tests
Tue, Jan 12, 9:26 AM
RKSimon committed rG2ed914cb7e9c: [X86][SSE] getFauxShuffleMask - handle PACKSS(SRAI(),SRAI()) shuffle patterns. (authored by RKSimon).
[X86][SSE] getFauxShuffleMask - handle PACKSS(SRAI(),SRAI()) shuffle patterns.
Tue, Jan 12, 6:09 AM
RKSimon committed rG7e44208115b3: [X86][SSE] combineSubToSubus - add v16i32 handling on pre-AVX512BW targets. (authored by RKSimon).
[X86][SSE] combineSubToSubus - add v16i32 handling on pre-AVX512BW targets.
Tue, Jan 12, 5:49 AM
RKSimon committed rGa5212b5c91cc: [X86][SSE] combineSubToSubus - remove SSE2 early-out. (authored by RKSimon).
[X86][SSE] combineSubToSubus - remove SSE2 early-out.
Tue, Jan 12, 4:53 AM

Mon, Jan 11

RKSimon added a comment to D66571: [X86] Add a DAG combine to turn vector (and (srl X, ((1 << C1) - 1)), C2) into (srl (shl (X, C3), C4)) to save a constant pool for the AND mask.

@craig.topper Whatever happened to this patch? It still looks useful.

Mon, Jan 11, 12:42 PM · Restricted Project
RKSimon added a reviewer for D94417: [ADT][Support] Fix C4146 error from MSVC: RKSimon.

Perhaps we could rewrite the code to use ~ or the like instead of unary - if that works?

Mon, Jan 11, 12:30 PM · Restricted Project
RKSimon added a reviewer for D94436: [X86] Add the FSRM feature (Fast Short Rep Mov) to Zen3.: GGanesh.
Mon, Jan 11, 12:23 PM · Restricted Project
RKSimon committed rG072714b96198: [X86] Regenerate vector-constrained-fp-intrinsics.ll tests (authored by RKSimon).
[X86] Regenerate vector-constrained-fp-intrinsics.ll tests
Mon, Jan 11, 10:14 AM
RKSimon committed rG4214ca96145c: [X86][AVX] Attempt to fold vpermf128(op(x,i),op(y,i)) -> op(vpermf128(x,y),i) (authored by RKSimon).
[X86][AVX] Attempt to fold vpermf128(op(x,i),op(y,i)) -> op(vpermf128(x,y),i)
Mon, Jan 11, 9:09 AM
RKSimon committed rGa0f82749f4f3: [X86] Extend lzcnt-cmp tests to test on non-lzcnt targets (authored by RKSimon).
[X86] Extend lzcnt-cmp tests to test on non-lzcnt targets
Mon, Jan 11, 7:27 AM
RKSimon committed rGa46982a25511: [X86] Add nounwind to lzcnt-cmp tests (authored by RKSimon).
[X86] Add nounwind to lzcnt-cmp tests
Mon, Jan 11, 7:07 AM
RKSimon committed rG8112a2598ce1: [X86][SSE] Add 'vectorized sum' test patterns (authored by RKSimon).
[X86][SSE] Add 'vectorized sum' test patterns
Mon, Jan 11, 4:51 AM
RKSimon committed rG596322926630: [X86][SSE] Add missing SSE test coverage for permute(hop,hop) folds (authored by RKSimon).
[X86][SSE] Add missing SSE test coverage for permute(hop,hop) folds
Mon, Jan 11, 3:29 AM
RKSimon added a reverting change for rGd43a264a5dd3: Revert "[X86][SSE] Fold unpack(hop(),hop()) -> permute(hop())": rG41bf338dd1e7: Revert rGd43a264a5dd3 "Revert "[X86][SSE] Fold unpack(hop(),hop()) -> permute….
Mon, Jan 11, 3:29 AM
RKSimon committed rG41bf338dd1e7: Revert rGd43a264a5dd3 "Revert "[X86][SSE] Fold unpack(hop(),hop()) -> permute… (authored by RKSimon).
Revert rGd43a264a5dd3 "Revert "[X86][SSE] Fold unpack(hop(),hop()) -> permute…
Mon, Jan 11, 3:29 AM

Sat, Jan 9

RKSimon added a comment to D94213: Clang: Remove support for 3DNow!, both intrinsics and builtins..

This all needs properly documenting in the release notes, and possibly in the clang docs as well explaining that mmx/3dnow is supported only inside assembly,

Sat, Jan 9, 10:41 AM · Restricted Project, Restricted Project
RKSimon accepted D94330: [NFC] Disallow unused prefixes in CodeGen/X86 tests..

LGTM cheers

Sat, Jan 9, 10:35 AM · Restricted Project

Fri, Jan 8

RKSimon added a comment to D52818: [Tablegen/SubtargetEmitter] Add Id field to ProcResource.

@kariddi Are you still looking at this, otherwise abandon it?

Fri, Jan 8, 7:51 AM
RKSimon committed rG80dee7965dff: [X86][SSE] Fold unpack(hop(),hop()) -> permute(hop()) (authored by RKSimon).
[X86][SSE] Fold unpack(hop(),hop()) -> permute(hop())
Fri, Jan 8, 7:26 AM
RKSimon committed rG4a582d766ae4: [X86][SSE] Add vphaddd/vphsubd unpack(hop(),hop()) tests (authored by RKSimon).
[X86][SSE] Add vphaddd/vphsubd unpack(hop(),hop()) tests
Fri, Jan 8, 6:41 AM
RKSimon committed rG7b9f541c1edb: [X86][SSE] Add tests for unpack(hop(),hop()) (authored by RKSimon).
[X86][SSE] Add tests for unpack(hop(),hop())
Fri, Jan 8, 6:12 AM

Thu, Jan 7

RKSimon planned changes to D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506).
Thu, Jan 7, 7:33 AM · Restricted Project
RKSimon committed rG037b058e4197: [AArch64] SVEIntrinsicOpts - use range loop and cast<> instead of dyn_cast<>… (authored by RKSimon).
[AArch64] SVEIntrinsicOpts - use range loop and cast<> instead of dyn_cast<>…
Thu, Jan 7, 6:22 AM
RKSimon committed rGfa6d89779990: [Analysis] MemoryDepChecker::couldPreventStoreLoadForward - remove dead store. (authored by RKSimon).
[Analysis] MemoryDepChecker::couldPreventStoreLoadForward - remove dead store.
Thu, Jan 7, 6:22 AM
RKSimon committed rGa9a8caf2ce2f: [llvm-objdump] Pass Twine by const reference instead of by value. NFCI. (authored by RKSimon).
[llvm-objdump] Pass Twine by const reference instead of by value. NFCI.
Thu, Jan 7, 4:54 AM
RKSimon committed rG028091195d76: [DWARF] DWARFDebugLoc::dumpRawEntry - remove dead stores. NFCI. (authored by RKSimon).
[DWARF] DWARFDebugLoc::dumpRawEntry - remove dead stores. NFCI.
Thu, Jan 7, 4:54 AM
RKSimon committed rG236129fb4460: [CompilationDatabase] Pass Twine by const reference instead of by value. NFCI. (authored by RKSimon).
[CompilationDatabase] Pass Twine by const reference instead of by value. NFCI.
Thu, Jan 7, 4:53 AM
RKSimon committed rG350ab7aa1c67: [DAG] Simplify OR(X,SHL(Y,BW/2)) eq/ne 0/-1 'all/any-of' style patterns (authored by RKSimon).
[DAG] Simplify OR(X,SHL(Y,BW/2)) eq/ne 0/-1 'all/any-of' style patterns
Thu, Jan 7, 4:04 AM
RKSimon closed D93599: [DAG] Simplify OR(X,SHL(Y,BW/2)) eq/ne 0/-1 'all/any-of' style patterns.
Thu, Jan 7, 4:03 AM · Restricted Project

Wed, Jan 6

RKSimon updated the diff for D93599: [DAG] Simplify OR(X,SHL(Y,BW/2)) eq/ne 0/-1 'all/any-of' style patterns.

Add better comment suggested by @spatel

Wed, Jan 6, 10:35 AM · Restricted Project
RKSimon updated the diff for D93599: [DAG] Simplify OR(X,SHL(Y,BW/2)) eq/ne 0/-1 'all/any-of' style patterns.

Add commuted pattern handling

Wed, Jan 6, 10:10 AM · Restricted Project
RKSimon committed rG3f8c2520c042: [X86] Add commuted patterns test coverage for D93599 (authored by RKSimon).
[X86] Add commuted patterns test coverage for D93599
Wed, Jan 6, 10:03 AM
RKSimon committed rG1307e3f6c46c: [TargetLowering] Add icmp ne/eq (srl (ctlz x), log2(bw)) vector support. (authored by RKSimon).
[TargetLowering] Add icmp ne/eq (srl (ctlz x), log2(bw)) vector support.
Wed, Jan 6, 8:14 AM
RKSimon committed rG500864f928c2: Remove some unused <vector> includes. NFCI. (authored by RKSimon).
Remove some unused <vector> includes. NFCI.
Wed, Jan 6, 7:52 AM
RKSimon committed rGb69fe6a85db4: [X86] Add icmp ne/eq (srl (ctlz x), log2(bw)) test coverage. (authored by RKSimon).
[X86] Add icmp ne/eq (srl (ctlz x), log2(bw)) test coverage.
Wed, Jan 6, 7:52 AM
RKSimon committed rG26c486c2eb1a: [TableGen] RegisterBankEmitter - Pass Twine by const reference instead of by… (authored by RKSimon).
[TableGen] RegisterBankEmitter - Pass Twine by const reference instead of by…
Wed, Jan 6, 6:23 AM
RKSimon committed rGdf5c2caf0fc0: [MIPS] MipsAsmParser - Pass Twine by const reference instead of by value. NFCI. (authored by RKSimon).
[MIPS] MipsAsmParser - Pass Twine by const reference instead of by value. NFCI.
Wed, Jan 6, 6:23 AM
RKSimon committed rG396dd6cd3d8b: [ProfileData] Pass Twine by const reference instead of by value. (authored by RKSimon).
[ProfileData] Pass Twine by const reference instead of by value.
Wed, Jan 6, 6:23 AM
RKSimon committed rG37ac4f865fba: [Hexagon] Regenerate zext-v4i1.ll tests (authored by RKSimon).
[Hexagon] Regenerate zext-v4i1.ll tests
Wed, Jan 6, 5:46 AM
RKSimon planned changes to D56387: [DAGCombiner] Enable SimplifyDemandedBits vector support for TRUNCATE (WIP).
Wed, Jan 6, 5:41 AM · Restricted Project
RKSimon updated the diff for D56387: [DAGCombiner] Enable SimplifyDemandedBits vector support for TRUNCATE (WIP).

rebase (still WIP though)

Wed, Jan 6, 5:41 AM · Restricted Project
RKSimon updated the diff for D93599: [DAG] Simplify OR(X,SHL(Y,BW/2)) eq/ne 0/-1 'all/any-of' style patterns.

Improve scalar test coverage

Wed, Jan 6, 4:08 AM · Restricted Project
RKSimon committed rGdfcb872c3e82: [X86] Add scalar/vector test coverage for D93599 (authored by RKSimon).
[X86] Add scalar/vector test coverage for D93599
Wed, Jan 6, 3:59 AM
RKSimon accepted D92812: [X86] Update tests for znver3.

LGTM - cheers

Wed, Jan 6, 2:07 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jan 5

RKSimon committed rG55488bd3cd1a: CGExpr - EmitMatrixSubscriptExpr - fix getAs<> null-dereference static analyzer… (authored by RKSimon).
CGExpr - EmitMatrixSubscriptExpr - fix getAs<> null-dereference static analyzer…
Tue, Jan 5, 9:09 AM
RKSimon added inline comments to D94092: [Clang] Remove unnecessary Attr.isArgIdent checks..
Tue, Jan 5, 8:55 AM · Restricted Project
RKSimon committed rG73a44f437bf1: [X86][AVX] combineVectorSignBitsTruncation - use PACKSS/PACKUS in more AVX cases (authored by RKSimon).
[X86][AVX] combineVectorSignBitsTruncation - use PACKSS/PACKUS in more AVX cases
Tue, Jan 5, 7:03 AM
RKSimon updated the diff for D93599: [DAG] Simplify OR(X,SHL(Y,BW/2)) eq/ne 0/-1 'all/any-of' style patterns.

Improve handling of AND/OR(OR(X2,SHL(Y2,BW/2)) , OR(X1,SHL(Y1,BW/2)) ) style patterns to fix remaining movmsk patterns

Tue, Jan 5, 5:42 AM · Restricted Project
RKSimon accepted D92907: [RegisterClassInfo] Return non-zero for RC without allocatable reg.

LGTM with one minor

Tue, Jan 5, 5:39 AM · Restricted Project