User Details
- User Since
- Feb 20 2018, 9:31 AM (152 w, 2 d)
Tue, Jan 19
Thu, Jan 14
This doesn't add metadata to llvm intrinsics that are not constrained.
Wed, Jan 13
Wed, Jan 6
Dec 21 2020
Dec 18 2020
Dec 17 2020
Do you need tests for the verifier part?
Dec 15 2020
Dec 11 2020
Dec 8 2020
Dec 7 2020
Dec 3 2020
Nov 30 2020
Thanks for the quick turnaround!
Nov 25 2020
Nov 23 2020
Nov 13 2020
Nov 12 2020
Nov 11 2020
Update for review comments.
No worries!
OK, I'll bite. I do know GOFF, having implemented it in a shipping, commercial compiler before. Give me some time to take a closer look.
Nov 6 2020
LGTM
Nov 4 2020
Update for review comments.
Update for review comments.
Nov 2 2020
Oct 30 2020
I'll see how much I can simplify of the tests.
Oct 29 2020
Fix test, and eliminate a debugging "tee" command accidentally left in.
Oct 28 2020
Add some tests for changing the rounding metadata.
I also added "-fexperimental-strict-floating-point" which makes it possible to write tests for a target when bringing up the support on that target. I think it would be confusing for that flag to work on command line arguments but not pragmas.
Oct 27 2020
Oct 26 2020
Ping
Oct 23 2020
Fix a bug introduced in the last round, and eliminate the pass manager argument from one of the tests.
Oct 13 2020
Updates from review.
Oct 8 2020
Update/simplify for review comments.
Oct 7 2020
Oct 6 2020
Oct 2 2020
Are you planning on supporting the case where an ED has a nonzero offset? For a general purpose dumper it matters: HLASM.
Sep 22 2020
Unneeded since D85960 landed.
Sep 11 2020
Say, in D80952 I added support for disabling strictfp support when a target doesn't support it. But it only applies to command line arguments.
Sep 10 2020
Sep 8 2020
Over in D80952 there was a comment from @steven.zhang: "Agree that we can turn on it later when it is done." But your comment here is that it is "almost done".
Aug 27 2020
Aug 17 2020
It would be better to go with D85960. I'll hedge and keep this open until that one gets pushed.
Aug 14 2020
You mentioned in D85920 a need to merge this review with that review. I don't think that's needed. This code here is farther along. It does everything that D85920 does and has necessary pieces implemented as well.
Aug 13 2020
Aug 3 2020
Jul 29 2020
Jul 21 2020
Jul 10 2020
Jul 9 2020
Thanks for the reviews and the fast turnaround! I do appreciate it!
Jul 7 2020
Add the -fexperimental-strict-floating-point flag to enable on hosts that are not marked as supporting strict FP yet. Add test and documentation.
Jul 6 2020
Already on it. I hope I got it now.
Jun 30 2020
Ping. I'm really hoping to get this into 11. Otherwise we're going multiple releases with options that people already use causing crashes on most architectures.
Jun 26 2020
Jun 25 2020
Jun 22 2020
Remove debugging command left in accidentally. Rebase.
Ping?
Jun 15 2020
Jun 12 2020
Ping.
Jun 11 2020
Added new warnings to a new group "unsupported-floating-point-opt". The warning can be disabled. The disabling of constrained floating point is unaffected by the status of the warning.