This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC, test] Fix use of undef FileCheck var
ClosedPublic

Authored by thopre on Apr 5 2021, 3:31 AM.

Details

Summary

LLVM test CodeGen/PowerPC/ppc-disable-non-volatile-cr.ll tries to check
for the absence of a sequence of instructions with several CHECK-NOT
with one of those directives using a variable defined in another.
However CHECK-NOT are checked independently so that is using a variable
defined in a pattern that should not occur in the input.

This commit changes occurence of the variable for the regex used in its
definition, thereby making each CHECK-NOT independent.

Diff Detail

Event Timeline

thopre created this revision.Apr 5 2021, 3:31 AM
thopre requested review of this revision.Apr 5 2021, 3:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2021, 3:31 AM
NeHuang accepted this revision.Apr 6 2021, 12:19 PM

LGTM. Thanks! Please give it another 24 hours before commit to wait for the other reviewers' comment.

This revision is now accepted and ready to land.Apr 6 2021, 12:19 PM
nemanjai accepted this revision.Apr 6 2021, 7:35 PM

LGTM. Thanks for fixing this.

This revision was automatically updated to reflect the committed changes.