This is an archive of the discontinued LLVM Phabricator instance.

[mlgo] fix build rules
ClosedPublic

Authored by mtrofin on Apr 2 2021, 11:53 PM.

Details

Summary

This was prompted by D95727, which had the side-effect to break the
'release' mode build bot for ML-driven policies. The problem is that now
the pre-compiled object files don't get transitively carried through as
'source' anymore; that being said, the previous way of consuming them
was problematic, because it was only working for static builds; in
dynamic builds, the whole tf_xla_runtime was linked, which is
undesirable.

The alternative is to treat tf_xla_runtime as an archive, which then
leads to the desired effect.

Diff Detail

Event Timeline

mtrofin created this revision.Apr 2 2021, 11:53 PM
mtrofin requested review of this revision.Apr 2 2021, 11:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 2 2021, 11:53 PM

I'll land it to unblock the ml build bots, and because the change should poise no risk elsewhere, but let me know if this could be expressed differently, and I'll follow up.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2021, 12:59 PM
This revision was automatically updated to reflect the committed changes.