Refactor: Simplify boolean conditional return statements in llvm/lib/Support

[LegalizeAdulthood]

Summary

Use clang-tidy to simplify boolean conditional return statements

[craig.topper]

lib/Support/YAMLParser.cpp

966

Operator should be on end of previous line

[LegalizeAdulthood]

lib/Support/YAMLParser.cpp

966

Fixed.

[LegalizeAdulthood]

clang-format

[LegalizeAdulthood]

Update from latest.
I do not have commit access.

[alexfh]

LG

lib/Support/CommandLine.cpp

while (Pos != StringRef::npos) {
       Value.substr(Pos + 1); // Increment the original value pointer as well.
       // Check for another comma.
       Pos = Val.find(',');
     }
 
     Value = Val;
   }
 
-  if (Handler->addOccurrence(pos, ArgName, Value, MultiArg))
-    return true;
-
-  return false;
+  return Handler->addOccurrence(pos, ArgName, Value, MultiArg);
 }
 
 /// ProvideOption - For Value, this differentiates between an empty value ("")
 /// and a null value (StringRef()).  The later is accepted for arguments that
 /// don't allow a value (-foo) the former is rejected (-foo=).
 static inline bool ProvideOption(Option *Handler, StringRef ArgName,
                                  StringRef Value, int argc,
                                  const char *const *argv, int &i) {

lib/Support/LineIterator.cpp

 #include "llvm/Support/LineIterator.h"
 #include "llvm/Support/MemoryBuffer.h"
 
 using namespace llvm;
 
 static bool isAtLineEnd(const char *P) {
   if (*P == '\n')
     return true;
-  if (*P == '\r' && *(P + 1) == '\n')
-    return true;
-  return false;
+  return *P == '\r' && *(P + 1) == '\n';
 }
 
 static bool skipIfAtLineEnd(const char *&P) {
   if (*P == '\n') {
     ++P;
     return true;
   }
   if (*P == '\r' && *(P + 1) == '\n') {

lib/Support/YAMLParser.cpp

void Scanner::skip(uint32_t Distance) {
   Current += Distance;
   Column += Distance;
   assert(Current <= End && "Skipped past the end");
 }
 
 bool Scanner::isBlankOrBreak(StringRef::iterator Position) {
   if (Position == End)
     return false;
-  if (   *Position == ' ' || *Position == '\t'
-      || *Position == '\r' || *Position == '\n')
-    return true;
-  return false;
+  return *Position == ' ' || *Position == '\t'
+      || *Position == '\r' || *Position == '\n';
 }
 
 bool Scanner::consumeLineBreakIfPresent() {
   auto Next = skip_b_break(Current);
   if (Next == Current)
     return false;
   Column = 0;
   ++Line;