Page MenuHomePhabricator

[OpenMP51] Accept `primary` as proc bind affinity policy in Clang
ClosedPublic

Authored by cchen on Mar 30 2021, 3:03 PM.

Diff Detail

Event Timeline

cchen created this revision.Mar 30 2021, 3:03 PM
cchen requested review of this revision.Mar 30 2021, 3:03 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript

Could you add a small codegen test?

cchen updated this revision to Diff 334482.Mar 31 2021, 10:36 AM

Add some codegen tests

ABataev added inline comments.Mar 31 2021, 10:41 AM
clang/test/OpenMP/distribute_parallel_for_proc_bind_codegen.cpp
108–135 ↗(On Diff #334482)

Same, could you move it to a different file?

clang/test/OpenMP/nvptx_target_parallel_proc_bind_codegen.cpp
110–147 ↗(On Diff #334482)

Put this part in a separate file, please

cchen added inline comments.Mar 31 2021, 10:56 AM
clang/test/OpenMP/nvptx_target_parallel_proc_bind_codegen.cpp
110–147 ↗(On Diff #334482)

Do you mean I should put all the primary tests into a single file and don't do any changes to the existing proc_bind tests?

ABataev added inline comments.Mar 31 2021, 11:00 AM
clang/test/OpenMP/nvptx_target_parallel_proc_bind_codegen.cpp
110–147 ↗(On Diff #334482)

Yes, keep the original tests and add new ones.

cchen updated this revision to Diff 334720.Apr 1 2021, 8:55 AM

Update codegen test

This revision is now accepted and ready to land.Apr 1 2021, 8:59 AM
This revision was landed with ongoing or failed builds.Apr 1 2021, 4:13 PM
This revision was automatically updated to reflect the committed changes.