This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Fix incorrect DW_TAG_pointer_type size in test
ClosedPublic

Authored by arichardson on Mar 26 2021, 4:05 AM.

Details

Summary

It should be 64 bits not 32 for wasm64-unknown-unknown. I noticed this
because this test was failing in our CHERI fork of LLVM due to a larger
.debug_abbrev section size. It turns out this happens because we add
DW_AT_byte_size for non-default pointer sizes to allow debugging our
hybrid compilation mode where we can have two different kinds of pointers.

Diff Detail

Event Timeline

arichardson created this revision.Mar 26 2021, 4:05 AM
arichardson requested review of this revision.Mar 26 2021, 4:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2021, 4:05 AM
aardappel accepted this revision.Mar 26 2021, 11:02 AM

Thanks, that would make sense, since this test was probably adapted from the 32-bit version.

It doesn't seem to affect anything in the test output though, which is unfortunate?

This revision is now accepted and ready to land.Mar 26 2021, 11:02 AM

If you apply https://reviews.llvm.org/D99411, the current test will fail due to additional bytes in debug_abbrev.

If you apply https://reviews.llvm.org/D99411, the current test will fail due to additional bytes in debug_abbrev.

I see now that phabricator has tested that revision and even shows it as failing.