This is an archive of the discontinued LLVM Phabricator instance.

[test] Fix variable definition in acle_sve_ld1.sh
ClosedPublic

Authored by thopre on Mar 18 2021, 3:56 AM.

Details

Summary

Clang test acle_sve_ld1.sh is missing the colon in one of the string
variable definition separating the variable name from the regex. This
leads the substitution block to be parsed as a numeric variable use.

Diff Detail

Event Timeline

thopre created this revision.Mar 18 2021, 3:56 AM
thopre requested review of this revision.Mar 18 2021, 3:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2021, 3:56 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
sdesmalen accepted this revision.Mar 18 2021, 4:32 AM

LGTM, thanks for fixing!

I'm curious, how did you find this case? :)

This revision is now accepted and ready to land.Mar 18 2021, 4:32 AM

LGTM, thanks for fixing!

I'm curious, how did you find this case? :)

The issue was caught by a patch of mine to FileCheck: https://reviews.llvm.org/D98691

This revision was automatically updated to reflect the committed changes.