Inline callstacks were being incorrectly displayed in the results of "image lookup --address". The deepest frame wasn't displaying the line table line entry, it was always showing the inline information's call file and line on the previous frame. This is now fixed and has tests to make sure it doesn't regress.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Remove extra parameter call to SymbolContext::DumpStopContext() recrusive call that was left over from iterating on my patch.
If anyone wants to try this out, you can yaml2obj the yaml file and then do manual lookups. You can also debug any binary with inline function calls and stop anywhere and compare "bt" to the "image lookup --address $pc" to verify this works as expected.
I'm not that familiar with this function, but the output seems right. Given that the show_inline_callsite_line_info argument is no longer used, can you remove it?
lldb/source/Symbol/SymbolContext.cpp | ||
---|---|---|
133 | I'm not sure if describing the old behavior of deleted code is that helpful. This may be better off in the commit message. | |
lldb/test/Shell/Commands/command-image-lookup.yaml | ||
130 | Could we delete pub*, aranges, and apple_* sections? |
Remove show_inline_callsite_line_info setting from SymbolContext dumping function as it isn't needed, show_inlined_frames controls this.
clang-tidy: error: 'lldb/Symbol/SymbolContext.h' file not found [clang-diagnostic-error]
not useful