Page MenuHomePhabricator

[compiler-rt] Produce the right arch suffix for arm libraries
ClosedPublic

Authored by mstorsjo on Mar 11 2021, 1:57 PM.

Details

Summary

If producing libraries with an arch suffix (i.e. if
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR isn't set), we append the
architecture name. However, for arm, clang doesn't look for libraries
with the full architecture name, but only looks for "arm" and "armhf".

Try to deduce what the full target triple might have been, and use
that for deciding between "arm" and "armhf".

This tries to reapply this bit from D98173, that had to be reverted
in 7b153b43d3a14d76975039408c4b922beb576735 due to affecting how
the builtins themselves are compiled, not only affecting the output
file name.

Diff Detail

Event Timeline

mstorsjo created this revision.Mar 11 2021, 1:57 PM
mstorsjo requested review of this revision.Mar 11 2021, 1:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 11 2021, 1:57 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Ping @phosek @MaskRay - hopefully the dust has settled after the patches last week, so we could try out this one, if it looks good to you.

phosek accepted this revision.Mar 17 2021, 11:18 PM

LGTM

This revision is now accepted and ready to land.Mar 17 2021, 11:18 PM