Page MenuHomePhabricator

rprichard (Ryan Prichard)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 7 2017, 9:53 PM (256 w, 16 h)

Recent Activity

Thu, Jun 9

rprichard added a comment to D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo.

I uploaded D127465, weakening the test.

Thu, Jun 9, 6:58 PM · Restricted Project, Restricted Project
rprichard added reviewers for D127465: [CUDA] Ignore __CLANG_ATOMIC_LLONG_LOCK_FREE on i386: tra, yaxunl.

This change is needed to keep the clang/test/Preprocessor/cuda-types.cu test passing after D28213 changes the value of __CLANG_ATOMIC_LLONG_LOCK_FREE from 1 to 2 for i586 and up.

Thu, Jun 9, 6:56 PM · Restricted Project, Restricted Project
rprichard updated the summary of D127465: [CUDA] Ignore __CLANG_ATOMIC_LLONG_LOCK_FREE on i386.
Thu, Jun 9, 6:51 PM · Restricted Project, Restricted Project
rprichard requested review of D127465: [CUDA] Ignore __CLANG_ATOMIC_LLONG_LOCK_FREE on i386.
Thu, Jun 9, 6:50 PM · Restricted Project, Restricted Project
rprichard updated subscribers of D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo.

Ok, I can upload a patch omitting *_ATOMIC_LLONG_LOCK_FREE from the macro testing.

Thu, Jun 9, 6:46 PM · Restricted Project, Restricted Project
rprichard added a comment to D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo.

This patch is to fix an issue, right? At least we need a test to prevent that issue from happening again.

Thu, Jun 9, 2:40 PM · Restricted Project, Restricted Project

Wed, Jun 8

rprichard added a comment to D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo.

Aside: There are only two calls to AllocateTarget: one in TargetInfo::CreateTargetInfo and one in NVPTXTargetInfo::NVPTXTargetInfo. This change removes NVPTXTargetInfo's call.

Wed, Jun 8, 3:49 PM · Restricted Project, Restricted Project
rprichard added a comment to D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo.

I don't expect this change to affect the compiler behavior by itself -- is there a particular test that should be written?

Wed, Jun 8, 3:23 PM · Restricted Project, Restricted Project

Tue, Jun 7

rprichard added a comment to D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo.

This change is needed for D28213, so that the __GCC_ATOMIC_LLONG_LOCK_FREE macro matches for -target i386-unknown-linux-gnu between --cuda-host-only and --cuda-device-only. This is tested in clang/test/Preprocessor/cuda-types.cu.

Tue, Jun 7, 8:22 PM · Restricted Project, Restricted Project
rprichard added reviewers for D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo: yaxunl, rjmccall, mgorny.
Tue, Jun 7, 8:18 PM · Restricted Project, Restricted Project
rprichard updated the diff for D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin.

Rebase this revision.

Tue, Jun 7, 8:07 PM · Restricted Project, Restricted Project, Restricted Project
rprichard commandeered D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin.
Tue, Jun 7, 8:06 PM · Restricted Project, Restricted Project, Restricted Project
rprichard requested review of D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo.
Tue, Jun 7, 7:06 PM · Restricted Project, Restricted Project

May 26 2022

rprichard added a comment to D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin.

@mgorny Do you mind if I commandeer this Phabricator revision (and also D29542, which I would abandon in favor of D59566 which is already merged)? I need this CL to get libc++ tests passing on i686-linux after D119931 was submitted.

May 26 2022, 6:14 PM · Restricted Project, Restricted Project, Restricted Project

May 25 2022

rprichard accepted D126343: [libunwind] Use process_vm_readv to avoid potential segfaults.
May 25 2022, 10:01 PM · Restricted Project, Restricted Project, Restricted Project
rprichard accepted D126342: [libunwind] Factor out sigreturn check condition. NFC.
May 25 2022, 10:00 PM · Restricted Project, Restricted Project, Restricted Project
rprichard accepted D126342: [libunwind] Factor out sigreturn check condition. NFC.
May 25 2022, 9:10 PM · Restricted Project, Restricted Project, Restricted Project
rprichard accepted D126343: [libunwind] Use process_vm_readv to avoid potential segfaults.

The fix and the test both look good to me.

May 25 2022, 8:58 PM · Restricted Project, Restricted Project, Restricted Project

May 23 2022

Herald added a project to D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin: Restricted Project.
May 23 2022, 6:54 PM · Restricted Project, Restricted Project, Restricted Project
rprichard added a comment to D119931: [libcxx][atomic] Remove workaround for PR31864.

I'm seeing this test fail on 32-bit x86 Linux currently because __CLANG_ATOMIC_LLONG_LOCK_FREE is still 1.

May 23 2022, 6:53 PM · Restricted Project, Restricted Project
Herald added a project to D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used: Restricted Project.

Maybe this change is obsolete now that D59566 is merged?

May 23 2022, 6:51 PM · Restricted Project

May 2 2022

rprichard updated subscribers of D123428: [libunwind] Add configuration to disable sigreturn frame check.

https://github.com/abseil/abseil-cpp/blob/master/absl/debugging/internal/address_is_readable.cc has gone through several iterations. We can use rt_sigprocmask.

@rprichard, do you know if this would work for Android? It has the TOCTOU issue, but I imagine it's much simpler than having to manage and synchronize the pipe fd, and we could live with the TOCTOU in practice.

I'm glad @MaskRay found this -- I think it will probably work, and it seems better than assuming the PC is readable.

I see rt_procsigmask listed in bionic/libc/SYSCALLS.TXT, and I don't see it mentioned in any of the bionic/libc/SECCOMP*.txt files. I think that means seccomp is allowing the system call. I looked at kernel/signal.c, and AFAICT it's not doing any security checks that could be a problem. Bionic itself uses rt_sigprocmask for (at least) spawning new processes, creating/exiting threads, TLS-related locking, POSIX timers, and abort(). I think any seccomp-like blocking of rt_sigprocmask would have to be very targeted, so I think the syscall is probably allowed everywhere on Android.

It is assuming that the kernel will validate the address before validating the how. The kernel has a principle of not breaking userland -- is there a more specific guarantee we can rely on? e.g. The code has this comment:

// This strategy depends on Linux implementation details,
// so we rely on the test to alert us if it stops working.

The kernel source is structured as two wrappers around sigprocmask, SYSCALL_DEFINE4(rt_sigprocmask, ...) and COMPAT_SYSCALL_DEFINE4(rt_sigprocmask, ...). The wrappers copy user memory to/from kernel memory before calling sigprocmask, so it makes sense that they would validate the address first.

May 2 2022, 5:13 PM · Restricted Project, Restricted Project, Restricted Project

Apr 29 2022

rprichard added inline comments to D124522: [libunwind][AArch64] Fix _Unwind_ForcedUnwind via sigreturn..
Apr 29 2022, 3:51 PM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2022

rprichard added inline comments to D124522: [libunwind][AArch64] Fix _Unwind_ForcedUnwind via sigreturn..
Apr 28 2022, 4:15 PM · Restricted Project, Restricted Project, Restricted Project

Apr 26 2022

rprichard added a comment to D123428: [libunwind] Add configuration to disable sigreturn frame check.

https://github.com/abseil/abseil-cpp/blob/master/absl/debugging/internal/address_is_readable.cc has gone through several iterations. We can use rt_sigprocmask.

@rprichard, do you know if this would work for Android? It has the TOCTOU issue, but I imagine it's much simpler than having to manage and synchronize the pipe fd, and we could live with the TOCTOU in practice.

Apr 26 2022, 8:58 PM · Restricted Project, Restricted Project, Restricted Project

Apr 12 2022

rprichard added a comment to D122251: [lit] Use sharding for GoogleTest format.
  File "/x/llvm-upstream/llvm-project/libcxx/utils/libcxx/test/dsl.py", line 80, in _executeScriptInternal
    litConfig = lit.LitConfig.LitConfig(
TypeError: __init__() missing 1 required positional argument: 'order'

Fixed in 81b51b61f849fa91bdf5d069591

Apr 12 2022, 3:58 PM · Restricted Project, Restricted Project
rprichard updated subscribers of D122251: [lit] Use sharding for GoogleTest format.

I think this change broke libc++ tests. _executeScriptInternal in libcxx/utils/libcxx/test/dsl.py does not pass an argument for LitConfig's new order parameter:

Apr 12 2022, 3:37 PM · Restricted Project, Restricted Project

Apr 11 2022

rprichard added a comment to D123428: [libunwind] Add configuration to disable sigreturn frame check.

Using /proc/self/maps would be subject to TOCTOU, but I think most methods wouldn't, e.g.:

  • Open /proc/self/mem and pread() the address. This seems strictly better than /proc/self/maps?
  • Create a pipe using pipe(), write() the bytes into the pipe buffer and read() them back out. I believe a Linux pipe buffer is guaranteed to be big enough (>= 8 bytes).
  • process_vm_readv

I wonder if security configurations are a problem. Maybe I should experiment on an Android build.

With all those methods, there's still the chance (however unlikely) that the address is readable at the time of the check but somehow becomes unreadable by the time we perform the actual read, right? I doubt it matters much in practice though.

Apr 11 2022, 4:41 PM · Restricted Project, Restricted Project, Restricted Project
rprichard added a comment to D123428: [libunwind] Add configuration to disable sigreturn frame check.

... that's still subject to time-of-check-to-time-of-use issues

Apr 11 2022, 4:12 PM · Restricted Project, Restricted Project, Restricted Project

Apr 5 2022

rprichard accepted D122593: [libcxx] locale_bionic.h: skip ndk-version.h on Android platform.
Apr 5 2022, 5:21 PM · Restricted Project, Restricted Project

Mar 28 2022

rprichard added a comment to D122593: [libcxx] locale_bionic.h: skip ndk-version.h on Android platform.

Suggested issue title: [libcxx] locale_bionic.h: skip ndk-version.h on Android platform

Mar 28 2022, 1:00 PM · Restricted Project, Restricted Project

Mar 14 2022

rprichard committed rG659029302dfb: [ARM] __cxa_end_cleanup: avoid clobbering r4 (authored by rprichard).
[ARM] __cxa_end_cleanup: avoid clobbering r4
Mar 14 2022, 3:45 PM · Restricted Project
rprichard closed D121432: [ARM] __cxa_end_cleanup: avoid clobbering r4.
Mar 14 2022, 3:45 PM · Restricted Project, Restricted Project

Mar 10 2022

rprichard requested review of D121432: [ARM] __cxa_end_cleanup: avoid clobbering r4.
Mar 10 2022, 6:04 PM · Restricted Project, Restricted Project

Mar 4 2022

rprichard added inline comments to D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..
Mar 4 2022, 4:02 PM · Restricted Project, Restricted Project, Restricted Project
rprichard added inline comments to D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..
Mar 4 2022, 3:44 PM · Restricted Project, Restricted Project, Restricted Project

Mar 3 2022

Herald added a project to D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume.: Restricted Project.
Mar 3 2022, 5:17 PM · Restricted Project, Restricted Project, Restricted Project

Mar 2 2022

Herald added a project to D119381: [MTE] Add NT_ANDROID_TYPE_MEMTAG: Restricted Project.

Yeah, I'm OK with this change. (I'm not really familiar with the MTE stuff.)

Mar 2 2022, 3:37 PM · Restricted Project, Restricted Project

Dec 7 2021

rprichard accepted D110720: Verify inferattrs doesn't infer unexpected attributes.

The lines where CHECK is split into CHECK-LINUX and CHECK-NOLINUX are also enabling the test for nvptx.

It's true that the nvptx case is now checking more than it used to, but not everything; making it check everything could probably be done, but is it worthwhile? I experimented with passing CHECK to the nvptx case, and it doesn't pass; there would have to be a CHECK-NVPTX line paralleling each CHECK: line, pretty much. Seems like a lot of effort, but is nvptx really that special?
I'll do it if someone says Yes, it's worth the trouble; but unless someone can say that, I'd rather not.

Dec 7 2021, 9:39 PM · Restricted Project

Dec 6 2021

rprichard added a comment to D114523: [compiler-rt][AArch64] Add a workaround for Exynos 9810.

... but it seems much easier to put the -fno-outline-atomics flag into the linker's .bp file instead of changing the behavior of __system_property_get.

Dec 6 2021, 2:25 PM · Restricted Project, Restricted Project, Restricted Project

Dec 1 2021

rprichard added a comment to D114523: [compiler-rt][AArch64] Add a workaround for Exynos 9810.

From what I understand, for dynamic executables, si->call_constructors() [1] calls the constructor of each loaded shared object. Right?

I put the LD_DEBUG=2 environment variable and found that libc.so's constructor is called before the main executable or any other shared object's constructor. And libc.so calls __libc_preinit_impl -> __libc_init_common -> __system_properties_init.
So the point is that __system_properties_init is initialized before this compiler-rt code is called. But I don't know if this is guaranteed behavior.

Of course, I think this code should work fine even if __system_properties_init is not yet called.

[1] https://cs.android.com/android/platform/superproject/+/9aafec59ccad4b3851269e4119561efd8a2f5e65:bionic/linker/linker_main.cpp;l=508

Dec 1 2021, 10:16 PM · Restricted Project, Restricted Project, Restricted Project

Nov 29 2021

rprichard added a comment to D114523: [compiler-rt][AArch64] Add a workaround for Exynos 9810.

Also: is it OK to use a mix of LSE and non-LSE atomic operations to access the same memory concurrently? I would think that should be fine, but it seems worth mentioning.

Nov 29 2021, 9:12 PM · Restricted Project, Restricted Project, Restricted Project
rprichard added a comment to D114523: [compiler-rt][AArch64] Add a workaround for Exynos 9810.

I noticed that using __system_property_get from a constructor function probably doesn't work within the Bionic loader (linker[64]), but maybe Bionic ought to be fixed (and it shouldn't matter much in practice):

  • The Bionic dynamic loader calls the constructor functions before calling __system_properties_init. (see tmp_linker_so.call_constructors();)
  • However, a static executable calls __system_properties_init before the constructors, so static executables should be OK.
  • Maybe the dynamic loader ought to call __system_properties_init before constructors.
  • Calling __system_property_get before __system_properties_init is probably OK? It looks like SystemProperties::Find would return nullptr, and __system_property_get would return 0.
  • In any case, it wouldn't actually matter unless someone ran a new loader on an affected device+kernel.
Nov 29 2021, 4:05 PM · Restricted Project, Restricted Project, Restricted Project

Nov 5 2021

rprichard added a comment to D111358: TargetLibraryInfo checker tool.

The motivating issue happened with Android (D107509).

Nov 5 2021, 12:17 AM · Restricted Project
rprichard updated subscribers of D111358: TargetLibraryInfo checker tool.

Adding some Android folks to the subscriber list.

Nov 5 2021, 12:11 AM · Restricted Project

Sep 29 2021

rprichard added a comment to D110720: Verify inferattrs doesn't infer unexpected attributes.

The dereferenceable.ll and dereferenceable-inseltpoison.ll files are also confusing to me. It *sounds* like they're trying to test inferred attributes, but its CHECK* lines would allow any or no attributes on the functions, so it's not actually testing anything attribute-related.

Sep 29 2021, 7:00 PM · Restricted Project

Aug 5 2021

rprichard committed rGdaab81cda18a: Replace "CHECK-NOT: #{{.*}}" with same-line positive checks. NFC. (authored by rprichard).
Replace "CHECK-NOT: #{{.*}}" with same-line positive checks. NFC.
Aug 5 2021, 9:56 PM
rprichard closed D107614: Replace "CHECK-NOT: #{{.*}}" with same-line positive checks. NFC..
Aug 5 2021, 9:55 PM · Restricted Project
rprichard added inline comments to D107614: Replace "CHECK-NOT: #{{.*}}" with same-line positive checks. NFC..
Aug 5 2021, 5:28 PM · Restricted Project
rprichard added reviewers for D107614: Replace "CHECK-NOT: #{{.*}}" with same-line positive checks. NFC.: MaskRay, efriedma.

Follow up from D107527 review.

Aug 5 2021, 5:24 PM · Restricted Project
rprichard requested review of D107614: Replace "CHECK-NOT: #{{.*}}" with same-line positive checks. NFC..
Aug 5 2021, 5:22 PM · Restricted Project
rprichard committed rG623cf3dfdf3e: Mark getc_unlocked as unavailable by default (authored by rprichard).
Mark getc_unlocked as unavailable by default
Aug 5 2021, 4:36 PM
rprichard closed D107527: Mark getc_unlocked as unavailable by default.
Aug 5 2021, 4:36 PM · Restricted Project
rprichard added inline comments to D107527: Mark getc_unlocked as unavailable by default.
Aug 5 2021, 4:32 PM · Restricted Project

Aug 4 2021

rprichard added reviewers for D107527: Mark getc_unlocked as unavailable by default: xbolva00, MaskRay, efriedma, echristo.

I noticed this inconsistency while reviewing D107509.

Aug 4 2021, 8:36 PM · Restricted Project
rprichard updated the diff for D107527: Mark getc_unlocked as unavailable by default.

Update test.

Aug 4 2021, 8:26 PM · Restricted Project
rprichard requested review of D107527: Mark getc_unlocked as unavailable by default.
Aug 4 2021, 8:13 PM · Restricted Project
rprichard accepted D107509: Disable LibFuncs for stpcpy and stpncpy for Android < 21.

Yes, Android did add stpcpy and stpncpy in API 21:
https://android.googlesource.com/platform/bionic/+/refs/heads/android11-dev/libc/libc.map.txt

Aug 4 2021, 6:29 PM · Restricted Project

Jul 30 2021

rprichard added a comment to D107127: [builtins] Try to ensure single copy of emulated TLS state.

It resolves everything to the first definition in the lookup order. The only special handling of weak symbols that I've found is that missing definition is not an error.

Jul 30 2021, 3:37 PM · Restricted Project
rprichard added a comment to D107127: [builtins] Try to ensure single copy of emulated TLS state.

Weak symbol is a purely link-time concept, AFAIK. It is ignored in the dynamic loader, so, unless we link multiple copies of this file into the same DSO, "weak" attribute here should not have any effect.

Jul 30 2021, 2:27 PM · Restricted Project
rprichard accepted D107127: [builtins] Try to ensure single copy of emulated TLS state.

Yeah, this looks fine to me.

Jul 30 2021, 2:02 PM · Restricted Project

May 27 2021

rprichard committed rGb834d6309455: [sanitizer] Android ELF TLS is supported from Q (API 29) (authored by rprichard).
[sanitizer] Android ELF TLS is supported from Q (API 29)
May 27 2021, 2:54 PM
rprichard closed D103214: [sanitizer] Android ELF TLS is supported from Q (API 29).
May 27 2021, 2:54 PM · Restricted Project

May 26 2021

rprichard added reviewers for D103214: [sanitizer] Android ELF TLS is supported from Q (API 29): oontvoo, vitalybuka.
May 26 2021, 4:40 PM · Restricted Project
rprichard updated the diff for D103214: [sanitizer] Android ELF TLS is supported from Q (API 29).

Update another place.

May 26 2021, 4:39 PM · Restricted Project
rprichard requested review of D103214: [sanitizer] Android ELF TLS is supported from Q (API 29).
May 26 2021, 4:38 PM · Restricted Project

May 19 2021

rprichard committed rG65d0264ba2e5: [MC][ARM] Reject Thumb "ror rX, #0" (authored by rprichard).
[MC][ARM] Reject Thumb "ror rX, #0"
May 19 2021, 3:06 PM
rprichard closed D102455: [MC][ARM] Reject Thumb "ror rX, #0".
May 19 2021, 3:05 PM · Restricted Project

May 13 2021

rprichard added reviewers for D102455: [MC][ARM] Reject Thumb "ror rX, #0": nickdesaulniers, kristof.beyls, srhines.
May 13 2021, 5:33 PM · Restricted Project
rprichard requested review of D102455: [MC][ARM] Reject Thumb "ror rX, #0".
May 13 2021, 5:30 PM · Restricted Project

Apr 9 2021

rprichard added a comment to D91841: [builtins] Define fmax and scalbn inline.

error: [FE_UPWARD] in __compiler_rt_scalbn(-0x1p+0 [BFF0000000000000], 10000) = -0x1.fffffffffffffp+1023 [FFEFFFFFFFFFFFFF] != -inf [FFF0000000000000]

Apr 9 2021, 5:17 PM · Restricted Project

Mar 22 2021

rprichard added a comment to D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt.

It is actually using clang-r416183 from toolchains.py. From there, you can go to the manifest for building those prebuilts. This line shows you the SHA for the toolchain/llvm-project used to build the prebuilts. Finally, you can look here to see what was merged. Note that there's a typo for the revision number in the commit message, but the upstream LLVM SHA mentioned there is correct. Here is where this toolchain was built in case that is useful/interesting.

Mar 22 2021, 1:03 PM · Restricted Project

Mar 19 2021

rprichard added a comment to D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt.

With NDK r22, I only see libunwind.a for armv7. Will it be provided for other architectures in future NDK versions?

Mar 19 2021, 5:07 PM · Restricted Project

Mar 9 2021

rprichard committed rGa478b0a199f4: [Android] Default to --rtlib=compiler-rt (authored by rprichard).
[Android] Default to --rtlib=compiler-rt
Mar 9 2021, 6:38 PM
rprichard closed D96404: [Android] Default to --rtlib=compiler-rt.
Mar 9 2021, 6:38 PM · Restricted Project
rprichard updated the diff for D96404: [Android] Default to --rtlib=compiler-rt.

Rebase this revision.

Mar 9 2021, 2:53 PM · Restricted Project
rprichard added a comment to D98173: [compiler-rt] Normalize i?86 to i386 and armv* to arm for COMPILER_RT_DEFAULT_TARGET_ARCH.

I think this is OK for Android.

Mar 9 2021, 12:42 AM · Restricted Project

Feb 26 2021

rprichard added a reverting change for rG680f836c2fa7: Revert "[builtins] Define fmax and scalbn inline": rGd20220141022: Reland "[builtins] Define fmax and scalbn inline".
Feb 26 2021, 4:22 PM
rprichard committed rGd20220141022: Reland "[builtins] Define fmax and scalbn inline" (authored by rprichard).
Reland "[builtins] Define fmax and scalbn inline"
Feb 26 2021, 4:22 PM
rprichard closed D91841: [builtins] Define fmax and scalbn inline.
Feb 26 2021, 4:22 PM · Restricted Project
rprichard added a comment to D91841: [builtins] Define fmax and scalbn inline.

MSVC's scalbn appears to ignore the current rounding mode, so the value returned from __compiler_rt_scalbn[f] disagreed with the value returned from scalbn[f]. I think it's sufficient to disable the non-default-rounding-mode tests for MSVC. With this change, the __divdc3 and __divsc3 builtins, when compiled with MSVC, should produce the same results as on Linux systems (or as with MinGW and the other Unix systems I tested).

Feb 26 2021, 4:59 AM · Restricted Project
rprichard updated the diff for D91841: [builtins] Define fmax and scalbn inline.

Disable non-default-rounding-mode scalbn[f] tests when using the MSVC libraries.

Feb 26 2021, 4:27 AM · Restricted Project
rprichard reopened D91841: [builtins] Define fmax and scalbn inline.
Feb 26 2021, 4:26 AM · Restricted Project

Feb 25 2021

rprichard committed rG91f8aacc040f: [Android] Use -l:libunwind.a with --rtlib=compiler-rt (authored by rprichard).
[Android] Use -l:libunwind.a with --rtlib=compiler-rt
Feb 25 2021, 3:40 PM
rprichard closed D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt.
Feb 25 2021, 3:40 PM · Restricted Project
rprichard retitled D97356: [sanitizer] Pass -e dotbytes=10m to wget from [sanitizer] Pass -e dotbytes=1m to wget to [sanitizer] Pass -e dotbytes=10m to wget.
Feb 25 2021, 1:53 PM
rprichard committed rZORG1a9f4798fee2: [sanitizer] Pass -e dotbytes=10m to wget (authored by rprichard).
[sanitizer] Pass -e dotbytes=10m to wget
Feb 25 2021, 1:52 PM
rprichard closed D97356: [sanitizer] Pass -e dotbytes=10m to wget.
Feb 25 2021, 1:52 PM
rprichard committed rZORG0477d926afac: [sanitizer] Update x86 ABILIST filtering for x86_64 devices (authored by rprichard).
[sanitizer] Update x86 ABILIST filtering for x86_64 devices
Feb 25 2021, 1:52 PM
rprichard closed D97355: [sanitizer] Update x86 ABILIST filtering for x86_64 devices.
Feb 25 2021, 1:52 PM
rprichard committed rZORG1e7891e19f50: [sanitizer] Set default rtlib to libgcc (authored by rprichard).
[sanitizer] Set default rtlib to libgcc
Feb 25 2021, 1:52 PM
rprichard closed D97354: [sanitizer] Set default rtlib to libgcc.
Feb 25 2021, 1:52 PM

Feb 24 2021

rprichard added a comment to D97356: [sanitizer] Pass -e dotbytes=10m to wget.

This happens only once after clean build, so it did not annoy us, but I don't mind for even bigger value e.g. 10m

Feb 24 2021, 5:10 PM
rprichard updated subscribers of D91841: [builtins] Define fmax and scalbn inline.

The new unit tests failed on sanitizer-windows. I reverted it for now. https://lab.llvm.org/buildbot/#builders/127/builds/6620

Feb 24 2021, 2:51 PM · Restricted Project
rprichard added a reverting change for rG341889ee9e03: [builtins] Define fmax and scalbn inline: rG680f836c2fa7: Revert "[builtins] Define fmax and scalbn inline".
Feb 24 2021, 2:49 PM
rprichard added a reverting change for D91841: [builtins] Define fmax and scalbn inline: rG680f836c2fa7: Revert "[builtins] Define fmax and scalbn inline".
Feb 24 2021, 2:49 PM · Restricted Project
rprichard committed rG680f836c2fa7: Revert "[builtins] Define fmax and scalbn inline" (authored by rprichard).
Revert "[builtins] Define fmax and scalbn inline"
Feb 24 2021, 2:49 PM
rprichard committed rG341889ee9e03: [builtins] Define fmax and scalbn inline (authored by rprichard).
[builtins] Define fmax and scalbn inline
Feb 24 2021, 2:33 PM
rprichard closed D91841: [builtins] Define fmax and scalbn inline.
Feb 24 2021, 2:33 PM · Restricted Project
rprichard updated the summary of D97355: [sanitizer] Update x86 ABILIST filtering for x86_64 devices.
Feb 24 2021, 2:24 AM