Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

rprichard (Ryan Prichard)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 7 2017, 9:53 PM (330 w, 2 d)

Recent Activity

Oct 19 2023

rprichard added a comment to D139147: [libc++][Android] Enable libc++ testing on Android.

Moved to GitHub:

Oct 19 2023, 9:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard added a comment to D155271: [libc++][Android] Add Android support to CI Docker image.

Moved to GitHub, https://github.com/llvm/llvm-project/pull/69273.

Oct 19 2023, 8:59 PM · Restricted Project, Restricted Project
rprichard abandoned D155341: [libc++][Android] Add NDK ABI lists for i686 and x86_64.

Abandoned in favor of GitHub PR, https://github.com/llvm/llvm-project/pull/69272.

Oct 19 2023, 8:57 PM · Restricted Project, Restricted Project

Oct 10 2023

rprichard added inline comments to D139147: [libc++][Android] Enable libc++ testing on Android.
Oct 10 2023, 2:12 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Cache the LIBCXX_ABI_VERSION variable in AndroidNDK.cmake.

Oct 10 2023, 2:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard added a comment to D139147: [libc++][Android] Enable libc++ testing on Android.

I can switch this review to a GitHub PR if needed.

Oct 10 2023, 1:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Use stdin=subprocess.DEVNULL for adb_run.py subprocesses, except for the main adb shell invocation where we want to forward stdin. This change was necessary to fix stdin forwarding on a Pixel 6 (oriole) device. (However, the API 33 emulator tests passed even without this change. Not sure why.)

Oct 10 2023, 1:30 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Rebase.

Oct 10 2023, 12:21 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the diff for D155341: [libc++][Android] Add NDK ABI lists for i686 and x86_64.

Rebase. Remove _ZNSt3__16locale2id6__initEv.

Oct 10 2023, 12:21 AM · Restricted Project, Restricted Project
rprichard updated the diff for D155271: [libc++][Android] Add Android support to CI Docker image.

Rebase.

Oct 10 2023, 12:20 AM · Restricted Project, Restricted Project

Sep 15 2023

rprichard added a comment to D159292: [driver] Conditionally include installed libc++ headers for Android.

Ping.

Sep 15 2023, 3:42 PM · Restricted Project, Restricted Project

Sep 12 2023

rprichard updated subscribers of D158930: [libc++][print] Fixes error reporting..
Sep 12 2023, 5:11 PM · Restricted Project, Restricted Project

Aug 31 2023

rprichard added a comment to D159292: [driver] Conditionally include installed libc++ headers for Android.

This change looks like an improvement to me. The NDK currently puts the libc++ headers into the sysroot, but putting it in the usual toolchain include location seems better.

Aug 31 2023, 1:02 PM · Restricted Project, Restricted Project

Aug 28 2023

rprichard added inline comments to D158641: [AArch64] Fix FMV ifunc resolver usage on old Android APIs. Rename internal compiler-rt FMV functions..
Aug 28 2023, 3:09 PM · Restricted Project, Restricted Project, Restricted Project

Aug 23 2023

rprichard added a comment to D158641: [AArch64] Fix FMV ifunc resolver usage on old Android APIs. Rename internal compiler-rt FMV functions..

further confirmation if android_get_device_api_level should work from ifunc_resolver

Aug 23 2023, 2:32 PM · Restricted Project, Restricted Project, Restricted Project

Aug 17 2023

rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

The last rebase accounted for about a month's worth of changes in LLVM. Fix the Android tests that were broken by the rebase:

Aug 17 2023, 11:52 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard added inline comments to D150044: [libc++][print] Adds FILE functions..
Aug 17 2023, 4:27 PM · Restricted Project, Restricted Project
rprichard updated the diff for D155271: [libc++][Android] Add Android support to CI Docker image.

Rebase.

Aug 17 2023, 12:40 PM · Restricted Project, Restricted Project

Aug 16 2023

rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Rebase.

Aug 16 2023, 9:06 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the diff for D155341: [libc++][Android] Add NDK ABI lists for i686 and x86_64.

Rebase.

Aug 16 2023, 9:00 PM · Restricted Project, Restricted Project
rprichard updated the diff for D155271: [libc++][Android] Add Android support to CI Docker image.

Restore the buildkite-agent.cfg setting. I confirmed that the tags from this config file can be overridden using the BUILDKITE_AGENT_TAGS environment variable.

Aug 16 2023, 8:26 PM · Restricted Project, Restricted Project

Aug 15 2023

rprichard added inline comments to D139147: [libc++][Android] Enable libc++ testing on Android.
Aug 15 2023, 10:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the summary of D139147: [libc++][Android] Enable libc++ testing on Android.
Aug 15 2023, 10:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Address review comments.

Aug 15 2023, 10:57 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the summary of D155271: [libc++][Android] Add Android support to CI Docker image.
Aug 15 2023, 10:56 PM · Restricted Project, Restricted Project
rprichard updated the diff for D155271: [libc++][Android] Add Android support to CI Docker image.

Add the Android team's current Clang build to the libcxx-builder Dockerfile.

Aug 15 2023, 10:56 PM · Restricted Project, Restricted Project

Aug 14 2023

rprichard updated the summary of D139147: [libc++][Android] Enable libc++ testing on Android.
Aug 14 2023, 3:12 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Disable flaky notify_one.pass.cpp test for Android, and remove the unnecessary adb socat workaround now that adb -a start-server works.

Aug 14 2023, 3:07 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard added a comment to D139147: [libc++][Android] Enable libc++ testing on Android.

Mark some of the comments as Done.

Aug 14 2023, 1:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Address some of the review comments.

Aug 14 2023, 1:49 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 23 2023

rprichard added inline comments to D155271: [libc++][Android] Add Android support to CI Docker image.
Jul 23 2023, 9:39 PM · Restricted Project, Restricted Project

Jul 22 2023

rprichard added inline comments to D155271: [libc++][Android] Add Android support to CI Docker image.
Jul 22 2023, 2:34 PM · Restricted Project, Restricted Project

Jul 19 2023

rprichard updated subscribers of D139147: [libc++][Android] Enable libc++ testing on Android.
Jul 19 2023, 4:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 17 2023

rprichard updated the summary of D155516: [libc++][Android] Squash Android patches into one for CI testing.
Jul 17 2023, 2:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard requested review of D155516: [libc++][Android] Squash Android patches into one for CI testing.
Jul 17 2023, 2:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Now that D155271 and D155341 are parent revisions of this revision, remove their edits from this revision. I expect this change to break the Android testing because the Android abilist files will be missing.

Jul 17 2023, 2:17 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 14 2023

rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Fix indentation in libcxx/test/support/filesystem_test_helper.h to make git-clang-format happy.

Jul 14 2023, 3:37 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard added a comment to D139147: [libc++][Android] Enable libc++ testing on Android.

I copied the two ABI lists into D155341. I think this patch is ready for review now.

Jul 14 2023, 3:12 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard added a comment to D155341: [libc++][Android] Add NDK ABI lists for i686 and x86_64.

These files are a part of D139147.

Jul 14 2023, 3:12 PM · Restricted Project, Restricted Project
rprichard requested review of D155341: [libc++][Android] Add NDK ABI lists for i686 and x86_64.
Jul 14 2023, 3:08 PM · Restricted Project, Restricted Project
rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

utils/adb_run.py: Print syncing command lines with -v.

Jul 14 2023, 1:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

In _job_limit_socket_thread, discard the address returned from accept.

Jul 14 2023, 1:33 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard added a comment to D155271: [libc++][Android] Add Android support to CI Docker image.

This change was copied from the larger D139147 change.

Jul 14 2023, 1:28 AM · Restricted Project, Restricted Project
rprichard added inline comments to D155271: [libc++][Android] Add Android support to CI Docker image.
Jul 14 2023, 1:27 AM · Restricted Project, Restricted Project
rprichard added a comment to D139147: [libc++][Android] Enable libc++ testing on Android.

I split off duplicated the Dockerfile changes to D155271.

Jul 14 2023, 1:24 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard added a reviewer for D155271: [libc++][Android] Add Android support to CI Docker image: EricWF.
Jul 14 2023, 1:24 AM · Restricted Project, Restricted Project
rprichard requested review of D155271: [libc++][Android] Add Android support to CI Docker image.
Jul 14 2023, 1:23 AM · Restricted Project, Restricted Project
rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

rebase

Jul 14 2023, 1:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the summary of D139147: [libc++][Android] Enable libc++ testing on Android.
Jul 14 2023, 12:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Switch adb_run's job limiting from POSIX semaphore to a Unix domain socket. Instead of needing a SIGINT handler in adb_run.py to release the semaphore, we can instead rely on the OS to close the socket connection.

Jul 14 2023, 12:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 8 2023

rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Run 'docker info' before 'docker image inspect ...' to make sure that Docker is working.

Jul 8 2023, 3:24 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the summary of D139147: [libc++][Android] Enable libc++ testing on Android.
Jul 8 2023, 1:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Switch Android testing to using the existing copies of Clang in ldionne/libcxx-builder. Add a recent Android sysroot and the platform-tools (e.g. adb) to libcxx-builder. Start an Android emulator in a sibling container to the libcxx-builder container. Use one Docker image per emulator OS image.

Jul 8 2023, 1:09 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 20 2023

rprichard added a comment to D139147: [libc++][Android] Enable libc++ testing on Android.

The patch is quite large. I think it would be better to land it in smaller parts, preferable after we see these changes have a green Android CI.

Sure, I can split parts of it off. I think the XFAIL additions and the libcxx/lib/abi* files are a good place to start.

The ABI could remain, but I would like to see the XFAIL annotations and the Dockerfile changes in two separate commits.

Jun 20 2023, 4:21 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 12 2023

rprichard committed rG1da06804e1a4: [libc++] Android temp dir is /data/local/tmp, enable Windows test (authored by rprichard).
[libc++] Android temp dir is /data/local/tmp, enable Windows test
Jun 12 2023, 8:44 PM · Restricted Project, Restricted Project
rprichard closed D137131: [libc++] Android temp dir is /data/local/tmp, enable Windows test.
Jun 12 2023, 8:44 PM · Restricted Project, Restricted Project
rprichard added a comment to D139147: [libc++][Android] Enable libc++ testing on Android.

The patch is quite large. I think it would be better to land it in smaller parts, preferable after we see these changes have a green Android CI.

Jun 12 2023, 8:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the summary of D139147: [libc++][Android] Enable libc++ testing on Android.
Jun 12 2023, 2:50 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Switch the Android run-buildbot-container from --device /dev/kvm back to --privileged, but add an option to switch it back to --device /dev/kvm.

Jun 12 2023, 2:48 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 11 2023

rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Rebase the commit.

Jun 11 2023, 11:34 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard added a comment to D139147: [libc++][Android] Enable libc++ testing on Android.

[...]

I'm not discouraged reviewing this, especially since it adds CI support. But several of us work as volunteer which means we have limited time to work on libc++.

For the way forward, I've a question. What is the intention regarding running the CI?

Are you going to host it yourself like AIX/FreeBSD do or is it the intention the run on our existing Linux runners?

Jun 11 2023, 10:56 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 7 2023

rprichard updated the summary of D137131: [libc++] Android temp dir is /data/local/tmp, enable Windows test.
Jun 7 2023, 4:30 PM · Restricted Project, Restricted Project

Jun 5 2023

rprichard updated subscribers of D137131: [libc++] Android temp dir is /data/local/tmp, enable Windows test.

Android apps aren't generally allowed to access /data/local/tmp, but they are able to access the app-specific cache dir. (/data/data/${APP_ID}/cache or /data/user/0/$APP_ID}/cache). New-enough versions of Android set TMPDIR to this cache dir for apps. I wonder if it'd make sense for libc++ to use the app cache as fallback for std::filesystem::temp_directory_path(), when running in an app context (app UID?). I suspect the answer is "no", because it's not feasible to determine the path to the app cache. Not sure though.

Jun 5 2023, 10:19 PM · Restricted Project, Restricted Project
rprichard updated the diff for D137131: [libc++] Android temp dir is /data/local/tmp, enable Windows test.

Rebase this commit.

Jun 5 2023, 8:26 PM · Restricted Project, Restricted Project

Jun 1 2023

rprichard added a comment to D139147: [libc++][Android] Enable libc++ testing on Android.

I was wondering whether I can land this patch adding Android testing to buildkite-pipeline.yml while the Android libc++ tests are still failing, or if the buildbot isn't set up yet. e.g. I wouldn't want non-Android-related LLVM patches to be affected. (Maybe I should land all the Android-related work first, and only then add the entry to the yml file.)

I think the way to go is marking all the failing tests as XFAIL and go from there. This avoids regressions and makes it easier to verify that a patch actually does what it claims to do.

These are the currently-failing tests with just this patch, https://gist.github.com/rprichard/4a8e9b160e7adc472778699c62ae1fff.

I can mark these tests as XFAIL. Would I do that in this patch or could I do that in an earlier commit?

Jun 1 2023, 12:23 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 31 2023

rprichard added a comment to D139147: [libc++][Android] Enable libc++ testing on Android.

I was wondering whether I can land this patch adding Android testing to buildkite-pipeline.yml while the Android libc++ tests are still failing, or if the buildbot isn't set up yet. e.g. I wouldn't want non-Android-related LLVM patches to be affected. (Maybe I should land all the Android-related work first, and only then add the entry to the yml file.)

I think the way to go is marking all the failing tests as XFAIL and go from there. This avoids regressions and makes it easier to verify that a patch actually does what it claims to do.

May 31 2023, 10:38 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard added a comment to D140183: [libc++][Android] Disable test_no_resolve_symlink_on_symlink on Android.

I reported a kernel bug related to this issue, https://bugzilla.kernel.org/show_bug.cgi?id=216834.

May 31 2023, 10:10 PM · Restricted Project, Restricted Project
rprichard added a comment to D139147: [libc++][Android] Enable libc++ testing on Android.

I was wondering whether I can land this patch adding Android testing to buildkite-pipeline.yml while the Android libc++ tests are still failing, or if the buildbot isn't set up yet. e.g. I wouldn't want non-Android-related LLVM patches to be affected. (Maybe I should land all the Android-related work first, and only then add the entry to the yml file.)

May 31 2023, 7:45 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 30 2023

rprichard retitled D139497: [libc++][Android] Adjust FP conversion tests for Bionic from [libc++][Android] Bionic also includes + for NAN to [libc++][Android] Adjust FP conversion tests for Bionic.
May 30 2023, 5:45 PM · Restricted Project, Restricted Project
rprichard updated the diff for D139497: [libc++][Android] Adjust FP conversion tests for Bionic.

Add a comment explaning why we don't just check __ANDROID_API__.

May 30 2023, 5:44 PM · Restricted Project, Restricted Project
rprichard retitled D139147: [libc++][Android] Enable libc++ testing on Android from [libc++][Android] Enable libc++ testing using adb on an x86-64 emulator to [libc++][Android] Enable libc++ testing on Android.
May 30 2023, 5:31 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard added a comment to D139147: [libc++][Android] Enable libc++ testing on Android.

I still haven't added anything to libcxx/utils/ci/buildkite-pipeline.yml. It's not clear to me whether that should be part of this patch, because there are several things that must happen first before CI tests will work:

  • I need to create a new docker image to add the Android stuff to it, and host it somewhere.
  • I need to setup a special buildbot on a VM somewhere that uses the new docker image.
  • There are a bunch of patches I have uploaded to Phabricator currently that are required to get tests running cleanly.
  • There are a few other fixes for tests that I don't have uploaded, because I'm not quite sure what we want to do (need to disable certain filesystem tests, and there are a couple of demangler problems involving floating-point).
May 30 2023, 5:30 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Various updates:

  • Use the std::__ndk1 namespace to match how the NDK libc++ is built.
  • Use a POSIX semaphore to limit concurrent adb jobs (libcxx/utils/semaphore_tool.py, --job-limit-semaphore) more than host jobs are limited.
  • Define android and LIBCXX-ANDROID-FIXME features in features.py.
  • Add a android_libcxx_kind={ndk,platform} param to libcxx[abi]/test/configs/llvm-libc++[abi]-android.cfg.in, which allows for testing either the NDK build of libc++ or the platform (/system/lib[64]/libc++.so) build of libc++ for Android.
May 30 2023, 5:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 10 2023

rprichard accepted D147849: [Android] Use ELF TLS for Android API level 29+.
Apr 10 2023, 3:50 PM · Restricted Project, Restricted Project
rprichard added a comment to D147849: [Android] Use ELF TLS for Android API level 29+.

One issue I noticed earlier was that the compiler flag (-f[no-]emulated-tls) doesn't work with LTO:

  • The flag is ignored when the compiler is only outputting LLVM IR, and
  • The flag is also ignored at link-time when the IR is converted to emutls-or-efltls machine code.

This link-time LTO setting can be changed using -Wl,-plugin-opt,-emulated-tls={0,1}.

does https://reviews.llvm.org/D147834 fix this?

Apr 10 2023, 3:48 PM · Restricted Project, Restricted Project
rprichard added a comment to D147849: [Android] Use ELF TLS for Android API level 29+.

nit: In the description/commit message, the "when the API level is > 29" should be "when the API level is >= 29".

Apr 10 2023, 2:32 PM · Restricted Project, Restricted Project

Jan 10 2023

rprichard added a comment to D141184: [libc++] Fix aligned_alloc usage for Android.

LGTM assuming D139147 is being worked on.

I'm not involved with that effort directly (I work on Meta's Android compiler team, whereas @rprichard is on the Android NDK team at Google), but I understand wanting a buildbot to test this configuration. I can't speak on his behalf, but I trust that Ryan will work on that actively once holiday season is wrapped up.

Jan 10 2023, 11:26 AM · Restricted Project, Restricted Project

Dec 21 2022

rprichard requested review of D137131: [libc++] Android temp dir is /data/local/tmp, enable Windows test.
Dec 21 2022, 2:14 PM · Restricted Project, Restricted Project

Dec 20 2022

rprichard added a comment to D140183: [libc++][Android] Disable test_no_resolve_symlink_on_symlink on Android.

Would it be better to instead XFAIL it using Lit machinery? Right now you're disabling the test even when it would succeed, which means you're losing that coverage.

I'm fine with the patch, but I think you may want to do something less drastic to retain coverage on your platform.

Dec 20 2022, 9:29 PM · Restricted Project, Restricted Project
rprichard added a comment to D137131: [libc++] Android temp dir is /data/local/tmp, enable Windows test.

Requesting changes for the queue. Is this ready to be re-reviewed?

Dec 20 2022, 5:38 PM · Restricted Project, Restricted Project

Dec 19 2022

rprichard added a comment to D140183: [libc++][Android] Disable test_no_resolve_symlink_on_symlink on Android.

Looks good from libc++'s point of view. I really like @danalbert review to see whether the comments are correct.

Dec 19 2022, 3:19 PM · Restricted Project, Restricted Project

Dec 15 2022

rprichard requested review of D140183: [libc++][Android] Disable test_no_resolve_symlink_on_symlink on Android.
Dec 15 2022, 6:21 PM · Restricted Project, Restricted Project

Dec 12 2022

rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Reword a comment.

Dec 12 2022, 5:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard added inline comments to D139497: [libc++][Android] Adjust FP conversion tests for Bionic.
Dec 12 2022, 4:07 PM · Restricted Project, Restricted Project

Dec 9 2022

rprichard committed rG106a99276f9e: [Headers][ARM] Allow `struct _Unwind_Exception` in unwind.h (authored by rprichard).
[Headers][ARM] Allow `struct _Unwind_Exception` in unwind.h
Dec 9 2022, 3:17 PM · Restricted Project, Restricted Project
rprichard committed rG5df7b45ae4b5: [libc++][Android] Disable pbump2gig for Android (authored by rprichard).
[libc++][Android] Disable pbump2gig for Android
Dec 9 2022, 3:16 PM · Restricted Project, Restricted Project
rprichard committed rG8f29d4ed7386: [libc++][Android] Android/Bionic headers don't work with modules yet (authored by rprichard).
[libc++][Android] Android/Bionic headers don't work with modules yet
Dec 9 2022, 3:16 PM · Restricted Project, Restricted Project
rprichard committed rGf8c2b0d249af: [libc++][Android] Include cstdlib to define __BIONIC__ (authored by rprichard).
[libc++][Android] Include cstdlib to define __BIONIC__
Dec 9 2022, 3:16 PM · Restricted Project
rprichard closed D139503: [Headers][ARM] Allow `struct _Unwind_Exception` in unwind.h.
Dec 9 2022, 3:16 PM · Restricted Project, Restricted Project
rprichard closed D139502: [libc++][Android] Disable pbump2gig for Android.
Dec 9 2022, 3:16 PM · Restricted Project, Restricted Project
rprichard closed D139498: [libc++][Android] Android/Bionic headers don't work with modules yet.
Dec 9 2022, 3:16 PM · Restricted Project, Restricted Project
rprichard closed D137128: [libc++][Android] Include cstdlib to define __BIONIC__.
Dec 9 2022, 3:16 PM · Restricted Project, Restricted Project

Dec 7 2022

rprichard retitled D139498: [libc++][Android] Android/Bionic headers don't work with modules yet from [libc++][Android] Android/Bionic headers don't work with modules to [libc++][Android] Android/Bionic headers don't work with modules yet.
Dec 7 2022, 4:26 PM · Restricted Project, Restricted Project
rprichard updated the diff for D139147: [libc++][Android] Enable libc++ testing on Android.

Add feature LIBCXX-ANDROID-FIXME.

Dec 7 2022, 4:25 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
rprichard updated the diff for D139498: [libc++][Android] Android/Bionic headers don't work with modules yet.

Use XFAIL instead of UNSUPPORTED.

Dec 7 2022, 4:24 PM · Restricted Project, Restricted Project
rprichard updated the diff for D139502: [libc++][Android] Disable pbump2gig for Android.

Bump BuildKite again.

Dec 7 2022, 10:36 AM · Restricted Project, Restricted Project
rprichard added inline comments to D137131: [libc++] Android temp dir is /data/local/tmp, enable Windows test.
Dec 7 2022, 10:36 AM · Restricted Project, Restricted Project
rprichard updated the diff for D139502: [libc++][Android] Disable pbump2gig for Android.

No change.

Dec 7 2022, 10:25 AM · Restricted Project, Restricted Project
rprichard updated the summary of D139498: [libc++][Android] Android/Bionic headers don't work with modules yet.
Dec 7 2022, 9:59 AM · Restricted Project, Restricted Project
rprichard added a comment to D139498: [libc++][Android] Android/Bionic headers don't work with modules yet.

I'm definitely not ruling out adding Android/Bionic support for modules later on. They might be needed to fix things like the user namespace pollution in D139380. At the moment, the goal is to update the libc++ used on Android, which is a few years out of date.

Dec 7 2022, 9:59 AM · Restricted Project, Restricted Project