Page MenuHomePhabricator

[flang][fir] Upstream changes to the pre-FIR tree
ClosedPublic

Authored by schweitz on Mar 9 2021, 12:40 PM.

Details

Summary

Upgrade the PFT to support the lowering of Fortran 77.

Update the tests.

Diff Detail

Event Timeline

schweitz created this revision.Mar 9 2021, 12:40 PM
schweitz requested review of this revision.Mar 9 2021, 12:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2021, 12:40 PM
jeanPerier accepted this revision.Mar 10 2021, 5:36 AM

You may want to apply the clang-tidy hints about const auto ([llvm-qualified-auto]), otherwise LGTM and builds ok for me.

This revision is now accepted and ready to land.Mar 10 2021, 5:36 AM
This revision was landed with ongoing or failed builds.Mar 10 2021, 7:46 AM
This revision was automatically updated to reflect the committed changes.

Hi @schweitz , thank you for working on this!

Sadly pre-fir-tree04.f90 won't work with the new driver just yet - we need https://reviews.llvm.org/D97080 first. I've restored the original run line here: https://github.com/llvm/llvm-project/commit/547624af1963f082f0c4676b0c019528372f6f13.

I will make sure to update pre-fir-tree04.f90 again once D97080 is merged. I hope that this is OK!

Thank you for the quick fix, @awarzynski.