Summary of changes:
- VOP3P op_sel_hi is encoded as 1 for unused operands;
- Disassembler can correctly decode VOP3P instructions regardless of op_sel_hi value for unused operands.
Fixed bug 49363.
Paths
| Differential D97689
[AMDGPU][MC][GFX9+] Corrected encoding of op_sel_hi for unused operands in VOP3P ClosedPublic Authored by dp on Mar 1 2021, 7:36 AM.
Details Summary Summary of changes:
Fixed bug 49363.
Diff Detail
Event TimelineHerald added subscribers: kerbowa, hiraditya, t-tye and 7 others. · View Herald TranscriptMar 1 2021, 7:36 AM Comment Actions I was surprised to discover that codegen tests include encodings. Is there any reason for that? Should I remove or update them? Comment Actions
Yes, it is surprising. I am inclined to say remove the encodings. Comment Actions
Looking at the blame now, arsenm added the encoding checks that are failing in 2020, so perhaps those should be converted into assembler tests. This revision is now accepted and ready to land.Mar 1 2021, 12:09 PM Closed by commit rG28f164bca724: [AMDGPU][MC][GFX9+] Corrected encoding of op_sel_hi for unused operands in VOP3P (authored by dp). · Explain WhyMar 2 2021, 2:02 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 327392 llvm/lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp
llvm/lib/Target/AMDGPU/SIDefines.h
llvm/lib/Target/AMDGPU/VOPInstructions.td
llvm/test/CodeGen/AMDGPU/immv216.ll
llvm/test/MC/AMDGPU/expressions-gfx9.s
llvm/test/MC/AMDGPU/gfx90a_asm_features.s
llvm/test/MC/AMDGPU/gfx9_asm_vop3p.s
llvm/test/MC/AMDGPU/lds_direct.s
llvm/test/MC/AMDGPU/literals.s
llvm/test/MC/AMDGPU/literalv216.s
llvm/test/MC/AMDGPU/vop3-literal.s
llvm/test/MC/AMDGPU/vop3p.s
llvm/test/MC/Disassembler/AMDGPU/gfx90a_dasm_features.txt
llvm/test/MC/Disassembler/AMDGPU/gfx9_dasm_all.txt
llvm/test/MC/Disassembler/AMDGPU/lds_direct_gfx9.txt
llvm/test/MC/Disassembler/AMDGPU/literal_gfx9.txt
llvm/test/MC/Disassembler/AMDGPU/literalv216_gfx10.txt
llvm/test/MC/Disassembler/AMDGPU/vop3-literal.txt
llvm/test/MC/Disassembler/AMDGPU/vop3p_opsel.txt
|