Page MenuHomePhabricator

[flang][fir] Add remaining Ops. Updates to pre-existing Ops.
ClosedPublic

Authored by schweitz on Feb 25 2021, 2:11 PM.

Details

Summary
  • add ops: rebox, insert_on_range, absent, is_present
  • embox, coordinate_of: replace old hand-written parser/pretty-printer with assembly format
  • remove dead floating point ops, since buitlins work for all types
  • update call op
  • update documentation
  • misc. NFC to formatting

Diff Detail

Event Timeline

schweitz created this revision.Feb 25 2021, 2:11 PM
schweitz requested review of this revision.Feb 25 2021, 2:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2021, 2:11 PM
mehdi_amini added inline comments.Feb 25 2021, 2:40 PM
flang/lib/Optimizer/Dialect/FIROps.cpp
1334

Do we have test coverage for all the manual verification? It should be possible to test it all with fir-opt --verify-diagnostic

schweitz added inline comments.Feb 26 2021, 8:14 AM
flang/lib/Optimizer/Dialect/FIROps.cpp
1334

It's being worked on.

clementval accepted this revision.Feb 26 2021, 1:15 PM

I'm working on the diagnostic tests.

This revision is now accepted and ready to land.Feb 26 2021, 1:15 PM

Did you miss the fir-ops tests for the new ops?

flang/include/flang/Optimizer/Dialect/FIROps.td
1021–1024

Nit: Might be good to have some documentation for the new arguments.

2292

Nit: (unrelated) scf.for now. Needs a description update.

2434–2457

Nice loop.

Did you miss the fir-ops tests for the new ops?

I thought I got them, but I'll double check. Thanks.

schweitz added inline comments.Feb 26 2021, 4:50 PM
flang/include/flang/Optimizer/Dialect/FIROps.td
1021–1024

+1

2292

+1

This revision was landed with ongoing or failed builds.Feb 26 2021, 5:22 PM
This revision was automatically updated to reflect the committed changes.