This is an archive of the discontinued LLVM Phabricator instance.

Differential D97484

Don't use $ as suffix for symbol names in ThinLTOBitcodeWriter and other places
ClosedPublic

Authored by hans on Feb 25 2021, 9:15 AM.

Details

Reviewers
rnk
thakis
pcc
tejohnson
Commits
rGc6e5c4654bd5: Don't use $ as suffix for symbol names in ThinLTOBitcodeWriter and other places
Summary

Using $ breaks demangling of the symbols. For example,

$ c++filt _Z3foov\$123
_Z3foov$123

This causes problems for developers who would like to see nice stack traces etc. but also for automatic crash tracking systems which try to organize crashes based on the stack traces.

Instead, use the period as suffix separator, since Itanium demanglers normally ignore such suffixes:

$ c++filt _Z3foov.123
foo() [clone .123]

This is already done in some places; create a utility function to do it, and try to use that everywhere.

Diff Detail

Event Timeline

hans created this revision.Feb 25 2021, 9:15 AM
Herald added subscribers: dexonsmith, arphaman, steven_wu and 2 others. · View Herald TranscriptFeb 25 2021, 9:15 AM
hans requested review of this revision.Feb 25 2021, 9:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2021, 9:15 AM
lebedev.ri added a subscriber: lebedev.ri.Feb 25 2021, 9:21 AM

Why isn't the solution is to fix the uses to prevent variable substitution in them?
Because of course $1 is substituted with a value of variable 1 in shell, and elsewhere.

$ c++filt _Z3foov\$123
_Z3foov$123
hans added a comment.Feb 25 2021, 9:24 AM
In D97484#2587991, @lebedev.ri wrote:

Why isn't the solution is to fix the uses to prevent variable substitution in them?
Because of course $1 is substituted with a value of variable 1 in shell, and elsewhere.

$ c++filt _Z3foov\$123
_Z3foov$123

Sorry, I should have used quotes. But your example shows that the name is still not getting demangled. Compare that with a period as separator:

$ c++filt _Z3foov.123
foo() [clone .123]

Now it demangles, and puts the suffix on the side.

tejohnson added a comment.Feb 25 2021, 9:29 AM

Thanks for fixing this. Question below

llvm/lib/IR/Module.cpp
677

Should getUniqueModuleId be changed to not put in the "$"? Looking at the other use sites, it is used for renaming comdats and types - can/should these get the same treatment via this function (use .llvm.moduleId instead of $moduleId)?

pcc added inline comments.Feb 25 2021, 10:47 AM
llvm/lib/IR/Module.cpp
677

I agree, that function should be changed to use . instead of $.

lebedev.ri added a comment.Feb 25 2021, 10:49 AM
In D97484#2588003, @hans wrote:
In D97484#2587991, @lebedev.ri wrote:

Why isn't the solution is to fix the uses to prevent variable substitution in them?
Because of course $1 is substituted with a value of variable 1 in shell, and elsewhere.

$ c++filt _Z3foov\$123
_Z3foov$123

Sorry, I should have used quotes. But your example shows that the name is still not getting demangled. Compare that with a period as separator:

$ c++filt _Z3foov.123
foo() [clone .123]

Now it demangles, and puts the suffix on the side.

Thank you, please make that more obvious in the patch's description :)

Harbormaster completed remote builds in B90845: Diff 326420.Feb 25 2021, 11:49 AM
hans edited the summary of this revision. (Show Details)Mar 16 2021, 5:48 AM
hans updated this revision to Diff 330963.Mar 16 2021, 6:25 AM

Sorry for the delay, I got distracted by other fires.

I've updated the patch to just use a period as separator in getUniqueModuleId() and tweak any other place I found that used $ as separator on their own.

Please take another look.

Harbormaster completed remote builds in B94036: Diff 330963.Mar 16 2021, 6:59 AM
tejohnson accepted this revision.Mar 25 2021, 11:01 AM

lgtm, thanks!

This revision is now accepted and ready to land.Mar 25 2021, 11:01 AM
This revision was landed with ongoing or failed builds.Mar 29 2021, 4:17 AM
Closed by commit rGc6e5c4654bd5: Don't use $ as suffix for symbol names in ThinLTOBitcodeWriter and other places (authored by hans). · Explain Why
This revision was automatically updated to reflect the committed changes.
hans added a commit: rGc6e5c4654bd5: Don't use $ as suffix for symbol names in ThinLTOBitcodeWriter and other places.

Revision Contents

PathSize
llvm/
include/
llvm/
IR/
3 lines
8 lines
lib/
IR/
10 lines
Transforms/
IPO/
2 lines
2 lines
test/
ThinLTO/
X86/
8 lines
Transforms/
ThinLTOBitcodeWriter/
6 lines
6 lines
8 lines
WholeProgramDevirt/
12 lines
tools/
llvm-lto2/
6 lines

Diff 326420

llvm/include/llvm/IR/Module.h

Show First 20 Lines • Show All 889 Lines • ▼ Show 20 Lines
/// Given "llvm.used" or "llvm.compiler.used" as a global name, collect the /// Given "llvm.used" or "llvm.compiler.used" as a global name, collect the
/// initializer elements of that global in a SmallVector and return the global /// initializer elements of that global in a SmallVector and return the global
/// itself. /// itself.
GlobalVariable *collectUsedGlobalVariables(const Module &M, GlobalVariable *collectUsedGlobalVariables(const Module &M,
SmallVectorImpl<GlobalValue *> &Vec, SmallVectorImpl<GlobalValue *> &Vec,
bool CompilerUsed); bool CompilerUsed);
/// Generate a unique name based on BaseName and UniqueSuffix.
std::string getUniqueName(StringRef BaseName, StringRef UniqueSuffix);
/// An raw_ostream inserter for modules. /// An raw_ostream inserter for modules.
inline raw_ostream &operator<<(raw_ostream &O, const Module &M) { inline raw_ostream &operator<<(raw_ostream &O, const Module &M) {
M.print(O, nullptr); M.print(O, nullptr);
return O; return O;
} }
// Create wrappers for C Binding types (see CBindingWrapping.h). // Create wrappers for C Binding types (see CBindingWrapping.h).
DEFINE_SIMPLE_CONVERSION_FUNCTIONS(Module, LLVMModuleRef) DEFINE_SIMPLE_CONVERSION_FUNCTIONS(Module, LLVMModuleRef)
Show All 11 Lines

llvm/include/llvm/IR/ModuleSummaryIndex.h

Show First 20 Lines • Show All 1,392 Lines • ▼ Show 20 Lines const ModuleHash &getModuleHash(const StringRef ModPath) const {
auto It = ModulePathStringTable.find(ModPath); auto It = ModulePathStringTable.find(ModPath);
assert(It != ModulePathStringTable.end() && "Module not registered"); assert(It != ModulePathStringTable.end() && "Module not registered");
return It->second.second; return It->second.second;
} }
/// Convenience method for creating a promoted global name /// Convenience method for creating a promoted global name
/// for the given value name of a local, and its original module's ID. /// for the given value name of a local, and its original module's ID.
static std::string getGlobalNameForLocal(StringRef Name, ModuleHash ModHash) { static std::string getGlobalNameForLocal(StringRef Name, ModuleHash ModHash) {
SmallString<256> NewName(Name); return getUniqueName(Name,
NewName += ".llvm."; utostr((uint64_t(ModHash[0]) << 32)
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-        utostr((uint64_t(ModHash[0]) << 32)
-               | ModHash[1])); // Take the first 64 bits
+                         utostr((uint64_t(ModHash[0]) << 32) |
+                                ModHash[1])); // Take the first 64 bits
Lint: Pre-merge checks: clang-format: please reformat the code ``` - utostr((uint64_t(ModHash[0]) << 32)…
NewName += utostr((uint64_t(ModHash[0]) << 32) | | ModHash[1])); // Take the first 64 bits
ModHash[1]); // Take the first 64 bits
return std::string(NewName.str());
} }
/// Helper to obtain the unpromoted name for a global value (or the original /// Helper to obtain the unpromoted name for a global value (or the original
/// name if not promoted). Split off the rightmost ".llvm.${hash}" suffix, /// name if not promoted). Split off the rightmost ".llvm.${hash}" suffix,
/// because it is possible in certain clients (not clang at the moment) for /// because it is possible in certain clients (not clang at the moment) for
/// two rounds of ThinLTO optimization and therefore promotion to occur. /// two rounds of ThinLTO optimization and therefore promotion to occur.
static StringRef getOriginalNameBeforePromote(StringRef Name) { static StringRef getOriginalNameBeforePromote(StringRef Name) {
std::pair<StringRef, StringRef> Pair = Name.rsplit(".llvm."); std::pair<StringRef, StringRef> Pair = Name.rsplit(".llvm.");
▲ Show 20 Lines • Show All 190 Lines • Show Last 20 Lines

llvm/lib/IR/Module.cpp

Show First 20 Lines • Show All 667 Lines • ▼ Show 20 LinesGlobalVariable *llvm::collectUsedGlobalVariables(
const ConstantArray *Init = cast<ConstantArray>(GV->getInitializer()); const ConstantArray *Init = cast<ConstantArray>(GV->getInitializer());
for (Value *Op : Init->operands()) { for (Value *Op : Init->operands()) {
GlobalValue *G = cast<GlobalValue>(Op->stripPointerCasts()); GlobalValue *G = cast<GlobalValue>(Op->stripPointerCasts());
Vec.push_back(G); Vec.push_back(G);
} }
return GV; return GV;
} }
std::string llvm::getUniqueName(StringRef BaseName, StringRef UniqueSuffix) {
// If the suffix comes from getUniqueModuleId() it may have a $ at the front.
tejohnsonUnsubmitted
Not Done
ReplyInline Actions

Should getUniqueModuleId be changed to not put in the "$"? Looking at the other use sites, it is used for renaming comdats and types - can/should these get the same treatment via this function (use .llvm.moduleId instead of $moduleId)?

tejohnson: Should getUniqueModuleId be changed to not put in the "$"? Looking at the other use sites, it…
pccUnsubmitted
Not Done
ReplyInline Actions

I agree, that function should be changed to use . instead of $.

pcc: I agree, that function should be changed to use `.` instead of `$`.
// Remove that as it doesn't demangle nicely.
UniqueSuffix.consume_front("$");
// Use a period to separate the suffix, since by convention Itanium demanglers
// will ignore it which means the symbol name will still demangle nicely.
return (BaseName + ".llvm." + UniqueSuffix).str();
}
void Module::setPartialSampleProfileRatio(const ModuleSummaryIndex &Index) { void Module::setPartialSampleProfileRatio(const ModuleSummaryIndex &Index) {
if (auto *SummaryMD = getProfileSummary(/*IsCS*/ false)) { if (auto *SummaryMD = getProfileSummary(/*IsCS*/ false)) {
std::unique_ptr<ProfileSummary> ProfileSummary( std::unique_ptr<ProfileSummary> ProfileSummary(
ProfileSummary::getFromMD(SummaryMD)); ProfileSummary::getFromMD(SummaryMD));
if (ProfileSummary) { if (ProfileSummary) {
if (ProfileSummary->getKind() != ProfileSummary::PSK_Sample || if (ProfileSummary->getKind() != ProfileSummary::PSK_Sample ||
!ProfileSummary->isPartialProfile()) !ProfileSummary->isPartialProfile())
return; return;
Show All 11 Lines

llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp

Show First 20 Lines • Show All 49 Lines • ▼ Show 20 Lines if (!PromoteExtra.count(&ExportGV)) {
continue; continue;
ImportGV->removeDeadConstantUsers(); ImportGV->removeDeadConstantUsers();
if (ImportGV->use_empty()) { if (ImportGV->use_empty()) {
ImportGV->eraseFromParent(); ImportGV->eraseFromParent();
continue; continue;
} }
} }
std::string NewName = (Name + ModuleId).str(); std::string NewName = getUniqueName(Name, ModuleId);
if (const auto *C = ExportGV.getComdat()) if (const auto *C = ExportGV.getComdat())
if (C->getName() == Name) if (C->getName() == Name)
RenamedComdats.try_emplace(C, ExportM.getOrInsertComdat(NewName)); RenamedComdats.try_emplace(C, ExportM.getOrInsertComdat(NewName));
ExportGV.setName(NewName); ExportGV.setName(NewName);
ExportGV.setLinkage(GlobalValue::ExternalLinkage); ExportGV.setLinkage(GlobalValue::ExternalLinkage);
ExportGV.setVisibility(GlobalValue::HiddenVisibility); ExportGV.setVisibility(GlobalValue::HiddenVisibility);
▲ Show 20 Lines • Show All 508 Lines • Show Last 20 Lines

llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp

Show First 20 Lines • Show All 1,147 Lines • ▼ Show 20 Linesbool DevirtModule::trySingleImplDevirt(
applySingleImplDevirt(SlotInfo, TheFn, IsExported); applySingleImplDevirt(SlotInfo, TheFn, IsExported);
if (!IsExported) if (!IsExported)
return false; return false;
// If the only implementation has local linkage, we must promote to external // If the only implementation has local linkage, we must promote to external
// to make it visible to thin LTO objects. We can only get here during the // to make it visible to thin LTO objects. We can only get here during the
// ThinLTO export phase. // ThinLTO export phase.
if (TheFn->hasLocalLinkage()) { if (TheFn->hasLocalLinkage()) {
std::string NewName = (TheFn->getName() + "$merged").str(); std::string NewName = getUniqueName(TheFn->getName(), "merged");
// Since we are renaming the function, any comdats with the same name must // Since we are renaming the function, any comdats with the same name must
// also be renamed. This is required when targeting COFF, as the comdat name // also be renamed. This is required when targeting COFF, as the comdat name
// must match one of the names of the symbols in the comdat. // must match one of the names of the symbols in the comdat.
if (Comdat *C = TheFn->getComdat()) { if (Comdat *C = TheFn->getComdat()) {
if (C->getName() == TheFn->getName()) { if (C->getName() == TheFn->getName()) {
Comdat *NewC = M.getOrInsertComdat(NewName); Comdat *NewC = M.getOrInsertComdat(NewName);
NewC->setSelectionKind(C->getSelectionKind()); NewC->setSelectionKind(C->getSelectionKind());
▲ Show 20 Lines • Show All 1,099 Lines • Show Last 20 Lines

llvm/test/ThinLTO/X86/devirt2.ll

Show First 20 Lines • Show All 184 Lines • ▼ Show 20 Lines
; RUN: -r=%t2.o,_ZTV1C,px \ ; RUN: -r=%t2.o,_ZTV1C,px \
; RUN: -r=%t2.o,_ZTV1D,px \ ; RUN: -r=%t2.o,_ZTV1D,px \
; RUN: -r=%t2.o,_ZTV1E,px 2>&1 | FileCheck %s --check-prefix=REMARK ; RUN: -r=%t2.o,_ZTV1E,px 2>&1 | FileCheck %s --check-prefix=REMARK
; RUN: llvm-dis %t5.1.4.opt.bc -o - | FileCheck %s --check-prefix=CHECK-IR1 ; RUN: llvm-dis %t5.1.4.opt.bc -o - | FileCheck %s --check-prefix=CHECK-IR1
; RUN: llvm-dis %t5.2.4.opt.bc -o - | FileCheck %s --check-prefix=CHECK-IR2 ; RUN: llvm-dis %t5.2.4.opt.bc -o - | FileCheck %s --check-prefix=CHECK-IR2
; RUN: llvm-nm %t5.1 | FileCheck %s --check-prefix=NM-HYBRID1 ; RUN: llvm-nm %t5.1 | FileCheck %s --check-prefix=NM-HYBRID1
; RUN: llvm-nm %t5.2 | FileCheck %s --check-prefix=NM-HYBRID2 ; RUN: llvm-nm %t5.2 | FileCheck %s --check-prefix=NM-HYBRID2
; NM-HYBRID1-DAG: U _ZN1A1nEi$ ; NM-HYBRID1-DAG: U _ZN1A1nEi.llvm.{{[0-9a-f]*}}
; NM-HYBRID1-DAG: U _ZN1E1mEi$ ; NM-HYBRID1-DAG: U _ZN1E1mEi.llvm.{{[0-9a-f]*}}
; NM-HYBRID1-DAG: U _ZN1D1mEi ; NM-HYBRID1-DAG: U _ZN1D1mEi
; NM-HYBRID2-DAG: T _ZN1A1nEi$ ; NM-HYBRID2-DAG: T _ZN1A1nEi.llvm.{{[0-9a-f]*}}
; NM-HYBRID2-DAG: T _ZN1E1mEi$ ; NM-HYBRID2-DAG: T _ZN1E1mEi.llvm.{{[0-9a-f]*}}
; NM-HYBRID2-DAG: W _ZN1D1mEi ; NM-HYBRID2-DAG: W _ZN1D1mEi
; NM-HYBRID2-DAG: T _ZN1B1fEi ; NM-HYBRID2-DAG: T _ZN1B1fEi
; NM-HYBRID2-DAG: T _ZN1C1fEi ; NM-HYBRID2-DAG: T _ZN1C1fEi
; REMARK-DAG: single-impl: devirtualized a call to _ZN1A1nEi ; REMARK-DAG: single-impl: devirtualized a call to _ZN1A1nEi
; REMARK-DAG: single-impl: devirtualized a call to _ZN1D1mEi ; REMARK-DAG: single-impl: devirtualized a call to _ZN1D1mEi
; We should devirt call to _ZN1E1mEi once in importing module and once ; We should devirt call to _ZN1E1mEi once in importing module and once
; in original (exporting) module. ; in original (exporting) module.
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines

llvm/test/Transforms/ThinLTOBitcodeWriter/split-internal1.ll

; RUN: opt -thinlto-bc -thinlto-split-lto-unit -o %t %s ; RUN: opt -thinlto-bc -thinlto-split-lto-unit -o %t %s
; RUN: llvm-modextract -b -n 0 -o %t0 %t ; RUN: llvm-modextract -b -n 0 -o %t0 %t
; RUN: llvm-modextract -b -n 1 -o %t1 %t ; RUN: llvm-modextract -b -n 1 -o %t1 %t
; RUN: not llvm-modextract -b -n 2 -o - %t 2>&1 | FileCheck --check-prefix=ERROR %s ; RUN: not llvm-modextract -b -n 2 -o - %t 2>&1 | FileCheck --check-prefix=ERROR %s
; RUN: llvm-dis -o - %t0 | FileCheck --check-prefix=M0 %s ; RUN: llvm-dis -o - %t0 | FileCheck --check-prefix=M0 %s
; RUN: llvm-dis -o - %t1 | FileCheck --check-prefix=M1 %s ; RUN: llvm-dis -o - %t1 | FileCheck --check-prefix=M1 %s
; RUN: llvm-bcanalyzer -dump %t0 | FileCheck --check-prefix=BCA0 %s ; RUN: llvm-bcanalyzer -dump %t0 | FileCheck --check-prefix=BCA0 %s
; RUN: llvm-bcanalyzer -dump %t1 | FileCheck --check-prefix=BCA1 %s ; RUN: llvm-bcanalyzer -dump %t1 | FileCheck --check-prefix=BCA1 %s
; ERROR: llvm-modextract: error: module index out of range; bitcode file contains 2 module(s) ; ERROR: llvm-modextract: error: module index out of range; bitcode file contains 2 module(s)
; BCA0: <GLOBALVAL_SUMMARY_BLOCK ; BCA0: <GLOBALVAL_SUMMARY_BLOCK
; BCA1-NOT: <GLOBALVAL_SUMMARY_BLOCK ; BCA1-NOT: <GLOBALVAL_SUMMARY_BLOCK
; M0: @"g$581d7631532fa146ba4061179da39272" = external hidden global i8{{$}} ; M0: @g.llvm.581d7631532fa146ba4061179da39272 = external hidden global i8{{$}}
; M1: @"g$581d7631532fa146ba4061179da39272" = hidden global i8 42, !type !0 ; M1: @g.llvm.581d7631532fa146ba4061179da39272 = hidden global i8 42, !type !0
@g = internal global i8 42, !type !0 @g = internal global i8 42, !type !0
; M0: define i8* @f() ; M0: define i8* @f()
; M1-NOT: @f() ; M1-NOT: @f()
define i8* @f() { define i8* @f() {
; M0: ret i8* @"g$581d7631532fa146ba4061179da39272" ; M0: ret i8* @g.llvm.581d7631532fa146ba4061179da39272
ret i8* @g ret i8* @g
} }
; M1: !0 = !{i32 0, !"typeid"} ; M1: !0 = !{i32 0, !"typeid"}
!0 = !{i32 0, !"typeid"} !0 = !{i32 0, !"typeid"}

llvm/test/Transforms/ThinLTOBitcodeWriter/split-internal2.ll

; RUN: opt -thinlto-bc -thinlto-split-lto-unit -o %t %s ; RUN: opt -thinlto-bc -thinlto-split-lto-unit -o %t %s
; RUN: llvm-modextract -b -n 0 -o %t0 %t ; RUN: llvm-modextract -b -n 0 -o %t0 %t
; RUN: llvm-modextract -b -n 1 -o %t1 %t ; RUN: llvm-modextract -b -n 1 -o %t1 %t
; RUN: not llvm-modextract -b -n 2 -o - %t 2>&1 | FileCheck --check-prefix=ERROR %s ; RUN: not llvm-modextract -b -n 2 -o - %t 2>&1 | FileCheck --check-prefix=ERROR %s
; RUN: llvm-dis -o - %t0 | FileCheck --check-prefix=M0 %s ; RUN: llvm-dis -o - %t0 | FileCheck --check-prefix=M0 %s
; RUN: llvm-dis -o - %t1 | FileCheck --check-prefix=M1 %s ; RUN: llvm-dis -o - %t1 | FileCheck --check-prefix=M1 %s
; RUN: llvm-bcanalyzer -dump %t0 | FileCheck --check-prefix=BCA0 %s ; RUN: llvm-bcanalyzer -dump %t0 | FileCheck --check-prefix=BCA0 %s
; RUN: llvm-bcanalyzer -dump %t1 | FileCheck --check-prefix=BCA1 %s ; RUN: llvm-bcanalyzer -dump %t1 | FileCheck --check-prefix=BCA1 %s
; ERROR: llvm-modextract: error: module index out of range; bitcode file contains 2 module(s) ; ERROR: llvm-modextract: error: module index out of range; bitcode file contains 2 module(s)
; BCA0: <GLOBALVAL_SUMMARY_BLOCK ; BCA0: <GLOBALVAL_SUMMARY_BLOCK
; BCA1-NOT: <GLOBALVAL_SUMMARY_BLOCK ; BCA1-NOT: <GLOBALVAL_SUMMARY_BLOCK
; M0: @g = external global void ()*{{$}} ; M0: @g = external global void ()*{{$}}
; M1: @g = global void ()* @"f$13757e0fb71915e385efa4dc9d1e08fd", !type !0 ; M1: @g = global void ()* @f.llvm.13757e0fb71915e385efa4dc9d1e08fd, !type !0
@g = global void ()* @f, !type !0 @g = global void ()* @f, !type !0
; M0: define hidden void @"f$13757e0fb71915e385efa4dc9d1e08fd"() ; M0: define hidden void @f.llvm.13757e0fb71915e385efa4dc9d1e08fd()
; M1: declare hidden void @"f$13757e0fb71915e385efa4dc9d1e08fd"() ; M1: declare hidden void @f.llvm.13757e0fb71915e385efa4dc9d1e08fd()
define internal void @f() { define internal void @f() {
call void @f2() call void @f2()
ret void ret void
} }
; M0: define internal void @f2() ; M0: define internal void @f2()
define internal void @f2() { define internal void @f2() {
ret void ret void
} }
; M1: !0 = !{i32 0, !"typeid"} ; M1: !0 = !{i32 0, !"typeid"}
!0 = !{i32 0, !"typeid"} !0 = !{i32 0, !"typeid"}

llvm/test/Transforms/ThinLTOBitcodeWriter/split-vfunc-internal.ll

; RUN: opt -thinlto-bc -thinlto-split-lto-unit -o %t %s ; RUN: opt -thinlto-bc -thinlto-split-lto-unit -o %t %s
; RUN: llvm-modextract -b -n 0 -o - %t | llvm-dis | FileCheck --check-prefix=M0 %s ; RUN: llvm-modextract -b -n 0 -o - %t | llvm-dis | FileCheck --check-prefix=M0 %s
; RUN: llvm-modextract -b -n 1 -o - %t | llvm-dis | FileCheck --check-prefix=M1 %s ; RUN: llvm-modextract -b -n 1 -o - %t | llvm-dis | FileCheck --check-prefix=M1 %s
define [1 x i8*]* @source() { define [1 x i8*]* @source() {
ret [1 x i8*]* @g ret [1 x i8*]* @g
} }
; M0: @"g$84f59439b469192440047efc8de357fb" = external hidden constant [1 x i8*]{{$}} ; M0: @g.llvm.84f59439b469192440047efc8de357fb = external hidden constant [1 x i8*]{{$}}
; M1: @"g$84f59439b469192440047efc8de357fb" = hidden constant [1 x i8*] [i8* bitcast (i64 (i8*)* @"ok$84f59439b469192440047efc8de357fb" to i8*)] ; M1: @g.llvm.84f59439b469192440047efc8de357fb = hidden constant [1 x i8*] [i8* bitcast (i64 (i8*)* @ok.llvm.84f59439b469192440047efc8de357fb to i8*)]
@g = internal constant [1 x i8*] [ @g = internal constant [1 x i8*] [
i8* bitcast (i64 (i8*)* @ok to i8*) i8* bitcast (i64 (i8*)* @ok to i8*)
], !type !0 ], !type !0
; M0: define hidden i64 @"ok$84f59439b469192440047efc8de357fb" ; M0: define hidden i64 @ok.llvm.84f59439b469192440047efc8de357fb
; M1: define available_externally hidden i64 @"ok$84f59439b469192440047efc8de357fb" ; M1: define available_externally hidden i64 @ok.llvm.84f59439b469192440047efc8de357fb
define internal i64 @ok(i8* %this) { define internal i64 @ok(i8* %this) {
ret i64 42 ret i64 42
} }
!0 = !{i32 0, !"typeid"} !0 = !{i32 0, !"typeid"}

llvm/test/Transforms/WholeProgramDevirt/export-single-impl.ll

; RUN: opt -wholeprogramdevirt -whole-program-visibility -wholeprogramdevirt-summary-action=export -wholeprogramdevirt-read-summary=%S/Inputs/export.yaml -wholeprogramdevirt-write-summary=%t -S -o - %s | FileCheck %s ; RUN: opt -wholeprogramdevirt -whole-program-visibility -wholeprogramdevirt-summary-action=export -wholeprogramdevirt-read-summary=%S/Inputs/export.yaml -wholeprogramdevirt-write-summary=%t -S -o - %s | FileCheck %s
; RUN: FileCheck --check-prefix=SUMMARY %s < %t ; RUN: FileCheck --check-prefix=SUMMARY %s < %t
; SUMMARY: TypeIdMap: ; SUMMARY: TypeIdMap:
; SUMMARY-NEXT: typeid3: ; SUMMARY-NEXT: typeid3:
; SUMMARY-NEXT: TTRes: ; SUMMARY-NEXT: TTRes:
; SUMMARY-NEXT: Kind: Unknown ; SUMMARY-NEXT: Kind: Unknown
; SUMMARY-NEXT: SizeM1BitWidth: 0 ; SUMMARY-NEXT: SizeM1BitWidth: 0
; SUMMARY-NEXT: AlignLog2: 0 ; SUMMARY-NEXT: AlignLog2: 0
; SUMMARY-NEXT: SizeM1: 0 ; SUMMARY-NEXT: SizeM1: 0
; SUMMARY-NEXT: BitMask: 0 ; SUMMARY-NEXT: BitMask: 0
; SUMMARY-NEXT: InlineBits: 0 ; SUMMARY-NEXT: InlineBits: 0
; SUMMARY-NEXT: WPDRes: ; SUMMARY-NEXT: WPDRes:
; SUMMARY-NEXT: 0: ; SUMMARY-NEXT: 0:
; SUMMARY-NEXT: Kind: SingleImpl ; SUMMARY-NEXT: Kind: SingleImpl
; SUMMARY-NEXT: SingleImplName: 'vf3$merged' ; SUMMARY-NEXT: SingleImplName: vf3.llvm.merged
; SUMMARY-NEXT: ResByArg: ; SUMMARY-NEXT: ResByArg:
; SUMMARY-NEXT: typeid1: ; SUMMARY-NEXT: typeid1:
; SUMMARY-NEXT: TTRes: ; SUMMARY-NEXT: TTRes:
; SUMMARY-NEXT: Kind: Unknown ; SUMMARY-NEXT: Kind: Unknown
; SUMMARY-NEXT: SizeM1BitWidth: 0 ; SUMMARY-NEXT: SizeM1BitWidth: 0
; SUMMARY-NEXT: AlignLog2: 0 ; SUMMARY-NEXT: AlignLog2: 0
; SUMMARY-NEXT: SizeM1: 0 ; SUMMARY-NEXT: SizeM1: 0
; SUMMARY-NEXT: BitMask: 0 ; SUMMARY-NEXT: BitMask: 0
Show All 22 Lines
; SUMMARY-NEXT: SizeM1BitWidth: 0 ; SUMMARY-NEXT: SizeM1BitWidth: 0
; SUMMARY-NEXT: AlignLog2: 0 ; SUMMARY-NEXT: AlignLog2: 0
; SUMMARY-NEXT: SizeM1: 0 ; SUMMARY-NEXT: SizeM1: 0
; SUMMARY-NEXT: BitMask: 0 ; SUMMARY-NEXT: BitMask: 0
; SUMMARY-NEXT: InlineBits: 0 ; SUMMARY-NEXT: InlineBits: 0
; SUMMARY-NEXT: WPDRes: ; SUMMARY-NEXT: WPDRes:
; SUMMARY-NEXT: 0: ; SUMMARY-NEXT: 0:
; SUMMARY-NEXT: Kind: SingleImpl ; SUMMARY-NEXT: Kind: SingleImpl
; SUMMARY-NEXT: SingleImplName: 'vf4$merged' ; SUMMARY-NEXT: SingleImplName: vf4.llvm.merged
; SUMMARY-NEXT: ResByArg: ; SUMMARY-NEXT: ResByArg:
; SUMMARY-NEXT: WithGlobalValueDeadStripping: false ; SUMMARY-NEXT: WithGlobalValueDeadStripping: false
; SUMMARY-NEXT: ... ; SUMMARY-NEXT: ...
; CHECK: $"vf4$merged" = comdat largest ; CHECK: $vf4.llvm.merged = comdat largest
$vf4 = comdat largest $vf4 = comdat largest
; CHECK: @vt1 = constant void (i8*)* @vf1 ; CHECK: @vt1 = constant void (i8*)* @vf1
@vt1 = constant void (i8*)* @vf1, !type !0 @vt1 = constant void (i8*)* @vf1, !type !0
; CHECK: @vt2 = constant void (i8*)* @vf2 ; CHECK: @vt2 = constant void (i8*)* @vf2
@vt2 = constant void (i8*)* @vf2, !type !1 @vt2 = constant void (i8*)* @vf2, !type !1
@vt3 = constant void (i8*)* @vf3, !type !2 @vt3 = constant void (i8*)* @vf3, !type !2
; CHECK: @vt4 = constant void (i8*)* @"vf4$merged", comdat($"vf4$merged") ; CHECK: @vt4 = constant void (i8*)* @vf4.llvm.merged, comdat($vf4.llvm.merged)
@vt4 = constant void (i8*)* @vf4, comdat($vf4), !type !3 @vt4 = constant void (i8*)* @vf4, comdat($vf4), !type !3
@vt5 = constant void (i8*)* @vf5, !type !4 @vt5 = constant void (i8*)* @vf5, !type !4
; CHECK: declare void @vf1(i8*) ; CHECK: declare void @vf1(i8*)
declare void @vf1(i8*) declare void @vf1(i8*)
; CHECK: define void @vf2(i8* %0) ; CHECK: define void @vf2(i8* %0)
define void @vf2(i8*) { define void @vf2(i8*) {
ret void ret void
} }
; CHECK: define hidden void @"vf3$merged"(i8* %0) { ; CHECK: define hidden void @vf3.llvm.merged(i8* %0) {
define internal void @vf3(i8*) { define internal void @vf3(i8*) {
ret void ret void
} }
; CHECK: define hidden void @"vf4$merged"(i8* %0) comdat { ; CHECK: define hidden void @vf4.llvm.merged(i8* %0) comdat {
define internal void @vf4(i8*) comdat { define internal void @vf4(i8*) comdat {
ret void ret void
} }
declare void @vf5(i8*) declare void @vf5(i8*)
!0 = !{i32 0, !"typeid1"} !0 = !{i32 0, !"typeid1"}
!1 = !{i32 0, !"typeid2"} !1 = !{i32 0, !"typeid2"}
!2 = !{i32 0, !"typeid3"} !2 = !{i32 0, !"typeid3"}
!3 = !{i32 0, !"typeid4"} !3 = !{i32 0, !"typeid4"}
!4 = !{i32 0, !5} !4 = !{i32 0, !5}
!5 = distinct !{} !5 = distinct !{}

llvm/tools/llvm-lto2/llvm-lto2.cpp

Show First 20 Lines • Show All 319 Lines • ▼ Show 20 Linesstatic int run(int argc, char **argv) {
for (std::string F : InputFilenames) { for (std::string F : InputFilenames) {
std::unique_ptr<MemoryBuffer> MB = check(MemoryBuffer::getFile(F), F); std::unique_ptr<MemoryBuffer> MB = check(MemoryBuffer::getFile(F), F);
std::unique_ptr<InputFile> Input = std::unique_ptr<InputFile> Input =
check(InputFile::create(MB->getMemBufferRef()), F); check(InputFile::create(MB->getMemBufferRef()), F);
std::vector<SymbolResolution> Res; std::vector<SymbolResolution> Res;
for (const InputFile::Symbol &Sym : Input->symbols()) { for (const InputFile::Symbol &Sym : Input->symbols()) {
auto I = CommandLineResolutions.find({F, std::string(Sym.getName())}); auto I = CommandLineResolutions.find({F, std::string(Sym.getName())});
// If it isn't found, look for "$", which would have been added // If it isn't found, look for ".llvm.", which would have been added
// (followed by a hash) when the symbol was promoted during module // (followed by a hash) when the symbol was promoted during module
// splitting if it was defined in one part and used in the other. // splitting if it was defined in one part and used in the other.
// Try looking up the symbol name before the "$". // Try looking up the symbol name before the suffix.
if (I == CommandLineResolutions.end()) { if (I == CommandLineResolutions.end()) {
auto SplitName = Sym.getName().rsplit("$"); auto SplitName = Sym.getName().rsplit(".llvm.");
I = CommandLineResolutions.find({F, std::string(SplitName.first)}); I = CommandLineResolutions.find({F, std::string(SplitName.first)});
} }
if (I == CommandLineResolutions.end()) { if (I == CommandLineResolutions.end()) {
llvm::errs() << argv[0] << ": missing symbol resolution for " << F llvm::errs() << argv[0] << ": missing symbol resolution for " << F
<< ',' << Sym.getName() << '\n'; << ',' << Sym.getName() << '\n';
HasErrors = true; HasErrors = true;
} else { } else {
Res.push_back(I->second.front()); Res.push_back(I->second.front());
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines