This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] [NFC] Eliminate dispatchCast, evalCastFromNonLoc and evalCastFromLoc functions from SValBuilder
ClosedPublic

Authored by ASDenysPetrov on Feb 23 2021, 5:59 AM.

Details

Summary

Remove dispatchCast, evalCastFromNonLoc and evalCastFromLoc functions since their functionality has been moved to common evalCast function.
Use evalCast instead.

Post-clean up patch for D96090 patch.
The patch shall not change any behavior.

Diff Detail

Event Timeline

ASDenysPetrov created this revision.Feb 23 2021, 5:59 AM
ASDenysPetrov requested review of this revision.Feb 23 2021, 5:59 AM

Rebased on main.

vsavchenko accepted this revision.Mar 9 2021, 2:56 AM

Looks great, thanks for cleaning up!

This revision is now accepted and ready to land.Mar 9 2021, 2:56 AM

Please, @ASDenysPetrov, mention NFC in the commit message when you commit this change.
The same applies to all of your NFC changes.

ASDenysPetrov retitled this revision from [analyzer] Eliminate dispatchCast, evalCastFromNonLoc and evalCastFromLoc functions from SValBuilder to [analyzer] [NFC] Eliminate dispatchCast, evalCastFromNonLoc and evalCastFromLoc functions from SValBuilder.Mar 9 2021, 9:24 AM