This is an archive of the discontinued LLVM Phabricator instance.

Differential D97248

[test-suite] Raise minimum required CMake version to match LLVM.
ClosedPublic

Authored by naromero77 on Feb 22 2021, 7:54 PM.

Details

Reviewers
jdoerfert
Meinersbur
rovka
sameeranjoshi
fhahn
Commits
rT0b0305c689d9: [test-suite] Raise minimum required CMake version to match LLVM.
Summary

Test-suite was using an old version of CMake. Raise minimum CMake version to match minimum required by LLVM. Additionally, the Fortran Test Suite requires at least 3.7 due to Ninja.

Diff Detail

Repository
rT test-suite

Event Timeline

naromero77 created this revision.Feb 22 2021, 7:54 PM
Herald added a subscriber: mgorny. · View Herald TranscriptFeb 22 2021, 7:54 PM
naromero77 requested review of this revision.Feb 22 2021, 7:54 PM
Harbormaster completed remote builds in B90322: Diff 325653.Feb 22 2021, 7:54 PM
naromero77 added reviewers: jdoerfert, Meinersbur, rovka, sameeranjoshi, fhahn.Feb 22 2021, 7:57 PM
naromero77 added subscribers: llvm-commits, naromero77.
Meinersbur accepted this revision.Feb 22 2021, 7:59 PM

LGTM

Could you also mention in the commit message that this is also the minimum version required by LLVM?

This revision is now accepted and ready to land.Feb 22 2021, 7:59 PM
naromero77 retitled this revision from [test-suite] Raise minimum required CMake version to match llvm-project. to [test-suite] Raise minimum required CMake version to match LLVM..Feb 22 2021, 10:40 PM
naromero77 edited the summary of this revision. (Show Details)
naromero77 edited the summary of this revision. (Show Details)
Closed by commit rT0b0305c689d9: [test-suite] Raise minimum required CMake version to match LLVM. (authored by naromero77). · Explain WhyFeb 22 2021, 10:56 PM
This revision was automatically updated to reflect the committed changes.
naromero77 added a commit: rT0b0305c689d9: [test-suite] Raise minimum required CMake version to match LLVM..

Revision Contents

PathSize
2 lines

Diff 325684

CMakeLists.txt

cmake_minimum_required(VERSION 3.4.3) cmake_minimum_required(VERSION 3.13.4)
include(CheckSymbolExists) include(CheckSymbolExists)
option(TEST_SUITE_FORTRAN "Enable Fortran test suite" OFF) option(TEST_SUITE_FORTRAN "Enable Fortran test suite" OFF)
project(test-suite C CXX) project(test-suite C CXX)
if(TEST_SUITE_FORTRAN) if(TEST_SUITE_FORTRAN)
▲ Show 20 Lines • Show All 388 Lines • Show Last 20 Lines