Changes for AMD GPU SIMemoryLegalizer:
- Limit the memory scope to maximum supported by the scratch, LDS and GDS address spaces.
- Improve assertion checking.
- Correct toSIAtomicScope argument name.
Paths
| Differential D96643
[AMDGPU] Limit memory scope for scratch, LDS and GDS ClosedPublic Authored by t-tye on Feb 13 2021, 1:03 AM.
Details Summary Changes for AMD GPU SIMemoryLegalizer:
Diff Detail
Event TimelineHerald added subscribers: kerbowa, jfb, hiraditya and 6 others. · View Herald TranscriptFeb 13 2021, 1:03 AM Comment Actions LGTM, thanks Tony!
This revision is now accepted and ready to land.Feb 13 2021, 1:31 AM madhur13490 added inline comments.
Comment Actions
t-tye retitled this revision from [AMDGPU] Limit memory scope for scratch and LDS to [AMDGPU] Limit memory scope for scratch, LDS and GDS.Feb 13 2021, 1:02 PM Comment Actions
I made the changes, thanks. I am waiting to get executable test results but Gerrit is currently down. Comment Actions Gerrit is down until 11pm CT according to IT. Stas
From: Tony Tye via Phabricator reviews@reviews.llvm.org [CAUTION: External Email] t-tye added a comment. In D96643#2561617 https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD96643%232561617&data=04%7C01%7Cstanislav.mekhanoshin%40amd.com%7Ce267676049fe4e987bda08d8d069ae2b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637488499635053925%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=gtSTLQKaH1%2FU22bx0vE3BSOOZ50ZhryRfYwQXHvYv20%3D&reserved=0, @rampitec wrote: LGTM, thanks Tony! I made the changes, thanks. I am waiting to get executable test results but Gerrit is currently down. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD96643%2Fnew%2F&data=04%7C01%7Cstanislav.mekhanoshin%40amd.com%7Ce267676049fe4e987bda08d8d069ae2b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637488499635053925%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ywkjGAacWwABrPmLCAfpRqa6spSOUy6RG2gqAQpTG0A%3D&reserved=0 This revision was landed with ongoing or failed builds.Feb 14 2021, 9:35 AM Closed by commit rG8a91b68b95e6: [AMDGPU] Limit memory scope for scratch, LDS and GDS (authored by t-tye). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 323620 llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp
llvm/test/CodeGen/AMDGPU/atomic_optimizations_local_pointer.ll
llvm/test/CodeGen/AMDGPU/atomicrmw-nand.ll
llvm/test/CodeGen/AMDGPU/local-atomics-fp.ll
llvm/test/CodeGen/AMDGPU/memory-legalizer-local-agent.ll
llvm/test/CodeGen/AMDGPU/memory-legalizer-local-system.ll
|
Scope = std::min(Scope, SIAtomicScope::SINGLETHREAD) ?
It just looks more formal.