Page MenuHomePhabricator

[flang][fir][NFC] Move FieldType to TableGen type definition
ClosedPublic

Authored by clementval on Feb 12 2021, 7:52 AM.

Details

Summary

This patch is a follow up of D96422 and move ComplexType to TableGen.

Diff Detail

Event Timeline

clementval requested review of this revision.Feb 12 2021, 7:52 AM
clementval created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 12 2021, 7:52 AM
clementval added a project: Restricted Project.Feb 12 2021, 8:07 AM

Add printer

mehdi_amini accepted this revision.Feb 12 2021, 11:23 AM

LGTM

All these type refactoring to table gen are fairly mechanical, I'm fine if you just push them with post-commit review. Or you could migrate all of them at once and sent one revision. Whatever works best.

This revision is now accepted and ready to land.Feb 12 2021, 11:23 AM

LGTM

All these type refactoring to table gen are fairly mechanical, I'm fine if you just push them with post-commit review. Or you could migrate all of them at once and sent one revision. Whatever works best.

Thanks. I'll make a final patch with the remaining types to be moved.

Keep fir_ prefix

schweitz accepted this revision.Feb 12 2021, 3:56 PM