Page MenuHomePhabricator

[lldb] Remove the legacy FreeBSD plugin
ClosedPublic

Authored by mgorny on Feb 11 2021, 3:42 PM.

Details

Summary

The new FreeBSDRemote plugin has reached feature parity with the legacy
plugin, so we can finally remove the latter. The new plugin will
be renamed to FreeBSD in a separate commit to avoid confusion.

Diff Detail

Event Timeline

mgorny created this revision.Feb 11 2021, 3:42 PM
mgorny requested review of this revision.Feb 11 2021, 3:42 PM

@labath, any clue if I'm missing some no-longer-necessary code? I feel like I was supposed to also remove something responsible for launching/attaching processes in the old mode.

Not sure if you're missing something, but removing the old plugin LGTM

lldb/tools/lldb-server/CMakeLists.txt
13

Should we rename this after?

13

Ah I see D96557

labath accepted this revision.Feb 15 2021, 12:57 AM

@labath, any clue if I'm missing some no-longer-necessary code? I feel like I was supposed to also remove something responsible for launching/attaching processes in the old mode.

We still have windows support around, so I don't think there's any generic code that we can remove. However, this is still a big milestone.

This revision is now accepted and ready to land.Feb 15 2021, 12:57 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2021, 4:04 AM
Herald added a subscriber: jrtc27. · View Herald Transcript