Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D96511

[cross-project-tests] Make clang optional if not in LLVM_ENABLE_PROJECTS - part 4
ClosedPublic
Actions

Authored by jhenderson on Feb 11 2021, 7:48 AM.

Details

Reviewers
aprantl
aganea
dblaikie
jmorse
rnk
Orlando
Commits
rG3827600ff3f7: [cross-project-tests] Make clang optional if not in LLVM_ENABLE_PROJECTS
Summary

Also mark debuginfo_tests as UNSUPPORTED if clang can't be found and remove it from the list of test dependencies if not in LLVM_ENABLE_PROJECTS.

Depends on D96510.

Diff Detail

Event Timeline

jhenderson created this revision.Feb 11 2021, 7:48 AM
Herald added a subscriber: mgorny. · View Herald TranscriptFeb 11 2021, 7:48 AM
jhenderson requested review of this revision.Feb 11 2021, 7:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2021, 7:48 AM
jhenderson retitled this revision from [cross-project-tests] Make clang optional if not in LLVM_ENABLE_PROJECTS to [cross-project-tests] Make clang optional if not in LLVM_ENABLE_PROJECTS - part 4.Feb 11 2021, 7:48 AM
Harbormaster completed remote builds in B88823: Diff 323015.Feb 11 2021, 7:49 AM
jhenderson added a child revision: D96513: [cross-project-tests] Add/update check-* targets for cross-project-tests - part 5.Feb 11 2021, 7:50 AM
aprantl accepted this revision.Feb 12 2021, 9:16 AM

This makes sense to me.

This revision is now accepted and ready to land.Feb 12 2021, 9:16 AM
jhenderson updated this revision to Diff 328506.Mar 5 2021, 6:29 AM

Rebase.

jhenderson mentioned this in D95339: [RFC][test] Adapt debug-info lit framework for more general purposes - part 1.Mar 16 2021, 2:06 AM
jhenderson mentioned this in D96510: [cross-project-tests] Add lld as a dependency, if in LLVM_ENABLE_PROJECTS - part 3.May 6 2021, 6:14 AM
jhenderson updated this revision to Diff 343386.May 6 2021, 6:21 AM

Rebase.

jhenderson mentioned this in D102630: [lit] Stop using PATH to lookup clang/lld/lldb unless requested.May 17 2021, 7:42 AM
This revision was landed with ongoing or failed builds.Jun 28 2021, 3:34 AM
Closed by commit rG3827600ff3f7: [cross-project-tests] Make clang optional if not in LLVM_ENABLE_PROJECTS (authored by jhenderson). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhenderson added a commit: rG3827600ff3f7: [cross-project-tests] Make clang optional if not in LLVM_ENABLE_PROJECTS.

Revision Contents
Changeset List

PathSize
cross-project-tests/
5 lines
debuginfo-tests/
2 lines
10 lines

Diff 323015

View Options

cross-project-tests/CMakeLists.txt

Loading...
View Options

cross-project-tests/debuginfo-tests/lit.local.cfg

Loading...
View Options

cross-project-tests/lit.cfg.py

Loading...