Page MenuHomePhabricator
Differential D96487

Restore diagnostic handler after CodeGenAction::ExecuteAction
ClosedPublic
Actions

Authored by mantognini on Feb 11 2021, 3:50 AM.

Details

Reviewers
aganea
xur
rsmith
Commits
rGe54811ff7e0b: Restore diagnostic handler after CodeGenAction::ExecuteAction
Summary

Fix dangling pointer to local variable and address some typos.

Diff Detail

Unit TestsFailed
View All

TimeTest
60 msx64 debian > Polly.ScopInfo::user_provided_assumptions.ll
Script: -- : 'RUN: at line 1'; opt -polly-process-unprofitable -polly-remarks-minimal -polly-use-llvm-names -polly-import-jscop-dir=/mnt/disks/ssd0/agent/llvm-project/polly/test/ScopInfo -polly-codegen-verify -pass-remarks-analysis="polly-scops" -polly-scops -disable-output < /mnt/disks/ssd0/agent/llvm-project/polly/test/ScopInfo/user_provided_assumptions.ll 2>&1 | FileCheck /mnt/disks/ssd0/agent/llvm-project/polly/test/ScopInfo/user_provided_assumptions.ll

Event Timeline

mantognini created this revision.Feb 11 2021, 3:50 AM
Herald added a subscriber: dexonsmith. · View Herald TranscriptFeb 11 2021, 3:50 AM
mantognini published this revision for review.Feb 11 2021, 3:54 AM
mantognini added inline comments.
llvm/include/llvm/IR/LLVMContext.h
196

Had to run clang-format. The change is replacing "third" with "second".

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 11 2021, 3:54 AM
Herald added subscribers: llvm-commits, cfe-commits. · View Herald Transcript
mantognini added reviewers: aganea, xur, rsmith.Feb 11 2021, 4:01 AM
Harbormaster completed remote builds in B88781: Diff 322944.Feb 11 2021, 5:00 AM
Anastasia added a subscriber: Anastasia.Feb 11 2021, 7:02 AM
xur accepted this revision.Feb 11 2021, 10:50 AM

This looks fine to me. Thanks for fixing.

This revision is now accepted and ready to land.Feb 11 2021, 10:50 AM
This revision was landed with ongoing or failed builds.Feb 15 2021, 2:33 AM
Closed by commit rGe54811ff7e0b: Restore diagnostic handler after CodeGenAction::ExecuteAction (authored by mantognini). · Explain Why
This revision was automatically updated to reflect the committed changes.
mantognini added a commit: rGe54811ff7e0b: Restore diagnostic handler after CodeGenAction::ExecuteAction.

Revision Contents
Changeset List

PathSize
clang/
lib/
CodeGen/
8 lines
llvm/
include/
llvm/
IR/
11 lines

Diff 322944

View Options

clang/lib/CodeGen/CodeGenAction.cpp

Loading...
View Options

llvm/include/llvm/IR/LLVMContext.h

Loading...