Page MenuHomePhabricator

xur (Rong Xu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2015, 4:19 PM (353 w, 1 d)

Recent Activity

Apr 7 2022

xur added a comment to D123323: Adds diagnostics for missing opportunities of indirect call promotion..

Also, adding a test would be helpful.

Apr 7 2022, 10:51 AM · Restricted Project, Restricted Project

Mar 8 2022

xur committed rG1712254b3f4d: [SampleFDO] Allow multiple of --enable-fs-discrimintor option [NFC] (authored by xur).
[SampleFDO] Allow multiple of --enable-fs-discrimintor option [NFC]
Mar 8 2022, 11:32 AM · Restricted Project

Feb 25 2022

xur committed rGccbbb4f6c716: [Sample-PGO] Emit FS discriminators only when -fdebug-info-for-profiling is set (authored by xur).
[Sample-PGO] Emit FS discriminators only when -fdebug-info-for-profiling is set
Feb 25 2022, 9:41 AM
xur closed D120536: [Sample-PGO] Emit FS discriminators only when -fdebug-info-for-profiling is set.
Feb 25 2022, 9:41 AM · Restricted Project

Feb 24 2022

xur added a comment to D120536: [Sample-PGO] Emit FS discriminators only when -fdebug-info-for-profiling is set.

Another way to do this is to check PGOOpt->DebugInfoForProfiling in TargetPassConfig before adding the passes.
That would be the same as IR level addDiscriminator.

Feb 24 2022, 9:54 PM · Restricted Project
xur requested review of D120536: [Sample-PGO] Emit FS discriminators only when -fdebug-info-for-profiling is set.
Feb 24 2022, 9:49 PM · Restricted Project

Feb 23 2022

xur added a comment to D120096: PGOInstrumentation, GCOVProfiling: Split indirectbr critical edges regardless of PHIs.

LGTM.
Thanks for this fix. I kind of know this (I used to have an assert to after calling SplitIndirectBrCriticalEdges(), but got rid of it because some cases it does return false).
Even this fix, there are still chance that we cannot split the edge.
Maybe we should emit a warning in this case.

Feb 23 2022, 2:52 PM · Restricted Project

Feb 22 2022

xur added a comment to D120295: [SampleProfile] [ICP] Handle the case when the option `MaxNumPromotions` is zero..

I think the reason MaxNumPromotion==0 breaks is likely the 0 size array think (like MaskRay mentioned).

Feb 22 2022, 3:14 PM · Restricted Project

Feb 5 2022

xur committed rG52d981a4c13a: [SampleFDO] Enable FSAFDO loading passes if --enable-fs-discriminator is enabled (authored by xur).
[SampleFDO] Enable FSAFDO loading passes if --enable-fs-discriminator is enabled
Feb 5 2022, 10:38 PM
xur closed D119033: [SampleFDO] Enable FSAFDO loading passes if --enable-fs-discriminator is enabled.
Feb 5 2022, 10:38 PM · Restricted Project

Feb 4 2022

xur requested review of D119033: [SampleFDO] Enable FSAFDO loading passes if --enable-fs-discriminator is enabled.
Feb 4 2022, 12:51 PM · Restricted Project

Dec 9 2021

xur committed rGad2e5be4bedd: [PGO] Adjust BFI verification option default values [NFC] (authored by xur).
[PGO] Adjust BFI verification option default values [NFC]
Dec 9 2021, 2:26 PM

Nov 23 2021

xur committed rGbf1138491a2b: [SampleFDO] Recompute BFI if the sample loader changes BPI (authored by xur).
[SampleFDO] Recompute BFI if the sample loader changes BPI
Nov 23 2021, 1:43 PM
xur closed D114400: [SampleFDO] Compute BFI if the sample loader changes BPI in FSAFDO.
Nov 23 2021, 1:42 PM · Restricted Project
xur accepted D113296: [FS-AFDO][llvm-profgen] Generate profile with FS-AFDO discriminator.

This looks good to me.

Nov 23 2021, 11:27 AM · Restricted Project

Nov 22 2021

xur requested review of D114400: [SampleFDO] Compute BFI if the sample loader changes BPI in FSAFDO.
Nov 22 2021, 2:32 PM · Restricted Project

Nov 18 2021

xur committed rGf2b5d81f62c7: [SampleFDO] Add pass name strings for the passes (NFC) (authored by xur).
[SampleFDO] Add pass name strings for the passes (NFC)
Nov 18 2021, 4:24 PM

Oct 19 2021

xur updated subscribers of D112042: [llvm-profgen] Skip duplication factor outside of body sample computation.

Sorry. I missed that part.

Oct 19 2021, 2:03 PM · Restricted Project

Oct 14 2021

xur committed rG21abe2128058: [TableGen][PGO] Disable profile instrumentation for printInstruction function (authored by xur).
[TableGen][PGO] Disable profile instrumentation for printInstruction function
Oct 14 2021, 1:43 PM
xur closed D111682: [TableGen][PGO] Disable profile instrumentation for printInstruction function.
Oct 14 2021, 1:43 PM · Restricted Project
xur updated the diff for D111682: [TableGen][PGO] Disable profile instrumentation for printInstruction function.

Integrated Reid's review comment.

Oct 14 2021, 12:20 PM · Restricted Project
xur added inline comments to D111682: [TableGen][PGO] Disable profile instrumentation for printInstruction function.
Oct 14 2021, 12:18 PM · Restricted Project
xur added inline comments to D111682: [TableGen][PGO] Disable profile instrumentation for printInstruction function.
Oct 14 2021, 12:14 PM · Restricted Project
xur added inline comments to D111682: [TableGen][PGO] Disable profile instrumentation for printInstruction function.
Oct 14 2021, 11:04 AM · Restricted Project

Oct 13 2021

xur updated the diff for D111682: [TableGen][PGO] Disable profile instrumentation for printInstruction function.

Reid: thanks for pointing out the error for MSC. I move the Macro definition to compiler.h.

Oct 13 2021, 3:44 PM · Restricted Project
xur added a comment to D111682: [TableGen][PGO] Disable profile instrumentation for printInstruction function.

Does it have the same issue with FE instrumentation? The only thing to consider here is the coverage test may be affected.

Oct 13 2021, 9:46 AM · Restricted Project

Oct 12 2021

xur requested review of D111682: [TableGen][PGO] Disable profile instrumentation for printInstruction function.
Oct 12 2021, 3:03 PM · Restricted Project

Sep 16 2021

xur added a comment to D108707: [SampleFDO] Set ProfileIsFS bit properly in extbinary format from the internal option.

Wei committed the FSAFDO tool part of change to GitHub yesterday. Sorry for
taking so long.

Sep 16 2021, 2:41 PM · Restricted Project

Sep 3 2021

xur committed rG6df09d6ccbc0: [SampleFDO] Fix -Wnon-virtual-dtor (authored by xur).
[SampleFDO] Fix -Wnon-virtual-dtor
Sep 3 2021, 12:22 PM

Aug 25 2021

xur committed rG24201b6437b2: [SampleFDO] Set ProfileIsFS bit properly from the internal option (authored by xur).
[SampleFDO] Set ProfileIsFS bit properly from the internal option
Aug 25 2021, 9:18 AM
xur closed D108707: [SampleFDO] Set ProfileIsFS bit properly in extbinary format from the internal option.
Aug 25 2021, 9:17 AM · Restricted Project
xur updated subscribers of D108707: [SampleFDO] Set ProfileIsFS bit properly in extbinary format from the internal option.

Thanks Wenlei for the fast response!

Aug 25 2021, 9:03 AM · Restricted Project
xur requested review of D108707: [SampleFDO] Set ProfileIsFS bit properly in extbinary format from the internal option.
Aug 25 2021, 8:35 AM · Restricted Project

Aug 24 2021

xur accepted D108603: [clang][codegen] Set CurLinkModule in CodeGenAction::ExecuteAction.

Thanks for fix this!
I like this fix and the patch looks good to me.

Aug 24 2021, 10:32 AM · Restricted Project
xur accepted D108432: [InstrProfiling] Keep profd non-private for non-renamable comdat functions.
Aug 24 2021, 9:43 AM · Restricted Project
xur committed rGde620f5b132b: [CSPGO] Fix lost IRPGOFlag in CSPGO instrumentation (authored by xur).
[CSPGO] Fix lost IRPGOFlag in CSPGO instrumentation
Aug 24 2021, 9:42 AM
xur closed D108581: [CSPGO] Fix lost IRPGOFlag in CSPGO instrumentation.
Aug 24 2021, 9:41 AM · Restricted Project

Aug 23 2021

xur added a comment to D108432: [InstrProfiling] Keep profd non-private for non-renamable comdat functions.

The problem you described is exactly what we wanted to solve with comdat renaming.
We had some correctness issues so I put many restrictions here. We have switched the default linker to lld
and linkage handling has evolved quite bit. I might revisit some of
the restrictions again, like if we can enable the renaming for weak linkage.

Aug 23 2021, 11:20 PM · Restricted Project
xur updated the diff for D108581: [CSPGO] Fix lost IRPGOFlag in CSPGO instrumentation.

Added a few comments to the test cases as suggested by Fangri.

Aug 23 2021, 6:15 PM · Restricted Project
xur updated the diff for D108581: [CSPGO] Fix lost IRPGOFlag in CSPGO instrumentation.

Thanks to Fangrui for the comments/suggestions.
Integrated his reviews to the patch.

Aug 23 2021, 5:39 PM · Restricted Project
xur added inline comments to D108581: [CSPGO] Fix lost IRPGOFlag in CSPGO instrumentation.
Aug 23 2021, 5:37 PM · Restricted Project
xur updated the summary of D108581: [CSPGO] Fix lost IRPGOFlag in CSPGO instrumentation.
Aug 23 2021, 4:59 PM · Restricted Project
xur added a comment to D108581: [CSPGO] Fix lost IRPGOFlag in CSPGO instrumentation.

Thanks for the patch. llvm.compiler.used does look better to me.


This happens in the module where IRPGOFlag is mard as non-prevailing

marked

Fixed

This is still problematic because we currently query this symbol to coordinate some actions B/W PGOInstrumentation and InstroProfiling lowering, like whether to do value profiling, weather to do comdat renaming.

Worth clarifying B/W.

InstruProfling

InstrProfiling

Fixed


I have confirmed that

In regular LTO, the non-prevailing variable is dropped unless its linkage weak_odr/linkonce_odr && -compute-dead=0
In ThinLTO, the variable is changed to available_external linkage by thinLTOResolvePrevailingGUID then dropped by GlobleOpt:deleteIfDead in the backend.

Thanks for confirming and put the conditions here

Aug 23 2021, 4:58 PM · Restricted Project
xur updated the summary of D108581: [CSPGO] Fix lost IRPGOFlag in CSPGO instrumentation.
Aug 23 2021, 4:56 PM · Restricted Project
xur updated subscribers of D107034: [CSPGO] Set module flag for CSPGO to avoid IRPGO value loss in LTO.

I sent my version of patch as https://reviews.llvm.org/D108581

Aug 23 2021, 1:40 PM · Restricted Project
xur requested review of D108581: [CSPGO] Fix lost IRPGOFlag in CSPGO instrumentation.
Aug 23 2021, 1:37 PM · Restricted Project
xur added a comment to D107034: [CSPGO] Set module flag for CSPGO to avoid IRPGO value loss in LTO.

@xur This is also reproducible using the existing test case PGOProfile/thinlto_cspgo_gen.ll. If evaluating the generated "%t.2.4.opt.bc" containing non-prevailing IRPGO flag, you will find the value is missed. (The value is still reserved in "%t.2.3.import.bc".)

In the LTO case, the symbol is dropped at *.preopt phase.

In summary after tracing:

  1. In LTO, the value is dropped when addRegularLTO as it has external linkage and non-prevailing.
  2. In ThinLTO, the value is first changed to available_external linkage by thinLTOResolvePrevailingInModule and thinLTOResolvePrevailingGUID. It is dropped later in the backend GlobleOpt pass by deleteIfDead.

Hence to keep the value we may need to identify the IRPGO variable in all above places, make sure it is reserved, and then drop it after instrumentation to avoid duplicate symbols in later linkage. My feeling is that using a module flag may avoid too much hassle across multiple places and more complexity to the symbol resolution stuff. (as suggested by Reid)
Agree that mixing EnableValueProfiling with IRPGO flag is improper as it seems Clang also may support value profiling (from comment of shouldRecordFunctionAddr ).
Maybe we can rename the module flag to "CSIRPGO"? We can also remove the flag after instrumentation as no need for later passes.

Aug 23 2021, 12:29 PM · Restricted Project

Aug 20 2021

xur added a comment to D108499: [clang][codegen] Don't assert on CurLinkModule for silenced diagnostic.

This looks fine to me. But I agree you that a more complete fix would be having CurLinkModule set for all callers.

Aug 20 2021, 6:19 PM · Restricted Project
xur added a comment to D107034: [CSPGO] Set module flag for CSPGO to avoid IRPGO value loss in LTO.

Sorry that I did not follow this patch closely. But after reading this I don't think this is a proper fix.

Aug 20 2021, 5:47 PM · Restricted Project
xur added a comment to D108364: Fix CodeGen/X86/fsafdo_test2.ll fail in release.

Thanks for the fix!

Aug 20 2021, 2:55 PM · Restricted Project

Aug 18 2021

xur committed rG5fdaaf7fd8f3: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader (authored by xur).
[SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader
Aug 18 2021, 6:45 PM
xur closed D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader.
Aug 18 2021, 6:44 PM · Restricted Project, Restricted Project
xur updated the diff for D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader.

Discussed with Wei offline: it's better to set fs profile loader as off by default so people can opt-in (rather opt-out).
Once we are done with more perf testing, we will switch the default to on.

Aug 18 2021, 2:07 PM · Restricted Project, Restricted Project
xur updated subscribers of D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader.

Yes. Resetting them will not cause correctness problems.

Aug 18 2021, 1:52 PM · Restricted Project, Restricted Project
xur updated the diff for D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader.

Fix some issues in last patch set.

Aug 18 2021, 11:54 AM · Restricted Project, Restricted Project
xur updated subscribers of D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader.

I just sent out the patch that puts PGOOptions to TargetMachine before
getting this message.
So EnableFSDiscriminator is not included.

Aug 18 2021, 10:14 AM · Restricted Project, Restricted Project
xur updated the diff for D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader.

Followed Wei's suggestion to put PGOOptions to TargetMachine.

Aug 18 2021, 9:57 AM · Restricted Project, Restricted Project

Aug 17 2021

xur added inline comments to D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader.
Aug 17 2021, 6:05 PM · Restricted Project, Restricted Project
xur updated the diff for D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader.

Integrated recent comments from Wei and Hongtao.

Aug 17 2021, 4:43 PM · Restricted Project, Restricted Project
xur added inline comments to D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader.
Aug 17 2021, 12:14 PM · Restricted Project, Restricted Project

Aug 16 2021

xur updated the diff for D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader.

Integrated review comments from Wei, Wenlei and Hongtao. Thanks for all the suggestions/comments!

Aug 16 2021, 4:26 PM · Restricted Project, Restricted Project
xur committed rG9b8425e42c25: Reapply commit b7425e956 (authored by xur).
Reapply commit b7425e956
Aug 16 2021, 12:19 PM
xur committed rGb7425e956be6: [NFC] Fix typos (authored by xur).
[NFC] Fix typos
Aug 16 2021, 10:47 AM

Aug 13 2021

xur added inline comments to D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader.
Aug 13 2021, 4:04 PM · Restricted Project, Restricted Project
xur added a comment to D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader.

Thanks all for the review comments! My replies are inlined.

Aug 13 2021, 1:04 PM · Restricted Project, Restricted Project

Aug 12 2021

xur added inline comments to D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader.
Aug 12 2021, 4:08 PM · Restricted Project, Restricted Project

Aug 11 2021

xur committed rG4c5909ba8303: [SampleFDO] Add two passes of MIRAddFSDiscriminatorsPass (authored by xur).
[SampleFDO] Add two passes of MIRAddFSDiscriminatorsPass
Aug 11 2021, 11:12 AM
xur closed D104579: [SampleFDO] Add two passes of MIRAddFSDiscriminatorsPass.
Aug 11 2021, 11:11 AM · Restricted Project
xur added inline comments to D104579: [SampleFDO] Add two passes of MIRAddFSDiscriminatorsPass.
Aug 11 2021, 10:49 AM · Restricted Project

Aug 10 2021

xur requested review of D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader.
Aug 10 2021, 9:59 PM · Restricted Project, Restricted Project
xur updated the diff for D104579: [SampleFDO] Add two passes of MIRAddFSDiscriminatorsPass.

Add another pass berfore RA (as suggested by WenLei).
I tested the performance for FSAFDO Loader using one google benchmark.
This extra pass turns to be positive in performance -- I'm seeing additional 0.6% - 0.8% improvement.

Aug 10 2021, 10:52 AM · Restricted Project

Jun 21 2021

xur added a comment to D104579: [SampleFDO] Add two passes of MIRAddFSDiscriminatorsPass.

This might just be specific to our deployment. Our AFDO optimized build
uses the profile generated in the previous release.
If we hold this Pass1 discriminator change and commit together with the FS
profile change. We won't see the FSAFDO performance in the release right
after -- we need to wait for another release to get all the samples with
Pass1 discriminations.

-Rong

Thanks for clarification, makes sense.

Sounds like your production usage is going to have one FS-Disc pass before block layout. And if we add more FS-Disc pass, say before RA, or others, it's not worth it?

That's a good suggestion. I haven't tried to experiment with one pass before RA. I know that the one before block placement will the performance. I also tried add one after block-placement but did not gain much.
Let me do some experiments and report back.

Another aspect of this change is that we want to do this more conservatively. We have many SampleFDO targets and we don't want to commit too much changes in the initial flip ( to minimize compile time, memory usage impact). We prefer to do this step by step.

Incremental approach sounds reasonable. Was just curious whether you have tried other passes and see no improvements.

Looks like FS-AFDO changes are mostly in tree now though the profile generation part for FS profile is still outside of llvm (in your create_llvm_prof tool), right? Otherwise, we can give it a try too.

Jun 21 2021, 2:52 PM · Restricted Project
xur committed rG8c68eb83065c: [SampleFDO] Make FSDiscriminator flag part of function parameters (authored by xur).
[SampleFDO] Make FSDiscriminator flag part of function parameters
Jun 21 2021, 2:38 PM
xur closed D104584: [SampleFDO] Make FSDiscriminator flag part of function parameters.
Jun 21 2021, 2:38 PM · Restricted Project
xur updated the diff for D104584: [SampleFDO] Make FSDiscriminator flag part of function parameters.

Integrated Wenlei's suggestion to remove the redundant interface.

Jun 21 2021, 1:04 PM · Restricted Project
xur added a comment to D104431: [LTO][lld] Add lto-pgo-warn-mismatch option.

CSPGO can have mismatches -- it's just like PGO that is triggered by a source change, or a compiler change (before the pass).
Usually if there is a mismatch, PGO use pass will catch it first. There are cases that PGO has no-mismatch while CSPGO has a mismatch, but I consider it extremely rare.

Jun 21 2021, 12:06 PM · Restricted Project
xur added inline comments to D104584: [SampleFDO] Make FSDiscriminator flag part of function parameters.
Jun 21 2021, 10:31 AM · Restricted Project

Jun 20 2021

xur updated the diff for D104584: [SampleFDO] Make FSDiscriminator flag part of function parameters.

Sent a wrong patch.
This is the patch I wanted to send for review.

Jun 20 2021, 10:48 PM · Restricted Project
xur added a comment to D104579: [SampleFDO] Add two passes of MIRAddFSDiscriminatorsPass.

This might just be specific to our deployment. Our AFDO optimized build
uses the profile generated in the previous release.
If we hold this Pass1 discriminator change and commit together with the FS
profile change. We won't see the FSAFDO performance in the release right
after -- we need to wait for another release to get all the samples with
Pass1 discriminations.

-Rong

Thanks for clarification, makes sense.

Sounds like your production usage is going to have one FS-Disc pass before block layout. And if we add more FS-Disc pass, say before RA, or others, it's not worth it?

Jun 20 2021, 10:46 PM · Restricted Project

Jun 18 2021

xur requested review of D104584: [SampleFDO] Make FSDiscriminator flag part of function parameters.
Jun 18 2021, 6:19 PM · Restricted Project
xur added a comment to D104579: [SampleFDO] Add two passes of MIRAddFSDiscriminatorsPass.

This might just be specific to our deployment. Our AFDO optimized build
uses the profile generated in the previous release.
If we hold this Pass1 discriminator change and commit together with the FS
profile change. We won't see the FSAFDO performance in the release right
after -- we need to wait for another release to get all the samples with
Pass1 discriminations.

Jun 18 2021, 6:15 PM · Restricted Project
xur requested review of D104579: [SampleFDO] Add two passes of MIRAddFSDiscriminatorsPass.
Jun 18 2021, 4:29 PM · Restricted Project

Jun 15 2021

xur committed rG82a0bb1afc29: [SampleFDO] Place the discriminator flag variable into the used list. (authored by xur).
[SampleFDO] Place the discriminator flag variable into the used list.
Jun 15 2021, 9:52 PM
xur added a reverting change for rG434fed5aff5e: [SampleFDO] Using common linkage for the discriminator flag variable: rG95f9026c1788: Revert "[SampleFDO] Using common linkage for the discriminator flag variable".
Jun 15 2021, 9:24 PM
xur committed rG95f9026c1788: Revert "[SampleFDO] Using common linkage for the discriminator flag variable" (authored by xur).
Revert "[SampleFDO] Using common linkage for the discriminator flag variable"
Jun 15 2021, 9:24 PM
xur added a reverting change for D103988: SampleFDO] place the discriminator flag variable into the used list.: rG95f9026c1788: Revert "[SampleFDO] Using common linkage for the discriminator flag variable".
Jun 15 2021, 9:24 PM · Restricted Project
xur added a comment to D103988: SampleFDO] place the discriminator flag variable into the used list..

CommonLinkage doesn't work.

Whether appendToUsed is needed depends on whether the runtime has a live section referencing __llvm_fs_discriminator__.
If the runtime has the guarantee, no need for appendToUsed.

Otherwise, the first revision appendToUsed with WeakODRLinkage looks good to me.

appendToUsed with ExternalLinkage in a comdat works as well, but comdat will need extra code when Mach-O wants this feature.

Jun 15 2021, 4:58 PM · Restricted Project
xur added a comment to D103988: SampleFDO] place the discriminator flag variable into the used list..

@Fangrui: My initial version was to place it into the use list. But Hoy
suggested that I use CommonLinage.
From llvm reference manual, it seems that linker should GC a common symbol.
Can you read the message and add comments there?
https://reviews.llvm.org/D103988

Jun 15 2021, 4:25 PM · Restricted Project
xur committed rG434fed5aff5e: [SampleFDO] Using common linkage for the discriminator flag variable (authored by xur).
[SampleFDO] Using common linkage for the discriminator flag variable
Jun 15 2021, 2:55 PM
xur closed D103988: SampleFDO] place the discriminator flag variable into the used list..
Jun 15 2021, 2:55 PM · Restricted Project

Jun 11 2021

xur updated the diff for D103988: SampleFDO] place the discriminator flag variable into the used list..
Jun 11 2021, 1:33 PM · Restricted Project
xur added inline comments to D103988: SampleFDO] place the discriminator flag variable into the used list..
Jun 11 2021, 1:28 PM · Restricted Project

Jun 9 2021

xur requested review of D103988: SampleFDO] place the discriminator flag variable into the used list..
Jun 9 2021, 1:02 PM · Restricted Project

Jun 4 2021

xur committed rG8d581857d771: [SampleFDO] New hierarchical discriminator for FS SampleFDO (llvm-profdata part) (authored by xur).
[SampleFDO] New hierarchical discriminator for FS SampleFDO (llvm-profdata part)
Jun 4 2021, 11:22 AM
xur closed D103550: [SampleFDO] New hierarchical discriminator for FS SampleFDO (llvm-profdata part).
Jun 4 2021, 11:22 AM · Restricted Project
xur updated the diff for D103550: [SampleFDO] New hierarchical discriminator for FS SampleFDO (llvm-profdata part).

Integrated Hongtao's suggestion to move setDiscriminatorMaskedBitFrom() to SampleProfileReader::create()

Jun 4 2021, 10:04 AM · Restricted Project
xur added inline comments to D103550: [SampleFDO] New hierarchical discriminator for FS SampleFDO (llvm-profdata part).
Jun 4 2021, 9:21 AM · Restricted Project

Jun 3 2021

xur updated the diff for D103550: [SampleFDO] New hierarchical discriminator for FS SampleFDO (llvm-profdata part).

Per Wei's suggestion, using enum option.

Jun 3 2021, 11:22 AM · Restricted Project
xur added inline comments to D103550: [SampleFDO] New hierarchical discriminator for FS SampleFDO (llvm-profdata part).
Jun 3 2021, 11:13 AM · Restricted Project

Jun 2 2021

xur requested review of D103550: [SampleFDO] New hierarchical discriminator for FS SampleFDO (llvm-profdata part).
Jun 2 2021, 12:23 PM · Restricted Project