Page MenuHomePhabricator

xur (Rong Xu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2015, 4:19 PM (200 w, 5 d)

Recent Activity

Mon, Jun 10

xur committed rG7ea131c20c11: [PGO] Fix the buildbot failure in r362995 (authored by xur).
[PGO] Fix the buildbot failure in r362995
Mon, Jun 10, 4:17 PM
xur committed rL363004: [PGO] Fix the buildbot failure in r362995.
[PGO] Fix the buildbot failure in r362995
Mon, Jun 10, 4:16 PM
xur committed rGe44fa83c3744: [PGO] Handle cases of non-instrument BBs (authored by xur).
[PGO] Handle cases of non-instrument BBs
Mon, Jun 10, 3:34 PM
xur committed rL362995: [PGO] Handle cases of non-instrument BBs.
[PGO] Handle cases of non-instrument BBs
Mon, Jun 10, 3:34 PM
xur closed D62700: [PGO] Handle cases of non-instrument BBs.
Mon, Jun 10, 3:34 PM · Restricted Project
xur updated the diff for D62700: [PGO] Handle cases of non-instrument BBs.

Integrated David's review suggestions.

Mon, Jun 10, 2:55 PM · Restricted Project
xur added a comment to D62700: [PGO] Handle cases of non-instrument BBs.

This can be handled this way:

BBInfo &SrcInfo = getBBInfo(SrcBB);    // BBInfo is the template type
BBInfo &DestInfo = getBBInfo(DestBB);
SrcInfo.addOutEdge(E.get());
DestInfo.addInEdge(E.get());

For base class BBInfo, addOutEdge, addInEdge will be empty, while it is defined for UseBBInfo class.

By so doing, the code is more readable.

Mon, Jun 10, 2:55 PM · Restricted Project
xur added inline comments to D62700: [PGO] Handle cases of non-instrument BBs.
Mon, Jun 10, 10:25 AM · Restricted Project
xur added inline comments to D62700: [PGO] Handle cases of non-instrument BBs.
Mon, Jun 10, 9:47 AM · Restricted Project

Fri, Jun 7

xur added inline comments to D62700: [PGO] Handle cases of non-instrument BBs.
Fri, Jun 7, 10:33 AM · Restricted Project
xur added inline comments to D62700: [PGO] Handle cases of non-instrument BBs.
Fri, Jun 7, 10:18 AM · Restricted Project

Mon, Jun 3

xur updated the diff for D62700: [PGO] Handle cases of non-instrument BBs.

My previous patch was not complete -- we need to set the profile count to the fail-to-instrument edge. Otherwise, we cannot propagate the counts in the CFG.
The new patch has this part of change.
Updated the test to test the profile-use.

Mon, Jun 3, 10:17 AM · Restricted Project

Thu, May 30

xur added a comment to D62700: [PGO] Handle cases of non-instrument BBs.

Another change of this patch is to move down statistic collection code for critical edge. I think this is a better place.

Thu, May 30, 1:53 PM · Restricted Project
xur created D62700: [PGO] Handle cases of non-instrument BBs.
Thu, May 30, 1:53 PM · Restricted Project
xur accepted D62430: [PPC] Correctly adjust branch probability in PPCReduceCRLogicals.

looks good to me.

Thu, May 30, 10:52 AM · Restricted Project

Tue, May 28

xur added inline comments to D62430: [PPC] Correctly adjust branch probability in PPCReduceCRLogicals.
Tue, May 28, 3:46 PM · Restricted Project
xur committed rGe88173abc01b: [PGO] Handle cases of failing to split critical edges (authored by xur).
[PGO] Handle cases of failing to split critical edges
Tue, May 28, 2:45 PM
xur committed rL361882: [PGO] Handle cases of failing to split critical edges.
[PGO] Handle cases of failing to split critical edges
Tue, May 28, 2:44 PM
xur closed D62439: PGO] Handle cases of failing to split critical edges.
Tue, May 28, 2:44 PM · Restricted Project
xur updated the diff for D62439: PGO] Handle cases of failing to split critical edges.

Fix comments suggested by David.

Tue, May 28, 10:49 AM · Restricted Project
xur updated the diff for D62439: PGO] Handle cases of failing to split critical edges.

Integrated comments from Noel and David.

Tue, May 28, 9:11 AM · Restricted Project
xur added inline comments to D62439: PGO] Handle cases of failing to split critical edges.
Tue, May 28, 9:04 AM · Restricted Project

May 24 2019

xur created D62439: PGO] Handle cases of failing to split critical edges.
May 24 2019, 5:12 PM · Restricted Project

May 20 2019

xur added inline comments to D61540: [PGO] Use sum of count values to fix func entry count and add a check to verify BFI counts.
May 20 2019, 4:00 PM · Restricted Project

May 3 2019

xur created D61540: [PGO] Use sum of count values to fix func entry count and add a check to verify BFI counts.
May 3 2019, 2:31 PM · Restricted Project

Apr 30 2019

xur committed rGb1f9577a5fdd: [llvm-profdata] Fix indentation error in docs. NFC. (authored by xur).
[llvm-profdata] Fix indentation error in docs. NFC.
Apr 30 2019, 3:37 PM
xur committed rL359625: [llvm-profdata] Fix indentation error in docs. NFC..
[llvm-profdata] Fix indentation error in docs. NFC.
Apr 30 2019, 3:33 PM
xur committed rG287908f9c867: [llvm-profdata] Fix indentation error. NFC (authored by xur).
[llvm-profdata] Fix indentation error. NFC
Apr 30 2019, 3:06 PM
xur committed rL359619: [llvm-profdata] Fix indentation error. NFC.
[llvm-profdata] Fix indentation error. NFC
Apr 30 2019, 3:02 PM
xur committed rG998b97f6f1fe: [llvm-profdata] Add overlap command to compute similarity b/w two profile files (authored by xur).
[llvm-profdata] Add overlap command to compute similarity b/w two profile files
Apr 30 2019, 2:19 PM
xur committed rL359612: [llvm-profdata] Add overlap command to compute similarity b/w two profile files.
[llvm-profdata] Add overlap command to compute similarity b/w two profile files
Apr 30 2019, 2:17 PM
xur closed D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files.
Apr 30 2019, 2:17 PM · Restricted Project

Apr 29 2019

xur updated the diff for D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files.

Adjusted the output string with David's comments.
Also made the naming more uniformed for edge and value profiles.

Apr 29 2019, 3:35 PM · Restricted Project
xur added inline comments to D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files.
Apr 29 2019, 3:12 PM · Restricted Project
xur updated the diff for D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files.

Discussed offline with David. We changed the output to a simpler: "Description: <Value>" format. This tool will mostly used in a script. Simpler format will make text grep cleaner.

Apr 29 2019, 12:32 PM · Restricted Project
xur updated the diff for D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files.

Integrated David's review comments

Apr 29 2019, 11:31 AM · Restricted Project
xur added inline comments to D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files.
Apr 29 2019, 10:41 AM · Restricted Project
xur added inline comments to D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files.
Apr 29 2019, 10:41 AM · Restricted Project

Apr 26 2019

xur updated the diff for D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files.

Integrated David's review comments. Mainly changed the reporting format.

Apr 26 2019, 11:00 AM · Restricted Project

Apr 25 2019

xur committed rGcef8481af013: [PGO] Fix buildbot failure in 359215 (authored by xur).
[PGO] Fix buildbot failure in 359215
Apr 25 2019, 2:16 PM
xur committed rC359241: [PGO] Fix buildbot failure in 359215.
[PGO] Fix buildbot failure in 359215
Apr 25 2019, 2:16 PM
xur committed rL359241: [PGO] Fix buildbot failure in 359215.
[PGO] Fix buildbot failure in 359215
Apr 25 2019, 2:15 PM
xur committed rG4059e143dc71: [PGO] Enable InstrProf lowering for Clang PGO instrumentation in the new pass… (authored by xur).
[PGO] Enable InstrProf lowering for Clang PGO instrumentation in the new pass…
Apr 25 2019, 10:51 AM
xur committed rL359215: [PGO] Enable InstrProf lowering for Clang PGO instrumentation in the new pass….
[PGO] Enable InstrProf lowering for Clang PGO instrumentation in the new pass…
Apr 25 2019, 10:51 AM
xur committed rC359215: [PGO] Enable InstrProf lowering for Clang PGO instrumentation in the new pass….
[PGO] Enable InstrProf lowering for Clang PGO instrumentation in the new pass…
Apr 25 2019, 10:51 AM
xur closed D61138: [PGO] Enable InstrProf lowering for Clang PGO instrumentation in the new pass manager.
Apr 25 2019, 10:51 AM · Restricted Project
xur created D61138: [PGO] Enable InstrProf lowering for Clang PGO instrumentation in the new pass manager.
Apr 25 2019, 10:05 AM · Restricted Project

Apr 24 2019

xur added inline comments to D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files.
Apr 24 2019, 3:05 PM · Restricted Project

Apr 23 2019

xur updated the diff for D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files.

Integrated David's review comments.

Apr 23 2019, 3:48 PM · Restricted Project
xur added inline comments to D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files.
Apr 23 2019, 3:44 PM · Restricted Project
xur accepted D61022: [ThinLTO] Pass down opt level to LTO backend and handle -O0 LTO in new PM.

LGTM. We need to Initialize the OptLevel no matter what.

Apr 23 2019, 10:48 AM · Restricted Project, Restricted Project

Apr 22 2019

xur updated the diff for D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files.

Removed some un-intended changes.

Apr 22 2019, 12:27 PM · Restricted Project
xur updated the diff for D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files.

Minor fix of the comments.

Apr 22 2019, 12:23 PM · Restricted Project
xur created D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files.
Apr 22 2019, 12:21 PM · Restricted Project

Apr 18 2019

xur committed rG4f471ee99098: [llvm-profdata] Fix one bad format in llvm-profdata CommandGuide doc. NFC (authored by xur).
[llvm-profdata] Fix one bad format in llvm-profdata CommandGuide doc. NFC
Apr 18 2019, 12:13 AM
xur committed rL358643: [llvm-profdata] Fix one bad format in llvm-profdata CommandGuide doc. NFC.
[llvm-profdata] Fix one bad format in llvm-profdata CommandGuide doc. NFC
Apr 18 2019, 12:13 AM

Apr 11 2019

xur committed rG959ef1685979: [PGO] Better handling of profile hash mismatch (authored by xur).
[PGO] Better handling of profile hash mismatch
Apr 11 2019, 1:56 PM
xur committed rL358225: [PGO] Better handling of profile hash mismatch.
[PGO] Better handling of profile hash mismatch
Apr 11 2019, 1:52 PM
xur closed D60154: [PGO] Better handling of profile hash mismatch.
Apr 11 2019, 1:52 PM · Restricted Project

Apr 10 2019

xur updated the diff for D60154: [PGO] Better handling of profile hash mismatch.

Integrated David's comments.

Apr 10 2019, 12:22 PM · Restricted Project
xur added inline comments to D60154: [PGO] Better handling of profile hash mismatch.
Apr 10 2019, 10:25 AM · Restricted Project

Apr 2 2019

xur added inline comments to D54175: [PGO] context sensitive PGO.
Apr 2 2019, 2:51 PM · Restricted Project
xur created D60154: [PGO] Better handling of profile hash mismatch.
Apr 2 2019, 2:51 PM · Restricted Project

Mar 12 2019

xur added a comment to D56675: [lld] add options for context-sensitive PGO..

Are there any bugs/reviews/etc. that I can subscribe to for the implementation of this in COFF?

Mar 12 2019, 10:50 AM · Restricted Project

Mar 11 2019

xur committed rGf92e59cbba59: [PGO] Add options for context-sensitive PGO (authored by xur).
[PGO] Add options for context-sensitive PGO
Mar 11 2019, 3:53 PM
xur committed rLLD355876: [PGO] Add options for context-sensitive PGO.
[PGO] Add options for context-sensitive PGO
Mar 11 2019, 3:53 PM
xur committed rL355876: [PGO] Add options for context-sensitive PGO.
[PGO] Add options for context-sensitive PGO
Mar 11 2019, 3:53 PM
xur closed D56675: [lld] add options for context-sensitive PGO..
Mar 11 2019, 3:53 PM · Restricted Project
xur updated the diff for D56675: [lld] add options for context-sensitive PGO..

Integrated Ruiu's review comments.

Mar 11 2019, 3:31 PM · Restricted Project
xur added a comment to D56675: [lld] add options for context-sensitive PGO..

Ping.

Mar 11 2019, 2:32 PM · Restricted Project

Mar 8 2019

xur committed rGce3be45cacc1: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst (authored by xur).
[CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst
Mar 8 2019, 2:49 PM
xur committed rL355751: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.
[CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst
Mar 8 2019, 2:48 PM
xur closed D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.
Mar 8 2019, 2:48 PM · Restricted Project
xur updated the diff for D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.

using utils/update_test_checks.py to generate the test checks.

Mar 8 2019, 1:57 PM · Restricted Project
xur updated the diff for D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.

changed test case based on spatel's comments.

Mar 8 2019, 11:39 AM · Restricted Project
xur updated the diff for D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.

add one missing updates in last version of the patch.

Mar 8 2019, 10:33 AM · Restricted Project
xur added inline comments to D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.
Mar 8 2019, 10:32 AM · Restricted Project
xur updated the diff for D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.

Integrated Teresa's comments.

Mar 8 2019, 10:15 AM · Restricted Project
xur added inline comments to D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.
Mar 8 2019, 10:11 AM · Restricted Project
xur created D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.
Mar 8 2019, 9:49 AM · Restricted Project

Mar 6 2019

xur committed rG10454dcc6a80: [PGO] Re-submit: Clang part of change for context-sensitive PGO (part2) (authored by xur).
[PGO] Re-submit: Clang part of change for context-sensitive PGO (part2)
Mar 6 2019, 3:00 PM
xur committed rC355563: [PGO] Re-submit: Clang part of change for context-sensitive PGO (part2).
[PGO] Re-submit: Clang part of change for context-sensitive PGO (part2)
Mar 6 2019, 3:00 PM
xur committed rL355563: [PGO] Re-submit: Clang part of change for context-sensitive PGO (part2).
[PGO] Re-submit: Clang part of change for context-sensitive PGO (part2)
Mar 6 2019, 3:00 PM
xur committed rG3ee1524afc63: [PGO] Fix hexagon buildbot errors in r355541 (authored by xur).
[PGO] Fix hexagon buildbot errors in r355541
Mar 6 2019, 2:18 PM
xur committed rL355556: [PGO] Fix hexagon buildbot errors in r355541.
[PGO] Fix hexagon buildbot errors in r355541
Mar 6 2019, 2:15 PM
xur committed rG05c0afe842cf: [PGO] Context sensitive PGO (part 4) (authored by xur).
[PGO] Context sensitive PGO (part 4)
Mar 6 2019, 11:33 AM
xur committed rL355541: [PGO] Context sensitive PGO (part 4).
[PGO] Context sensitive PGO (part 4)
Mar 6 2019, 11:33 AM

Mar 5 2019

xur committed rG1d8d6373ec2e: Revert r355432 for buildbot failures in ppc64be-linux and s390x-linux (authored by xur).
Revert r355432 for buildbot failures in ppc64be-linux and s390x-linux
Mar 5 2019, 3:03 PM
xur committed rL355454: Revert r355432 for buildbot failures in ppc64be-linux and s390x-linux.
Revert r355432 for buildbot failures in ppc64be-linux and s390x-linux
Mar 5 2019, 3:03 PM
xur committed rC355454: Revert r355432 for buildbot failures in ppc64be-linux and s390x-linux.
Revert r355432 for buildbot failures in ppc64be-linux and s390x-linux
Mar 5 2019, 3:03 PM
xur added inline comments to D56675: [lld] add options for context-sensitive PGO..
Mar 5 2019, 11:46 AM · Restricted Project
xur committed rG7c03c58af629: [PGO] Clang part of change for context-sensitive PGO (part2) (authored by xur).
[PGO] Clang part of change for context-sensitive PGO (part2)
Mar 5 2019, 11:09 AM
xur committed rC355432: [PGO] Clang part of change for context-sensitive PGO (part2).
[PGO] Clang part of change for context-sensitive PGO (part2)
Mar 5 2019, 11:09 AM
xur committed rL355432: [PGO] Clang part of change for context-sensitive PGO (part2).
[PGO] Clang part of change for context-sensitive PGO (part2)
Mar 5 2019, 11:09 AM
xur added inline comments to D56675: [lld] add options for context-sensitive PGO..
Mar 5 2019, 10:57 AM · Restricted Project

Mar 4 2019

xur committed rGa4a09b23983c: [PGO] Clang part of change for context-sensitive PGO (part1) (authored by xur).
[PGO] Clang part of change for context-sensitive PGO (part1)
Mar 4 2019, 12:22 PM
xur committed rGdb29a3a438d5: [PGO] Context sensitive PGO (part 3) (authored by xur).
[PGO] Context sensitive PGO (part 3)
Mar 4 2019, 12:21 PM
xur committed rL355331: [PGO] Clang part of change for context-sensitive PGO (part1).
[PGO] Clang part of change for context-sensitive PGO (part1)
Mar 4 2019, 12:21 PM
xur committed rL355330: [PGO] Context sensitive PGO (part 3).
[PGO] Context sensitive PGO (part 3)
Mar 4 2019, 12:21 PM
xur committed rC355331: [PGO] Clang part of change for context-sensitive PGO (part1).
[PGO] Clang part of change for context-sensitive PGO (part1)
Mar 4 2019, 12:21 PM