Page MenuHomePhabricator

xur (Rong Xu)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2015, 4:19 PM (191 w, 15 h)

Recent Activity

Yesterday

xur committed rG4f471ee99098: [llvm-profdata] Fix one bad format in llvm-profdata CommandGuide doc. NFC (authored by xur).
[llvm-profdata] Fix one bad format in llvm-profdata CommandGuide doc. NFC
Thu, Apr 18, 12:13 AM
xur committed rL358643: [llvm-profdata] Fix one bad format in llvm-profdata CommandGuide doc. NFC.
[llvm-profdata] Fix one bad format in llvm-profdata CommandGuide doc. NFC
Thu, Apr 18, 12:13 AM

Thu, Apr 11

xur committed rG959ef1685979: [PGO] Better handling of profile hash mismatch (authored by xur).
[PGO] Better handling of profile hash mismatch
Thu, Apr 11, 1:56 PM
xur committed rL358225: [PGO] Better handling of profile hash mismatch.
[PGO] Better handling of profile hash mismatch
Thu, Apr 11, 1:52 PM
xur closed D60154: [PGO] Better handling of profile hash mismatch.
Thu, Apr 11, 1:52 PM · Restricted Project

Wed, Apr 10

xur updated the diff for D60154: [PGO] Better handling of profile hash mismatch.

Integrated David's comments.

Wed, Apr 10, 12:22 PM · Restricted Project
xur added inline comments to D60154: [PGO] Better handling of profile hash mismatch.
Wed, Apr 10, 10:25 AM · Restricted Project

Tue, Apr 2

xur added inline comments to D54175: [PGO] context sensitive PGO.
Tue, Apr 2, 2:51 PM · Restricted Project
xur created D60154: [PGO] Better handling of profile hash mismatch.
Tue, Apr 2, 2:51 PM · Restricted Project

Mar 12 2019

xur added a comment to D56675: [lld] add options for context-sensitive PGO..

Are there any bugs/reviews/etc. that I can subscribe to for the implementation of this in COFF?

Mar 12 2019, 10:50 AM · Restricted Project

Mar 11 2019

xur committed rGf92e59cbba59: [PGO] Add options for context-sensitive PGO (authored by xur).
[PGO] Add options for context-sensitive PGO
Mar 11 2019, 3:53 PM
xur committed rLLD355876: [PGO] Add options for context-sensitive PGO.
[PGO] Add options for context-sensitive PGO
Mar 11 2019, 3:53 PM
xur committed rL355876: [PGO] Add options for context-sensitive PGO.
[PGO] Add options for context-sensitive PGO
Mar 11 2019, 3:53 PM
xur closed D56675: [lld] add options for context-sensitive PGO..
Mar 11 2019, 3:53 PM · Restricted Project
xur updated the diff for D56675: [lld] add options for context-sensitive PGO..

Integrated Ruiu's review comments.

Mar 11 2019, 3:31 PM · Restricted Project
xur added a comment to D56675: [lld] add options for context-sensitive PGO..

Ping.

Mar 11 2019, 2:32 PM · Restricted Project

Mar 8 2019

xur committed rGce3be45cacc1: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst (authored by xur).
[CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst
Mar 8 2019, 2:49 PM
xur committed rL355751: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.
[CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst
Mar 8 2019, 2:48 PM
xur closed D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.
Mar 8 2019, 2:48 PM · Restricted Project
xur updated the diff for D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.

using utils/update_test_checks.py to generate the test checks.

Mar 8 2019, 1:57 PM · Restricted Project
xur updated the diff for D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.

changed test case based on spatel's comments.

Mar 8 2019, 11:39 AM · Restricted Project
xur updated the diff for D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.

add one missing updates in last version of the patch.

Mar 8 2019, 10:33 AM · Restricted Project
xur added inline comments to D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.
Mar 8 2019, 10:32 AM · Restricted Project
xur updated the diff for D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.

Integrated Teresa's comments.

Mar 8 2019, 10:15 AM · Restricted Project
xur added inline comments to D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.
Mar 8 2019, 10:11 AM · Restricted Project
xur created D59139: [CodeGenPrepare] Fix ModifiedDT flag in optimizeSelectInst.
Mar 8 2019, 9:49 AM · Restricted Project

Mar 6 2019

xur committed rG10454dcc6a80: [PGO] Re-submit: Clang part of change for context-sensitive PGO (part2) (authored by xur).
[PGO] Re-submit: Clang part of change for context-sensitive PGO (part2)
Mar 6 2019, 3:00 PM
xur committed rC355563: [PGO] Re-submit: Clang part of change for context-sensitive PGO (part2).
[PGO] Re-submit: Clang part of change for context-sensitive PGO (part2)
Mar 6 2019, 3:00 PM
xur committed rL355563: [PGO] Re-submit: Clang part of change for context-sensitive PGO (part2).
[PGO] Re-submit: Clang part of change for context-sensitive PGO (part2)
Mar 6 2019, 3:00 PM
xur committed rG3ee1524afc63: [PGO] Fix hexagon buildbot errors in r355541 (authored by xur).
[PGO] Fix hexagon buildbot errors in r355541
Mar 6 2019, 2:18 PM
xur committed rL355556: [PGO] Fix hexagon buildbot errors in r355541.
[PGO] Fix hexagon buildbot errors in r355541
Mar 6 2019, 2:15 PM
xur committed rG05c0afe842cf: [PGO] Context sensitive PGO (part 4) (authored by xur).
[PGO] Context sensitive PGO (part 4)
Mar 6 2019, 11:33 AM
xur committed rL355541: [PGO] Context sensitive PGO (part 4).
[PGO] Context sensitive PGO (part 4)
Mar 6 2019, 11:33 AM

Mar 5 2019

xur committed rG1d8d6373ec2e: Revert r355432 for buildbot failures in ppc64be-linux and s390x-linux (authored by xur).
Revert r355432 for buildbot failures in ppc64be-linux and s390x-linux
Mar 5 2019, 3:03 PM
xur committed rL355454: Revert r355432 for buildbot failures in ppc64be-linux and s390x-linux.
Revert r355432 for buildbot failures in ppc64be-linux and s390x-linux
Mar 5 2019, 3:03 PM
xur committed rC355454: Revert r355432 for buildbot failures in ppc64be-linux and s390x-linux.
Revert r355432 for buildbot failures in ppc64be-linux and s390x-linux
Mar 5 2019, 3:03 PM
xur added inline comments to D56675: [lld] add options for context-sensitive PGO..
Mar 5 2019, 11:46 AM · Restricted Project
xur committed rG7c03c58af629: [PGO] Clang part of change for context-sensitive PGO (part2) (authored by xur).
[PGO] Clang part of change for context-sensitive PGO (part2)
Mar 5 2019, 11:09 AM
xur committed rC355432: [PGO] Clang part of change for context-sensitive PGO (part2).
[PGO] Clang part of change for context-sensitive PGO (part2)
Mar 5 2019, 11:09 AM
xur committed rL355432: [PGO] Clang part of change for context-sensitive PGO (part2).
[PGO] Clang part of change for context-sensitive PGO (part2)
Mar 5 2019, 11:09 AM
xur added inline comments to D56675: [lld] add options for context-sensitive PGO..
Mar 5 2019, 10:57 AM · Restricted Project

Mar 4 2019

xur committed rGa4a09b23983c: [PGO] Clang part of change for context-sensitive PGO (part1) (authored by xur).
[PGO] Clang part of change for context-sensitive PGO (part1)
Mar 4 2019, 12:22 PM
xur committed rGdb29a3a438d5: [PGO] Context sensitive PGO (part 3) (authored by xur).
[PGO] Context sensitive PGO (part 3)
Mar 4 2019, 12:21 PM
xur committed rL355331: [PGO] Clang part of change for context-sensitive PGO (part1).
[PGO] Clang part of change for context-sensitive PGO (part1)
Mar 4 2019, 12:21 PM
xur committed rL355330: [PGO] Context sensitive PGO (part 3).
[PGO] Context sensitive PGO (part 3)
Mar 4 2019, 12:21 PM
xur committed rC355331: [PGO] Clang part of change for context-sensitive PGO (part1).
[PGO] Clang part of change for context-sensitive PGO (part1)
Mar 4 2019, 12:21 PM
xur closed D54176: [PGO] clang part of change for context-sensitive PGO..
Mar 4 2019, 12:21 PM · Restricted Project
xur updated the diff for D54176: [PGO] clang part of change for context-sensitive PGO..

Added usage example to UserManual.rst suggested by David.

Mar 4 2019, 10:50 AM · Restricted Project

Mar 1 2019

xur updated the diff for D54176: [PGO] clang part of change for context-sensitive PGO..

Integrated Teresa's suggestion to change the err() to assert.
Added documentation change suggested by David.

Mar 1 2019, 12:07 PM · Restricted Project
xur committed rG06ed38517e68: [PGO] Remove the default parameter in ProfileSummary API. NFC (authored by xur).
[PGO] Remove the default parameter in ProfileSummary API. NFC
Mar 1 2019, 10:36 AM
xur committed rL355216: [PGO] Remove the default parameter in ProfileSummary API. NFC.
[PGO] Remove the default parameter in ProfileSummary API. NFC
Mar 1 2019, 10:36 AM
xur committed rG39f6d7e6160b: [PGO] Use the explicit parameter in ProfileSummary API. NFC (authored by xur).
[PGO] Use the explicit parameter in ProfileSummary API. NFC
Mar 1 2019, 9:50 AM
xur committed rC355209: [PGO] Use the explicit parameter in ProfileSummary API. NFC.
[PGO] Use the explicit parameter in ProfileSummary API. NFC
Mar 1 2019, 9:50 AM
xur committed rL355209: [PGO] Use the explicit parameter in ProfileSummary API. NFC.
[PGO] Use the explicit parameter in ProfileSummary API. NFC
Mar 1 2019, 9:49 AM

Feb 28 2019

xur committed rGa6ff69f6ddf9: [PGO] Context sensitive PGO (part 2) (authored by xur).
[PGO] Context sensitive PGO (part 2)
Feb 28 2019, 11:56 AM
xur committed rL355131: [PGO] Context sensitive PGO (part 2).
[PGO] Context sensitive PGO (part 2)
Feb 28 2019, 11:55 AM
xur committed rG23452e1c85ce: [PGO] Update InstrProfData.inc to sync with llvm (authored by xur).
[PGO] Update InstrProfData.inc to sync with llvm
Feb 28 2019, 11:06 AM
xur committed rCRT355119: [PGO] Update InstrProfData.inc to sync with llvm.
[PGO] Update InstrProfData.inc to sync with llvm
Feb 28 2019, 11:06 AM
xur committed rL355119: [PGO] Update InstrProfData.inc to sync with llvm.
[PGO] Update InstrProfData.inc to sync with llvm
Feb 28 2019, 11:06 AM

Feb 27 2019

xur accepted D58737: [InstrProf] Use separate comdat group for data and counters.

BTW, I'm in the process of committing D54175. After that patch, PGO instrumentation can be called after the main inlining. I don't think it will conflict anything in this patch

Feb 27 2019, 3:18 PM · Restricted Project, Restricted Project, Restricted Project
xur added inline comments to D58737: [InstrProf] Use separate comdat group for data and counters.
Feb 27 2019, 2:51 PM · Restricted Project, Restricted Project, Restricted Project
xur committed rGac552f77f4a0: Fixed ubsan failures in r355005. (authored by xur).
Fixed ubsan failures in r355005.
Feb 27 2019, 12:02 PM
xur committed rL355023: Fixed ubsan failures in r355005..
Fixed ubsan failures in r355005.
Feb 27 2019, 12:01 PM
xur committed rG6cdf3d8086fe: Recommit r354930 "[PGO] Context sensitive PGO (part 1)" (authored by xur).
Recommit r354930 "[PGO] Context sensitive PGO (part 1)"
Feb 27 2019, 9:27 AM
xur committed rL355005: Recommit r354930 "[PGO] Context sensitive PGO (part 1)".
Recommit r354930 "[PGO] Context sensitive PGO (part 1)"
Feb 27 2019, 9:24 AM

Feb 26 2019

xur committed rG35d2d51369b4: [PGO] Context sensitive PGO (part 1) (authored by xur).
[PGO] Context sensitive PGO (part 1)
Feb 26 2019, 2:39 PM
xur committed rL354930: [PGO] Context sensitive PGO (part 1).
[PGO] Context sensitive PGO (part 1)
Feb 26 2019, 2:39 PM
xur closed D54175: [PGO] context sensitive PGO.
Feb 26 2019, 2:38 PM · Restricted Project

Feb 12 2019

xur updated the diff for D54175: [PGO] context sensitive PGO.

Removed the unrelated instructions (comments) from the tests.

Feb 12 2019, 12:23 PM · Restricted Project

Feb 8 2019

xur updated the diff for D54176: [PGO] clang part of change for context-sensitive PGO..

Updated the patch to sync with D54175

Feb 8 2019, 11:56 AM · Restricted Project
xur updated the diff for D54175: [PGO] context sensitive PGO.

Forgot to include one more test:
A test/Other/cspgo-O2-pipeline.ll

Feb 8 2019, 11:50 AM · Restricted Project
xur committed rG017bbd96cf00: [Cmake] Add an option to build LLVM using the experimental new pass manager (authored by xur).
[Cmake] Add an option to build LLVM using the experimental new pass manager
Feb 8 2019, 11:32 AM
xur committed rL353550: [Cmake] Add an option to build LLVM using the experimental new pass manager.
[Cmake] Add an option to build LLVM using the experimental new pass manager
Feb 8 2019, 11:31 AM
xur closed D57068: [cmake] Add option to build LLVM using the experimental new pass manager.
Feb 8 2019, 11:31 AM · Restricted Project
xur added inline comments to D54175: [PGO] context sensitive PGO.
Feb 8 2019, 9:45 AM · Restricted Project
xur updated the diff for D54175: [PGO] context sensitive PGO.

Fixed the missing changes David mentioned.

Feb 8 2019, 9:45 AM · Restricted Project

Feb 7 2019

xur updated the diff for D54175: [PGO] context sensitive PGO.

Integrated the review comments from Teresa and David.
Added unit tests for
(1) llvm-profdata
(2) context-sensitive profile summary
(3) opt new options and passes
(4) gold plugin
(5) using lto2 to test csgen and csuse.

Feb 7 2019, 6:25 PM · Restricted Project

Feb 5 2019

xur committed rGce10d5ead422: [PGO] Use a function for creating variable for profile file name. NFC. (authored by xur).
[PGO] Use a function for creating variable for profile file name. NFC.
Feb 5 2019, 2:35 PM
xur committed rL353230: [PGO] Use a function for creating variable for profile file name. NFC..
[PGO] Use a function for creating variable for profile file name. NFC.
Feb 5 2019, 2:34 PM

Jan 28 2019

xur updated the diff for D54175: [PGO] context sensitive PGO.

Fixed a pass ordering issue in legacy pass manager for ThinLTO: Need to place CS Instrumentation after EliminateAvailableExternallyPass. This can cause duplicate profile variables that leads to bad profile for online profile merge.

Jan 28 2019, 10:09 AM · Restricted Project

Jan 23 2019

xur updated the diff for D54175: [PGO] context sensitive PGO.

Integrated Teresa's review comments.

Jan 23 2019, 10:13 AM · Restricted Project
xur added inline comments to D54175: [PGO] context sensitive PGO.
Jan 23 2019, 9:59 AM · Restricted Project

Jan 22 2019

xur created D57068: [cmake] Add option to build LLVM using the experimental new pass manager.
Jan 22 2019, 2:45 PM · Restricted Project

Jan 15 2019

xur accepted D56749: [NFC] Make pgo related options in opt more consistent. .

This cleanup looks good to me.

Jan 15 2019, 4:08 PM
xur updated the diff for D54177: PGO] change InstrProfData.inc for context sensitive PGO.

As Teresa suggested, split unrelated change to r351257 (NFC)

Jan 15 2019, 2:07 PM
xur committed rL351257: [profile] Sync up InstrProfData.inc with llvm copy /NFC.
[profile] Sync up InstrProfData.inc with llvm copy /NFC
Jan 15 2019, 2:03 PM
xur committed rCRT351257: [profile] Sync up InstrProfData.inc with llvm copy /NFC.
[profile] Sync up InstrProfData.inc with llvm copy /NFC
Jan 15 2019, 2:03 PM

Jan 14 2019

xur added a comment to D56015: Allow new comdat symbols to be added as a result of LTO..

An update: I now use a separated pass to create the comdat variables before LTO/ThinLTO. @ruir: You can discard this patch now. Thanks the help from ruir and pcc.

Jan 14 2019, 12:20 PM
xur updated the diff for D54175: [PGO] context sensitive PGO.

Fixed the issue with lld (where lld is not happy with the COMDAT variables created
after LTO/ThinLTO)

Jan 14 2019, 10:38 AM · Restricted Project
xur created D56675: [lld] add options for context-sensitive PGO..
Jan 14 2019, 10:33 AM · Restricted Project
xur updated the diff for D54177: PGO] change InstrProfData.inc for context sensitive PGO.

Update the patch to sync with
https://reviews.llvm.org/D54175

Jan 14 2019, 10:25 AM
xur updated the diff for D54176: [PGO] clang part of change for context-sensitive PGO..

Update the patch to sync with https://reviews.llvm.org/D54175

Jan 14 2019, 10:25 AM · Restricted Project

Jan 9 2019

xur added a comment to D56327: [PGO] Use SourceFileName rather module name in PGOFuncName.

@kristina: This patch does not functionally change anything in current code base. We think this patch makes more sense than the original one (which also contributed by us)
Current code works fine (as all the callers to getPGOFuncName() are before LTO). Tests for stripping behavior is already in the test suite.
It will break once that functions is called in LTO or after LTO with unknown function error. This will show in patch here https://reviews.llvm.org/D54175.

Jan 9 2019, 12:19 PM

Jan 8 2019

xur committed rL350673: [llvm-profdata] add value-cutoff functionality in show command.
[llvm-profdata] add value-cutoff functionality in show command
Jan 8 2019, 2:45 PM
xur closed D56342: [llvm-profdata] add value-cutoff functionality to show command.
Jan 8 2019, 2:45 PM
xur committed rL350671: [PGO] Use SourceFileName rather module name in PGOFuncName.
[PGO] Use SourceFileName rather module name in PGOFuncName
Jan 8 2019, 2:44 PM
xur closed D56327: [PGO] Use SourceFileName rather module name in PGOFuncName.
Jan 8 2019, 2:44 PM
xur committed rL350670: [PGO] Revert r350579 to fix commit message..
[PGO] Revert r350579 to fix commit message.
Jan 8 2019, 2:41 PM
xur committed rL350667: [PGO] Revert r350442 to fix commit message..
[PGO] Revert r350442 to fix commit message.
Jan 8 2019, 2:37 PM
xur added inline comments to D56327: [PGO] Use SourceFileName rather module name in PGOFuncName.
Jan 8 2019, 9:15 AM