Page MenuHomePhabricator

mantognini (Marco Antognini)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 1 2018, 7:44 AM (225 w, 6 d)

Recent Activity

Jun 20 2022

mantognini committed rG0ad4f29b545d: [analyzer] SATest: Weaken assumption about HTML files (authored by mantognini).
[analyzer] SATest: Weaken assumption about HTML files
Jun 20 2022, 12:46 AM · Restricted Project, Restricted Project
mantognini closed D126197: [analyzer] SATest: Weaken assumption about HTML files.
Jun 20 2022, 12:46 AM · Restricted Project, Restricted Project
mantognini committed rGe15fef41709a: [analyzer] SATest: Ensure Docker image can be built (authored by mantognini).
[analyzer] SATest: Ensure Docker image can be built
Jun 20 2022, 12:43 AM · Restricted Project, Restricted Project
mantognini closed D126196: [analyzer] SATest: Ensure Docker image can be built.
Jun 20 2022, 12:43 AM · Restricted Project, Restricted Project

May 24 2022

mantognini added a comment to D126196: [analyzer] SATest: Ensure Docker image can be built.

LGTM;
So you have used this tool. Could you add some notes somewhere on how to get this to work?
What is the workflow?
Is it documented anywhere?

I know that's an unrelated topic, but I might consider using/integrating this stuff into our workflow.

May 24 2022, 2:44 AM · Restricted Project, Restricted Project
mantognini added a comment to D126197: [analyzer] SATest: Weaken assumption about HTML files.

I'm not using this script file, so I'm not gonna be too picky about this.
However, I would be more confident landing changes if we had tests exercising the changed behavior.
If you plan to land more changes to this file, consider adding some tests.

May 24 2022, 2:27 AM · Restricted Project, Restricted Project
mantognini published D126197: [analyzer] SATest: Weaken assumption about HTML files for review.

This patch relates to my previous comment: https://reviews.llvm.org/D124621#3485799

May 24 2022, 12:56 AM · Restricted Project, Restricted Project
mantognini published D126196: [analyzer] SATest: Ensure Docker image can be built for review.

This patch relates to my previous comment: https://reviews.llvm.org/D124621#3485799

May 24 2022, 12:54 AM · Restricted Project, Restricted Project

May 5 2022

mantognini committed rGc894e85fc64d: In MSVC compatibility mode, handle unqualified templated base class… (authored by frederic-tingaud-sonarsource).
In MSVC compatibility mode, handle unqualified templated base class…
May 5 2022, 7:04 AM · Restricted Project, Restricted Project
mantognini closed D124666: In MSVC compatibility mode, handle unqualified templated base class initialization.
May 5 2022, 7:03 AM · Restricted Project, Restricted Project

May 3 2022

mantognini committed rGad47114ad850: In MSVC compatibility mode, friend function declarations behave as function… (authored by frederic-tingaud-sonarsource).
In MSVC compatibility mode, friend function declarations behave as function…
May 3 2022, 2:32 AM · Restricted Project, Restricted Project
mantognini closed D124613: In MSVC compatibility mode, friend function declarations behave as function declarations.
May 3 2022, 2:31 AM · Restricted Project, Restricted Project
mantognini committed rG68ee5ec07d4a: [Analyzer] Fix assumptions about const field with member-initializer (authored by mantognini).
[Analyzer] Fix assumptions about const field with member-initializer
May 3 2022, 2:28 AM · Restricted Project, Restricted Project
mantognini closed D124621: [Analyzer] Fix assumptions about const field with member-initializer.
May 3 2022, 2:28 AM · Restricted Project, Restricted Project
mantognini added a comment to D124621: [Analyzer] Fix assumptions about const field with member-initializer.

I can confirm the issue with my patch, so this piece of code needs to be removed.

As long as the following test still succeeds, this looks good to me. Back then, the analyzer was not able to cover that case without that addition.

https://github.com/llvm/llvm-project/blob/main/clang/test/Analysis/globals.cpp#L110

May 3 2022, 12:12 AM · Restricted Project, Restricted Project

May 2 2022

mantognini committed rGf34639828f5a: [Analyzer] Minor cleanups in StreamChecker (authored by mantognini).
[Analyzer] Minor cleanups in StreamChecker
May 2 2022, 8:50 AM · Restricted Project, Restricted Project
mantognini closed D124681: [Analyzer] Minor cleanups in StreamChecker.
May 2 2022, 8:50 AM · Restricted Project, Restricted Project
mantognini committed rG5a47accda88c: [Analyzer] Fix clang::ento::taint::dumpTaint definition (authored by mantognini).
[Analyzer] Fix clang::ento::taint::dumpTaint definition
May 2 2022, 8:44 AM · Restricted Project, Restricted Project
mantognini closed D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition.
May 2 2022, 8:44 AM · Restricted Project, Restricted Project
mantognini added a comment to D124621: [Analyzer] Fix assumptions about const field with member-initializer.

For the upcoming patches, it would be nice to test the patches on a small set of open-source projects for exactly this reason.
I think there is a clang/utils/analyzer/SATest.py script helping you on this part.
It seems we have quite a few projects on the testset clang/utils/analyzer/projects/projects.json.
We are not using it, because we have a different internal testing infrastructure, but it's definitely better than nothing.

May 2 2022, 8:38 AM · Restricted Project, Restricted Project
mantognini published D124681: [Analyzer] Minor cleanups in StreamChecker for review.

For reference, the modified code was introduced with https://reviews.llvm.org/D80015.

May 2 2022, 2:20 AM · Restricted Project, Restricted Project

Apr 29 2022

mantognini retitled D124621: [Analyzer] Fix assumptions about const field with member-initializer from CPP-2461 [Analyzer] Fix assumptions about const field with member-initializer to [Analyzer] Fix assumptions about const field with member-initializer.
Apr 29 2022, 9:06 AM · Restricted Project, Restricted Project
mantognini added a comment to D124621: [Analyzer] Fix assumptions about const field with member-initializer.

LGTM

One thing I'm not sure about and couldn't easily find in the doc is how to reference in the commit message the bug (https://llvm.org/PR48534) this patch fixes. Is it good as is?

AFAIK we should prefer GitHub issue numbers to the old BugZilla numbers.
Could you please update all references of 48534 -> 47878.

In addition, I think Fixes #47878 should work in the commit message, and automatically close the given GitHub issue.

Apr 29 2022, 9:05 AM · Restricted Project, Restricted Project
mantognini updated the diff for D124621: [Analyzer] Fix assumptions about const field with member-initializer.

Update commit message and add FIXMEs

Apr 29 2022, 9:01 AM · Restricted Project, Restricted Project
mantognini added a comment to D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition.

Thanks for the stats.
@aaron.ballman WDYT, where should we put the LLVM_DUMP_METHOD ?

The documentation for the attribute says function definitions, but I don't think it matters in terms of the semantics of the attributes. I'd probably put it on the definition in this case because the goal is to keep the function around at runtime but it doesn't impact the interface of the call or how users would use it at compile time.

I noticed that we seem to be pretty bad about this advice however:

/// Note that you should also surround dump() functions with
/// `#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)` so they do always
/// get stripped in release builds.
Apr 29 2022, 8:46 AM · Restricted Project, Restricted Project
mantognini published D124621: [Analyzer] Fix assumptions about const field with member-initializer for review.

One thing I'm not sure about and couldn't easily find in the doc is how to reference in the commit message the bug (https://llvm.org/PR48534) this patch fixes. Is it good as is?

Apr 29 2022, 12:45 AM · Restricted Project, Restricted Project

Apr 28 2022

mantognini updated the summary of D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition.
Apr 28 2022, 7:18 AM · Restricted Project, Restricted Project
mantognini updated the diff for D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition.

Remove LLVM_DUMP_METHOD from definition

Apr 28 2022, 7:17 AM · Restricted Project, Restricted Project
mantognini abandoned D124614: [Analyzer] Fix clang::ento::taint::dumpTaint definition.

Ran wrong arc command...

Apr 28 2022, 7:11 AM · Restricted Project, Restricted Project
mantognini requested review of D124614: [Analyzer] Fix clang::ento::taint::dumpTaint definition.
Apr 28 2022, 7:10 AM · Restricted Project, Restricted Project
mantognini added a comment to D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition.

Although gcc (and probably clang too) allows specifying __attribute__((noinline)) at any declaration (by merging compatible attributes), I would prefer not to repeat ourselves.
The attribute must be present at the header to force all usages not to inline it, hence I would rather drop such attributes from the definition files.

Apr 28 2022, 7:06 AM · Restricted Project, Restricted Project
mantognini committed rGbf0bcb5e539b: [Analyzer] Remove undefined function (authored by mantognini).
[Analyzer] Remove undefined function
Apr 28 2022, 2:55 AM · Restricted Project, Restricted Project
mantognini closed D124461: [Analyzer] Remove undefined function.
Apr 28 2022, 2:54 AM · Restricted Project, Restricted Project

Apr 27 2022

mantognini added a comment to D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition.

Could you please elaborate whats the motivation for this change?

Apr 27 2022, 3:53 AM · Restricted Project, Restricted Project
mantognini published D124461: [Analyzer] Remove undefined function for review.

I'd appreciate reviews for this small patch. Thanks.

Apr 27 2022, 12:46 AM · Restricted Project, Restricted Project
mantognini published D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition for review.

I'd appreciate reviews for this small patch. Thanks.

Apr 27 2022, 12:41 AM · Restricted Project, Restricted Project

Sep 18 2021

mantognini resigned from D110019: [gn build] improve write_cmake_config to be truthy and exception friendly.
Sep 18 2021, 5:40 AM · Restricted Project

May 14 2021

mantognini accepted D100976: [OpenCL] Simplify use of C11 atomic types.

LGTM, thanks for the update.

May 14 2021, 1:18 AM · Restricted Project

May 7 2021

mantognini added inline comments to D100976: [OpenCL] Simplify use of C11 atomic types.
May 7 2021, 6:58 AM · Restricted Project

May 6 2021

mantognini added a comment to D100976: [OpenCL] Simplify use of C11 atomic types.

This change removes the requirement on pragma when atomic types from the extensions are supported because the behavior is not conformant. With this change, the developers can use atomic types from the extensions if they are supported without enabling the pragma because disabling the pragma doesn't do anything useful but only prevents the use of already available identifiers for types and issues extra diagnostics. This makes semantics consistent with the atomic functions that are also available when the extension is supported without any need for the pragma.

May 6 2021, 8:25 AM · Restricted Project

Apr 23 2021

mantognini accepted D100984: [OpenCL] Remove the need for subgroups extension pragma in enqueue kernel and pipe builtins.

Thanks, I believe this goes in the right direction.

Apr 23 2021, 2:17 AM · Restricted Project
mantognini accepted D100985: [OpenCL] Remove pragma requirement for functions from Arm dot extension.

Feels appropriate to remove this indeed.

Apr 23 2021, 2:11 AM · Restricted Project

Apr 22 2021

mantognini added a comment to D101043: [OpenCL] Drop extension pragma handling for extension types/declarations.

Reasoning and strategy looks sensible to me. I'm not formally approving the patch because I feel I'm not familiar enough with the code base to do that.

Apr 22 2021, 9:28 AM · Restricted Project

Mar 2 2021

mantognini accepted D97052: [OpenCL] Prevent adding extension pragma by default.

LGTM, thanks for the update.

Mar 2 2021, 3:14 AM · Restricted Project

Feb 24 2021

mantognini added a comment to D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features.

Some minor comments.

Feb 24 2021, 8:46 AM · Restricted Project
mantognini added a comment to D97052: [OpenCL] Prevent adding extension pragma by default.

Some relatively minor comments, overall direction seems good to me.

Feb 24 2021, 6:41 AM · Restricted Project

Feb 23 2021

mantognini accepted D97203: [OpenCL][PR49264] Allow taking address of functions by enabling the extension.

looks appropriate to me.

Feb 23 2021, 7:06 AM · Restricted Project

Feb 16 2021

mantognini added a comment to D96771: [OpenCL] Add distinct file extension for C++ for OpenCL.

I feel this would be a valuable addition, indeed. Only a minor question from me.

Feb 16 2021, 8:15 AM · Restricted Project

Feb 15 2021

mantognini committed rGe54811ff7e0b: Restore diagnostic handler after CodeGenAction::ExecuteAction (authored by mantognini).
Restore diagnostic handler after CodeGenAction::ExecuteAction
Feb 15 2021, 2:33 AM
mantognini closed D96487: Restore diagnostic handler after CodeGenAction::ExecuteAction.
Feb 15 2021, 2:33 AM · Restricted Project, Restricted Project

Feb 11 2021

mantognini added reviewers for D96487: Restore diagnostic handler after CodeGenAction::ExecuteAction: aganea, xur, rsmith.
Feb 11 2021, 4:01 AM · Restricted Project, Restricted Project
mantognini published D96487: Restore diagnostic handler after CodeGenAction::ExecuteAction for review.
Feb 11 2021, 3:54 AM · Restricted Project, Restricted Project

Feb 9 2021

mantognini accepted D96161: [OpenCL] Fix printing of types with signed prefix in arg info metadata.

LGTM, thanks. All the comments seem to be addressed.

Feb 9 2021, 6:33 AM · Restricted Project

Feb 8 2021

mantognini accepted D96151: [OpenCL] Fix pipe type printing in arg info metadata.

Nice refactoring & fix! LGTM. I suppose Stuart's comment about moving typeNameRef can be addressed when pushing.

Feb 8 2021, 1:44 AM · Restricted Project

Jan 27 2021

mantognini accepted D95442: [OpenCL] Add diagnostics for references to functions.

Right, thanks for the explanations. They make sense.

Jan 27 2021, 8:41 AM · Restricted Project
mantognini added a comment to D95442: [OpenCL] Add diagnostics for references to functions.

Looks sensible to me.

Jan 27 2021, 6:25 AM · Restricted Project

Jan 8 2021

mantognini accepted D94188: [OpenCL] Documentation for experimental C++ libraries support.

LGTM

Jan 8 2021, 1:17 AM · Restricted Project

Jan 7 2021

mantognini added a comment to D94188: [OpenCL] Documentation for experimental C++ libraries support.

Looks good overall.

Jan 7 2021, 7:19 AM · Restricted Project

Jan 6 2021

mantognini accepted D94027: [OpenCL] Add clang extension for variadic functions.

Thanks for the update.

Jan 6 2021, 6:06 AM · Restricted Project
mantognini added a comment to D93942: [OpenCL] Improve online documentation..

LGTM, except for a minor typo. Otherwise my comments have been addressed. Thanks.

Jan 6 2021, 2:27 AM · Restricted Project
mantognini added a comment to D94027: [OpenCL] Add clang extension for variadic functions.

LGTM, just one question: I see in the other review you updated clang/test/SemaOpenCL/extension-version.cl. Do you need to do the same here?

Jan 6 2021, 2:01 AM · Restricted Project
mantognini accepted D94021: [OpenCL] Add clang extension for function pointers.

LGTM

Jan 6 2021, 1:56 AM · Restricted Project, Restricted Project

Dec 31 2020

mantognini added a comment to D93942: [OpenCL] Improve online documentation..

Thanks for the update. Looks good overall. A minor question about backticks. I'm no native English speaker, so I would recommend a second review from someone else too.

Dec 31 2020, 9:03 AM · Restricted Project
mantognini accepted D93958: [OpenCL] Restrict pointer to member functions.

lgtm, thanks

Dec 31 2020, 8:25 AM · Restricted Project

Dec 30 2020

mantognini added a comment to D93942: [OpenCL] Improve online documentation..

Looks good, only a few typos and minor comments.

Dec 30 2020, 9:14 AM · Restricted Project

Nov 26 2020

mantognini added a comment to D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros.

When reading the documentation [1] for -cl-ext (which I've never used so far), I've noticed nothing is said about non-standard configurations (such as disabling cl_khr_depth_images with CL2.0). Quickly testing this shows that options can be specified to produce non-standard behaviour, as shown by https://godbolt.org/z/1Yz1Md.

Nov 26 2020, 3:51 AM

Nov 13 2020

mantognini added a comment to D91429: [OpenCL] Stop opencl-c-base.h leaking extension enabling.

LGMT as it reduces the divergence in compilation flows. I let @Anastasia, or someone else more familiar with the codebase, give the final approval though.

Nov 13 2020, 8:08 AM · Restricted Project

Nov 9 2020

mantognini added inline comments to D60193: [OpenCL] Added addrspace_cast operator.
Nov 9 2020, 2:28 AM · Restricted Project

Oct 30 2020

mantognini committed rGbbdbd020d2c2: Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr (authored by mantognini).
Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr
Oct 30 2020, 7:12 AM
mantognini closed D90385: Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr.
Oct 30 2020, 7:12 AM · Restricted Project

Oct 29 2020

mantognini added a comment to D60193: [OpenCL] Added addrspace_cast operator.

I've put up https://reviews.llvm.org/D90385 as a fix for this issue.

Oct 29 2020, 6:39 AM · Restricted Project
mantognini published D90385: Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr for review.

A follow up on https://reviews.llvm.org/D60193.

Oct 29 2020, 6:39 AM · Restricted Project

Oct 22 2020

mantognini committed rGa779a169931c: [OpenCL] Remove unused extensions (authored by mantognini).
[OpenCL] Remove unused extensions
Oct 22 2020, 9:02 AM
mantognini closed D89372: [OpenCL] Remove unused extensions.
Oct 22 2020, 9:01 AM · Restricted Project

Oct 20 2020

mantognini added a comment to D89372: [OpenCL] Remove unused extensions.

I don't want to stop the wider discussion, that being said I think I've addressed the comment regarding the content of this PR. Let me know if the latest version is fine or needs further addressing. Thanks.

Oct 20 2020, 5:40 AM · Restricted Project

Oct 16 2020

mantognini updated the summary of D89372: [OpenCL] Remove unused extensions.
Oct 16 2020, 10:22 AM · Restricted Project
mantognini updated the diff for D89372: [OpenCL] Remove unused extensions.

Keep cl_khr_byte_addressable_store and cles_khr_int64 out of this PR. Add more details on the extensions being removed in the commit message.

Oct 16 2020, 10:06 AM · Restricted Project

Oct 15 2020

mantognini added inline comments to D89372: [OpenCL] Remove unused extensions.
Oct 15 2020, 2:21 AM · Restricted Project
mantognini updated the diff for D89372: [OpenCL] Remove unused extensions.

Addressed comments.

Oct 15 2020, 2:21 AM · Restricted Project

Oct 14 2020

mantognini added inline comments to D89372: [OpenCL] Remove unused extensions.
Oct 14 2020, 9:48 AM · Restricted Project
mantognini added a comment to D89372: [OpenCL] Remove unused extensions.

what if users rely on the predefined macros associated with the extension e.g. cl_khr_srgb_image_writes to enable/disable certain code?

What's the issue with these extensions not removed?

Oct 14 2020, 6:50 AM · Restricted Project
mantognini published D89372: [OpenCL] Remove unused extensions for review.
Oct 14 2020, 4:41 AM · Restricted Project

May 11 2020

mantognini accepted D60193: [OpenCL] Added addrspace_cast operator.

LGTM

May 11 2020, 2:06 AM · Restricted Project

May 7 2020

mantognini added a comment to D60193: [OpenCL] Added addrspace_cast operator.

Thanks for your clarifications and updates. Just one tiny question about a test file, but otherwise LGTM.

May 7 2020, 2:48 AM · Restricted Project

Oct 17 2019

mantognini accepted D69072: [OpenCL] Added doc to describe OpenCL support.

Alright, thanks for the explanation. LGTM then.

Oct 17 2019, 4:20 AM · Restricted Project
mantognini added a comment to D69072: [OpenCL] Added doc to describe OpenCL support.

Shouldn't this page be referenced from clang/docs/index.rst?

Oct 17 2019, 2:21 AM · Restricted Project

Oct 16 2019

mantognini added inline comments to D65850: GlobalISel: pack various parameters for lowerCall into a struct..
Oct 16 2019, 8:45 AM · Restricted Project

Sep 25 2019

mantognini committed rGaefdc1e37a84: [gn build] Fix Python DeprecationWarning (authored by mantognini).
[gn build] Fix Python DeprecationWarning
Sep 25 2019, 7:15 AM
mantognini committed rL372876: [gn build] Fix Python DeprecationWarning.
[gn build] Fix Python DeprecationWarning
Sep 25 2019, 7:14 AM
mantognini closed D67753: [gn build] Fix Python DeprecationWarning.
Sep 25 2019, 7:14 AM · Restricted Project
mantognini added a comment to D67753: [gn build] Fix Python DeprecationWarning.

That's mysterious indeed. Looks like the default warnings come from here: https://github.com/python/cpython/blob/88e6447451fb5525e83e802c66c3e51b4a45bf86/Python/initconfig.c#L2064 You don't happen to run python in dev mode, do you? In dev mode, the warnings default to "default"; else they apparently don't.

Sep 25 2019, 3:49 AM · Restricted Project

Sep 24 2019

mantognini added a comment to D67753: [gn build] Fix Python DeprecationWarning.

I don't have PYTHONWARNINGS set in my env. Maybe ninja invoke the script using python -Wignore write_cmake_config.py or something? It's quite worrisome that Python runtime can exhibit different behaviours without apparent reasons. :/

Sep 24 2019, 8:31 AM · Restricted Project
mantognini added a comment to D67753: [gn build] Fix Python DeprecationWarning.
/usr/bin/env python --version
Python 3.7.0
Sep 24 2019, 8:01 AM · Restricted Project
mantognini added a comment to D67753: [gn build] Fix Python DeprecationWarning.

I'm afraid I can't give you the exact log we have, because we have a special integration of LLVM downstream and don't directly rely on the usual cmake/gn/... workflow. I'm sorry about that.

Sep 24 2019, 6:34 AM · Restricted Project
mantognini added a comment to D67753: [gn build] Fix Python DeprecationWarning.

You need Python 3.7.4 or later. The warnings are emitted only starting from this minor release.

Sep 24 2019, 5:58 AM · Restricted Project
mantognini added inline comments to D67753: [gn build] Fix Python DeprecationWarning.
Sep 24 2019, 3:37 AM · Restricted Project

Sep 19 2019

mantognini added reviewers for D67753: [gn build] Fix Python DeprecationWarning: thakis, gribozavr, alexfh, phosek.

Let me know what you think of this patch. Thanks.

Sep 19 2019, 2:55 AM · Restricted Project
mantognini created D67753: [gn build] Fix Python DeprecationWarning.
Sep 19 2019, 2:46 AM · Restricted Project

Sep 3 2019

mantognini committed rL370715: Request commit access for mantognini.
Request commit access for mantognini
Sep 3 2019, 2:16 AM

Aug 21 2019

mantognini added a comment to D65744: [PR42707][OpenCL] Fix addr space deduction for auto.

I think this looks good. Maybe the tests should be extended to test auto as function return type, and if there's some special handling around decltype(auto), then it should be tested too, but I'm not sure it's actually needed here. What do you think?

Aug 21 2019, 5:55 AM · Restricted Project