Page MenuHomePhabricator

mantognini (Marco Antognini)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 1 2018, 7:44 AM (46 w, 2 d)

Recent Activity

Today

mantognini added a comment to D65744: [PR42707][OpenCL] Fix addr space deduction for auto.

I think this looks good. Maybe the tests should be extended to test auto as function return type, and if there's some special handling around decltype(auto), then it should be tested too, but I'm not sure it's actually needed here. What do you think?

Wed, Aug 21, 5:55 AM

Mon, Aug 19

mantognini accepted D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL.

Thanks for addressing my comments.

Mon, Aug 19, 9:17 AM
mantognini added inline comments to D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL.
Mon, Aug 19, 3:48 AM

Thu, Aug 15

mantognini requested changes to D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL.

The overall structure seems alright. I'll let people more familiar with the code-base judge whether other important features should be added there as well.

Thu, Aug 15, 8:43 AM

Tue, Jul 30

mantognini accepted D65286: [OpenCL] Allow OpenCL C style vector initialization in C++.

LGTM, thanks for the update.

Tue, Jul 30, 9:29 AM · Restricted Project
mantognini added a comment to D65286: [OpenCL] Allow OpenCL C style vector initialization in C++.

In vector_literals_nested.cl, we have tests for (global) constants. Do you think it would be worth testing those as well in C++ mode? Maybe the two files (vector_literals_nested.cl and vector_literals_valid.cl) should also be merged as most of their content seems duplicated.

Tue, Jul 30, 5:28 AM · Restricted Project

Jul 22 2019

mantognini added a comment to D64569: [OpenCL] Improve destructor support in C++ for OpenCL.

FYI In order to fix buildbot test failures, I've pushed https://reviews.llvm.org/rG1b2da771f561affe36eb5eb0c7a3d2862c5a5c1c. I'll keep an eye on buildbots for additional fallout.

Jul 22 2019, 7:51 AM · Restricted Project, Restricted Project
mantognini added 3 commit(s) for D64569: [OpenCL] Improve destructor support in C++ for OpenCL: rG1b2da771f561: [NFC] Relaxed regression tests for PR42665, rL366694: [NFC] Relaxed regression tests for PR42665, rC366694: [NFC] Relaxed regression tests for PR42665.
Jul 22 2019, 7:50 AM · Restricted Project, Restricted Project
mantognini added an edge to rG1b2da771f561: [NFC] Relaxed regression tests for PR42665: D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
Jul 22 2019, 7:50 AM
mantognini added an edge to rL366694: [NFC] Relaxed regression tests for PR42665: D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
Jul 22 2019, 7:50 AM
mantognini committed rG1b2da771f561: [NFC] Relaxed regression tests for PR42665 (authored by mantognini).
[NFC] Relaxed regression tests for PR42665
Jul 22 2019, 7:48 AM
mantognini committed rL366694: [NFC] Relaxed regression tests for PR42665.
[NFC] Relaxed regression tests for PR42665
Jul 22 2019, 7:47 AM
mantognini closed D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
Jul 22 2019, 2:50 AM · Restricted Project, Restricted Project
mantognini added an edge to rL366670: [OpenCL] Improve destructor support in C++ for OpenCL: D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
Jul 22 2019, 2:45 AM
mantognini added 3 commit(s) for D64569: [OpenCL] Improve destructor support in C++ for OpenCL: rG88559637641e: [OpenCL] Improve destructor support in C++ for OpenCL, rC366670: [OpenCL] Improve destructor support in C++ for OpenCL, rL366670: [OpenCL] Improve destructor support in C++ for OpenCL.
Jul 22 2019, 2:45 AM · Restricted Project, Restricted Project
mantognini added an edge to rG88559637641e: [OpenCL] Improve destructor support in C++ for OpenCL: D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
Jul 22 2019, 2:45 AM
mantognini committed rG88559637641e: [OpenCL] Improve destructor support in C++ for OpenCL (authored by mantognini).
[OpenCL] Improve destructor support in C++ for OpenCL
Jul 22 2019, 2:42 AM
mantognini committed rL366670: [OpenCL] Improve destructor support in C++ for OpenCL.
[OpenCL] Improve destructor support in C++ for OpenCL
Jul 22 2019, 2:42 AM

Jul 19 2019

mantognini added a comment to D64569: [OpenCL] Improve destructor support in C++ for OpenCL.

Yes, that's the right fix, although you might also consider adding a getObjectType() to CXXMemberCallExpr.

Jul 19 2019, 9:08 AM · Restricted Project, Restricted Project
mantognini updated the diff for D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
  • Add minimal regression test for PR42665
  • Add CXXMemberCallExpr::getObjectType()
Jul 19 2019, 9:07 AM · Restricted Project, Restricted Project

Jul 18 2019

mantognini added inline comments to D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
Jul 18 2019, 9:47 AM · Restricted Project, Restricted Project
mantognini requested review of D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
Jul 18 2019, 9:40 AM · Restricted Project, Restricted Project
mantognini updated the diff for D64569: [OpenCL] Improve destructor support in C++ for OpenCL.

Add patch for Bug PR42665.

Jul 18 2019, 9:39 AM · Restricted Project, Restricted Project
mantognini reopened D64569: [OpenCL] Improve destructor support in C++ for OpenCL.

While investigating PR42665, I've noticed that getImplicitObjectArgument doesn't always return a pointer type. For example, when dealing with shared_ptr. In libc++'s test std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/make_shared.pass.cpp, dumping CE in EmitVirtualDestructorCall shows that the callee is .~Bar (mind the .):

CXXMemberCallExpr 0x29d10a0 'void'
`-MemberExpr 0x29d1070 '<bound member function type>' .~Bar 0x23f5250
  `-CXXMemberCallExpr 0x29d1040 'struct Bar':'struct Bar' lvalue
    `-MemberExpr 0x29d1010 '<bound member function type>' .second 0x2883328
      `-MemberExpr 0x29d0f80 '__compressed_pair<class std::__1::allocator<struct Bar>, struct Bar>':'class std::__1::__compressed_pair<class std::__1::allocator<struct Bar>, struct Bar>' lvalue ->__data_ 0x2896960
        `-CXXThisExpr 0x29d0f70 'class std::__1::__shared_ptr_emplace<struct Bar, class std::__1::allocator<struct Bar> > *' implicit this
Jul 18 2019, 9:39 AM · Restricted Project, Restricted Project
mantognini committed rG83748cc5abc1: [OpenCL] Improve destructor support in C++ for OpenCL (authored by mantognini).
[OpenCL] Improve destructor support in C++ for OpenCL
Jul 18 2019, 3:05 AM
mantognini committed rL366422: [OpenCL] Improve destructor support in C++ for OpenCL.
[OpenCL] Improve destructor support in C++ for OpenCL
Jul 18 2019, 3:05 AM
mantognini closed D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
Jul 18 2019, 3:05 AM · Restricted Project, Restricted Project
mantognini updated the diff for D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
  • Minor refactoring of getThisObjectType
  • Removed unnecessary assertion
Jul 18 2019, 1:56 AM · Restricted Project, Restricted Project
mantognini added inline comments to D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
Jul 18 2019, 1:56 AM · Restricted Project, Restricted Project

Jul 17 2019

mantognini added inline comments to D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
Jul 17 2019, 8:49 AM · Restricted Project, Restricted Project
mantognini updated the diff for D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
  • Addressed comments
Jul 17 2019, 8:44 AM · Restricted Project, Restricted Project
mantognini accepted D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode.

Beside my two comments, I think this looks good.

Jul 17 2019, 2:26 AM · Restricted Project
mantognini committed rG9eb95903da45: [OpenCL][Sema] Minor refactoring and constraint checking (authored by mantognini).
[OpenCL][Sema] Minor refactoring and constraint checking
Jul 17 2019, 1:53 AM
mantognini committed rL366306: [OpenCL][Sema] Minor refactoring and constraint checking.
[OpenCL][Sema] Minor refactoring and constraint checking
Jul 17 2019, 1:53 AM
mantognini closed D64804: [OpenCL][Sema] Minor refactoring and constraint checking.
Jul 17 2019, 1:53 AM · Restricted Project, Restricted Project

Jul 16 2019

mantognini added reviewers for D64804: [OpenCL][Sema] Minor refactoring and constraint checking: Anastasia, rjmccall.

This should address the minor refactoring requesting in D64083.

Jul 16 2019, 9:08 AM · Restricted Project, Restricted Project
mantognini created D64804: [OpenCL][Sema] Minor refactoring and constraint checking.
Jul 16 2019, 9:05 AM · Restricted Project, Restricted Project
mantognini added a comment to D64569: [OpenCL] Improve destructor support in C++ for OpenCL.

Mind the fact that I've rebased the changes onto a more recent master version. If you look at the diff of v1 against v2 you might see some unrelated changes.

Jul 16 2019, 6:27 AM · Restricted Project, Restricted Project
mantognini updated the diff for D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
  • Refactored common bits from CheckConstructorDeclarator and CheckDestructorDeclarator.
  • Added as many "ThisTy" parameter I could.
  • Addressed issue with identifier format in tests (%N to %var.ascast).
Jul 16 2019, 6:14 AM · Restricted Project, Restricted Project

Jul 12 2019

mantognini added inline comments to D64083: [OpenCL][Sema] Improve address space support for blocks.
Jul 12 2019, 4:15 AM · Restricted Project, Restricted Project

Jul 11 2019

mantognini added reviewers for D64569: [OpenCL] Improve destructor support in C++ for OpenCL: Anastasia, rjmccall.
Jul 11 2019, 9:33 AM · Restricted Project, Restricted Project
mantognini created D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
Jul 11 2019, 9:16 AM · Restricted Project, Restricted Project
mantognini added a child revision for D62413: [OpenCL][PR41727] Prevent ICE on global dtors: D64569: [OpenCL] Improve destructor support in C++ for OpenCL.
Jul 11 2019, 9:16 AM · Restricted Project

Jul 9 2019

mantognini added a comment to D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode.

Here are a few comments from me but keep in mind that English is not my primary language

Jul 9 2019, 10:13 AM · Restricted Project
mantognini closed D64074: [OpenCL][Sema] Fix builtin rewriting.
Jul 9 2019, 8:12 AM · Restricted Project
mantognini added an edge to rGb00d5f732cd3: [OpenCL][Sema] Fix builtin rewriting: D64074: [OpenCL][Sema] Fix builtin rewriting.
Jul 9 2019, 8:11 AM
mantognini added 3 commit(s) for D64074: [OpenCL][Sema] Fix builtin rewriting: rGb00d5f732cd3: [OpenCL][Sema] Fix builtin rewriting, rL365499: [OpenCL][Sema] Fix builtin rewriting, rC365499: [OpenCL][Sema] Fix builtin rewriting.
Jul 9 2019, 8:11 AM · Restricted Project
mantognini added an edge to rL365499: [OpenCL][Sema] Fix builtin rewriting: D64074: [OpenCL][Sema] Fix builtin rewriting.
Jul 9 2019, 8:11 AM
mantognini committed rGd36e130a86d1: [OpenCL][Sema] Improve address space support for blocks (authored by mantognini).
[OpenCL][Sema] Improve address space support for blocks
Jul 9 2019, 8:05 AM
mantognini committed rGb00d5f732cd3: [OpenCL][Sema] Fix builtin rewriting (authored by mantognini).
[OpenCL][Sema] Fix builtin rewriting
Jul 9 2019, 8:05 AM
mantognini committed rL365500: [OpenCL][Sema] Improve address space support for blocks.
[OpenCL][Sema] Improve address space support for blocks
Jul 9 2019, 8:05 AM
mantognini closed D64083: [OpenCL][Sema] Improve address space support for blocks.
Jul 9 2019, 8:05 AM · Restricted Project, Restricted Project
mantognini committed rL365499: [OpenCL][Sema] Fix builtin rewriting.
[OpenCL][Sema] Fix builtin rewriting
Jul 9 2019, 8:05 AM

Jul 4 2019

mantognini added a comment to D64074: [OpenCL][Sema] Fix builtin rewriting.

I'll commit this along with D64083 in a few days in case John has any feedback.

Jul 4 2019, 2:21 AM · Restricted Project
mantognini updated the diff for D64074: [OpenCL][Sema] Fix builtin rewriting.

Addressed missing colon in FIXME comment.

Jul 4 2019, 2:16 AM · Restricted Project

Jul 2 2019

mantognini created D64083: [OpenCL][Sema] Improve address space support for blocks.
Jul 2 2019, 8:56 AM · Restricted Project, Restricted Project
mantognini added a comment to D64074: [OpenCL][Sema] Fix builtin rewriting.

I added the FIXME and reduced the amount of testing. Let me know if it looks alright.

Jul 2 2019, 8:53 AM · Restricted Project
mantognini updated the diff for D64074: [OpenCL][Sema] Fix builtin rewriting.

Address comments: reduce testing & add FIXME.

Jul 2 2019, 8:53 AM · Restricted Project
mantognini created D64074: [OpenCL][Sema] Fix builtin rewriting.
Jul 2 2019, 6:25 AM · Restricted Project

Jun 19 2019

mantognini added a comment to D60193: [OpenCL] Added addrspace_cast operator.

When compiling this I get the following warning:

clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:1213:10: warning: enumeration value 'CXXAddrspaceCastExprClass' not handled in switch
Jun 19 2019, 2:42 AM

Jun 4 2019

mantognini accepted D62591: [OpenCL][PR42031] Prevent deducing addr space in type alias..

LGTM

Jun 4 2019, 5:00 AM · Restricted Project

May 29 2019

mantognini added inline comments to D62591: [OpenCL][PR42031] Prevent deducing addr space in type alias..
May 29 2019, 11:36 AM · Restricted Project

Dec 3 2018

mantognini committed rC348139: [OpenCL][Sema] Improving formatting.
[OpenCL][Sema] Improving formatting
Dec 3 2018, 6:07 AM
mantognini committed rL348139: [OpenCL][Sema] Improving formatting.
[OpenCL][Sema] Improving formatting
Dec 3 2018, 6:06 AM
mantognini committed rC348120: [OpenCL][Sema] Improve BuildResolvedCallExpr handling of builtins.
[OpenCL][Sema] Improve BuildResolvedCallExpr handling of builtins
Dec 3 2018, 3:02 AM
mantognini committed rL348120: [OpenCL][Sema] Improve BuildResolvedCallExpr handling of builtins.
[OpenCL][Sema] Improve BuildResolvedCallExpr handling of builtins
Dec 3 2018, 3:02 AM
mantognini closed D55136: [OpenCL][Sema] Improve BuildResolvedCallExpr handling of builtins.
Dec 3 2018, 3:02 AM

Nov 30 2018

mantognini added a comment to D52879: Derive builtin return type from its definition.

Please see https://reviews.llvm.org/D55136 for the patch addressing these issues.

Nov 30 2018, 10:22 AM
mantognini created D55136: [OpenCL][Sema] Improve BuildResolvedCallExpr handling of builtins.
Nov 30 2018, 10:21 AM
mantognini added a comment to D52879: Derive builtin return type from its definition.

Thank you for the detailed review. I'll work on a patch and add you as reviewer once done (prob. on Monday though).

Nov 30 2018, 9:26 AM
mantognini added a comment to D52879: Derive builtin return type from its definition.

And moreover I believe this change is subtly incorrect for the following reason:
The type that is passed into the constructor of the call expression is the type
of the call expression, and not the return type.

The difference between the return type and the type of the call expression is that
1.) References are dropped, and
2.) For C++: The cv-qualifiers of non class pr-values are dropped,
3.) For C: The cv-qualifiers are dropped.

( as can be seen in FunctionType::getCallResultType )

Nov 30 2018, 8:06 AM

Nov 27 2018

mantognini added a comment to D52879: Derive builtin return type from its definition.

I see plenty of TheCall->setType left in Sema::CheckBuiltinFunctionCall
(Builtin::BI__builtin_classify_type, Builtin::BI__builtin_constant_p,
Builtin::BI__builtin_dump_struct and so on...).

Is there a reason for not removing them ?

Nov 27 2018, 8:43 AM
mantognini committed rL347658: Derive builtin return type from its definition.
Derive builtin return type from its definition
Nov 27 2018, 6:58 AM
mantognini committed rC347658: Derive builtin return type from its definition.
Derive builtin return type from its definition
Nov 27 2018, 6:58 AM
mantognini closed D52879: Derive builtin return type from its definition.
Nov 27 2018, 6:57 AM

Nov 13 2018

mantognini added a reviewer for D52879: Derive builtin return type from its definition: rsmith.
Nov 13 2018, 3:40 AM

Nov 1 2018

mantognini accepted D53871: [OpenCL] Allow clk_event_t comparisons.

LGTM, but please add a comment in the test file.

Nov 1 2018, 3:07 AM

Oct 22 2018

mantognini added a comment to D52879: Derive builtin return type from its definition.

ping

Oct 22 2018, 4:32 AM
mantognini committed rL344891: [OpenCL] Fix definitions of __builtin_(add|sub|mul)_overflow.
[OpenCL] Fix definitions of __builtin_(add|sub|mul)_overflow
Oct 22 2018, 3:43 AM
mantognini committed rC344891: [OpenCL] Fix definitions of __builtin_(add|sub|mul)_overflow.
[OpenCL] Fix definitions of __builtin_(add|sub|mul)_overflow
Oct 22 2018, 3:43 AM
mantognini closed D52875: Fix definitions of __builtin_(add|sub|mul)_overflow.
Oct 22 2018, 3:43 AM

Oct 19 2018

mantognini committed rC344778: [OpenCL] Remove unwanted signedness conversion from tests.
[OpenCL] Remove unwanted signedness conversion from tests
Oct 19 2018, 2:04 AM
mantognini committed rL344778: [OpenCL] Remove unwanted signedness conversion from tests.
[OpenCL] Remove unwanted signedness conversion from tests
Oct 19 2018, 2:04 AM
mantognini closed D52873: Remove unwanted signedness conversion from tests.
Oct 19 2018, 2:04 AM
mantognini closed D52873: Remove unwanted signedness conversion from tests.
Oct 19 2018, 2:04 AM

Oct 4 2018

mantognini added a comment to D52873: Remove unwanted signedness conversion from tests.

Note: the get_kernel_* functions used here all return unsigned integers, hence the warning/present patch.

Oct 4 2018, 6:42 AM
mantognini added a comment to D52875: Fix definitions of __builtin_(add|sub|mul)_overflow.

Can you write tests for this please? Particularly validate the results in a constexpr context.

Oct 4 2018, 6:42 AM
mantognini added a child revision for D52873: Remove unwanted signedness conversion from tests: D52879: Derive builtin return type from its definition.
Oct 4 2018, 3:56 AM
mantognini added parent revisions for D52879: Derive builtin return type from its definition: D52873: Remove unwanted signedness conversion from tests, D52875: Fix definitions of __builtin_(add|sub|mul)_overflow.
Oct 4 2018, 3:56 AM
mantognini added a child revision for D52875: Fix definitions of __builtin_(add|sub|mul)_overflow: D52879: Derive builtin return type from its definition.
Oct 4 2018, 3:56 AM
mantognini created D52879: Derive builtin return type from its definition.
Oct 4 2018, 3:56 AM
mantognini created D52875: Fix definitions of __builtin_(add|sub|mul)_overflow.
Oct 4 2018, 3:43 AM
mantognini created D52873: Remove unwanted signedness conversion from tests.
Oct 4 2018, 3:30 AM