This is an archive of the discontinued LLVM Phabricator instance.

[CodeGen] Fix two dots between text section name and symbol name
ClosedPublic

Authored by TaoPan on Feb 9 2021, 2:23 AM.

Details

Summary

There is a trailing dot in text section name if it has prefix, don't add
repeated dot when connect text section name and symbol name.

Diff Detail

Event Timeline

TaoPan created this revision.Feb 9 2021, 2:23 AM
TaoPan requested review of this revision.Feb 9 2021, 2:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2021, 2:23 AM
TaoPan added a comment.Feb 9 2021, 2:24 AM

Could you please have a review?

TaoPan updated this revision to Diff 322555.Feb 9 2021, 5:41 PM

git rebase

I'll take 1 week national holiday, 2/11~2/17, I'll handle the review comment soon after the holiday, thanks in advance!

MaskRay added inline comments.Feb 10 2021, 1:05 AM
llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp
920

If this makes a difference, it needs a test.

And delete braces around simple one-line statements.

TaoPan updated this revision to Diff 324525.Feb 17 2021, 9:54 PM

Modify test/DebugInfo/X86/basic-block-sections_1.ll for text section prefix test.
Without this fixing patch, there are two dots between .text.hot and _Z3fooi.__part.1~3
Delete braces around simple one-line statements

MaskRay accepted this revision.Feb 17 2021, 10:00 PM
This revision is now accepted and ready to land.Feb 17 2021, 10:00 PM

Thanks MaskRay for reviewing and accepting this patch!

TaoPan updated this revision to Diff 324878.Feb 18 2021, 9:41 PM

git rebase and merge conflict

TaoPan updated this revision to Diff 325120.Feb 19 2021, 4:55 PM

git rebase