[CodeGen] Fix two dots between text section name and symbol name

[TaoPan]

Summary

There is a trailing dot in text section name if it has prefix, don't add
repeated dot when connect text section name and symbol name.

[TaoPan]

Could you please have a review?

[TaoPan]

git rebase

[TaoPan]

I'll take 1 week national holiday, 2/11~2/17, I'll handle the review comment soon after the holiday, thanks in advance!

[MaskRay]

llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp

920

If this makes a difference, it needs a test.

And delete braces around simple one-line statements.

[TaoPan]

Modify test/DebugInfo/X86/basic-block-sections_1.ll for text section prefix test.
Without this fixing patch, there are two dots between .text.hot and _Z3fooi.__part.1~3
Delete braces around simple one-line statements

[TaoPan]

Thanks MaskRay for reviewing and accepting this patch!

[TaoPan]

git rebase and merge conflict

[TaoPan]

git rebase

llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp

if (Optional<StringRef> Prefix = F->getSectionPrefix()) {
       HasPrefix = true;
     }
   }
 
   if (UniqueSectionName) {
     Name.push_back('.');
     TM.getNameWithPrefix(Name, GO, Mang, /*MayAlwaysUsePrivate*/true);
   } else if (HasPrefix)
+    // For distinguishing between .text.${text-section-prefix}. (with trailing
+    // dot) and .text.${function-name}
     Name.push_back('.');
   return Name;
 }
 
 namespace {
 class LoweringDiagnosticInfo : public DiagnosticInfo {
   const Twine &Msg;
 
if (MBB.getSectionID() == MBBSectionID::ColdSectionID) {
     Name += BBSectionsColdTextPrefix;
     Name += MBB.getParent()->getName();
   } else if (MBB.getSectionID() == MBBSectionID::ExceptionSectionID) {
     Name += ".text.eh.";
     Name += MBB.getParent()->getName();
   } else {
     Name += MBB.getParent()->getSection()->getName();
     if (TM.getUniqueBasicBlockSectionNames()) {
+      if (!Name.endswith(".")) {
         Name += ".";
+      }
       Name += MBB.getSymbol()->getName();
     } else {
       UniqueID = NextUniqueID++;
     }
   }
 
   unsigned Flags = ELF::SHF_ALLOC | ELF::SHF_EXECINSTR;
   std::string GroupName;