danielcdh (Dehao Chen)
User

Projects

User does not belong to any projects.
User Since
Aug 26 2015, 2:20 PM (82 w, 3 d)

Recent Activity

Fri, Mar 24

danielcdh created D31344: Fix the InstCombine to reserve the VP metadata and sets correct call count..
Fri, Mar 24, 9:47 AM

Thu, Mar 23

danielcdh closed D31310: Fix trellis layout to avoid mis-identify triangle..
Thu, Mar 23, 4:40 PM
danielcdh closed D31143: Set the prof weight correctly for call instructions in DeadArgumentElimination..
Thu, Mar 23, 4:38 PM
danielcdh closed D31225: Use isFunctionHotInCallGraph to set the function section prefix..
Thu, Mar 23, 4:26 PM
danielcdh retitled D31310: Fix trellis layout to avoid mis-identify triangle. from Fix trellis layout when there is triangle. to Fix trellis layout to avoid mis-identify triangle..
Thu, Mar 23, 4:26 PM
danielcdh updated the diff for D31310: Fix trellis layout to avoid mis-identify triangle..

update

Thu, Mar 23, 4:09 PM
danielcdh closed D31219: Update the SamplePGO test to verify that unroll/icp is not invoked in thinlto compile phase..
Thu, Mar 23, 2:32 PM
danielcdh closed D31217: Disable loop unrolling and icp in SamplePGO ThinLTO compile phase.
Thu, Mar 23, 2:32 PM
danielcdh created D31310: Fix trellis layout to avoid mis-identify triangle..
Thu, Mar 23, 2:20 PM
danielcdh closed D31228: Do not set branch weight if the branch weight annotation is present..
Thu, Mar 23, 7:55 AM

Wed, Mar 22

danielcdh updated the diff for D31225: Use isFunctionHotInCallGraph to set the function section prefix..

update

Wed, Mar 22, 5:20 PM
danielcdh updated the diff for D31143: Set the prof weight correctly for call instructions in DeadArgumentElimination..

update

Wed, Mar 22, 5:14 PM
danielcdh updated the diff for D31225: Use isFunctionHotInCallGraph to set the function section prefix..

update

Wed, Mar 22, 4:18 PM
danielcdh added inline comments to D31225: Use isFunctionHotInCallGraph to set the function section prefix..
Wed, Mar 22, 3:59 PM
danielcdh updated the diff for D31225: Use isFunctionHotInCallGraph to set the function section prefix..

update

Wed, Mar 22, 3:59 PM
danielcdh added a comment to D31225: Use isFunctionHotInCallGraph to set the function section prefix..

Updated the patch to change for the cold prefix tool.

Wed, Mar 22, 2:31 PM
danielcdh updated the diff for D31225: Use isFunctionHotInCallGraph to set the function section prefix..

update

Wed, Mar 22, 2:30 PM
danielcdh updated the diff for D31143: Set the prof weight correctly for call instructions in DeadArgumentElimination..

update

Wed, Mar 22, 2:06 PM
danielcdh added inline comments to D31143: Set the prof weight correctly for call instructions in DeadArgumentElimination..
Wed, Mar 22, 2:06 PM

Tue, Mar 21

danielcdh created D31228: Do not set branch weight if the branch weight annotation is present..
Tue, Mar 21, 6:15 PM
danielcdh created D31225: Use isFunctionHotInCallGraph to set the function section prefix..
Tue, Mar 21, 5:33 PM
danielcdh created D31219: Update the SamplePGO test to verify that unroll/icp is not invoked in thinlto compile phase..
Tue, Mar 21, 3:37 PM
danielcdh added inline comments to D31217: Disable loop unrolling and icp in SamplePGO ThinLTO compile phase.
Tue, Mar 21, 3:17 PM
danielcdh created D31217: Disable loop unrolling and icp in SamplePGO ThinLTO compile phase.
Tue, Mar 21, 2:55 PM
danielcdh closed D31213: Add support for -fno-auto-profile and -fno-profile-sample-use.
Tue, Mar 21, 2:53 PM
danielcdh updated the diff for D31213: Add support for -fno-auto-profile and -fno-profile-sample-use.

add more test

Tue, Mar 21, 2:51 PM
danielcdh created D31213: Add support for -fno-auto-profile and -fno-profile-sample-use.
Tue, Mar 21, 2:36 PM
danielcdh closed D31202: Clang change: Do not inline hot callsites for samplepgo in thinlto compile phase..
Tue, Mar 21, 1:07 PM
danielcdh closed D31201: Do not inline hot callsites for samplepgo in thinlto compile phase..
Tue, Mar 21, 1:07 PM
danielcdh created D31202: Clang change: Do not inline hot callsites for samplepgo in thinlto compile phase..
Tue, Mar 21, 12:34 PM
danielcdh created D31201: Do not inline hot callsites for samplepgo in thinlto compile phase..
Tue, Mar 21, 12:33 PM
danielcdh closed D31154: Use ProfileSummary:getProfileCount to get ScaledCount for ModuleSummary.
Tue, Mar 21, 10:34 AM

Mon, Mar 20

danielcdh added inline comments to D31154: Use ProfileSummary:getProfileCount to get ScaledCount for ModuleSummary.
Mon, Mar 20, 6:22 PM
danielcdh updated the diff for D31154: Use ProfileSummary:getProfileCount to get ScaledCount for ModuleSummary.

update

Mon, Mar 20, 6:22 PM
danielcdh created D31154: Use ProfileSummary:getProfileCount to get ScaledCount for ModuleSummary.
Mon, Mar 20, 3:39 PM
danielcdh created D31143: Set the prof weight correctly for call instructions in DeadArgumentElimination..
Mon, Mar 20, 11:08 AM
danielcdh closed D30767: Updates branch_weights annotation for call instructions during inlining..
Mon, Mar 20, 9:52 AM

Fri, Mar 17

danielcdh updated the diff for D30767: Updates branch_weights annotation for call instructions during inlining..

update

Fri, Mar 17, 11:04 AM
danielcdh added inline comments to D30767: Updates branch_weights annotation for call instructions during inlining..
Fri, Mar 17, 9:29 AM
danielcdh updated the diff for D30767: Updates branch_weights annotation for call instructions during inlining..

update

Fri, Mar 17, 9:29 AM

Thu, Mar 16

danielcdh updated the diff for D30767: Updates branch_weights annotation for call instructions during inlining..

update

Thu, Mar 16, 3:57 PM

Wed, Mar 15

danielcdh updated the diff for D30767: Updates branch_weights annotation for call instructions during inlining..

update

Wed, Mar 15, 1:23 PM

Tue, Mar 14

danielcdh closed D30754: SamplePGO ThinLTO ICP fix for local functions..
Tue, Mar 14, 10:45 AM
danielcdh updated the summary of D30754: SamplePGO ThinLTO ICP fix for local functions..
Tue, Mar 14, 10:42 AM
danielcdh updated the diff for D30754: SamplePGO ThinLTO ICP fix for local functions..

update comments

Tue, Mar 14, 10:41 AM
danielcdh added inline comments to D30754: SamplePGO ThinLTO ICP fix for local functions..
Tue, Mar 14, 10:14 AM
danielcdh updated the diff for D30754: SamplePGO ThinLTO ICP fix for local functions..

update

Tue, Mar 14, 9:54 AM

Mon, Mar 13

danielcdh updated the diff for D30767: Updates branch_weights annotation for call instructions during inlining..

update

Mon, Mar 13, 8:04 PM

Fri, Mar 10

danielcdh added inline comments to D30767: Updates branch_weights annotation for call instructions during inlining..
Fri, Mar 10, 10:13 PM
danielcdh updated the diff for D30767: Updates branch_weights annotation for call instructions during inlining..

update

Fri, Mar 10, 10:13 PM
danielcdh closed D30799: Refactor the PSI to extract getCallSiteCount and remove checks for profile type..
Fri, Mar 10, 11:57 AM
danielcdh updated the diff for D30799: Refactor the PSI to extract getCallSiteCount and remove checks for profile type..

update

Fri, Mar 10, 11:55 AM
danielcdh updated the diff for D30799: Refactor the PSI to extract getCallSiteCount and remove checks for profile type..

update

Fri, Mar 10, 10:35 AM

Thu, Mar 9

danielcdh updated the summary of D30754: SamplePGO ThinLTO ICP fix for local functions..
Thu, Mar 9, 6:50 PM
danielcdh updated the diff for D30754: SamplePGO ThinLTO ICP fix for local functions..

update

Thu, Mar 9, 6:46 PM
danielcdh updated the diff for D30799: Refactor the PSI to extract getCallSiteCount and remove checks for profile type..

update

Thu, Mar 9, 6:00 PM
danielcdh closed D30800: Do not use branch metadata to check if a basic block is hot..
Thu, Mar 9, 5:56 PM
danielcdh created D30800: Do not use branch metadata to check if a basic block is hot..
Thu, Mar 9, 5:30 PM
danielcdh created D30799: Refactor the PSI to extract getCallSiteCount and remove checks for profile type..
Thu, Mar 9, 5:10 PM
danielcdh updated the summary of D30754: SamplePGO ThinLTO ICP fix for local functions..
Thu, Mar 9, 1:14 PM
danielcdh updated the diff for D30767: Updates branch_weights annotation for call instructions during inlining..

update

Thu, Mar 9, 8:49 AM

Wed, Mar 8

danielcdh created D30767: Updates branch_weights annotation for call instructions during inlining..
Wed, Mar 8, 5:13 PM
danielcdh created D30754: SamplePGO ThinLTO ICP fix for local functions..
Wed, Mar 8, 12:55 PM

Mon, Mar 6

danielcdh closed D30658: Remove the sample pgo annotation heuristic that uses call count to annotate basic block count..
Mon, Mar 6, 10:01 AM
danielcdh created D30658: Remove the sample pgo annotation heuristic that uses call count to annotate basic block count..
Mon, Mar 6, 8:25 AM

Tue, Feb 28

danielcdh closed D30053: Add function importing info from samplepgo profile to the module summary..
Tue, Feb 28, 10:21 AM
danielcdh updated the diff for D30053: Add function importing info from samplepgo profile to the module summary..

update

Tue, Feb 28, 10:20 AM

Mon, Feb 27

danielcdh added inline comments to D30053: Add function importing info from samplepgo profile to the module summary..
Mon, Feb 27, 1:55 PM
danielcdh updated the diff for D30053: Add function importing info from samplepgo profile to the module summary..

update

Mon, Feb 27, 1:55 PM

Feb 23 2017

danielcdh closed D30282: Add call branch annotation for ICP promoted direct call in SamplePGO mode..
Feb 23 2017, 2:26 PM
danielcdh updated the diff for D30282: Add call branch annotation for ICP promoted direct call in SamplePGO mode..

update

Feb 23 2017, 1:45 PM
danielcdh closed D30218: Use base discriminator in sample pgo profile matching..
Feb 23 2017, 10:39 AM

Feb 22 2017

danielcdh added a comment to D30282: Add call branch annotation for ICP promoted direct call in SamplePGO mode..

Yes, SamplePGO annotate all hot callsites with absolute branch weight to prevent BFI from messing up with inaccurate branch probability.

Feb 22 2017, 5:54 PM
danielcdh created D30282: Add call branch annotation for ICP promoted direct call in SamplePGO mode..
Feb 22 2017, 5:03 PM
danielcdh closed D30233: Fix an obvious bug in SampleProfileReaderGCC..
Feb 22 2017, 9:39 AM
danielcdh updated the diff for D30233: Fix an obvious bug in SampleProfileReaderGCC..

The gcc reader does not work on certain architectures. Move the tests to a separate file and added XFAIL for those architectures.

Feb 22 2017, 9:19 AM

Feb 21 2017

danielcdh added inline comments to D30233: Fix an obvious bug in SampleProfileReaderGCC..
Feb 21 2017, 4:52 PM
danielcdh updated the diff for D30233: Fix an obvious bug in SampleProfileReaderGCC..

add unittest

Feb 21 2017, 4:38 PM
danielcdh created D30233: Fix an obvious bug in SampleProfileReaderGCC..
Feb 21 2017, 3:31 PM
danielcdh closed D30220: Only enable AddDiscriminator pass when -fdebug-info-for-profiling is true.
Feb 21 2017, 12:47 PM
danielcdh added a comment to D30220: Only enable AddDiscriminator pass when -fdebug-info-for-profiling is true.

You are right, only discriminator is needed, the encoding and emission part should be orthogonal. Patch updated.

Feb 21 2017, 12:00 PM
danielcdh updated the diff for D30220: Only enable AddDiscriminator pass when -fdebug-info-for-profiling is true.

update

Feb 21 2017, 11:59 AM
danielcdh created D30220: Only enable AddDiscriminator pass when -fdebug-info-for-profiling is true.
Feb 21 2017, 11:45 AM
danielcdh created D30218: Use base discriminator in sample pgo profile matching..
Feb 21 2017, 11:00 AM

Feb 17 2017

danielcdh closed D28368: Increases full-unroll threshold..
Feb 17 2017, 7:58 PM
danielcdh updated the diff for D28368: Increases full-unroll threshold..

clang-format and rebase

Feb 17 2017, 7:58 PM
danielcdh added a comment to D28368: Increases full-unroll threshold..

Thanks for the reviews.

Feb 17 2017, 7:52 PM
danielcdh updated the diff for D28368: Increases full-unroll threshold..

Move the threshold update to O3

Feb 17 2017, 2:31 PM
danielcdh added a reviewer for D28368: Increases full-unroll threshold.: chandlerc.
Feb 17 2017, 2:31 PM

Feb 16 2017

danielcdh added a comment to D30053: Add function importing info from samplepgo profile to the module summary..

Is it better to introduce a new meta data for this, e.g. MD_inline_instance_imports ?

Feb 16 2017, 5:32 PM
danielcdh added inline comments to D30053: Add function importing info from samplepgo profile to the module summary..
Feb 16 2017, 5:12 PM
danielcdh added inline comments to D30053: Add function importing info from samplepgo profile to the module summary..
Feb 16 2017, 4:58 PM
danielcdh added inline comments to D30053: Add function importing info from samplepgo profile to the module summary..
Feb 16 2017, 4:49 PM
danielcdh added inline comments to D30053: Add function importing info from samplepgo profile to the module summary..
Feb 16 2017, 3:05 PM
danielcdh updated the diff for D30053: Add function importing info from samplepgo profile to the module summary..

update

Feb 16 2017, 2:50 PM
danielcdh created D30053: Add function importing info from samplepgo profile to the module summary..
Feb 16 2017, 1:29 PM

Feb 15 2017

danielcdh closed D29852: Expose getBaseDiscriminatorFromDiscriminator, getDuplicationFactorFromDiscriminator and getCopyIdentifierFromDiscriminator API so that downstream tools can use them to get the correct encoding..
Feb 15 2017, 10:06 AM
danielcdh updated the diff for D29852: Expose getBaseDiscriminatorFromDiscriminator, getDuplicationFactorFromDiscriminator and getCopyIdentifierFromDiscriminator API so that downstream tools can use them to get the correct encoding..

update

Feb 15 2017, 9:32 AM

Feb 13 2017

danielcdh updated the summary of D28368: Increases full-unroll threshold..
Feb 13 2017, 8:28 AM

Feb 10 2017

danielcdh retitled D28368: Increases full-unroll threshold. from Give higher full-unroll boosting when the loop iteration is small. to Increases full-unroll threshold..
Feb 10 2017, 3:52 PM