Page MenuHomePhabricator

TaoPan (TaoPan)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 20 2020, 12:33 AM (29 w, 1 d)

Recent Activity

Tue, Jun 8

TaoPan added inline comments to D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.
Tue, Jun 8, 12:45 AM · Restricted Project
TaoPan updated the diff for D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.

Change condition from MachineBasicBlock is begin section to MachineFunction has BB sections and add comment

Tue, Jun 8, 12:41 AM · Restricted Project

Mon, Jun 7

TaoPan added inline comments to D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.
Mon, Jun 7, 2:03 AM · Restricted Project
TaoPan updated the diff for D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.

Don't emit location of BB sections

Mon, Jun 7, 1:51 AM · Restricted Project

Tue, Jun 1

TaoPan updated the diff for D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.

Disable .cv_loc directive emission outside the primary function section.

Tue, Jun 1, 10:52 PM · Restricted Project

Thu, May 20

TaoPan added inline comments to D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched.
Thu, May 20, 7:11 PM · Restricted Project, Restricted Project

Wed, May 19

TaoPan added inline comments to D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.
Wed, May 19, 1:22 AM · Restricted Project

May 11 2021

TaoPan added inline comments to D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.
May 11 2021, 10:16 PM · Restricted Project
TaoPan updated the summary of D100735: [CodeGen] Enable Windows exception handling for basic block sections.
May 11 2021, 10:04 PM · Restricted Project
TaoPan updated the diff for D100735: [CodeGen] Enable Windows exception handling for basic block sections.

git rebase

May 11 2021, 10:03 PM · Restricted Project
TaoPan updated the diff for D99487: [CodeGen] Port basic block sections from ELF to COFF.

git rebase

May 11 2021, 10:02 PM · Restricted Project
TaoPan updated the diff for D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.

git rebase

May 11 2021, 8:41 PM · Restricted Project

May 10 2021

TaoPan updated the diff for D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.

Remove same modification of D100735

May 10 2021, 1:19 AM · Restricted Project
TaoPan updated the summary of D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.
May 10 2021, 1:15 AM · Restricted Project
TaoPan updated the diff for D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.

Remove same modification of parent D99487 and add .cv_inline_linetable to test

May 10 2021, 1:13 AM · Restricted Project

May 7 2021

TaoPan added a comment to D99487: [CodeGen] Port basic block sections from ELF to COFF.

The x64 debian failed was introduced by D101797 and is being fixed by https://reviews.llvm.org/rG72bd0116e3a1a70fb52fc47c056349b290ce2204

May 7 2021, 11:39 PM · Restricted Project
TaoPan updated the diff for D100735: [CodeGen] Enable Windows exception handling for basic block sections.

Remove content of parent D99487 for applying this patch

May 7 2021, 10:28 PM · Restricted Project
TaoPan updated the diff for D100735: [CodeGen] Enable Windows exception handling for basic block sections.

Remove content of parent D99487 for applying this patch

May 7 2021, 10:25 PM · Restricted Project
TaoPan updated the diff for D99487: [CodeGen] Port basic block sections from ELF to COFF.

git rebase for triggering auto test

May 7 2021, 10:08 PM · Restricted Project
TaoPan updated the diff for D99487: [CodeGen] Port basic block sections from ELF to COFF.

git rebase for triggering auto test

May 7 2021, 8:46 PM · Restricted Project
TaoPan updated the summary of D99487: [CodeGen] Port basic block sections from ELF to COFF.
May 7 2021, 8:23 PM · Restricted Project
TaoPan updated the diff for D99487: [CodeGen] Port basic block sections from ELF to COFF.

Remove if mingw conditionals of MBB sections.

May 7 2021, 8:20 PM · Restricted Project
TaoPan added inline comments to D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched.
May 7 2021, 7:57 PM · Restricted Project, Restricted Project
TaoPan added inline comments to D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched.
May 7 2021, 7:09 PM · Restricted Project, Restricted Project
TaoPan updated the diff for D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched.

Move test back to clang/test/CodeGen/

May 7 2021, 7:05 PM · Restricted Project, Restricted Project
TaoPan updated the summary of D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched.
May 7 2021, 6:44 PM · Restricted Project, Restricted Project
TaoPan added inline comments to D99487: [CodeGen] Port basic block sections from ELF to COFF.
May 7 2021, 2:21 AM · Restricted Project
TaoPan updated the diff for D99487: [CodeGen] Port basic block sections from ELF to COFF.

git rebase

May 7 2021, 2:15 AM · Restricted Project
TaoPan updated the diff for D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched.

git rebase

May 7 2021, 12:48 AM · Restricted Project, Restricted Project
TaoPan updated the diff for D99487: [CodeGen] Port basic block sections from ELF to COFF.

Change selection of the auxilliary MBB sections to IMAGE_COMDAT_SELECT_ASSOCIATIVE, git rebase, fix comdat name issue

May 7 2021, 12:31 AM · Restricted Project

May 6 2021

TaoPan added a comment to D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched.

Thanks Pengfei for your review comments!

May 6 2021, 11:49 PM · Restricted Project, Restricted Project
TaoPan updated the diff for D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched.

Move test from clang/test to llvm/test, remove comma of the last enum item.

May 6 2021, 11:29 PM · Restricted Project, Restricted Project
TaoPan added a reviewer for D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched: pengfei.
May 6 2021, 6:15 PM · Restricted Project, Restricted Project
TaoPan updated subscribers of D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched.
May 6 2021, 6:15 PM · Restricted Project, Restricted Project
TaoPan added reviewers for D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched: RKSimon, craig.topper.

Could you please have a review?

May 6 2021, 6:13 PM · Restricted Project, Restricted Project

Apr 30 2021

TaoPan added a comment to D99487: [CodeGen] Port basic block sections from ELF to COFF.

Thanks all!
I'll take leave between 5.1~5.6 for national holiday and personal affair, I'll response @rnk 's review comment and other further review comment after then.

Apr 30 2021, 2:35 AM · Restricted Project
TaoPan added a comment to D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.

Thanks for your review comment!
I'll take leave between 5.1~5.6 for national holiday and personal affair, I'll response further review comment after then.

Apr 30 2021, 2:32 AM · Restricted Project
TaoPan updated the diff for D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.

Forgot .section directives in the first CHECK of the last update

Apr 30 2021, 1:43 AM · Restricted Project
TaoPan updated the diff for D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.

Add .section directives test

Apr 30 2021, 1:29 AM · Restricted Project
TaoPan requested review of D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched.
Apr 30 2021, 1:10 AM · Restricted Project, Restricted Project

Apr 29 2021

TaoPan added a comment to D99487: [CodeGen] Port basic block sections from ELF to COFF.

Agree with @MaskRay I'd like to see a holistics plan/RFC on all the pieces that are needed to get this functionality. The functionality here is only tested when exceptions are actually propagated which is not common in LLVM test suite. You'll want to run and likely write very specific tests stressing the test matrix here of BBS + MFS + EH. Given all that, a larger plan that details how we can be confident that all the pieces have been accounted for and will be well tested is (IMO) imperative in getting this change reviewed and accepted.

Since this (the test matrix) is already done for ELF, would it be complete if the author added equivalent tests for COFF?

Good point, that sounds like a good avenue to pursue. @snehasish mentions some of these exact tests here https://reviews.llvm.org/D95209#2523227. Looks like there was some movement for these tests here: https://reviews.llvm.org/D96393 although it appears BBS might need Windows debuginfo support for testing. I'm chasing through a bunch of these diffs to figure out what the state of this is and I'm not quite certain what it is. @TaoPan do you have a plan you can share about the progress here so we can follow along?

Apr 29 2021, 11:58 PM · Restricted Project

Apr 28 2021

TaoPan added a comment to D99487: [CodeGen] Port basic block sections from ELF to COFF.

For some added testing you can run MSVC's SEH tests to see that this works properly: https://github.com/microsoft/compiler-tests/tree/master/seh. I wouldn't be surprised if not all of these pass in the baseline but we certainly want to make sure the ones that are remain non-regressed.

Apr 28 2021, 7:17 PM · Restricted Project

Apr 27 2021

TaoPan added a comment to D99487: [CodeGen] Port basic block sections from ELF to COFF.

Hi tmsriram, MaskRay,

Apr 27 2021, 10:34 PM · Restricted Project
TaoPan updated subscribers of D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.
Apr 27 2021, 9:55 PM · Restricted Project
TaoPan added reviewers for D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections: tmsriram, snehasish, MaskRay, rnk, pengfei.

Could you please have a review?

Apr 27 2021, 9:53 PM · Restricted Project
TaoPan requested review of D101421: [DebugInfo] Enable CodeView DebugInfo for basic block sections.
Apr 27 2021, 7:05 PM · Restricted Project

Apr 20 2021

TaoPan added a comment to D99487: [CodeGen] Port basic block sections from ELF to COFF.

Would you be able to paste the entire assembly with cv loc directives? I can try to take a look.

As the entire assembly has 500 lines, I sent to you through mail, I'll do if you think paste part of them or entire assembly to here is better.

Apr 20 2021, 12:07 AM · Restricted Project

Apr 18 2021

TaoPan updated the diff for D100735: [CodeGen] Enable Windows exception handling for basic block sections.

git rebase

Apr 18 2021, 11:39 PM · Restricted Project
TaoPan requested review of D100735: [CodeGen] Enable Windows exception handling for basic block sections.
Apr 18 2021, 6:18 PM · Restricted Project

Apr 16 2021

TaoPan added a comment to D100612: [clangd][test] Fix build error of FeatureModulesTests.

thanks, lgtm! which compiler is this btw?

Apr 16 2021, 1:39 AM · Restricted Project

Apr 15 2021

TaoPan added a comment to D100612: [clangd][test] Fix build error of FeatureModulesTests.

Hi sammccall,

Apr 15 2021, 10:32 PM · Restricted Project
TaoPan requested review of D100612: [clangd][test] Fix build error of FeatureModulesTests.
Apr 15 2021, 6:37 PM · Restricted Project
TaoPan updated the diff for D99487: [CodeGen] Port basic block sections from ELF to COFF.

git rebase

Apr 15 2021, 2:08 AM · Restricted Project
TaoPan updated the diff for D99487: [CodeGen] Port basic block sections from ELF to COFF.

Simplify text section name code

Apr 15 2021, 12:02 AM · Restricted Project

Apr 14 2021

TaoPan added a comment to D99487: [CodeGen] Port basic block sections from ELF to COFF.

This is quite important to validate the correctness of the generated assembly. If you could please check that CFI and DebugInfo are sane before we take this patch forward? Let's get a temperature on how good these are before we decide how to take it forward.

Thanks! I got the importance.
As for DebugInfo, I tried to add "--basic-block-sections=all" to RUN of llvm/test/DebugInfo/COFF/comdat.ll, text sections includes basic block text sections and CodeViewDebugInfo can be created correctly after

  1. apply this patch
  2. commenting out a Linux exception handling protocol dependent function which I plan to do in later basic block section Windows exception handling patch.

There are some non-blocking errors "error: all .cv_loc directives for a function must be in the same section" in llc stage, one error for each basic block, below is the first one.
f.__part.1: # %if.then
#DEBUG_VALUE: f:c <- $ecx
<unknown>:0: error: all .cv_loc directives for a function must be in the same section
.Ltmp3:

Apr 14 2021, 10:37 PM · Restricted Project
TaoPan added a comment to D99487: [CodeGen] Port basic block sections from ELF to COFF.

If it is easier for you to break this up, you can present exception handling in a separate patch with a clear "TODO:" at the appropriate places. That should be alright and is also easier to review.

I added "TODO:" for constructing exception section and cold section later.

Apr 14 2021, 2:11 AM · Restricted Project
TaoPan updated the summary of D99487: [CodeGen] Port basic block sections from ELF to COFF.
Apr 14 2021, 1:33 AM · Restricted Project
TaoPan updated the diff for D99487: [CodeGen] Port basic block sections from ELF to COFF.

Add TODO for constructing exception section and cold section later

Apr 14 2021, 1:32 AM · Restricted Project

Apr 5 2021

TaoPan added a comment to D99487: [CodeGen] Port basic block sections from ELF to COFF.

Hi tmsriram, MaskRay,

Apr 5 2021, 7:14 PM · Restricted Project

Mar 31 2021

TaoPan added inline comments to D99487: [CodeGen] Port basic block sections from ELF to COFF.
Mar 31 2021, 6:08 PM · Restricted Project
TaoPan updated the diff for D99487: [CodeGen] Port basic block sections from ELF to COFF.

git rebase

Mar 31 2021, 5:48 PM · Restricted Project
TaoPan updated the diff for D99487: [CodeGen] Port basic block sections from ELF to COFF.

Simplify condition of setting COFF::IMAGE_SCN_LNK_COMDAT

Mar 31 2021, 5:45 PM · Restricted Project
TaoPan updated the diff for D99487: [CodeGen] Port basic block sections from ELF to COFF.

Conditionally set COFF::IMAGE_SCN_LNK_COMDAT, add mtriple x86_64-windows-gnu support

Mar 31 2021, 2:33 AM · Restricted Project

Mar 29 2021

TaoPan added inline comments to D99487: [CodeGen] Port basic block sections from ELF to COFF.
Mar 29 2021, 11:16 PM · Restricted Project
TaoPan updated the diff for D99487: [CodeGen] Port basic block sections from ELF to COFF.

git rebase

Mar 29 2021, 1:59 AM · Restricted Project
TaoPan requested review of D99487: [CodeGen] Port basic block sections from ELF to COFF.
Mar 29 2021, 12:31 AM · Restricted Project

Mar 21 2021

TaoPan added a comment to D95209: [CodeGen] Port Machine Function Splitter from ELF to COFF.

Thanks Snehasish! I got the simplicity and value of Windows exception handling test for basic block sections. Is it ok adding llvm/test/CodeGen/X86/basic-block-sections-wineh.ll in a separate patch, as running the test won't execute the source code in this patch?

Mar 21 2021, 11:13 PM · Restricted Project

Mar 19 2021

TaoPan updated the diff for D95209: [CodeGen] Port Machine Function Splitter from ELF to COFF.

Fix llvm-mc option -mtriple -> -triple

Mar 19 2021, 1:13 AM · Restricted Project

Mar 18 2021

TaoPan updated the diff for D95209: [CodeGen] Port Machine Function Splitter from ELF to COFF.

Use same triple option format

Mar 18 2021, 11:58 PM · Restricted Project
TaoPan updated the diff for D95209: [CodeGen] Port Machine Function Splitter from ELF to COFF.

Add MFS Windows exception handling testcase

Mar 18 2021, 11:56 PM · Restricted Project
TaoPan updated the diff for D95209: [CodeGen] Port Machine Function Splitter from ELF to COFF.

Use comdat name for split text section

Mar 18 2021, 11:52 PM · Restricted Project
TaoPan updated the diff for D95209: [CodeGen] Port Machine Function Splitter from ELF to COFF.

git rebase

Mar 18 2021, 11:44 PM · Restricted Project

Feb 19 2021

TaoPan abandoned D96219: [CodeGen] Remove trailing dot of name of text section with prefix.
Feb 19 2021, 8:52 PM · Restricted Project
TaoPan updated the diff for D96327: [CodeGen] Fix two dots between text section name and symbol name.

git rebase

Feb 19 2021, 4:55 PM · Restricted Project

Feb 18 2021

TaoPan updated the diff for D96327: [CodeGen] Fix two dots between text section name and symbol name.

git rebase and merge conflict

Feb 18 2021, 9:41 PM · Restricted Project

Feb 17 2021

TaoPan added a comment to D96327: [CodeGen] Fix two dots between text section name and symbol name.

Thanks MaskRay for reviewing and accepting this patch!

Feb 17 2021, 10:51 PM · Restricted Project
TaoPan added a comment to D96393: [CodeGen] Add Machine Function Splitter and DebugInfo composite testcase.

We have not added support for Windows debug info format so we need to add that before extending the test. :)
Lets discuss the approach offline before spending time on how to add this support.

Thanks! I got the status of Windows debug info format. Let's discuss offline.

Feb 17 2021, 10:44 PM · Restricted Project
TaoPan updated the diff for D96327: [CodeGen] Fix two dots between text section name and symbol name.

Modify test/DebugInfo/X86/basic-block-sections_1.ll for text section prefix test.
Without this fixing patch, there are two dots between .text.hot and _Z3fooi.__part.1~3
Delete braces around simple one-line statements

Feb 17 2021, 9:54 PM · Restricted Project
TaoPan added a comment to D96393: [CodeGen] Add Machine Function Splitter and DebugInfo composite testcase.

Please do not merge this test. Apologies if I was unclear earlier - there is no need for this test since the functionality is already tested in test/DebugInfo/X86/basic-block-sections_1.ll
The machine function splitter (MFS) pass uses basic block sections so if the dwarf debug info generated by basic block sections is correct then MFS is also correct.

Thanks! I got it's MFS dependent basic block sections ensure dwarf debug info correct.
As for Windows COFF, is it also not MFS but MFS dependent basic block sections may be incorrect for Windows native debuggers, so need to extend basic block sections debug info test at first?

Feb 17 2021, 9:25 PM · Restricted Project
TaoPan added a comment to D96393: [CodeGen] Add Machine Function Splitter and DebugInfo composite testcase.

Thanks for reminding the discussion of not adding a separate debug info test for function splitting! I’ll merge the test into test/DebugInfo/X86/basic-block-sections_1.ll.
Thanks for sharing information of dwarf, PE/COFF, CodeView, cygwin and Windows native debuggers! I think

add dwarf based test for Linux and Windows Cygwin

is independent on

(refer to your shared information and existing test of test/DebugInfo/PDB/Native/ to) add CodeView based test for Windows native debuggers, it’s depends on #D95209, it’s better be added in #D95209.
Feb 17 2021, 8:05 PM · Restricted Project

Feb 10 2021

TaoPan added a comment to D96393: [CodeGen] Add Machine Function Splitter and DebugInfo composite testcase.

I'll take 1 week national holiday, 2/11~2/17, I'll handle the review comment soon after the holiday, thanks in advance!

Feb 10 2021, 12:24 AM · Restricted Project
TaoPan added a comment to D96327: [CodeGen] Fix two dots between text section name and symbol name.

I'll take 1 week national holiday, 2/11~2/17, I'll handle the review comment soon after the holiday, thanks in advance!

Feb 10 2021, 12:23 AM · Restricted Project

Feb 9 2021

TaoPan added a comment to D96393: [CodeGen] Add Machine Function Splitter and DebugInfo composite testcase.

Can you elaborate on the motivation behind this test?

As the behaviour exists today, -split-machine-functions and -basic-block-sections are exclusive options and the former takes precedence. With D96392 we are planning on switching the precedence but they still remain exclusive. Thus in this test, the RUN invocations on line 2,3 and 4 are using -split-machine-functions. Furthermore, the underlying mechanism driving both options are the same so testing the generation of debug information together is redundant. For more information take a look at the discussion in D90989.

Feb 9 2021, 10:13 PM · Restricted Project
TaoPan updated the diff for D96393: [CodeGen] Add Machine Function Splitter and DebugInfo composite testcase.

git rebase

Feb 9 2021, 9:59 PM · Restricted Project
TaoPan updated the diff for D96393: [CodeGen] Add Machine Function Splitter and DebugInfo composite testcase.

Remove redundant -basic-block-sections test as it's exclusive with -split-machine-functions.

Feb 9 2021, 9:58 PM · Restricted Project
TaoPan updated the summary of D96393: [CodeGen] Add Machine Function Splitter and DebugInfo composite testcase.
Feb 9 2021, 9:39 PM · Restricted Project
TaoPan added a comment to D96393: [CodeGen] Add Machine Function Splitter and DebugInfo composite testcase.

I referred llvm/test/CodeGen/X86/machine-function-splitter.ll and llvm/test/DebugInfo/X86/basic-block-sections_1.ll to add this machine function splitter and DebugInfo composite testcase.
Could you please have a review?

Feb 9 2021, 7:48 PM · Restricted Project
TaoPan requested review of D96393: [CodeGen] Add Machine Function Splitter and DebugInfo composite testcase.
Feb 9 2021, 7:44 PM · Restricted Project
TaoPan updated the diff for D96327: [CodeGen] Fix two dots between text section name and symbol name.

git rebase

Feb 9 2021, 5:41 PM · Restricted Project
TaoPan added a comment to D96219: [CodeGen] Remove trailing dot of name of text section with prefix.

Thank MaskRay!
I submitted a new patch https://reviews.llvm.org/D96327 to add the comment and fix the issue of Summary.

Feb 9 2021, 2:26 AM · Restricted Project
TaoPan added a comment to D96327: [CodeGen] Fix two dots between text section name and symbol name.

Could you please have a review?

Feb 9 2021, 2:24 AM · Restricted Project
TaoPan requested review of D96327: [CodeGen] Fix two dots between text section name and symbol name.
Feb 9 2021, 2:23 AM · Restricted Project

Feb 8 2021

TaoPan added a comment to D96219: [CodeGen] Remove trailing dot of name of text section with prefix.

Thanks! I got the trailing dot is for distinguishing text section name with prefix and function name with --function-sections.
Is it ok adding comment to the code of adding trailing dot, like "For distinguishing between .text.${text-section-prefix}. (with trailing dot) and .text.${function-name}"?

Feb 8 2021, 9:22 PM · Restricted Project
TaoPan added a comment to D96219: [CodeGen] Remove trailing dot of name of text section with prefix.

Thank MaskRay for the review comment!
I don’t understand the intention of the last dot of “.text.hot.”, it’s “.text.${text-section-prefix}.”.
The example of function name exit with –ffunction-sections doesn’t include text-section-prefix, it’s “.text.${function-name}”.

Feb 8 2021, 7:33 PM · Restricted Project

Feb 7 2021

TaoPan updated the summary of D96219: [CodeGen] Remove trailing dot of name of text section with prefix.
Feb 7 2021, 1:31 AM · Restricted Project
TaoPan updated the diff for D96219: [CodeGen] Remove trailing dot of name of text section with prefix.

Add Summary

Feb 7 2021, 1:28 AM · Restricted Project
TaoPan added a comment to D96219: [CodeGen] Remove trailing dot of name of text section with prefix.

Could you please have a review?

Feb 7 2021, 1:11 AM · Restricted Project
TaoPan requested review of D96219: [CodeGen] Remove trailing dot of name of text section with prefix.
Feb 7 2021, 1:10 AM · Restricted Project

Jan 26 2021

TaoPan added a comment to D95209: [CodeGen] Port Machine Function Splitter from ELF to COFF.

Thanks for your guidance of the existing CFI and DebugInfo tests, I'll add COFF tests.

Jan 26 2021, 5:55 PM · Restricted Project

Jan 25 2021

TaoPan added a comment to D95209: [CodeGen] Port Machine Function Splitter from ELF to COFF.

Thanks for your review comment!
I don’t have any more detail information about COFF versus ELF difference with regards to DebugInfo and CFI handling.
I used this patch to build my c micro case, workable.
Is it ok that improves this feature by issue driven as it’s default off?
I’ll try to enable this feature to build some complex application, e.g. chromium windows, improve this feature if there are any issues.

Jan 25 2021, 6:27 PM · Restricted Project