Differential D96272

[mlir][math] Split off the math dialect.
ClosedPublic
Actions

Authored by herhut on Feb 8 2021, 8:55 AM.

Details

Reviewers

ftynse
mravishankar
antiagainst
aartbik
nicolasvasilache

Commits

rG4348d8ab7f6a: [mlir][math] Split off the math dialect.

Summary

This does not split transformations, yet. Those will be done as future clean ups.

RFC in https://llvm.discourse.group/t/rfc-split-the-math-dialect-from-std/

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

herhut created this revision.Feb 8 2021, 8:55 AM

Herald added a reviewer: mravishankar. · View Herald TranscriptFeb 8 2021, 8:55 AM

Herald added a reviewer: antiagainst. · View Herald Transcript

Herald added a reviewer: aartbik. · View Herald Transcript

Herald added subscribers: mravishankar, teijeong, rdzhabarov and 20 others. · View Herald Transcript

herhut requested review of this revision.Feb 8 2021, 8:55 AM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptFeb 8 2021, 8:55 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Thanks!

mlir/include/mlir/Dialect/Linalg/EDSC/FoldedIntrinsics.h
59–60	Nit: keep dialect prefixes sorted
mlir/include/mlir/Dialect/Math/IR/MathOps.td
2	copy-pasta
mlir/include/mlir/Dialect/Math/Transforms/Passes.h
10–11	Copy-pasta of copy-pasta
mlir/lib/Conversion/StandardToSPIRV/StandardToSPIRV.cpp
1136	Nit: we drop usernames in LLVM
mlir/test/lib/Transforms/TestExpandTanh.cpp
1–2	Something went wrong here

This revision is now accepted and ready to land.Feb 8 2021, 9:11 AM

Harbormaster completed remote builds in B88306: Diff 322133.Feb 8 2021, 9:47 AM

Fix formatting issues.

Added missing tests

Harbormaster completed remote builds in B88601: Diff 322630.Feb 10 2021, 3:34 AM

Thanks for the review!

Harbormaster completed remote builds in B88606: Diff 322639.Feb 10 2021, 4:04 AM

Implement inlining interface

This revision was landed with ongoing or failed builds.Feb 12 2021, 1:55 AM

Closed by commit rG4348d8ab7f6a: [mlir][math] Split off the math dialect. (authored by herhut). · Explain Why

This revision was automatically updated to reflect the committed changes.

herhut added a commit: rG4348d8ab7f6a: [mlir][math] Split off the math dialect..

Harbormaster completed remote builds in B88950: Diff 323248.Feb 12 2021, 3:16 AM

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

Dialect/

1 line

Linalg/

EDSC/

FoldedIntrinsics.h

3 lines

Math/

1 line

EDSC/

25 lines

IR/

2 lines

32 lines

19 lines

430 lines

Transforms/

24 lines

StandardOps/

EDSC/

2 lines

IR/

329 lines

Transforms/

4 lines

InitAllDialects.h

2 lines

lib/

Conversion/

GPUToNVVM/

LowerGpuOpsToNVVMOps.cpp

53 lines

GPUToROCDL/

LowerGpuOpsToROCDLOps.cpp

53 lines

StandardToLLVM/

1 line

StandardToLLVM.cpp

30 lines

StandardToSPIRV/

1 line

StandardToSPIRV.cpp

19 lines

TosaToLinalg/

1 line

TosaToLinalg.cpp

9 lines

TosaToLinalgPass.cpp

4 lines

Dialect/

1 line

Linalg/

EDSC/

3 lines

1 line

Transforms/

4 lines

Math/

2 lines

IR/

14 lines

MathDialect.cpp

35 lines

19 lines

Transforms/

12 lines

	Math/	Transforms/
	StandardOps/	Transforms/

16 lines

StandardOps/

Transforms/

1 line

test/

Analysis/

test-shape-fn-report.mlir

2 lines

Conversion/

GPUToNVVM/

gpu-to-nvvm.mlir

66 lines

GPUToROCDL/

gpu-to-rocdl.mlir

60 lines

StandardToLLVM/

convert-to-llvmir.mlir

8 lines

standard-to-llvm.mlir

12 lines

StandardToSPIRV/

std-ops-to-spirv.mlir

14 lines

subview-to-spirv.mlir

4 lines

Dialect/

Linalg/

10 lines

convert-elementwise-to-linalg.mlir

4 lines

2 lines

vectorization.mlir

24 lines

Math/

172 lines

SCF/

parallel-loop-fusion.mlir

4 lines

Standard/

expand-tanh.mlir

6 lines

4 lines

EDSC/

builder-api-test.cpp

2 lines

IR/

70 lines

Transforms/

buffer-deallocation.mlir

8 lines

buffer-hoisting.mlir

4 lines

buffer-loop-hoisting.mlir

2 lines

canonicalize-dce.mlir

8 lines

copy-removal.mlir

8 lines

promote-buffers-to-stack.mlir

2 lines

lib/

Transforms/

TestExpandTanh.cpp

4 lines

mlir-opt/

commandline.mlir

1 line

Diff 323259

mlir/include/mlir/Dialect/CMakeLists.txt

Loading...

mlir/include/mlir/Dialect/Linalg/EDSC/FoldedIntrinsics.h

Loading...

mlir/include/mlir/Dialect/Math/CMakeLists.txt

Loading...

mlir/include/mlir/Dialect/Math/EDSC/Intrinsics.h

Loading...

mlir/include/mlir/Dialect/Math/IR/CMakeLists.txt

Loading...

mlir/include/mlir/Dialect/Math/IR/Math.h

Loading...

mlir/include/mlir/Dialect/Math/IR/MathBase.td

Loading...

mlir/include/mlir/Dialect/Math/IR/MathOps.td

Loading...

mlir/include/mlir/Dialect/Math/Transforms/Passes.h

Loading...

mlir/include/mlir/Dialect/StandardOps/EDSC/Intrinsics.h

Loading...

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

Loading...

mlir/include/mlir/Dialect/StandardOps/Transforms/Passes.h

Loading...

mlir/include/mlir/InitAllDialects.h

Loading...

mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp

Loading...

mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp

Loading...

mlir/lib/Conversion/StandardToLLVM/CMakeLists.txt

Loading...

mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp

Loading...

mlir/lib/Conversion/StandardToSPIRV/CMakeLists.txt

Loading...

mlir/lib/Conversion/StandardToSPIRV/StandardToSPIRV.cpp

Loading...

mlir/lib/Conversion/TosaToLinalg/CMakeLists.txt

Loading...

mlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp

Loading...

mlir/lib/Conversion/TosaToLinalg/TosaToLinalgPass.cpp

Loading...

mlir/lib/Dialect/CMakeLists.txt

Loading...

mlir/lib/Dialect/Linalg/EDSC/Builders.cpp

Loading...

mlir/lib/Dialect/Linalg/EDSC/CMakeLists.txt

Loading...

mlir/lib/Dialect/Linalg/Transforms/Bufferize.cpp

Loading...

mlir/lib/Dialect/Math/CMakeLists.txt

Loading...

mlir/lib/Dialect/Math/IR/CMakeLists.txt

Loading...

mlir/lib/Dialect/Math/IR/MathDialect.cpp

Loading...

mlir/lib/Dialect/Math/IR/MathOps.cpp

Loading...

mlir/lib/Dialect/Math/Transforms/CMakeLists.txt

Loading...

mlir/lib/Dialect/Math/Transforms/ExpandTanh.cpp

Loading...

mlir/lib/Dialect/StandardOps/Transforms/CMakeLists.txt

Loading...

mlir/lib/Dialect/StandardOps/Transforms/ExpandTanh.cpp

Loading...

mlir/test/Analysis/test-shape-fn-report.mlir

Loading...

mlir/test/Conversion/GPUToNVVM/gpu-to-nvvm.mlir

Loading...

mlir/test/Conversion/GPUToROCDL/gpu-to-rocdl.mlir

Loading...

mlir/test/Conversion/StandardToLLVM/convert-to-llvmir.mlir

Loading...

mlir/test/Conversion/StandardToLLVM/standard-to-llvm.mlir

Loading...

mlir/test/Conversion/StandardToSPIRV/std-ops-to-spirv.mlir

Loading...

mlir/test/Conversion/StandardToSPIRV/subview-to-spirv.mlir

Loading...

mlir/test/Dialect/Linalg/bufferize.mlir

Loading...

mlir/test/Dialect/Linalg/convert-elementwise-to-linalg.mlir

Loading...

mlir/test/Dialect/Linalg/fusion.mlir

Loading...

mlir/test/Dialect/Linalg/vectorization.mlir

Loading...

mlir/test/Dialect/Math/ops.mlir

Loading...

mlir/test/Dialect/SCF/parallel-loop-fusion.mlir

Loading...

mlir/test/Dialect/Standard/expand-tanh.mlir

Loading...

mlir/test/Dialect/Standard/ops.mlir

Loading...

mlir/test/EDSC/builder-api-test.cpp

Loading...

mlir/test/IR/core-ops.mlir

Loading...

mlir/test/Transforms/buffer-deallocation.mlir

Loading...

mlir/test/Transforms/buffer-hoisting.mlir

Loading...

mlir/test/Transforms/buffer-loop-hoisting.mlir

Loading...

mlir/test/Transforms/canonicalize-dce.mlir

Loading...

mlir/test/Transforms/copy-removal.mlir

Loading...

mlir/test/Transforms/promote-buffers-to-stack.mlir

Loading...

mlir/test/lib/Transforms/TestExpandTanh.cpp

Loading...

mlir/test/mlir-opt/commandline.mlir

Loading...