[AArch64] Use '//' as comment string for MSVC assembly

[mstorsjo]

Summary

As the actual MSVC toolset doesn't use the GAS-style assembly that Clang/LLVM produces and consumes, there's no reference for what string to use for e.g. comments when building with a MSVC triple.

This frees up the use of semicolon as separator string, just like was done for GNU targets in 23413195649d0cf6f3860ae8b5fb115b35032075. (Previously, both the separator and comment strings were set to the same, a semicolon.)

Compiler-rt extensively uses separator chars in its assembly, and that assembly should be buildable with clang-cl for MSVC too.

[maxim-kuvyrkov]

Looks good to me. It might be prudent to switch comment string from ";" to "//" for 32-bit ARM COFF as well, but that should be a separate change anyway.

[tambre]

Thanks! Maybe worth a changelog entry?

[rnk]

I guess the actual rules for the armasm tool that MSVC uses are documented here:
https://developer.arm.com/documentation/dui0802/b/Via-File-Syntax/Via-file-syntax

Lines beginning with a semicolon (;) or a hash (#) character as the first nonwhitespace character are comment lines. If a semicolon or hash character appears anywhere else in a line, it is not treated as the start of a comment. For example:
-o objectname.axf ;this is not a comment
A comment ends at the end of a line, or at the end of the file. There are no multi-line comments, and there are no part-line comments.

But we want to support part-line comments, so I guess we have to use //.

lgtm

[mstorsjo]

In D96259#2548724, @tambre wrote:

Thanks! Maybe worth a changelog entry?

I think that's a bit overkill TBH

In D96259#2548965, @rnk wrote:

I guess the actual rules for the armasm tool that MSVC uses are documented here:
https://developer.arm.com/documentation/dui0802/b/Via-File-Syntax/Via-file-syntax

Lines beginning with a semicolon (;) or a hash (#) character as the first nonwhitespace character are comment lines. If a semicolon or hash character appears anywhere else in a line, it is not treated as the start of a comment. For example:
-o objectname.axf ;this is not a comment
A comment ends at the end of a line, or at the end of the file. There are no multi-line comments, and there are no part-line comments.

But we want to support part-line comments, so I guess we have to use //.

Yes - and the armasm syntax is pretty much orthogonal here anyway.

In the same way on x86, clang-cl doesn't interpret .S files as if they were in masm format as that's something totally different (we have llvm-ml for that), and when instructed to output asm, it outputs gas-like syntax (although maybe it should produce masm-like assembly for consistency with msvc?). So in both cases, masm and armasm syntax are entirely different from what's put into or interpreted from gas-like .S assembly.

[mstorsjo]

@rnk @tstellar Are you ok with backporting this to 12.x (after cooking in main for a couple days), to fix the issue that is brought up in https://reviews.llvm.org/rGb2851aea80e5a8f0cfd6c3c5a56a6b00fb28c6b6?

[mstorsjo]

In D96259#2549432, @mstorsjo wrote:

@rnk @tstellar Are you ok with backporting this to 12.x (after cooking in main for a couple days), to fix the issue that is brought up in https://reviews.llvm.org/rGb2851aea80e5a8f0cfd6c3c5a56a6b00fb28c6b6?

This has been in main for a couple days now and I haven't heard back about it. Anyone want to give a thumbs up for backporting to 12.x, @rnk @tstellar?

[tstellar]

Can you file a bug for the backport request?

[mstorsjo]

In D96259#2560135, @tstellar wrote:

Can you file a bug for the backport request?

(Adding a reference here as well) I guess https://bugs.llvm.org/show_bug.cgi?id=49075 will do for that.

llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp

AArch64MCAsmInfoMicrosoftCOFF::AArch64MCAsmInfoMicrosoftCOFF() {
   Data16bitsDirective = "\t.hword\t";
   Data32bitsDirective = "\t.word\t";
   Data64bitsDirective = "\t.xword\t";
 
   AlignmentIsInBytes = false;
   SupportsDebugInformation = true;
   CodePointerSize = 8;
 
-  CommentString = ";";
+  CommentString = "//";
   ExceptionsType = ExceptionHandling::WinEH;
   WinEHEncodingType = WinEH::EncodingType::Itanium;
 }
 
 AArch64MCAsmInfoGNUCOFF::AArch64MCAsmInfoGNUCOFF() {
   PrivateGlobalPrefix = ".L";
   PrivateLabelPrefix = ".L";
 

llvm/test/CodeGen/AArch64/cfguard-checks.ll

lpad:                                             ; preds = %entry
   ; CHECK:        adrp x8, __guard_check_icall_fptr
   ; CHECK:        ldr x9, [x8, :lo12:__guard_check_icall_fptr]
   ; CHECK:        adrp x8, target_func
   ; CHECK:        add x8, x8, :lo12:target_func
   ; CHECK:        mov x15, x8
   ; CHECK:        blr x9
   ; CHECK-NEXT:   .Ltmp0:
   ; CHECK-NEXT:   blr x8
-  ; CHECK:       ; %invoke.cont
-  ; CHECK:       ; %lpad
+  ; CHECK:       // %invoke.cont
+  ; CHECK:       // %lpad
 }
 
 declare void @h()
 
 
 ; Test that longjmp targets have public labels and are included in the .gljmp section.
 %struct._SETJMP_FLOAT128 = type { [2 x i64] }
 @buf1 = internal global [16 x %struct._SETJMP_FLOAT128] zeroinitializer, align 16

llvm/test/CodeGen/AArch64/landingpad-ifcvt.ll

 ; RUN: llc < %s | FileCheck %s
 
 ; Make sure this doesn't crash (and the output is sane).
-; CHECK: ; %__except.ret
+; CHECK: // %__except.ret
 ; CHECK-NEXT: mov     x0, xzr
 
 target datalayout = "e-m:w-p:64:64-i32:32-i64:64-i128:128-n32:64-S128"
 target triple = "aarch64-pc-windows-msvc19.11.0"
 
 define i64 @f(i32* %hwnd, i32 %message, i64 %wparam, i64 %lparam) personality i8* bitcast (i32 (...)* @__C_specific_handler to i8*) {
 entry:
   %call = invoke i64 @callee(i32* %hwnd, i32 %message, i64 %wparam, i64 %lparam)

llvm/test/CodeGen/AArch64/reloc-specifiers.mir

 # RUN: llc -mtriple=arm64-windows -start-after=prologepilog -show-mc-encoding \
 # RUN: -o - %s | FileCheck %s
 
 --- |
   define void @bar() { ret void }
 ...
 
 ---
 name:            bar
 body: |
   bb.0:
     ; CHECK-LABEL: bar
 
-    ; CHECK: movz    x0, #:abs_g1_s:.Lfoo$frame_escape_0 ; encoding: [0bAAA00000,A,0b101AAAAA,0xd2]
+    ; CHECK: movz    x0, #:abs_g1_s:.Lfoo$frame_escape_0 // encoding: [0bAAA00000,A,0b101AAAAA,0xd2]
     ; CHECK: fixup A - offset: 0, value: :abs_g1_s:.Lfoo$frame_escape_0, kind: fixup_aarch64_movw
     renamable $x0 = MOVZXi target-flags(aarch64-g1, aarch64-s) <mcsymbol .Lfoo$frame_escape_0>, 16
 
-    ; CHECK: movk    x0, #:abs_g0_nc:.Lfoo$frame_escape_0 ; encoding: [0bAAA00000,A,0b100AAAAA,0xf2]
+    ; CHECK: movk    x0, #:abs_g0_nc:.Lfoo$frame_escape_0 // encoding: [0bAAA00000,A,0b100AAAAA,0xf2]
     ; CHECK: fixup A - offset: 0, value: :abs_g0_nc:.Lfoo$frame_escape_0, kind: fixup_aarch64_movw
     renamable $x0 = MOVKXi $x0, target-flags(aarch64-g0, aarch64-nc) <mcsymbol .Lfoo$frame_escape_0>, 0
 ...

llvm/test/CodeGen/AArch64/seh_funclet_x1.ll

 ; RUN: llc -o - %s -verify-machineinstrs -mtriple=aarch64-windows | FileCheck %s
 
 ; Windows runtime passes the establisher frame as the second argument to the
 ; termination handler.  Check that we copy it into fp.
 
 ; CHECK:      ?dtor$3@?0?main@4HA":
 ; CHECK:      .seh_proc "?dtor$3@?0?main@4HA"
-; CHECK:      stp     x29, x30, [sp, #-16]!   ; 16-byte Folded Spill
+; CHECK:      stp     x29, x30, [sp, #-16]!   // 16-byte Folded Spill
 ; CHECK-NEXT: .seh_save_fplr_x 16
 ; CHECK-NEXT: .seh_endprologue
 ; CHECK-NEXT: mov     x29, x1
 
 target datalayout = "e-m:w-p:64:64-i32:32-i64:64-i128:128-n32:64-S128"
 target triple = "aarch64-unknown-windows-msvc19.15.26732"
 
 ; Function Attrs: noinline nounwind optnone uwtable

llvm/test/CodeGen/AArch64/win64-no-uwtable.ll

 ; RUN: llc -mtriple=arm64-windows -o - %s | FileCheck %s
 
 declare void @f()
 declare void @g()
 
 ; Function Attrs: nounwind
 define dso_local void @SEHfilter() nounwind "frame-pointer"="all" {
 ; CHECK-LABEL: @SEHfilter
 ; CHECK:       %bb.0:
 ; CHECK-NEXT:  stp     x30, x29, [sp, #-32]!
 ; CHECK-NEXT:  str     x19, [sp, #16]
 ; CHECK-NEXT:  ldr     w19, [x8]
 ; CHECK-NEXT:  mov     x29, sp
 ; CHECK-NEXT:  bl      g
 ; CHECK-NEXT:  cbz     w19, .LBB0_2
-; CHECK-NEXT:  ; %bb.1:
+; CHECK-NEXT:  // %bb.1:
 ; CHECK-NEXT:  ldr     x19, [sp, #16]
 ; CHECK-NEXT:  ldp     x30, x29, [sp], #32
 ; CHECK-NEXT:  ret
-; CHECK-NEXT:  .LBB0_2:                                ; %if.end.i
+; CHECK-NEXT:  .LBB0_2:                                // %if.end.i
 ; CHECK-NEXT:  bl      f
 ; CHECK-NEXT:  brk     #0x1
   %1 = load i32, i32* undef, align 4
   tail call void @g()
   %tobool.i = icmp eq i32 %1, 0
   br i1 %tobool.i, label %if.end.i, label %exit
 
 if.end.i:
   call void @f()
   unreachable
 
 exit:
   ret void
 }
 

llvm/test/CodeGen/AArch64/windows-extern-weak.ll

 ; RUN: llc -mtriple aarch64-windows -filetype asm -o - < %s | FileCheck %s
 ; RUN: llc -mtriple aarch64-windows -filetype asm -o - -fast-isel %s | FileCheck %s
 ; RUN: llc -mtriple aarch64-windows -filetype asm -o - -global-isel -global-isel-abort=0 %s | FileCheck %s
 
 define void @func() {
 ; CHECK-LABEL: func:
 ; CHECK:      str x30, [sp, #-16]!
 ; CHECK-NEXT: .seh_save_reg_x x30, 16
 ; CHECK-NEXT: .seh_endprologue
 ; CHECK-NEXT: adrp x8, .refptr.weakfunc
 ; CHECK-NEXT: ldr x8, [x8, :lo12:.refptr.weakfunc]
 ; CHECK-NEXT: cbz     x8, .LBB0_2
-; CHECK-NEXT: ; %bb.1:
+; CHECK-NEXT: // %bb.1:
 ; CHECK-NEXT: blr     x8
 ; CHECK-NEXT: .LBB0_2:
 ; CHECK-NEXT: .seh_startepilogue
 ; CHECK-NEXT: ldr x30, [sp], #16
 ; CHECK-NEXT: .seh_save_reg_x x30, 16
 ; CHECK-NEXT: .seh_endepilogue
 ; CHECK-NEXT: ret
 

llvm/test/CodeGen/AArch64/wineh-try-catch-nobase.ll

 ; RUN: llc -o - %s -mtriple=aarch64-windows -verify-machineinstrs | FileCheck %s
 
 ; Make sure we don't have a base pointer.
 ; CHECK-LABEL: "?a@@YAXXZ":
 ; CHECK-NOT: x19
 
 ; Check that we compute the address relative to fp.
 ; CHECK-LABEL: "?catch$2@?0??a@@YAXXZ@4HA":
-; CHECK:             stp     x29, x30, [sp, #-16]!   ; 16-byte Folded Spill
+; CHECK:             stp     x29, x30, [sp, #-16]!   // 16-byte Folded Spill
 ; CHECK-NEXT:        .seh_save_fplr_x 16
 ; CHECK-NEXT:        .seh_endprologue
-; CHECK-NEXT:        sub     x0, x29, #16            ; =16
+; CHECK-NEXT:        sub     x0, x29, #16            // =16
 ; CHECK-NEXT:        mov     x1, xzr
 ; CHECK-NEXT:        bl      "?bb@@YAXPEAHH@Z"
 ; CHECK-NEXT:        adrp    x0, .LBB0_1
 ; CHECK-NEXT:        add     x0, x0, .LBB0_1
 ; CHECK-NEXT:        .seh_startepilogue
-; CHECK-NEXT:        ldp     x29, x30, [sp], #16     ; 16-byte Folded Reload
+; CHECK-NEXT:        ldp     x29, x30, [sp], #16     // 16-byte Folded Reload
 ; CHECK-NEXT:        .seh_save_fplr_x 16
 ; CHECK-NEXT:        .seh_endepilogue
 ; CHECK-NEXT:        ret
 
 target datalayout = "e-m:w-p:64:64-i32:32-i64:64-i128:128-n32:64-S128"
 target triple = "aarch64-unknown-windows-msvc19.11.0"
 
 define dso_local void @"?a@@YAXXZ"(i64 %p1) personality i8* bitcast (i32 (...)* @__CxxFrameHandler3 to i8*) {

llvm/test/CodeGen/AArch64/wineh-try-catch.ll

 ; CHECK:       sub     x0, x29, [[B_OFFSET:#[1-9][0-9]+]]
 ; CHECK:       bl      "?init@@YAXPEAH@Z"
 
 ; This is the label for the throw that is encoded in the ip2state.
 ; We are inside the try block, where we make a call to func2
 ; CHECK-LABEL: .Ltmp0:
 ; CHECK:       bl      "?func2@@YAHXZ
 
-; CHECK:        [[CATCHRETDEST:.LBB0_[0-9]+]]:      ; %catchret.dest
+; CHECK:        [[CATCHRETDEST:.LBB0_[0-9]+]]:      // %catchret.dest
 
 ; Check the catch funclet.
 ; CHECK-LABEL: "?catch$2@?0??func@@YAHXZ@4HA":
 
 ; Check that the stack space is allocated only for the callee saved registers.
 ; CHECK:       stp     x19, x20, [sp, #-48]!
 ; CHECK:       str     x21, [sp, #16]
 ; CHECK:       str     x28, [sp, #24]

 ; CHECK:       adrp    x0, .LBB0_3
 ; CHECK-NEXT:  add     x0, x0, [[CATCHRETDEST]]
 
 
 ; Now check that the offset of the unwind help object from the stack pointer on
 ; entry to func is encoded in cppxdata that is passed to __CxxFrameHandler3.  As
 ; computed above, this comes to -16.
 ; CHECK-LABEL:        "$cppxdata$?func@@YAHXZ":
-; CHECK-NEXT:         .word   429065506               ; MagicNumber
-; CHECK-NEXT:         .word   2                       ; MaxState
-; CHECK-NEXT:         .word   ("$stateUnwindMap$?func@@YAHXZ")@IMGREL ; UnwindMap
-; CHECK-NEXT:         .word   1                       ; NumTryBlocks
-; CHECK-NEXT:         .word   ("$tryMap$?func@@YAHXZ")@IMGREL ; TryBlockMap
-; CHECK-NEXT:         .word   4                       ; IPMapEntries
-; CHECK-NEXT:         .word   ("$ip2state$?func@@YAHXZ")@IMGREL ; IPToStateXData
-; CHECK-NEXT:         .word   -16                     ; UnwindHelp
+; CHECK-NEXT:         .word   429065506               // MagicNumber
+; CHECK-NEXT:         .word   2                       // MaxState
+; CHECK-NEXT:         .word   ("$stateUnwindMap$?func@@YAHXZ")@IMGREL // UnwindMap
+; CHECK-NEXT:         .word   1                       // NumTryBlocks
+; CHECK-NEXT:         .word   ("$tryMap$?func@@YAHXZ")@IMGREL // TryBlockMap
+; CHECK-NEXT:         .word   4                       // IPMapEntries
+; CHECK-NEXT:         .word   ("$ip2state$?func@@YAHXZ")@IMGREL // IPToStateXData
+; CHECK-NEXT:         .word   -16                     // UnwindHelp
 
 ; UNWIND: Function: ?func@@YAHXZ (0x0)
 ; UNWIND: Prologue [
 ; UNWIND-NEXT: ; nop
 ; UNWIND-NEXT: ; sub sp, #624
 ; UNWIND-NEXT: ; add fp, sp, #32
 ; UNWIND-NEXT: ; stp x29, x30, [sp, #32]
 ; UNWIND-NEXT: ; str x28, [sp, #24]

llvm/test/MC/AArch64/coff-relocations.s

-; RUN: llvm-mc -triple aarch64-windows -filetype obj -o %t.obj %s
-; RUN: llvm-readobj -r %t.obj | FileCheck %s
-; RUN: llvm-objdump -d %t.obj | FileCheck %s --check-prefix=DISASM
+// RUN: llvm-mc -triple aarch64-windows -filetype obj -o %t.obj %s
+// RUN: llvm-readobj -r %t.obj | FileCheck %s
+// RUN: llvm-objdump -d %t.obj | FileCheck %s --check-prefix=DISASM
 
-; IMAGE_REL_ARM64_ADDR32
+// IMAGE_REL_ARM64_ADDR32
 .Linfo_foo:
   .asciz "foo"
   .long foo
 
-; IMAGE_REL_ARM64_ADDR32NB
+// IMAGE_REL_ARM64_ADDR32NB
 .long func@IMGREL
 
-; IMAGE_REL_ARM64_ADDR64
+// IMAGE_REL_ARM64_ADDR64
 .globl struc
 struc:
   .quad arr
 
-; IMAGE_REL_ARM64_BRANCH26
+// IMAGE_REL_ARM64_BRANCH26
 b target
 
-; IMAGE_REL_ARM64_PAGEBASE_REL21
+// IMAGE_REL_ARM64_PAGEBASE_REL21
 adrp x0, foo
 
-; IMAGE_REL_ARM64_PAGEOFFSET_12A
+// IMAGE_REL_ARM64_PAGEOFFSET_12A
 add x0, x0, :lo12:foo
 
-; IMAGE_REL_ARM64_PAGEOFFSET_12L
+// IMAGE_REL_ARM64_PAGEOFFSET_12L
 ldr x0, [x0, :lo12:foo]
 
-; IMAGE_REL_ARM64_PAGEBASE_REL21, even if the symbol offset is known
+// IMAGE_REL_ARM64_PAGEBASE_REL21, even if the symbol offset is known
 adrp x0, bar
 bar:
 
-; IMAGE_REL_ARM64_SECREL
+// IMAGE_REL_ARM64_SECREL
 .secrel32 .Linfo_bar
 .Linfo_bar:
 
-; IMAGE_REL_ARM64_SECTION
+// IMAGE_REL_ARM64_SECTION
 .secidx func
 
 .align 2
 adrp x0, baz + 0x12345
 baz:
 add x0, x0, :lo12:foo + 0x12345
 ldrb w0, [x0, :lo12:foo + 0x12345]
 ldr x0, [x0, :lo12:foo + 0x12348]
 
-; IMAGE_REL_ARM64_SECREL_LOW12A
+// IMAGE_REL_ARM64_SECREL_LOW12A
 add x0, x0, :secrel_lo12:foo
-; IMAGE_REL_ARM64_SECREL_HIGH12A
+// IMAGE_REL_ARM64_SECREL_HIGH12A
 add x0, x0, :secrel_hi12:foo
-; IMAGE_REL_ARM64_SECREL_LOW12L
+// IMAGE_REL_ARM64_SECREL_LOW12L
 ldr x0, [x0, :secrel_lo12:foo]
 
-; IMAGE_REL_ARM64_REL21
+// IMAGE_REL_ARM64_REL21
 adr x0, foo + 0x12345
 
-; IMAGE_REL_ARM64_BRANCH19
+// IMAGE_REL_ARM64_BRANCH19
 bne target
 
-; IMAGE_REL_ARM64_BRANCH14
+// IMAGE_REL_ARM64_BRANCH14
 tbz x0, #0, target
 
-; CHECK: Format: COFF-ARM64
-; CHECK: Arch: aarch64
-; CHECK: AddressSize: 64bit
-; CHECK: Relocations [
-; CHECK:   Section (1) .text {
-; CHECK: 0x4 IMAGE_REL_ARM64_ADDR32 foo
-; CHECK: 0x8 IMAGE_REL_ARM64_ADDR32NB func
-; CHECK: 0xC IMAGE_REL_ARM64_ADDR64 arr
-; CHECK: 0x14 IMAGE_REL_ARM64_BRANCH26 target
-; CHECK: 0x18 IMAGE_REL_ARM64_PAGEBASE_REL21 foo
-; CHECK: 0x1C IMAGE_REL_ARM64_PAGEOFFSET_12A foo
-; CHECK: 0x20 IMAGE_REL_ARM64_PAGEOFFSET_12L foo
-; CHECK: 0x24 IMAGE_REL_ARM64_PAGEBASE_REL21 bar
-; CHECK: 0x28 IMAGE_REL_ARM64_SECREL .text
-; CHECK: 0x2C IMAGE_REL_ARM64_SECTION func
-; CHECK: 0x30 IMAGE_REL_ARM64_PAGEBASE_REL21 baz
-; CHECK: 0x34 IMAGE_REL_ARM64_PAGEOFFSET_12A foo
-; CHECK: 0x38 IMAGE_REL_ARM64_PAGEOFFSET_12L foo
-; CHECK: 0x3C IMAGE_REL_ARM64_PAGEOFFSET_12L foo
-; CHECK: 0x40 IMAGE_REL_ARM64_SECREL_LOW12A foo
-; CHECK: 0x44 IMAGE_REL_ARM64_SECREL_HIGH12A foo
-; CHECK: 0x48 IMAGE_REL_ARM64_SECREL_LOW12L foo
-; CHECK: 0x4C IMAGE_REL_ARM64_REL21 foo
-; CHECK: 0x50 IMAGE_REL_ARM64_BRANCH19 target
-; CHECK: 0x54 IMAGE_REL_ARM64_BRANCH14 target
-; CHECK:   }
-; CHECK: ]
-
-; DISASM: 30:       20 1a 09 b0     adrp    x0, 0x12345000
-; DISASM: 34:       00 14 0d 91     add     x0, x0, #837
-; DISASM: 38:       00 14 4d 39     ldrb    w0, [x0, #837]
-; DISASM: 3c:       00 a4 41 f9     ldr     x0, [x0, #840]
-; DISASM: 40:       00 00 00 91     add     x0, x0, #0
-; DISASM: 44:       00 00 40 91     add     x0, x0, #0, lsl #12
-; DISASM: 48:       00 00 40 f9     ldr     x0, [x0]
-; DISASM: 4c:       20 1a 09 30     adr     x0, #74565
+// CHECK: Format: COFF-ARM64
+// CHECK: Arch: aarch64
+// CHECK: AddressSize: 64bit
+// CHECK: Relocations [
+// CHECK:   Section (1) .text {
+// CHECK: 0x4 IMAGE_REL_ARM64_ADDR32 foo
+// CHECK: 0x8 IMAGE_REL_ARM64_ADDR32NB func
+// CHECK: 0xC IMAGE_REL_ARM64_ADDR64 arr
+// CHECK: 0x14 IMAGE_REL_ARM64_BRANCH26 target
+// CHECK: 0x18 IMAGE_REL_ARM64_PAGEBASE_REL21 foo
+// CHECK: 0x1C IMAGE_REL_ARM64_PAGEOFFSET_12A foo
+// CHECK: 0x20 IMAGE_REL_ARM64_PAGEOFFSET_12L foo
+// CHECK: 0x24 IMAGE_REL_ARM64_PAGEBASE_REL21 bar
+// CHECK: 0x28 IMAGE_REL_ARM64_SECREL .text
+// CHECK: 0x2C IMAGE_REL_ARM64_SECTION func
+// CHECK: 0x30 IMAGE_REL_ARM64_PAGEBASE_REL21 baz
+// CHECK: 0x34 IMAGE_REL_ARM64_PAGEOFFSET_12A foo
+// CHECK: 0x38 IMAGE_REL_ARM64_PAGEOFFSET_12L foo
+// CHECK: 0x3C IMAGE_REL_ARM64_PAGEOFFSET_12L foo
+// CHECK: 0x40 IMAGE_REL_ARM64_SECREL_LOW12A foo
+// CHECK: 0x44 IMAGE_REL_ARM64_SECREL_HIGH12A foo
+// CHECK: 0x48 IMAGE_REL_ARM64_SECREL_LOW12L foo
+// CHECK: 0x4C IMAGE_REL_ARM64_REL21 foo
+// CHECK: 0x50 IMAGE_REL_ARM64_BRANCH19 target
+// CHECK: 0x54 IMAGE_REL_ARM64_BRANCH14 target
+// CHECK:   }
+// CHECK: ]
+
+// DISASM: 30:       20 1a 09 b0     adrp    x0, 0x12345000
+// DISASM: 34:       00 14 0d 91     add     x0, x0, #837
+// DISASM: 38:       00 14 4d 39     ldrb    w0, [x0, #837]
+// DISASM: 3c:       00 a4 41 f9     ldr     x0, [x0, #840]
+// DISASM: 40:       00 00 00 91     add     x0, x0, #0
+// DISASM: 44:       00 00 40 91     add     x0, x0, #0, lsl #12
+// DISASM: 48:       00 00 40 f9     ldr     x0, [x0]
+// DISASM: 4c:       20 1a 09 30     adr     x0, #74565

llvm/test/MC/AArch64/coff-separator.s

 // RUN: llvm-mc -triple aarch64-windows-gnu -filetype obj -o %t.obj %s
 // RUN: llvm-objdump -d %t.obj | FileCheck %s
+// RUN: llvm-mc -triple aarch64-windows-msvc -filetype obj -o %t.obj %s
+// RUN: llvm-objdump -d %t.obj | FileCheck %s
 
 func:
 // Check that the nop instruction after the semicolon also is handled
 nop; nop
 add x0, x0, #42
 
 // CHECK:  0:       1f 20 03 d5     nop
 // CHECK:  4:       1f 20 03 d5     nop
 // CHECK:  8:       00 a8 00 91     add x0, x0, #42