Page MenuHomePhabricator

tambre (Raul Tambre)
Software Developer @ Cleveron AS

Projects

User does not belong to any projects.

User Details

User Since
May 4 2019, 1:33 AM (171 w, 2 d)

Recent Activity

Jul 11 2022

tambre committed rG1544d1f9fdb1: [libc++] Undeprecate ATOMIC_FLAG_INIT (LWG3659) (authored by tambre).
[libc++] Undeprecate ATOMIC_FLAG_INIT (LWG3659)
Jul 11 2022, 10:01 PM · Restricted Project, Restricted Project
tambre closed D129380: [libc++] Undeprecate ATOMIC_FLAG_INIT (LWG3659).
Jul 11 2022, 10:00 PM · Restricted Project, Restricted Project
tambre updated the diff for D129380: [libc++] Undeprecate ATOMIC_FLAG_INIT (LWG3659).

Address nit

Jul 11 2022, 1:29 PM · Restricted Project, Restricted Project

Jul 10 2022

tambre added inline comments to D129380: [libc++] Undeprecate ATOMIC_FLAG_INIT (LWG3659).
Jul 10 2022, 6:17 AM · Restricted Project, Restricted Project
tambre updated the diff for D129380: [libc++] Undeprecate ATOMIC_FLAG_INIT (LWG3659).

Address review comments

Jul 10 2022, 6:15 AM · Restricted Project, Restricted Project

Jul 8 2022

tambre added inline comments to D129380: [libc++] Undeprecate ATOMIC_FLAG_INIT (LWG3659).
Jul 8 2022, 10:02 AM · Restricted Project, Restricted Project
tambre updated the diff for D129380: [libc++] Undeprecate ATOMIC_FLAG_INIT (LWG3659).

Address review comments

Jul 8 2022, 9:58 AM · Restricted Project, Restricted Project
tambre added a comment to D129362: Undeprecate ATOMIC_FLAG_INIT in C++.

Makes sense to me, thanks!

Thanks! Would you mind handling the libc++ side like last time, or do you prefer I handle it as part of the changes in this patch?

Jul 8 2022, 9:42 AM · Restricted Project, Restricted Project
tambre requested review of D129380: [libc++] Undeprecate ATOMIC_FLAG_INIT (LWG3659).
Jul 8 2022, 9:41 AM · Restricted Project, Restricted Project
tambre accepted D129362: Undeprecate ATOMIC_FLAG_INIT in C++.

Makes sense to me, thanks!

Jul 8 2022, 4:20 AM · Restricted Project, Restricted Project

Jun 14 2022

tambre added a comment to D127379: [Lex] Keep track of skipped preprocessor blocks and advance the lexer directly if they are revisited.

Do you believe an entry in the ReleaseNotes would get this achievement more visibility?

Jun 14 2022, 4:20 AM · Restricted Project, Restricted Project

Mar 24 2022

tambre added inline comments to D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct.
Mar 24 2022, 1:23 PM · Restricted Project, Restricted Project, Restricted Project

Jan 27 2022

tambre added inline comments to D118200: [CMake] Use generator expression to get in-tree libc++ path.
Jan 27 2022, 12:34 AM · Restricted Project

Dec 21 2021

tambre added a comment to D115995: [libcxx] Add deprecation notices to macros deprecated in P0883R2.

Okay, now that I'm hitting this in a real codebase, I'm stumped as to what the (WG21 and/or libc++) recommendation is, here. ATOMIC_FLAG_INIT is required up-to-and-including C++17, and then deprecated in-and-above C++20? So if I have code in my codebase today like

I don't see why you'd think using the macro would be required.

AFAICT, on paper, C++17/20 atomic_flag has no constructors
https://en.cppreference.com/w/cpp/atomic/atomic_flag/atomic_flag
except for the default constructor (trivial in C++17) and the deleted copy constructor. So if you want an atomic_flag initialized with false, you need some way of getting false into it. On paper, there's no guarantee that std::atomic_flag f = {false}; will compile. But I just checked Godbolt and every major compiler does support that syntax, so I suppose it's safe to use in practice: https://godbolt.org/z/4cbbGcv96

Dec 21 2021, 11:24 PM · Restricted Project
tambre added a comment to D115995: [libcxx] Add deprecation notices to macros deprecated in P0883R2.

Okay, now that I'm hitting this in a real codebase, I'm stumped as to what the (WG21 and/or libc++) recommendation is, here. ATOMIC_FLAG_INIT is required up-to-and-including C++17, and then deprecated in-and-above C++20? So if I have code in my codebase today like

Dec 21 2021, 11:55 AM · Restricted Project

Dec 20 2021

tambre committed rG4e730aeb731c: [libcxx] Add deprecation notices to macros deprecated in P0883R2 (authored by tambre).
[libcxx] Add deprecation notices to macros deprecated in P0883R2
Dec 20 2021, 10:30 AM
tambre closed D115995: [libcxx] Add deprecation notices to macros deprecated in P0883R2.
Dec 20 2021, 10:30 AM · Restricted Project
tambre updated the diff for D115995: [libcxx] Add deprecation notices to macros deprecated in P0883R2.

Update paper status to version 14.0

Dec 20 2021, 10:00 AM · Restricted Project

Dec 19 2021

tambre added inline comments to D115995: [libcxx] Add deprecation notices to macros deprecated in P0883R2.
Dec 19 2021, 8:39 AM · Restricted Project
tambre updated the diff for D115995: [libcxx] Add deprecation notices to macros deprecated in P0883R2.

Guard deprecation macros

Dec 19 2021, 8:39 AM · Restricted Project

Dec 18 2021

tambre added a comment to D115995: [libcxx] Add deprecation notices to macros deprecated in P0883R2.

Should I bump the version listed for P0883R2 to 14.0? This only adds an extra non-mandated deprecation warning.

Dec 18 2021, 12:30 PM · Restricted Project
tambre requested review of D115995: [libcxx] Add deprecation notices to macros deprecated in P0883R2.
Dec 18 2021, 12:25 PM · Restricted Project

Dec 15 2021

tambre added a comment to D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated.

@tambre Any appetite for a libc++ patch? :)

Otherwise, let me know and I'll put it in my list of things to fix up.

Dec 15 2021, 11:41 PM · Restricted Project, Restricted Project
tambre added a comment to D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated.

Sorry, I seemed to have missed this entirely.

Since this is touching only <stdatomic.h> and not libc++'s <atomic>, I think it would actually be OK not to make any changes at all inside libc++. Nothing should break. We should separately implement P0883 in libc++ and deprecate the macros that we define in <atomic>. Note that I thought P0883 was implemented -- it is definitely marked as such, so we'll have to investigate. CC @tambre who implemented P0883.

So, as far as this patch is concerned, I think we could remove all the libc++ specific stuff and this would LGTM. Thanks for the heads up -- we'll tackle the C++ equivalent of this change in libc++ separately.

Dec 15 2021, 11:52 AM · Restricted Project, Restricted Project

Nov 6 2021

tambre committed rGb5aef90d4656: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964) (authored by ricejasonf).
[Clang] Fix instantiation of OpaqueValueExprs (Bug #45964)
Nov 6 2021, 1:09 AM
tambre closed D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964).
Nov 6 2021, 1:09 AM · Restricted Project

Nov 5 2021

tambre added a comment to D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964).

I presume you lack the permissions to push this to the main repo yourself. Would you like me to do that for you?

Yes, please.

Nov 5 2021, 3:33 AM · Restricted Project

Nov 3 2021

tambre added a comment to D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964).

I presume you lack the permissions to push this to the main repo yourself. Would you like me to do that for you?

Nov 3 2021, 6:46 AM · Restricted Project
tambre added a comment to D103395: PR45879: Keep evaluated expression in LValue object.

Strange, I see that it cannot be compiled neither by gcc nor by clang: https://godbolt.org/z/1dY9Gs6zM. Do I miss something?

Nov 3 2021, 4:21 AM · Restricted Project

Oct 29 2021

tambre added a comment to D103395: PR45879: Keep evaluated expression in LValue object.

This breaks the following code:

struct sub
{
	char data;
};
Oct 29 2021, 4:23 AM · Restricted Project

Oct 5 2021

tambre added inline comments to D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964).
Oct 5 2021, 1:48 AM · Restricted Project
tambre added a comment to D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964).

I rebased onto main and made one small style fix. I don't think the rebase changes anything.

I do not understand why random things are failing in the CI. Even on my own build machine with a fresh build directory CMake fails with errors about unregistered files in ExecutionEngine/Orc.

All this stuff is completely unrelated to my very minor change. Is there something about the process that I am missing?

Oct 5 2021, 1:47 AM · Restricted Project

Oct 2 2021

tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Abandoning since I don't think there's any further review/actions to be done here.
D58531 would be the solution for the raised pthread_create() issue.

How about making this "Closed" instead of "Abandoned" considering the patch was actually landed?

Oct 2 2021, 12:51 PM · Restricted Project
tambre closed D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.
Oct 2 2021, 12:50 PM · Restricted Project
tambre removed a reviewer for D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness: rjmccall.
Oct 2 2021, 12:50 PM · Restricted Project
tambre accepted D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.
Oct 2 2021, 12:49 PM · Restricted Project
tambre reclaimed D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.
Oct 2 2021, 12:49 PM · Restricted Project
tambre abandoned D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Abandoning since I don't think there's any further review/actions to be done here.
D58531 would be the solution for the raised pthread_create() issue.

Oct 2 2021, 9:44 AM · Restricted Project
tambre added a comment to D110596: [CUDA] Move CUDA SDK include path further down the include search path..

Thank you for your quick turnaround. I can confirm that this works for me on Debian Unstable with my vendored LLVM.

Oct 2 2021, 9:42 AM · Restricted Project

Sep 27 2021

tambre added a comment to D108247: [CUDA] Improve CUDA version detection and diagnostics..

So, what's the current state of affairs regarding CUDA SDK layout in debian?

Sep 27 2021, 11:26 AM · Restricted Project

Sep 26 2021

tambre added a comment to D108247: [CUDA] Improve CUDA version detection and diagnostics..

This unfortunately breaks using Debian distribution CUDA.
The Debian/Ubuntu special case is now useless.

Sep 26 2021, 9:33 AM · Restricted Project

Sep 1 2021

tambre added inline comments to D108890: Document LLVM_ENABLE_RUNTIMES.
Sep 1 2021, 12:55 AM · Restricted Project

Aug 21 2021

tambre requested changes to D108482: [Clang] Fix instantiation of OpaqueValueExprs (Bug #45964).

Please:

  • Add a test case based on the one in the bug. Hopefully you'll be able to reduce it further now that you understand the bug.
  • Use imperative style for the commit message, i.e. "Fix instantiation of OpaqueValueExprs".
Aug 21 2021, 1:24 AM · Restricted Project

Aug 20 2021

tambre accepted D107251: [ARM] Allow using ';' as asm statement separator in MSVC mode.

LGTM. Maybe add a changelog entry?

Aug 20 2021, 12:19 PM · Restricted Project

Jul 26 2021

tambre committed rGb31080c59624: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources (authored by tambre).
[compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources
Jul 26 2021, 11:42 AM
tambre closed D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources.
Jul 26 2021, 11:42 AM · Restricted Project
tambre added a comment to D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources.

Oh, wait, I do see this warning in the build and I am not sure if this will be a problem or not:

Dependee "/Users/steven/dev/monorepo/makefile_build/projects/compiler-rt/lib/builtins/CMakeFiles/lse_builtin_symlinks.dir/DependInfo.cmake" is newer than depender "/Users/steven/dev/monorepo/makefile_build/projects/compiler-rt/lib/builtins/CMakeFiles/lse_builtin_symlinks.dir/depend.internal".
Jul 26 2021, 11:41 AM · Restricted Project
tambre added a comment to D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources.

I still get the same error. 😿

Jul 26 2021, 3:50 AM · Restricted Project
tambre updated the diff for D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources.

Fix Darwin target creation check

Jul 26 2021, 3:50 AM · Restricted Project

Jul 24 2021

tambre added a comment to D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources.

Now I got this error when generating makefile:

Jul 24 2021, 3:22 AM · Restricted Project
tambre updated the diff for D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources.

Fix missing dependency for Darwin kexts

Jul 24 2021, 3:22 AM · Restricted Project

Jul 23 2021

tambre updated the diff for D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources.

Remove whitespace changes

Jul 23 2021, 12:27 AM · Restricted Project
tambre added a comment to D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources.

No, this doesn't work:

CMake Error at /Users/steven/dev/monorepo/llvm-project/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:420 (add_custom_target):
  add_custom_target cannot create target "lse_builtin_symlinks" because
  another target with the same name already exists.  The existing target is a
  custom target created in source directory
  "/Users/steven/dev/monorepo/llvm-project/compiler-rt/lib/builtins".  See
  documentation for policy CMP0002 for more details.
Call Stack (most recent call first):
  /Users/steven/dev/monorepo/llvm-project/compiler-rt/lib/builtins/CMakeLists.txt:674 (darwin_add_builtin_libraries)


-- For ios_arm64e builtins preferring aarch64/fp_mode.c to fp_mode.c
CMake Error at /Users/steven/dev/monorepo/llvm-project/compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:420 (add_custom_target):
  add_custom_target cannot create target "lse_builtin_symlinks" because
  another target with the same name already exists.  The existing target is a
  custom target created in source directory
  "/Users/steven/dev/monorepo/llvm-project/compiler-rt/lib/builtins".  See
  documentation for policy CMP0002 for more details.
Call Stack (most recent call first):
  /Users/steven/dev/monorepo/llvm-project/compiler-rt/lib/builtins/CMakeLists.txt:674 (darwin_add_builtin_libraries)

That is exactly the error I got when I tried custom_target in a slightly different approach. lse_builtin_symlinks target is created twice by arm64 and arm64e builtin.

Jul 23 2021, 12:25 AM · Restricted Project
tambre updated the diff for D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources.

Prevent duplicate targets, simplify code

Jul 23 2021, 12:24 AM · Restricted Project

Jul 21 2021

tambre added a comment to D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources.

I've commandeered this and used the custom target approach to ensure that all builtin Make sub-invocations depend on the symlinks having been created before.
Makefiles seem to now be generated in the correct way.

Jul 21 2021, 11:32 AM · Restricted Project
tambre retitled D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources from [compiler-rt][CMake] create aarch64 helper asm during configure time to [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources.
Jul 21 2021, 11:31 AM · Restricted Project
tambre updated the diff for D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources.

Fix whitespace changes

Jul 21 2021, 11:31 AM · Restricted Project
tambre updated the diff for D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources.

Custom target approach

Jul 21 2021, 11:26 AM · Restricted Project
tambre commandeered D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources.
Jul 21 2021, 11:25 AM · Restricted Project

Jul 20 2021

tambre added a comment to D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources.

The configured directory is rather large so let me give some more detail from the makefile generated. The custom target is generated in two of the makefiles I mentioned above, like following:

projects/compiler-rt/lib/builtins/outline_atomic_helpers.dir/outline_atomic_cas1_1.S:
        @$(CMAKE_COMMAND) -E cmake_echo_color --switch=$(COLOR) --blue --bold --progress-dir=/Users/steven/makefile_build/CMakeFiles --progress-num=$(CMAKE_PROGRESS_1) "Generating outline_atomic_helpers.dir/outline_atomic_cas1_1.S"
        cd /Users/steven/makefile_build/projects/compiler-rt/lib/builtins && /usr/local/bin/cmake -E create_symlink /Users/steven/llvm-project/compiler-rt/lib/builtins/aarch64/lse.S /Users/steven/makefile_build/projects/compiler-rt/lib/builtins/outline_atomic_helpers.dir/outline_atomic_cas1_1.S

When you build the clang builtin library, it does:

$ make -j 32 clang_rt.osx VERBOSE=1
...
/usr/bin/make  -f projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.builtins_arm64_osx.dir/build.make projects/compiler-rt/lib/        builtins/CMakeFiles/clang_rt.builtins_arm64_osx.dir/depend
/usr/bin/make  -f projects/compiler-rt/lib/builtins/CMakeFiles/clang_rt.builtins_arm64e_osx.dir/build.make projects/compiler-rt/lib/       builtins/CMakeFiles/clang_rt.builtins_arm64e_osx.dir/depend
...
CMake Error: failed to create symbolic link '/Users/steven/makefile_build/projects/compiler-rt/lib/builtins/outline_atomic_helpers.dir/outline_atomic_ldset1_3.S': file already exists
``
Jul 20 2021, 12:28 PM · Restricted Project

Jul 19 2021

tambre added a comment to D106305: [compiler-rt][CMake][arm64] Use a custom target for symlinking LSE sources.

See this mailing list thread for the background. Please also link it in the commit description.

Jul 19 2021, 10:34 PM · Restricted Project

Jul 12 2021

tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

First:
Do I assume right this this feature was simply disabled without any plan to:

  • inform the authors (me)
  • update the documentation
  • re-enable support eventually or provide alternatives

XFAILing a test and calling it a day seems inadequate IMHO.

Second:
Would an approach like this still work: https://reviews.llvm.org/D58531 ?

Jul 12 2021, 7:48 AM · Restricted Project

Jul 5 2021

tambre added inline comments to D102531: PR45881: Properly use CXXThisOverride for templated lambda.
Jul 5 2021, 11:56 PM · Restricted Project

Jun 25 2021

tambre added a comment to D102453: [CMake][ELF] Add -fno-semantic-interposition for GCC and Clang>=13.

Compiling Polly with ThinLTO in either Release or RelWithDebInfo fails after this with relocation errors:

root@xinux:/opt/deb/llvm/build# rm -r * .*
root@xinux:/opt/deb/llvm/build# cmake ../llvm -GNinja \
		-DCMAKE_BUILD_TYPE=Release \
		-DLLVM_ENABLE_PROJECTS="polly" \
		-DLLVM_ENABLE_LTO=Thin && ninja LLVMPolly.so
-- The C compiler identification is Clang 13.0.0
-- The CXX compiler identification is Clang 13.0.0
-- The ASM compiler identification is Clang
-- Found assembler: /usr/bin/clang
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- clang project is disabled
-- clang-tools-extra project is disabled
-- compiler-rt project is disabled
-- debuginfo-tests project is disabled
-- libc project is disabled
-- libclc project is disabled
-- libcxx project is disabled
-- libcxxabi project is disabled
-- libunwind project is disabled
-- lld project is disabled
-- lldb project is disabled
-- mlir project is disabled
-- openmp project is disabled
-- parallel-libs project is disabled
-- polly project is enabled
-- pstl project is disabled
-- flang project is disabled
-- Performing Test LLVM_LIBSTDCXX_MIN
-- Performing Test LLVM_LIBSTDCXX_MIN - Success
-- Performing Test LLVM_LIBSTDCXX_SOFT_ERROR
-- Performing Test LLVM_LIBSTDCXX_SOFT_ERROR - Success
-- Looking for dlfcn.h
-- Looking for dlfcn.h - found
-- Looking for errno.h
-- Looking for errno.h - found
-- Looking for fcntl.h
-- Looking for fcntl.h - found
-- Looking for link.h
-- Looking for link.h - found
-- Looking for malloc/malloc.h
-- Looking for malloc/malloc.h - not found
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for signal.h
-- Looking for signal.h - found
-- Looking for sys/ioctl.h
-- Looking for sys/ioctl.h - found
-- Looking for sys/mman.h
-- Looking for sys/mman.h - found
-- Looking for sys/param.h
-- Looking for sys/param.h - found
-- Looking for sys/resource.h
-- Looking for sys/resource.h - found
-- Looking for sys/stat.h
-- Looking for sys/stat.h - found
-- Looking for sys/time.h
-- Looking for sys/time.h - found
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for sysexits.h
-- Looking for sysexits.h - found
-- Looking for termios.h
-- Looking for termios.h - found
-- Looking for unistd.h
-- Looking for unistd.h - found
-- Looking for valgrind/valgrind.h
-- Looking for valgrind/valgrind.h - not found
-- Looking for fenv.h
-- Looking for fenv.h - found
-- Looking for FE_ALL_EXCEPT
-- Looking for FE_ALL_EXCEPT - found
-- Looking for FE_INEXACT
-- Looking for FE_INEXACT - found
-- Looking for mach/mach.h
-- Looking for mach/mach.h - not found
-- Looking for histedit.h
-- Looking for histedit.h - found
-- Looking for CrashReporterClient.h
-- Looking for CrashReporterClient.h - not found
-- Looking for linux/magic.h
-- Looking for linux/magic.h - found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Looking for pthread_getspecific in pthread
-- Looking for pthread_getspecific in pthread - found
-- Looking for pthread_rwlock_init in pthread
-- Looking for pthread_rwlock_init in pthread - found
-- Looking for pthread_mutex_lock in pthread
-- Looking for pthread_mutex_lock in pthread - found
-- Looking for dlopen in dl
-- Looking for dlopen in dl - found
-- Looking for clock_gettime in rt
-- Looking for clock_gettime in rt - found
-- Looking for pfm_initialize in pfm
-- Looking for pfm_initialize in pfm - found
-- Looking for perfmon/perf_event.h
-- Looking for perfmon/perf_event.h - found
-- Looking for perfmon/pfmlib.h
-- Looking for perfmon/pfmlib.h - found
-- Looking for perfmon/pfmlib_perf_event.h
-- Looking for perfmon/pfmlib_perf_event.h - found
-- Performing Test COMPILE_WITH_CYCLES
-- Performing Test COMPILE_WITH_CYCLES - Success
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.11")
-- Looking for compress2
-- Looking for compress2 - found
-- Found LibXml2: /usr/lib/x86_64-linux-gnu/libxml2.so (found version "2.9.10")
-- Looking for xmlReadMemory
-- Looking for xmlReadMemory - found
-- Looking for el_init in edit
-- Looking for el_init in edit - found
-- Looking for xar_open in xar
-- Looking for xar_open in xar - not found
-- Looking for arc4random
-- Looking for arc4random - not found
-- Looking for backtrace
-- Looking for backtrace - found
-- backtrace facility detected in default set of libraries
-- Found Backtrace: /usr/include
-- Performing Test C_SUPPORTS_WERROR_UNGUARDED_AVAILABILITY_NEW
-- Performing Test C_SUPPORTS_WERROR_UNGUARDED_AVAILABILITY_NEW - Success
-- Looking for __register_frame
-- Looking for __register_frame - not found
-- Looking for __deregister_frame
-- Looking for __deregister_frame - not found
-- Looking for _Unwind_Backtrace
-- Looking for _Unwind_Backtrace - not found
-- Looking for getpagesize
-- Looking for getpagesize - found
-- Looking for sysconf
-- Looking for sysconf - found
-- Looking for getrusage
-- Looking for getrusage - found
-- Looking for setrlimit
-- Looking for setrlimit - found
-- Looking for isatty
-- Looking for isatty - found
-- Looking for futimens
-- Looking for futimens - found
-- Looking for futimes
-- Looking for futimes - found
-- Looking for posix_fallocate
-- Looking for posix_fallocate - found
-- Looking for sigaltstack
-- Looking for sigaltstack - found
-- Looking for lseek64
-- Looking for lseek64 - found
-- Looking for mallctl
-- Looking for mallctl - not found
-- Looking for mallinfo
-- Looking for mallinfo - found
-- Looking for mallinfo2
-- Looking for mallinfo2 - not found
-- Looking for malloc_zone_statistics
-- Looking for malloc_zone_statistics - not found
-- Looking for getrlimit
-- Looking for getrlimit - found
-- Looking for posix_spawn
-- Looking for posix_spawn - found
-- Looking for pread
-- Looking for pread - found
-- Looking for sbrk
-- Looking for sbrk - found
-- Looking for strerror
-- Looking for strerror - found
-- Looking for strerror_r
-- Looking for strerror_r - found
-- Looking for strerror_s
-- Looking for strerror_s - not found
-- Looking for setenv
-- Looking for setenv - found
-- Looking for dlopen
-- Looking for dlopen - found
-- Looking for dladdr
-- Looking for dladdr - not found
-- Performing Test HAVE_STRUCT_STAT_ST_MTIMESPEC_TV_NSEC
-- Performing Test HAVE_STRUCT_STAT_ST_MTIMESPEC_TV_NSEC - Failed
-- Performing Test HAVE_STRUCT_STAT_ST_MTIM_TV_NSEC
-- Performing Test HAVE_STRUCT_STAT_ST_MTIM_TV_NSEC - Success
-- Looking for __GLIBC__
-- Looking for __GLIBC__ - found
-- Looking for pthread_getname_np
-- Looking for pthread_getname_np - found
-- Looking for pthread_setname_np
-- Looking for pthread_setname_np - found
-- Looking for proc_pid_rusage
-- Looking for proc_pid_rusage - not found
-- Performing Test HAVE_STD_IS_TRIVIALLY_COPYABLE
-- Performing Test HAVE_STD_IS_TRIVIALLY_COPYABLE - Success
-- Performing Test HAVE_CXX_ATOMICS_WITHOUT_LIB
-- Performing Test HAVE_CXX_ATOMICS_WITHOUT_LIB - Success
-- Performing Test HAVE_CXX_ATOMICS64_WITHOUT_LIB
-- Performing Test HAVE_CXX_ATOMICS64_WITHOUT_LIB - Success
-- Performing Test LLVM_HAS_ATOMICS
-- Performing Test LLVM_HAS_ATOMICS - Success
-- Performing Test SUPPORTS_VARIADIC_MACROS_FLAG
-- Performing Test SUPPORTS_VARIADIC_MACROS_FLAG - Success
-- Performing Test SUPPORTS_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS_FLAG
-- Performing Test SUPPORTS_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS_FLAG - Success
-- Native target architecture is X86
-- Threads enabled.
-- Doxygen disabled.
-- Go bindings disabled.
-- Ninja version: 1.10.1
-- Found OCaml: /usr/bin/ocamlfind
-- OCaml bindings disabled, need ctypes >=0.4.
-- Could NOT find Python module pygments
-- Could NOT find Python module pygments.lexers.c_cpp
-- Could NOT find Python module yaml
-- LLVM host triple: x86_64-unknown-linux-gnu
-- LLVM default target triple: x86_64-unknown-linux-gnu
-- ThinLTO provides its own parallel linking - limiting parallel link jobs to 2.
-- Performing Test C_SUPPORTS_FPIC
-- Performing Test C_SUPPORTS_FPIC - Success
-- Performing Test CXX_SUPPORTS_FPIC
-- Performing Test CXX_SUPPORTS_FPIC - Success
-- Building with -fPIC
-- Performing Test C_SUPPORTS_FNO_SEMANTIC_INTERPOSITION
-- Performing Test C_SUPPORTS_FNO_SEMANTIC_INTERPOSITION - Success
-- Performing Test CXX_SUPPORTS_FNO_SEMANTIC_INTERPOSITION
-- Performing Test CXX_SUPPORTS_FNO_SEMANTIC_INTERPOSITION - Success
-- Performing Test SUPPORTS_FVISIBILITY_INLINES_HIDDEN_FLAG
-- Performing Test SUPPORTS_FVISIBILITY_INLINES_HIDDEN_FLAG - Success
-- Performing Test C_SUPPORTS_WERROR_DATE_TIME
-- Performing Test C_SUPPORTS_WERROR_DATE_TIME - Success
-- Performing Test CXX_SUPPORTS_WERROR_DATE_TIME
-- Performing Test CXX_SUPPORTS_WERROR_DATE_TIME - Success
-- Performing Test CXX_SUPPORTS_WERROR_UNGUARDED_AVAILABILITY_NEW
-- Performing Test CXX_SUPPORTS_WERROR_UNGUARDED_AVAILABILITY_NEW - Success
-- Performing Test CXX_SUPPORTS_MISSING_FIELD_INITIALIZERS_FLAG
-- Performing Test CXX_SUPPORTS_MISSING_FIELD_INITIALIZERS_FLAG - Success
-- Performing Test C_SUPPORTS_CXX98_COMPAT_EXTRA_SEMI_FLAG
-- Performing Test C_SUPPORTS_CXX98_COMPAT_EXTRA_SEMI_FLAG - Success
-- Performing Test CXX_SUPPORTS_CXX98_COMPAT_EXTRA_SEMI_FLAG
-- Performing Test CXX_SUPPORTS_CXX98_COMPAT_EXTRA_SEMI_FLAG - Success
-- Performing Test C_SUPPORTS_IMPLICIT_FALLTHROUGH_FLAG
-- Performing Test C_SUPPORTS_IMPLICIT_FALLTHROUGH_FLAG - Success
-- Performing Test CXX_SUPPORTS_IMPLICIT_FALLTHROUGH_FLAG
-- Performing Test CXX_SUPPORTS_IMPLICIT_FALLTHROUGH_FLAG - Success
-- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG
-- Performing Test C_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Success
-- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG
-- Performing Test CXX_SUPPORTS_COVERED_SWITCH_DEFAULT_FLAG - Success
-- Performing Test CXX_SUPPORTS_CLASS_MEMACCESS_FLAG
-- Performing Test CXX_SUPPORTS_CLASS_MEMACCESS_FLAG - Failed
-- Performing Test CXX_SUPPORTS_NOEXCEPT_TYPE_FLAG
-- Performing Test CXX_SUPPORTS_NOEXCEPT_TYPE_FLAG - Success
-- Performing Test CXX_WONT_WARN_ON_FINAL_NONVIRTUALDTOR
-- Performing Test CXX_WONT_WARN_ON_FINAL_NONVIRTUALDTOR - Success
-- Performing Test C_SUPPORTS_DELETE_NON_VIRTUAL_DTOR_FLAG
-- Performing Test C_SUPPORTS_DELETE_NON_VIRTUAL_DTOR_FLAG - Success
-- Performing Test CXX_SUPPORTS_DELETE_NON_VIRTUAL_DTOR_FLAG
-- Performing Test CXX_SUPPORTS_DELETE_NON_VIRTUAL_DTOR_FLAG - Success
-- Performing Test CXX_SUPPORTS_SUGGEST_OVERRIDE_FLAG
-- Performing Test CXX_SUPPORTS_SUGGEST_OVERRIDE_FLAG - Success
-- Performing Test CXX_WSUGGEST_OVERRIDE_ALLOWS_ONLY_FINAL
-- Performing Test CXX_WSUGGEST_OVERRIDE_ALLOWS_ONLY_FINAL - Success
-- Performing Test C_WCOMMENT_ALLOWS_LINE_WRAP
-- Performing Test C_WCOMMENT_ALLOWS_LINE_WRAP - Success
-- Performing Test C_SUPPORTS_STRING_CONVERSION_FLAG
-- Performing Test C_SUPPORTS_STRING_CONVERSION_FLAG - Success
-- Performing Test CXX_SUPPORTS_STRING_CONVERSION_FLAG
-- Performing Test CXX_SUPPORTS_STRING_CONVERSION_FLAG - Success
-- Performing Test C_SUPPORTS_MISLEADING_INDENTATION_FLAG
-- Performing Test C_SUPPORTS_MISLEADING_INDENTATION_FLAG - Success
-- Performing Test CXX_SUPPORTS_MISLEADING_INDENTATION_FLAG
-- Performing Test CXX_SUPPORTS_MISLEADING_INDENTATION_FLAG - Success
-- Performing Test LINKER_SUPPORTS_COLOR_DIAGNOSTICS
-- Performing Test LINKER_SUPPORTS_COLOR_DIAGNOSTICS - Success
-- Performing Test C_SUPPORTS_FNO_FUNCTION_SECTIONS
-- Performing Test C_SUPPORTS_FNO_FUNCTION_SECTIONS - Success
-- Performing Test C_SUPPORTS_FFUNCTION_SECTIONS
-- Performing Test C_SUPPORTS_FFUNCTION_SECTIONS - Success
-- Performing Test CXX_SUPPORTS_FFUNCTION_SECTIONS
-- Performing Test CXX_SUPPORTS_FFUNCTION_SECTIONS - Success
-- Performing Test C_SUPPORTS_FDATA_SECTIONS
-- Performing Test C_SUPPORTS_FDATA_SECTIONS - Success
-- Performing Test CXX_SUPPORTS_FDATA_SECTIONS
-- Performing Test CXX_SUPPORTS_FDATA_SECTIONS - Success
-- Looking for os_signpost_interval_begin
-- Looking for os_signpost_interval_begin - not found
-- Found Python3: /usr/bin/python3.9 (found suitable version "3.9.2", minimum required is "3.6") found components: Interpreter
-- Linker detection: unknown
-- Found Git: /usr/bin/git (found version "2.32.0")
-- Targeting AArch64
-- Targeting AMDGPU
-- Targeting ARM
-- Targeting AVR
-- Targeting BPF
-- Targeting Hexagon
-- Targeting Lanai
-- Targeting Mips
-- Targeting MSP430
-- Targeting NVPTX
-- Targeting PowerPC
-- Targeting RISCV
-- Targeting Sparc
-- Targeting SystemZ
-- Targeting WebAssembly
-- Targeting X86
-- Targeting XCore
-- ISL version: isl-0.23-61-g24e8cd12
-- Performing Test HAS_ATTRIBUTE_WARN_UNUSED_RESULT
-- Performing Test HAS_ATTRIBUTE_WARN_UNUSED_RESULT - Success
-- Performing Test HAVE___ATTRIBUTE__
-- Performing Test HAVE___ATTRIBUTE__ - Success
-- Performing Test HAVE_DECL_FFS
-- Performing Test HAVE_DECL_FFS - Success
-- Performing Test HAVE_DECL___BUILTIN_FFS
-- Performing Test HAVE_DECL___BUILTIN_FFS - Success
-- Performing Test HAVE_DECL__BITSCANFORWARD
-- Performing Test HAVE_DECL__BITSCANFORWARD - Failed
-- Performing Test HAVE_DECL_STRCASECMP
-- Performing Test HAVE_DECL_STRCASECMP - Success
-- Performing Test HAVE_DECL__STRICMP
-- Performing Test HAVE_DECL__STRICMP - Failed
-- Performing Test HAVE_DECL_STRNCASECMP
-- Performing Test HAVE_DECL_STRNCASECMP - Success
-- Performing Test HAVE_DECL__STRNICMP
-- Performing Test HAVE_DECL__STRNICMP - Failed
-- Performing Test HAVE_DECL_SNPRINTF
-- Performing Test HAVE_DECL_SNPRINTF - Success
-- Performing Test HAVE_DECL__SNPRINTF
-- Performing Test HAVE_DECL__SNPRINTF - Failed
-- Performing Test HAVE_UINT8T
-- Performing Test HAVE_UINT8T - Failed
-- Performing Test HAVE_STDINT_H
-- Performing Test HAVE_STDINT_H - Success
-- Performing Test HAVE_INTTYPES_H
-- Performing Test HAVE_INTTYPES_H - Success
-- Performing Test HAVE_SYS_INTTYPES_H
-- Performing Test HAVE_SYS_INTTYPES_H - Failed
-- Registering Polly as a pass plugin (static build: ON)
-- Registering Bye as a pass plugin (static build: OFF)
-- Failed to find LLVM FileCheck
-- Version: 0.0.0
-- Performing Test HAVE_CXX_FLAG_STD_CXX11
-- Performing Test HAVE_CXX_FLAG_STD_CXX11 - Success
-- Performing Test HAVE_CXX_FLAG_WALL
-- Performing Test HAVE_CXX_FLAG_WALL - Success
-- Performing Test HAVE_CXX_FLAG_WEXTRA
-- Performing Test HAVE_CXX_FLAG_WEXTRA - Success
-- Performing Test HAVE_CXX_FLAG_WSHADOW
-- Performing Test HAVE_CXX_FLAG_WSHADOW - Success
-- Performing Test HAVE_CXX_FLAG_PEDANTIC
-- Performing Test HAVE_CXX_FLAG_PEDANTIC - Success
-- Performing Test HAVE_CXX_FLAG_PEDANTIC_ERRORS
-- Performing Test HAVE_CXX_FLAG_PEDANTIC_ERRORS - Success
-- Performing Test HAVE_CXX_FLAG_WSHORTEN_64_TO_32
-- Performing Test HAVE_CXX_FLAG_WSHORTEN_64_TO_32 - Success
-- Performing Test HAVE_CXX_FLAG_WFLOAT_EQUAL
-- Performing Test HAVE_CXX_FLAG_WFLOAT_EQUAL - Success
-- Performing Test HAVE_CXX_FLAG_FSTRICT_ALIASING
-- Performing Test HAVE_CXX_FLAG_FSTRICT_ALIASING - Success
-- Performing Test HAVE_CXX_FLAG_FNO_EXCEPTIONS
-- Performing Test HAVE_CXX_FLAG_FNO_EXCEPTIONS - Success
-- Performing Test HAVE_CXX_FLAG_WNO_SUGGEST_OVERRIDE
-- Performing Test HAVE_CXX_FLAG_WNO_SUGGEST_OVERRIDE - Success
-- Performing Test HAVE_CXX_FLAG_WSTRICT_ALIASING
-- Performing Test HAVE_CXX_FLAG_WSTRICT_ALIASING - Success
-- Performing Test HAVE_CXX_FLAG_WD654
-- Performing Test HAVE_CXX_FLAG_WD654 - Failed
-- Performing Test HAVE_CXX_FLAG_WTHREAD_SAFETY
-- Performing Test HAVE_CXX_FLAG_WTHREAD_SAFETY - Success
-- Performing Test HAVE_THREAD_SAFETY_ATTRIBUTES
-- Performing Test HAVE_THREAD_SAFETY_ATTRIBUTES
-- Performing Test HAVE_THREAD_SAFETY_ATTRIBUTES -- failed to compile
-- Performing Test HAVE_CXX_FLAG_COVERAGE
-- Performing Test HAVE_CXX_FLAG_COVERAGE - Success
-- Performing Test HAVE_GNU_POSIX_REGEX
-- Performing Test HAVE_GNU_POSIX_REGEX
-- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile
-- Performing Test HAVE_POSIX_REGEX
-- Performing Test HAVE_POSIX_REGEX
-- Performing Test HAVE_POSIX_REGEX -- success
-- Performing Test HAVE_STEADY_CLOCK
-- Performing Test HAVE_STEADY_CLOCK
-- Performing Test HAVE_STEADY_CLOCK -- success
-- Configuring done
-- Generating done
-- Build files have been written to: /opt/deb/llvm/build
[380/380] Linking CXX shared module lib/LLVMPolly.so
FAILED: lib/LLVMPolly.so
: && /usr/bin/clang++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -flto=thin -fno-exceptions -fno-rtti -O3 -DNDEBUG  -Wl,-z,nodelete -Wl,--color-diagnostics -shared  -o lib/LLVMPolly.so tools/polly/lib/CMakeFiles/obj.Polly.dir/Analysis/DependenceInfo.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Analysis/PolyhedralInfo.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Analysis/ScopDetection.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Analysis/ScopDetectionDiagnostic.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Analysis/ScopInfo.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Analysis/ScopBuilder.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Analysis/ScopGraphPrinter.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Analysis/ScopPass.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Analysis/PruneUnprofitable.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/BlockGenerators.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/IslAst.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/IslExprBuilder.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/IslNodeBuilder.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/CodeGeneration.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/LoopGenerators.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/LoopGeneratorsGOMP.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/LoopGeneratorsKMP.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/IRBuilder.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/Utils.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/RuntimeDebugBuilder.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/CodegenCleanup.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/PerfMonitor.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Exchange/JSONExporter.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Support/GICHelper.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Support/SCEVAffinator.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Support/SCEVValidator.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Support/RegisterPasses.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Support/ScopHelper.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Support/ScopLocation.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Support/ISLTools.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Support/DumpModulePass.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Support/VirtualInstruction.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/Canonicalization.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/CodePreparation.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/DeadCodeElimination.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/ScheduleOptimizer.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/ScheduleTreeTransform.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/FlattenSchedule.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/FlattenAlgo.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/ForwardOpTree.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/DeLICM.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/ZoneAlgo.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/Simplify.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/MaximalStaticExpansion.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/RewriteByReferenceParameters.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/ScopInliner.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/ManualOptimizer.cpp.o tools/polly/lib/CMakeFiles/obj.Polly.dir/Transform/MatmulOptimizer.cpp.o tools/polly/lib/CMakeFiles/LLVMPolly.dir/Plugin/Polly.cpp.o  lib/libPollyISL.a && :
ld.lld: error: relocation R_X86_64_PC32 cannot be used against symbol isl_map_coalesce; recompile with -fPIC
>>> defined in lto.tmp
>>> referenced by DependenceInfo.cpp
>>>               lto.tmp:(polly::Dependences::addPrivatizationDependences())
Jun 25 2021, 11:46 PM · Restricted Project

Jun 20 2021

tambre committed rG56aac567acfd: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization") (authored by tambre).
[libcxx] Implement P0883R2 ("Fixing Atomic Initialization")
Jun 20 2021, 7:38 AM
tambre closed D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization").
Jun 20 2021, 7:37 AM · Restricted Project

Jun 17 2021

tambre added inline comments to D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization").
Jun 17 2021, 10:41 AM · Restricted Project
tambre updated the diff for D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization").

Update deprecation test to not use main() since it doesn't need to be run

Jun 17 2021, 10:39 AM · Restricted Project

Jun 16 2021

tambre added a comment to D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization").

LGTM % comments at this point; but before landing it please

  • wait for a second OK from the "libc++" reviewer
  • make sure CI is green
Jun 16 2021, 4:22 AM · Restricted Project
tambre updated the diff for D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization").

Address review comments

Jun 16 2021, 4:10 AM · Restricted Project

Jun 12 2021

tambre added a comment to D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization").

Thanks for the continued reviewing and sorry for the delay.

Jun 12 2021, 7:55 AM · Restricted Project
tambre updated the diff for D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization").

Address review comments

Jun 12 2021, 7:54 AM · Restricted Project

Jun 9 2021

tambre added inline comments to D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization").
Jun 9 2021, 4:16 AM · Restricted Project
tambre updated the diff for D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization").

Address review comments

Jun 9 2021, 4:14 AM · Restricted Project

Jun 7 2021

tambre updated the diff for D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization").

Fix a missed case of parentheses

Jun 7 2021, 3:18 AM · Restricted Project
tambre added a comment to D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization").

Thanks for the lightning fast review!

Jun 7 2021, 3:17 AM · Restricted Project
tambre updated the diff for D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization").

Address review comments

Jun 7 2021, 3:16 AM · Restricted Project

Jun 6 2021

tambre requested review of D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization").
Jun 6 2021, 9:49 AM · Restricted Project

Apr 12 2021

tambre added a comment to D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins..

Summary also looks good. 👍
You probably don't need to wait for more approvals.

Apr 12 2021, 12:36 AM · Restricted Project
tambre accepted D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins..

Thanks, LGTM! Probably worth mentioning what I had in my comment in the commit message.

Apr 12 2021, 12:30 AM · Restricted Project

Apr 10 2021

tambre added inline comments to D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins..
Apr 10 2021, 9:42 AM · Restricted Project

Apr 9 2021

tambre added a comment to D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins..

The fact that Clang chooses to (explicitly) forget about a builtin in SemaDecl.cpp was quite puzzling to me. Maybe that just shows that I don't fully understand how the builtin mechanism is supposed to work.
@rsmith and @tambre, git history showed me you have more experience in this area and touched some of that code before, so hopefully you can give me some good feedback!

Apr 9 2021, 9:55 AM · Restricted Project

Apr 5 2021

tambre abandoned D99886: [CMake] Propagate static extensions to LLVMExtensions object library.

@bjope Could you try without your workaround from https://reviews.llvm.org/rGd66f9c4f1e83e69abf75f97cb5f8fd1dc9422357 with this patch? I think this should fix the lack of include directory propagation that likely caused your issue.

I'm planning to revert d66f9c4f1e along with 43ceb74eb. I"m just waiting for my test build to finish.

Apr 5 2021, 9:11 AM · Restricted Project
tambre added a comment to D99886: [CMake] Propagate static extensions to LLVMExtensions object library.

@bjope Could you try without your workaround from https://reviews.llvm.org/rGd66f9c4f1e83e69abf75f97cb5f8fd1dc9422357 with this patch? I think this should fix the lack of include directory propagation that likely caused your issue.

Apr 5 2021, 9:00 AM · Restricted Project
tambre requested review of D99886: [CMake] Propagate static extensions to LLVMExtensions object library.
Apr 5 2021, 8:58 AM · Restricted Project

Mar 7 2021

tambre added a comment to D98111: [CMake][compiler-rt] Use copying instead of symlinking for LSE builtins on non-Unix-likes.

The fix resolves the issue on my environment. Thank you for the quick response!

Mar 7 2021, 11:48 PM · Restricted Project
tambre committed rGba860963b156: [CMake][compiler-rt] Use copying instead of symlinking for LSE builtins on non… (authored by tambre).
[CMake][compiler-rt] Use copying instead of symlinking for LSE builtins on non…
Mar 7 2021, 11:11 PM
tambre closed D98111: [CMake][compiler-rt] Use copying instead of symlinking for LSE builtins on non-Unix-likes.
Mar 7 2021, 11:10 PM · Restricted Project

Mar 6 2021

tambre resigned from D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path..
Mar 6 2021, 1:49 AM · Restricted Project, Restricted Project
tambre added a comment to D98111: [CMake][compiler-rt] Use copying instead of symlinking for LSE builtins on non-Unix-likes.

@ikudrin Thanks for the report on D93278. Could you give this patch a try?

Mar 6 2021, 1:49 AM · Restricted Project
tambre requested review of D98111: [CMake][compiler-rt] Use copying instead of symlinking for LSE builtins on non-Unix-likes.
Mar 6 2021, 1:48 AM · Restricted Project
tambre committed rG10a7289649cf: [runtimes] Fix crosscompiling after a7cad6680b4087eff8994f1f99ac40c661a6621f… (authored by tambre).
[runtimes] Fix crosscompiling after a7cad6680b4087eff8994f1f99ac40c661a6621f…
Mar 6 2021, 1:35 AM
tambre closed D97855: [runtimes] Fix crosscompiling after a7cad6680b4087eff8994f1f99ac40c661a6621f (D97451).
Mar 6 2021, 1:35 AM · Restricted Project

Mar 3 2021

tambre added inline comments to D97855: [runtimes] Fix crosscompiling after a7cad6680b4087eff8994f1f99ac40c661a6621f (D97451).
Mar 3 2021, 8:58 AM · Restricted Project
tambre updated the diff for D97855: [runtimes] Fix crosscompiling after a7cad6680b4087eff8994f1f99ac40c661a6621f (D97451).

Move ARG_TARGET_TRIPLE block down to simplify code.

Mar 3 2021, 8:58 AM · Restricted Project
tambre requested review of D97855: [runtimes] Fix crosscompiling after a7cad6680b4087eff8994f1f99ac40c661a6621f (D97451).
Mar 3 2021, 6:32 AM · Restricted Project

Feb 8 2021

tambre accepted D96259: [AArch64] Use '//' as comment string for MSVC assembly.

Thanks! Maybe worth a changelog entry?

Feb 8 2021, 8:11 AM · Restricted Project

Feb 6 2021

tambre added a comment to rGb2851aea80e5: Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser….

Thanks for the background.

Feb 6 2021, 11:52 PM
tambre updated subscribers of rGb2851aea80e5: Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser….
Feb 6 2021, 9:58 AM
tambre updated subscribers of rGb2851aea80e5: Revert "[Compiler-rt][AArch64] Workaround for .cfi_startproc assembler parser….

Hi Raul,

I'm seeing this only on aarch64-windows-msvc target, and not on any aarch64-linux-gnu targets. The command line is below, but I'm not sure you'll reproduce the problem outside of Windows environment.

C:\Users\tcwg\source\llvm-package\bin\clang-cl.exe /nologo -DHAS_ASM_LSE -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -DSTDC_CONSTANT_MACROS -DSTDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -DL_cas -DMODEL=3 -DSIZE=2 -IC:\Users\tcwg\source\maxim\llvm_package_92a5106e\llvm-project\compiler-rt\lib\builtins -Iprojects\compiler-rt\lib\builtins -IC:\Users\tcwg\source\maxim\llvm_package_92a5106e\llvm-project\compiler-rt\lib\builtins -Iinclude -IC:\Users\tcwg\source\maxim\llvm_package_92a5106e\llvm-project\llvm\include -march=armv8-a -DCOMPILER_RT_HAS_FLOAT16 /showIncludes /Foprojects\compiler-rt\lib\builtins\CMakeFiles\clang_rt.builtins-aarch64.dir\outline_atomic_helpers.dir\outline_atomic_cas2_3.S.obj /Fdprojects\compiler-rt\lib\builtins\CMakeFiles\clang_rt.builtins-aarch64.dir\clang_rt.builtins-aarch64.pdb -c -- projects\compiler-rt\lib\builtins\outline_atomic_helpers.dir\outline_atomic_cas2_3.S

Feb 6 2021, 1:02 AM