Page MenuHomePhabricator

tambre (Raul Tambre)
Software Developer @ Cleveron AS

Projects

User does not belong to any projects.

User Details

User Since
May 4 2019, 1:33 AM (56 w, 3 d)

Recent Activity

Sat, May 30

tambre added inline comments to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.
Sat, May 30, 3:40 AM · Restricted Project
tambre updated the diff for D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Fix some intrinsics not being marked as builtin due to being static in the headers.
Make some code easier to read, fix test for sigsetjmp in Sema/implicit-builtin-decl.c to reflect the original intent.

Sat, May 30, 3:40 AM · Restricted Project
tambre abandoned D79800: [Sema] Implement DR2233.

Unfortunately, I think this approach basically can't work, because we need to consider inheriting default arguments from a previous (or subsequent!) declaration before dropping default arguments preceding a pack. I think we will instead need to detect this situation when issuing the diagnostic for a parameter with a default argument followed by a parameter without one, and will need to make sure that all the parts of Clang that look at default arguments can cope with them being discontiguous.

Sat, May 30, 3:09 AM · Restricted Project
tambre added a comment to D77296: [libc++abi] Make libunwind static linking possible in standalone builds.

ldionne: ping

Sat, May 30, 3:09 AM · Restricted Project

Fri, May 29

tambre updated the diff for D77505: [libc++] Implement <numbers>.

Fix typo in a comment.

Fri, May 29, 10:21 AM · Restricted Project

Sat, May 23

tambre updated the diff for D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Weakened noexcept checking.

Sat, May 23, 10:03 AM · Restricted Project
tambre updated the diff for D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Remove memcpy overload tests from warn-fortify-source.c, which relied on identifier-based builtin identification.

Sat, May 23, 10:03 AM · Restricted Project
tambre added inline comments to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.
Sat, May 23, 10:03 AM · Restricted Project
tambre added a comment to D77505: [libc++] Implement <numbers>.

Borrow useful things from D78427:

  • A test
  • Version guard
  • Double include test

    Rebased on master.

you can also take comments like
https://oeis.org/A001113 for e.

Sat, May 23, 6:52 AM · Restricted Project
tambre added a comment to D79800: [Sema] Implement DR2233.

Thanks for the reviews!
I believe this now handles all cases and with this we're standards-conforming in regard to DR777 and DR2233.

Sat, May 23, 6:20 AM · Restricted Project
tambre updated the diff for D79800: [Sema] Implement DR2233.

Improve comment

Sat, May 23, 6:19 AM · Restricted Project
tambre retitled D79800: [Sema] Implement DR2233 from [Sema] Remove default values for arguments prior to a parameter pack if the pack is used to [Sema] Implement DR2233.
Sat, May 23, 6:19 AM · Restricted Project
tambre updated the diff for D79800: [Sema] Implement DR2233.

Handle multiple parameter packs interleaved with default values.
Mark DR777 as superseded by DR2233. Mark DR2233 as resolved.
Moved tests from dr7xx.cpp to dr22xx.cpp. Added note in dr7xx.cpp about DR777 being superseded.
Add more tests that cover bugs observed in other implementations and the deficiency in my first implementation.

Sat, May 23, 5:15 AM · Restricted Project
tambre added reviewers for D77505: [libc++] Implement <numbers>: zoecarver, curdeius.

Adding a few reviewers from D78427 so they can take a look at this too.

Sat, May 23, 1:01 AM · Restricted Project
tambre updated the diff for D77505: [libc++] Implement <numbers>.

Borrow useful things from D78427:

  • A test
  • Version guard
  • Double include test
Sat, May 23, 1:01 AM · Restricted Project

Fri, May 22

tambre added a comment to D77505: [libc++] Implement <numbers>.

thanks @curdeius for pointing this.
Hi @tambre
I was unaware of this work and ended of doing same work.
please take things from here D78427 which seems reasonable.
and update the this review. so i can cancel my review.

Fri, May 22, 11:15 AM · Restricted Project

Thu, May 21

tambre added a comment to D79800: [Sema] Implement DR2233.

ping

Thu, May 21, 10:10 PM · Restricted Project
tambre added a comment to D77296: [libc++abi] Make libunwind static linking possible in standalone builds.

ldionne: ping

Thu, May 21, 10:10 PM · Restricted Project
tambre added a comment to D77505: [libc++] Implement <numbers>.

ping

Thu, May 21, 10:10 PM · Restricted Project

Sun, May 17

tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Thanks for the reviews and design pointers, John!

Sun, May 17, 9:02 AM · Restricted Project
tambre updated the summary of D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.
Sun, May 17, 8:30 AM · Restricted Project
tambre updated the diff for D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Semantic compatibility checking for C++ builtin redeclarations.
Remove some now unnecessary logic from getBuiltinID().
Update more tests. 4 tests still failing.

Sun, May 17, 8:30 AM · Restricted Project

Sat, May 16

tambre updated the diff for D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Fix adding BuiltinAttr in C++ mode. Update one test.

Sat, May 16, 11:05 AM · Restricted Project
tambre retitled D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness from [Sema] Fix incompatible builtin redeclarations in non-global scope to [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.
Sat, May 16, 8:57 AM · Restricted Project
tambre updated the diff for D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

Rework builtin declaration handling. Introduce BuiltinAttr.

Sat, May 16, 8:57 AM · Restricted Project

Wed, May 13

tambre added a comment to D77296: [libc++abi] Make libunwind static linking possible in standalone builds.

ldionne: ping

Wed, May 13, 11:57 PM · Restricted Project
tambre added a comment to D77505: [libc++] Implement <numbers>.

EricWF: ping

Wed, May 13, 11:57 PM · Restricted Project
tambre updated the diff for D79800: [Sema] Implement DR2233.

Simplify code, improve comments.

Wed, May 13, 10:16 AM · Restricted Project

Tue, May 12

tambre created D79800: [Sema] Implement DR2233.
Tue, May 12, 12:54 PM · Restricted Project

Thu, May 7

tambre added a comment to D77296: [libc++abi] Make libunwind static linking possible in standalone builds.

ldionne: ping

Thu, May 7, 1:41 AM · Restricted Project
tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

ping

Thu, May 7, 1:41 AM · Restricted Project

May 3 2020

tambre added a comment to D77505: [libc++] Implement <numbers>.

This needs a bunch of additional tests. Specifically of the passing kind :-)

May 3 2020, 3:11 AM · Restricted Project
tambre updated the diff for D77505: [libc++] Implement <numbers>.

Add more tests, assert on ill-formed specialization

May 3 2020, 3:11 AM · Restricted Project

Apr 30 2020

tambre added a comment to D77940: [AArch64] Add NVIDIA Carmel support.

LGTM!

Apr 30 2020, 2:25 AM · Restricted Project, Restricted Project
Herald added a project to D77940: [AArch64] Add NVIDIA Carmel support: Restricted Project.

sdesmalen: ping

Apr 30 2020, 1:12 AM · Restricted Project, Restricted Project
tambre added a comment to D77296: [libc++abi] Make libunwind static linking possible in standalone builds.

ldionne: Ping. Per the mailing list thread it seems reasonable to support this scenario.

Apr 30 2020, 1:12 AM · Restricted Project
tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

ping

Apr 30 2020, 1:12 AM · Restricted Project

Apr 24 2020

tambre added a reviewer for D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness: MaskRay.

Could someone please review this?

Apr 24 2020, 12:29 AM · Restricted Project

Apr 23 2020

tambre added a comment to D77940: [AArch64] Add NVIDIA Carmel support.

It seems a NVIDIA Developer Program Membership is needed in order to download the TRM. I'm not sure if that is just a matter of creating an account, but without it I can't really verify that the architecture version and the features are correct and complete.

Apr 23 2020, 11:53 AM · Restricted Project, Restricted Project
tambre updated the diff for D77940: [AArch64] Add NVIDIA Carmel support.

Remove SVE, add another check to parser test

Apr 23 2020, 11:52 AM · Restricted Project, Restricted Project
tambre abandoned D78726: [CUDA] Define __CUDACC_DEBUG__ when compiling device code in debug mode.

Abandoning as there are good reasons to not add this.

Apr 23 2020, 11:21 AM · Restricted Project
tambre added a comment to D77530: [AArch64][GlobalISel] Generalize logic for promoting copies.

Please land this for me as I lack commit privileges.

Apr 23 2020, 11:21 AM · Restricted Project
tambre added a comment to D77530: [AArch64][GlobalISel] Generalize logic for promoting copies.

paquette: ping

Apr 23 2020, 9:43 AM · Restricted Project
tambre created D78726: [CUDA] Define __CUDACC_DEBUG__ when compiling device code in debug mode.
Apr 23 2020, 9:43 AM · Restricted Project
tambre added a comment to D77940: [AArch64] Add NVIDIA Carmel support.

sdesmalen: Could you please take another look?

Apr 23 2020, 1:02 AM · Restricted Project, Restricted Project

Apr 21 2020

tambre added a reviewer for D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness: hokein.
Apr 21 2020, 8:04 AM · Restricted Project

Apr 18 2020

tambre updated the diff for D77940: [AArch64] Add NVIDIA Carmel support.

Add cacheline size per the technical reference manual

Apr 18 2020, 6:28 AM · Restricted Project, Restricted Project
tambre updated the summary of D77940: [AArch64] Add NVIDIA Carmel support.
Apr 18 2020, 5:55 AM · Restricted Project, Restricted Project

Apr 17 2020

tambre created D78392: [CUDA] Define __CUDACC__ before standard library headers.
Apr 17 2020, 12:26 PM · Restricted Project
tambre updated the summary of D78392: [CUDA] Define __CUDACC__ before standard library headers.
Apr 17 2020, 12:26 PM · Restricted Project
tambre updated the summary of D78392: [CUDA] Define __CUDACC__ before standard library headers.
Apr 17 2020, 12:26 PM · Restricted Project

Apr 16 2020

tambre added inline comments to D77940: [AArch64] Add NVIDIA Carmel support.
Apr 16 2020, 7:16 AM · Restricted Project, Restricted Project
tambre updated the diff for D77940: [AArch64] Add NVIDIA Carmel support.

Remove SVE, fix formatting

Apr 16 2020, 7:16 AM · Restricted Project, Restricted Project
tambre added a comment to D77505: [libc++] Implement <numbers>.

ldionne: ping

Apr 16 2020, 6:10 AM · Restricted Project
tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

rsmith: ping 2

Apr 16 2020, 6:10 AM · Restricted Project

Apr 15 2020

tambre added a comment to D77530: [AArch64][GlobalISel] Generalize logic for promoting copies.

Where did the testcase go?

Apr 15 2020, 10:01 PM · Restricted Project

Apr 14 2020

tambre added a comment to D77530: [AArch64][GlobalISel] Generalize logic for promoting copies.

paquette: ping

Apr 14 2020, 2:37 AM · Restricted Project

Apr 11 2020

tambre updated the diff for D77940: [AArch64] Add NVIDIA Carmel support.

Fix formatting

Apr 11 2020, 5:51 AM · Restricted Project, Restricted Project
tambre updated the diff for D77940: [AArch64] Add NVIDIA Carmel support.

Remove cacheline size

Apr 11 2020, 4:46 AM · Restricted Project, Restricted Project
tambre updated the summary of D77940: [AArch64] Add NVIDIA Carmel support.
Apr 11 2020, 4:46 AM · Restricted Project, Restricted Project
tambre created D77940: [AArch64] Add NVIDIA Carmel support.
Apr 11 2020, 4:46 AM · Restricted Project, Restricted Project

Apr 10 2020

tambre abandoned D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC.

[...]
Actually, if we want to do that, I think that we should redo the build to remove LIBUNWIND_ENABLE_SHARED/LIBUNWIND_ENABLE_STATIC - they are supposed to be specified by the user as BUILD_SHARED_LIBS=[YES|NO] not as a single build as it is currently. But, that is beyond the scope of this change and more about the philosophical approach that you are suggesting here.

I agree with that in principle, and it has been a source of frustration/confusion about how we build things in the runtimes.

So, @tambre, is there anything that makes specifying CMAKE_POSITION_INDEPENDENT_CODE=ON in your cache not a viable option? Would it work? Would it introduce other complexity or weirdness into your build? I'm trying to weigh the options we have here.

Apr 10 2020, 1:35 AM · Restricted Project, Restricted Project

Apr 9 2020

tambre added a comment to D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.

rsmith: ping

Apr 9 2020, 2:08 AM · Restricted Project

Apr 8 2020

tambre added a comment to D77296: [libc++abi] Make libunwind static linking possible in standalone builds.

I'll chime in on that. I just recently migrated the company I work for to LLVM, so I was only aware that building in a non-monorepo layout is unsupported now.

Apr 8 2020, 11:57 AM · Restricted Project
tambre added a comment to D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC.

I'm fine with passing -DCMAKE_POSITION_INDEPENDENT_CODE=ON on the command line. I didn't think of that before @compnerd mentioned it.
I'll run a toolchain build tomorrow and try it.

Apr 8 2020, 11:57 AM · Restricted Project, Restricted Project
tambre added a comment to D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC.

ping

Apr 8 2020, 2:39 AM · Restricted Project, Restricted Project
tambre added a comment to D77375: [compiler-rt] Don't print warning about missing testingsupport if not including tests.

ping

Apr 8 2020, 2:39 AM · Restricted Project

Apr 7 2020

tambre added inline comments to D77505: [libc++] Implement <numbers>.
Apr 7 2020, 9:44 AM · Restricted Project
tambre updated the diff for D77505: [libc++] Implement <numbers>.

Fix floating point constraint tests, remove bad test

Apr 7 2020, 9:44 AM · Restricted Project
tambre retitled D77530: [AArch64][GlobalISel] Generalize logic for promoting copies from [AArch64][GlobalISel] Generalize logic for subregister copies to [AArch64][GlobalISel] Generalize logic for promoting copies.
Apr 7 2020, 9:12 AM · Restricted Project
tambre updated the diff for D77530: [AArch64][GlobalISel] Generalize logic for promoting copies.

Fix formatting

Apr 7 2020, 8:39 AM · Restricted Project
tambre added a comment to D77530: [AArch64][GlobalISel] Generalize logic for promoting copies.

Added proper generalization for the DstSize > SrcSize aka SUBREG_TO_REG case. Also moved the missing comment to SrcSize > DstSize.
Tests now pass.

Apr 7 2020, 8:39 AM · Restricted Project
tambre updated the diff for D77530: [AArch64][GlobalISel] Generalize logic for promoting copies.

Generalized SUBREG_TO_REG logic

Apr 7 2020, 8:39 AM · Restricted Project
tambre updated the diff for D77296: [libc++abi] Make libunwind static linking possible in standalone builds.

Add cache variable for LIBCXXABI_UNWIND_LIBRARY_PATH to improve discoverability and clarify usage.

Apr 7 2020, 7:34 AM · Restricted Project
tambre added inline comments to D77296: [libc++abi] Make libunwind static linking possible in standalone builds.
Apr 7 2020, 7:34 AM · Restricted Project
tambre added a comment to D77505: [libc++] Implement <numbers>.

Should we have some kind of test coverage that the values of these constants are correct?

Apr 7 2020, 2:40 AM · Restricted Project
tambre added a comment to D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding.

Updated the comment.

Apr 7 2020, 1:03 AM · Restricted Project
tambre updated the diff for D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding.

Update comment

Apr 7 2020, 1:03 AM · Restricted Project
tambre added a comment to D77296: [libc++abi] Make libunwind static linking possible in standalone builds.

ldionne: ping

Apr 7 2020, 1:03 AM · Restricted Project

Apr 6 2020

tambre added inline comments to D77505: [libc++] Implement <numbers>.
Apr 6 2020, 4:50 AM · Restricted Project
tambre updated the diff for D77505: [libc++] Implement <numbers>.

Add version macro

Apr 6 2020, 4:50 AM · Restricted Project
tambre updated the diff for D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding.

Emit undef lvalue, add throw CHECK to test

Apr 6 2020, 4:17 AM · Restricted Project
tambre added inline comments to D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding.
Apr 6 2020, 4:17 AM · Restricted Project
tambre updated the summary of D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding.
Apr 6 2020, 4:17 AM · Restricted Project
tambre added a comment to D77530: [AArch64][GlobalISel] Generalize logic for promoting copies.

This actually breaks CodeGen/AArch64/f16-instructions.ll's test_select. Will investigate.
If you see anything incorrect in the current changes let me know. :)

Apr 6 2020, 2:08 AM · Restricted Project
tambre retitled D77530: [AArch64][GlobalISel] Generalize logic for promoting copies from [AArch64] Generalize logic for subregister copies to [AArch64][GlobalISel] Generalize logic for subregister copies.
Apr 6 2020, 1:36 AM · Restricted Project
tambre created D77530: [AArch64][GlobalISel] Generalize logic for promoting copies.
Apr 6 2020, 1:36 AM · Restricted Project

Apr 5 2020

tambre added a comment to D77505: [libc++] Implement <numbers>.

Is docs/TestingLibcxx.rst up-to-date? I can't find the lit.site.cfg for libc++ in my build directory to be able to run tests locally. I do see others for libc++ benchmarks and LLVM components.

Apr 5 2020, 11:12 AM · Restricted Project
tambre updated the diff for D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding.

Fix formatting

Apr 5 2020, 10:08 AM · Restricted Project
tambre created D77505: [libc++] Implement <numbers>.
Apr 5 2020, 10:08 AM · Restricted Project
tambre created D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding.
Apr 5 2020, 7:59 AM · Restricted Project
tambre updated the summary of D77502: [clang][CodeGen] Handle throw expression in conditional operator constant folding.
Apr 5 2020, 7:59 AM · Restricted Project
tambre abandoned D77492: [LLVM] Fix LLVM_CSPROFILE_FILE_PATTERN not being used.

Just discovered that only -fprofile-instr-generate supports taking a pattern, but others don't. Seems inconsistent. I'd like to use a pattern not a directory with -fcs-profile-generate too.

Apr 5 2020, 6:55 AM · Restricted Project
tambre created D77492: [LLVM] Fix LLVM_CSPROFILE_FILE_PATTERN not being used.
Apr 5 2020, 5:51 AM · Restricted Project
tambre created D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness.
Apr 5 2020, 5:19 AM · Restricted Project

Apr 4 2020

tambre added a comment to D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC.

I think that this really was an oversight, and that we should default to PIC builds, at least for shared libraries.

Would two flags LIBUNWIND_ENABLE_SHARED_PIC and LIBUNWIND_ENABLE_STATIC_PIC sound good to you? Then we could default shared to ON, but static to OFF.
Enabling PIC in static builds is something I need.

Can't you just enable it globally for libunwind and then only use the static library? The creation of several MEOW_SHARED and MEOW_STATIC options makes the build system a lot more complicated than it should be.

Apr 4 2020, 1:57 AM · Restricted Project, Restricted Project
tambre updated the diff for D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC.

Changed LIBUNWIND_ENABLE_PIC default to ON

Apr 4 2020, 1:57 AM · Restricted Project, Restricted Project

Apr 3 2020

tambre added a comment to D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC.

I think that this really was an oversight, and that we should default to PIC builds, at least for shared libraries.

Apr 3 2020, 12:28 PM · Restricted Project, Restricted Project
tambre added a comment to D61548: Fix use of 'is' operator for comparison.

Why did you abandon this?

Apr 3 2020, 12:25 PM · Restricted Project
tambre added a comment to D77375: [compiler-rt] Don't print warning about missing testingsupport if not including tests.

Please land this for me. I lack commit privileges. :)

Apr 3 2020, 4:48 AM · Restricted Project