The change looks ok to me. In my environments, the main branch does build correctly, but this should be good for consistency in any case. (The 12.x release branch does need a cherrypick though - but it'd be good to settle this first.)
I can test build it in a couple hours, I'll mark it as formally approved after doing that.
There seems to be trailing whitespace here.
I don't feel knowledgeable enough to backport the commit, so if you can do
it, it would be great :)
Il giorno gio 4 feb 2021 alle ore 13:04 Martin Storsjö via Phabricator <
email@example.com> ha scritto:
mstorsjo added a comment.
I can test build it in a couple hours
It still built fine for me now - thanks!
Repository:rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIONhttps://reviews.llvm.org/D96060/new/