@mstorsjo found a mistake that I made when trying to fix some Windows
compilation errors encountered by @stella.stamenova.
I was incorrectly using the LLVM_ON_UNIX macro. In any case, proper use
of
#if defined(_WIN32)
should be the actual fix.
Paths
| Differential D96060
[lldb-vscode] correctly use Windows macros ClosedPublic Authored by wallace on Feb 4 2021, 10:09 AM.
Details Summary @mstorsjo found a mistake that I made when trying to fix some Windows I was incorrectly using the LLVM_ON_UNIX macro. In any case, proper use #if defined(_WIN32) should be the actual fix.
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Feb 4 2021, 10:57 AM This revision was landed with ongoing or failed builds.Feb 4 2021, 11:03 AM Closed by commit rG36496cc2992d: [lldb-vscode] correctly use Windows macros (authored by wallace). · Explain Why This revision was automatically updated to reflect the committed changes. Comment Actions The change looks ok to me. In my environments, the main branch does build correctly, but this should be good for consistency in any case. (The 12.x release branch does need a cherrypick though - but it'd be good to settle this first.) I can test build it in a couple hours, I'll mark it as formally approved after doing that.
Comment Actions
It still built fine for me now - thanks! Comment Actions I don't feel knowledgeable enough to backport the commit, so if you can do Il giorno gio 4 feb 2021 alle ore 13:04 Martin Storsjö via Phabricator <
Revision Contents
Diff 321519 lldb/tools/lldb-vscode/FifoFiles.cpp
lldb/tools/lldb-vscode/IOStream.h
lldb/tools/lldb-vscode/IOStream.cpp
lldb/tools/lldb-vscode/RunInTerminal.cpp
lldb/tools/lldb-vscode/VSCode.cpp
lldb/tools/lldb-vscode/lldb-vscode.cpp
|
There seems to be trailing whitespace here.