Page MenuHomePhabricator

Chirag (Chirag Patel)
Software Engineer

Projects

User does not belong to any projects.

User Details

User Since
Jul 17 2018, 12:37 AM (97 w, 3 d)

Working for Raincode Labs, contributing to LLVM on behalf of LzLabs.

Recent Activity

Feb 21 2020

Chirag updated the diff for D74470: Seperated DIBasicType DIFlags to DIBTFlags..

Moved five of the DIFlags to DISPFlags. (updated few clang testcases)
DIFlagExplicit -> DISPFlagExplicit
DIFlagPrototyped -> DISPFlagPrototyped
DIFlagNoReturn -> DISPFlagNoReturn
DIFlagThunk -> DISPFlagThunk
DIFlagAllCallsDescribed -> DISPFlagAllCallsDescribed

Feb 21 2020, 3:05 AM · Restricted Project, debug-info, Restricted Project

Feb 13 2020

Chirag added inline comments to D74470: Seperated DIBasicType DIFlags to DIBTFlags..
Feb 13 2020, 2:39 AM · Restricted Project, debug-info, Restricted Project
Chirag added inline comments to D74470: Seperated DIBasicType DIFlags to DIBTFlags..
Feb 13 2020, 2:30 AM · Restricted Project, debug-info, Restricted Project
Chirag added inline comments to D74470: Seperated DIBasicType DIFlags to DIBTFlags..
Feb 13 2020, 2:12 AM · Restricted Project, debug-info, Restricted Project
Chirag added a comment to D74470: Seperated DIBasicType DIFlags to DIBTFlags..

D73261 would also benefit from moving more flags into the subprogram flags field. The refactoring really should move out as many flags as possible all in one go. I understand this is more than you anticipated but it will be the right thing to do for the project as a whole.

Feb 13 2020, 12:23 AM · Restricted Project, debug-info, Restricted Project
Chirag updated the diff for D74470: Seperated DIBasicType DIFlags to DIBTFlags..
  • some typos cleanup.
  • updated bitcode test(both .bc and .ll files) to use old flags and checked against new btflags.
Feb 13 2020, 12:14 AM · Restricted Project, debug-info, Restricted Project

Feb 12 2020

Chirag added a comment to D73861: Added DIBasicType scale/picture_string/digits/sign attribute support..

I have created a small patch to separate DIFlags for DIBasicType. https://reviews.llvm.org/D74470
I will modify this patch afterwards.

Thanks, I will look at that soon.

The use case of this patch is to generate optional dwarf attributes DW_AT_digit_count/DW_AT_decimal_scale/DW_AT_binary_scale/DW_AT_decimal_sign/DW_AT_picture_string for languages like cobol, PL1, basic data types with encoding such as DW_ATE_edited DW_ATE_numeric_string etc.

That's more a statement of the functionality of the patch than the use-case. You have a COBOL or PL/1 or BASIC compiler using LLVM?

Feb 12 2020, 9:10 PM · Restricted Project, debug-info
Chirag updated the diff for D74470: Seperated DIBasicType DIFlags to DIBTFlags..
  • Bitcode backward compatibility, added flag with distinct to mark BTFlags' presence.
Feb 12 2020, 4:41 AM · Restricted Project, debug-info, Restricted Project
Chirag added a child revision for D74470: Seperated DIBasicType DIFlags to DIBTFlags.: D73861: Added DIBasicType scale/picture_string/digits/sign attribute support..
Feb 12 2020, 3:00 AM · Restricted Project, debug-info, Restricted Project
Chirag added a parent revision for D73861: Added DIBasicType scale/picture_string/digits/sign attribute support.: D74470: Seperated DIBasicType DIFlags to DIBTFlags..
Feb 12 2020, 3:00 AM · Restricted Project, debug-info
Chirag added a comment to D74470: Seperated DIBasicType DIFlags to DIBTFlags..

Does this support the old metadata? We should have a test for the old metadata as well (e.g. flags: DIFlagBigEndian).

As we discussed on D73261, we might have to move a few flags from DIFlags into DISPFlags.

Feb 12 2020, 3:00 AM · Restricted Project, debug-info, Restricted Project
Chirag updated the diff for D74470: Seperated DIBasicType DIFlags to DIBTFlags..
  • Updated bitcode test to check type with proper variable.
Feb 12 2020, 2:42 AM · Restricted Project, debug-info, Restricted Project
Chirag added a project to D74470: Seperated DIBasicType DIFlags to DIBTFlags.: debug-info.
Feb 12 2020, 1:38 AM · Restricted Project, debug-info, Restricted Project
Chirag added a comment to D73861: Added DIBasicType scale/picture_string/digits/sign attribute support..

I have created a small patch to separate DIFlags for DIBasicType. https://reviews.llvm.org/D74470
I will modify this patch afterwards.

Feb 12 2020, 1:29 AM · Restricted Project, debug-info
Chirag created D74470: Seperated DIBasicType DIFlags to DIBTFlags..
Feb 12 2020, 1:29 AM · Restricted Project, debug-info, Restricted Project

Feb 9 2020

Chirag added a comment to D73861: Added DIBasicType scale/picture_string/digits/sign attribute support..

Ping.

Feb 9 2020, 6:15 PM · Restricted Project, debug-info

Feb 2 2020

Chirag created D73861: Added DIBasicType scale/picture_string/digits/sign attribute support..
Feb 2 2020, 9:59 PM · Restricted Project, debug-info

May 7 2019

Chirag updated the diff for D61587: [lldb] Added support for dwarf expressions DW_OP_call2/DW_OP_call4.

Fixed as per comments. passed proper execution/register context. for the time being DW_OP_piece is not allowed in call op. Working on testcase.

May 7 2019, 5:01 AM · Unknown Object (Project)

May 6 2019

Chirag added a reviewer for D61587: [lldb] Added support for dwarf expressions DW_OP_call2/DW_OP_call4: clayborg.
May 6 2019, 2:47 AM · Unknown Object (Project)
Chirag added a reviewer for D61587: [lldb] Added support for dwarf expressions DW_OP_call2/DW_OP_call4: jingham.
May 6 2019, 2:42 AM · Unknown Object (Project)
Chirag created D61587: [lldb] Added support for dwarf expressions DW_OP_call2/DW_OP_call4.
May 6 2019, 2:42 AM · Unknown Object (Project)

Feb 21 2019

Chirag closed D58438: [LLVM-C] Add bindings to add DIGlobalVariableExpression to GlobalVariable..

Missed, LLVMGlobalSetMetadata.

Feb 21 2019, 2:00 AM

Feb 20 2019

Chirag added a comment to D58438: [LLVM-C] Add bindings to add DIGlobalVariableExpression to GlobalVariable..

Can you please push this changes, i do not have write permission. Thanks.

Feb 20 2019, 4:38 AM
Chirag created D58438: [LLVM-C] Add bindings to add DIGlobalVariableExpression to GlobalVariable..
Feb 20 2019, 4:28 AM

Oct 30 2018

Chirag abandoned D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info..
Oct 30 2018, 6:56 AM · debug-info

Oct 19 2018

Chirag added inline comments to D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info..
Oct 19 2018, 10:50 AM · debug-info

Oct 17 2018

Chirag added a comment to D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info..

Ping.

Oct 17 2018, 11:32 AM · debug-info

Oct 9 2018

Chirag updated the diff for D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info..
  • clang-format
Oct 9 2018, 7:28 AM · debug-info
Chirag updated the diff for D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info..
  • Added DW_AT_binary_scale attribute.
  • Fixed llvm type code formatting
  • Fixed minor typos.
Oct 9 2018, 5:38 AM · debug-info

Oct 1 2018

Chirag added a comment to D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info..

What I meant by "use case" is, do you have a front end that will make use of these new features?

Are you supporting binary scale as well as decimal scale, for [un]signed_fixed encodings? It looks like you are supporting only decimal scale.

Oct 1 2018, 11:39 AM · debug-info

Sep 27 2018

Chirag added a comment to D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info..

@aprantl yes, at the moment clang is not generating bi-endian code, hence not using DIFlags.

Sep 27 2018, 12:30 AM · debug-info

Sep 26 2018

Chirag added inline comments to D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info..
Sep 26 2018, 1:44 AM · debug-info

Sep 25 2018

Chirag updated the diff for D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info..
  • Updated metatdata unittest
  • Fixed optional issues with decimal attributes.
  • Added doxygen comments.
  • Updated asm roundtrip tests.
Sep 25 2018, 5:38 AM · debug-info

Sep 21 2018

Chirag added a comment to D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info..

I will also include the metadata unit test with listed changes, thanks.

Sep 21 2018, 9:26 AM · debug-info

Sep 20 2018

Chirag created D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info..
Sep 20 2018, 3:15 AM · debug-info

Sep 7 2018

Chirag added a comment to D51721: [Bindings][Go] Fixed go.test failure due to C-API argument type mismatch..

Can anyone kindly submit this? i do not have write access. Thanks.

Sep 7 2018, 10:12 AM
Chirag added a comment to D51721: [Bindings][Go] Fixed go.test failure due to C-API argument type mismatch..

Hello Kristina,

Sep 7 2018, 7:25 AM

Sep 6 2018

Chirag created D51721: [Bindings][Go] Fixed go.test failure due to C-API argument type mismatch..
Sep 6 2018, 1:20 AM

Aug 17 2018

Chirag requested review of D50832: [C-API][DIBuilder] Added DIFlags in LLVMDIBuilderCreateBasicType.
Aug 17 2018, 12:19 AM
Chirag updated the diff for D50832: [C-API][DIBuilder] Added DIFlags in LLVMDIBuilderCreateBasicType.
  • fixed mistake with go.
Aug 17 2018, 12:19 AM

Aug 15 2018

Chirag added a comment to D50832: [C-API][DIBuilder] Added DIFlags in LLVMDIBuilderCreateBasicType.

Hello whitequark.

Aug 15 2018, 11:45 PM
Chirag updated the diff for D50832: [C-API][DIBuilder] Added DIFlags in LLVMDIBuilderCreateBasicType.
  • minor format fixes.
Aug 15 2018, 11:43 PM
Chirag added a comment to D50832: [C-API][DIBuilder] Added DIFlags in LLVMDIBuilderCreateBasicType.

This change will support to add optional dwarf attributes to tag_base_type entries.
At the moment only DW_AT_endianity is supported. which is useful for bi-endian code generation such as scaler-storage-order extension in gcc

Aug 15 2018, 10:58 PM
Chirag created D50832: [C-API][DIBuilder] Added DIFlags in LLVMDIBuilderCreateBasicType.
Aug 15 2018, 10:55 PM

Aug 13 2018

Chirag added a comment to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..

Hello adrian,

Aug 13 2018, 9:50 AM
Chirag updated the diff for D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
  • removed wrong testcase.
Aug 13 2018, 1:43 AM

Aug 11 2018

Chirag added inline comments to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
Aug 11 2018, 7:45 AM

Aug 9 2018

Chirag updated the diff for D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
  • fixed unique node lookup for basicType
  • fixed assert message for conflicting flags.
  • added testcases for comparing basictype with flags.
Aug 9 2018, 1:21 AM
Chirag added inline comments to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
Aug 9 2018, 1:16 AM

Aug 7 2018

Chirag added inline comments to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
Aug 7 2018, 11:22 AM
Chirag added inline comments to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
Aug 7 2018, 3:52 AM

Aug 6 2018

Chirag updated the diff for D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
Aug 6 2018, 3:01 AM
Chirag updated the diff for D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
  • Minor changes relating to DIFlags checks.
  • Added bitcode upgrade test for DIBasicType with flags endianity.
Aug 6 2018, 2:53 AM

Aug 3 2018

Chirag added a comment to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..

The last thing that is missing is a bitcode upgrade test (unless you can show that one of the existing checked in .bc files in the testsuite also covers the upgrade path for the old, shorter DIBasicType).

It seems like there is no such dedicated test case for DIBasicType, but some other testcases such as DIVariable, DiExpression uses the DIBasicType.
Please advice, if you want me to create a new test case for bitcode upgrade of DIBasicType or is it okey to modify the existing DiVariable one.

Aug 3 2018, 1:04 AM
Chirag updated the diff for D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
  • moved endianity enums to dwarf.def
  • Added verifier check for DIBasicType for invalid flags.
  • removed hashing of flags from DIBasicType
Aug 3 2018, 1:00 AM

Aug 2 2018

Chirag added inline comments to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
Aug 2 2018, 9:00 AM
Chirag updated the diff for D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
  • Included Full context.
  • Changed flag values for BigEndian, LittleEndian.
  • Included assembler round-trip test for BasicType with BigEndian/LittleEndian testcases.
Aug 2 2018, 1:00 AM

Aug 1 2018

Chirag added a comment to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..

for the time being the basicType that maps to DW_TAG_base_type, but in future the variables created using that basictype or any other type with DW_TAG_variable and DW_TAG_formal_parameters tags.

Aug 1 2018, 9:42 PM
Chirag added a comment to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..

Do you need to support endinaness attributes just on basic types or eventually on any type?

for the time being the basicType that maps to DW_TAG_base_type, but in future the variables created using that basictype or any other type with DW_TAG_variable and DW_TAG_formal_parameters tags.

Aug 1 2018, 9:24 AM
Chirag added a comment to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..

For testing i have ran llvm-check with no regressions.

Aug 1 2018, 2:06 AM
Chirag updated the diff for D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..

Extended DIFlags to support DW_AT_endianity in basictype as per DWARFv4

Aug 1 2018, 2:04 AM
Chirag added a comment to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..

Hello Adrian,

Aug 1 2018, 12:59 AM

Jul 23 2018

Chirag abandoned D49532: [DebugInfoMetadata] Added endianity field in DIBasicType to hold DW_AT_endianity attribute for DW_TAG_basic_type..

Hello Adrian,
can i discard this review?

Jul 23 2018, 11:44 PM

Jul 20 2018

Chirag added a watcher for debug-info: Chirag.
Jul 20 2018, 11:52 AM
Chirag added a comment to D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..

Testing Done: Compilation and llvm-check.

Jul 20 2018, 11:18 AM
Chirag created D49610: [DebugInfoMetadata] Added DIFlags interface in DIBasicType..
Jul 20 2018, 11:17 AM
Chirag added a comment to D49532: [DebugInfoMetadata] Added endianity field in DIBasicType to hold DW_AT_endianity attribute for DW_TAG_basic_type..

Thank you guys for the help.

Jul 20 2018, 2:48 AM

Jul 18 2018

Chirag added a comment to D49532: [DebugInfoMetadata] Added endianity field in DIBasicType to hold DW_AT_endianity attribute for DW_TAG_basic_type..

Hello All,

Jul 18 2018, 10:52 PM
Chirag created D49532: [DebugInfoMetadata] Added endianity field in DIBasicType to hold DW_AT_endianity attribute for DW_TAG_basic_type..
Jul 18 2018, 10:28 PM